vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-01 15:50:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix post meta caching system to reduce queries and eliminate redundant WP code. fixes #3273

Browse Source 
git-svn-id: https://develop.svn.wordpress.org/trunk@4419 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Mark Jaquith
2006-10-24 10:52:59 +00:00
parent 60fb538b78
commit f3f5188f24
2 changed files with 31 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
wp-includes/functions.php
View File

@@ -563,10 +563,27 @@ function update_post_caches(&$posts) {
update_post_category_cache($post_id_list);
update_postmeta_cache($post_id_list);
}
function update_postmeta_cache($post_id_list = '') {
global $wpdb, $post_meta_cache;
// We should validate this comma-separated list for the upcoming SQL query
$post_id_list = preg_replace('|[^0-9,]|', '', $post_id_list);
// we're marking each post as having its meta cached (with no keys... empty array), to prevent posts with no meta keys from being queried again
// any posts that DO have keys will have this empty array overwritten with a proper array, down below
$post_id_array = explode(',', $post_id_list);
foreach ( (array) $post_id_array as $pid )
$post_meta_cache[$pid] = array();
// Get post-meta info
if ( $meta_list = $wpdb->get_results("SELECT post_id, meta_key, meta_value FROM $wpdb->postmeta WHERE post_id IN($post_id_list) ORDER BY post_id, meta_key", ARRAY_A) ) {
// Change from flat structure to hierarchical:
$post_meta_cache = array();
if ( !isset($post_meta_cache) )
$post_meta_cache = array();
foreach ($meta_list as $metarow) {
$mpid = (int) $metarow['post_id'];
$mkey = $metarow['meta_key'];