vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-03 16:50:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Link Template: In get_adjacent_post(), move the sanitisation of $excluded_terms earlier.

Browse Source 
This is a followup to [42828], ensuring that the `get_{$adjacent}_post_excluded_terms` filter is always passed an array, as expected.

Props soulseekah, zottto.
Fixes #43521.



git-svn-id: https://develop.svn.wordpress.org/trunk@44591 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Gary Pendergast
2019-01-15 01:53:02 +00:00
parent d7e86e8313
commit f418ee12b1
2 changed files with 47 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
tests/phpunit/tests/link/getAdjacentPost.php
View File

@@ -312,6 +312,40 @@ class Tests_Link_GetAdjacentPost extends WP_UnitTestCase {
$this->assertSame( $p3, $found->ID );
}
/**
* @ticket 43521
*/
public function test_excluded_terms_filter_empty() {
register_taxonomy( 'wptests_tax', 'post' );
$terms = self::factory()->term->create_many(
2,
array(
'taxonomy' => 'wptests_tax',
)
);
$p1 = self::factory()->post->create( array( 'post_date' => '2015-08-27 12:00:00' ) );
$p2 = self::factory()->post->create( array( 'post_date' => '2015-08-26 12:00:00' ) );
$p3 = self::factory()->post->create( array( 'post_date' => '2015-08-25 12:00:00' ) );
wp_set_post_terms( $p1, array( $terms[0], $terms[1] ), 'wptests_tax' );
wp_set_post_terms( $p2, array( $terms[1] ), 'wptests_tax' );
wp_set_post_terms( $p3, array( $terms[0] ), 'wptests_tax' );
$this->go_to( get_permalink( $p1 ) );
$this->exclude_term = $terms[1];
add_filter( 'get_previous_post_excluded_terms', array( $this, 'filter_excluded_terms' ) );
$found = get_adjacent_post( false, array(), true, 'wptests_tax' );
remove_filter( 'get_previous_post_excluded_terms', array( $this, 'filter_excluded_terms' ) );
unset( $this->exclude_term );
$this->assertSame( $p3, $found->ID );
}
public function filter_excluded_terms( $excluded_terms ) {
$excluded_terms[] = $this->exclude_term;
return $excluded_terms;