vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 22:30:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Code Editor: Improve ability to create Customizer CodeEditorControl instances in JS, lessening PHP dependencies.

Browse Source 
Allow `CodeEditorControl` to be instantiated with a `editor_settings` param which is merged with `wp.codeEditor.defaultSettings`.

Also:

* Turn redundant "CSS Code" control label into screen reader text for Additional CSS.
* Remove `code-editor` as script dependency for `custom-html-widgets` since enqueueing is determined by `wp_enqueue_code_editor()`.
* Remove useless exporting of `code_type` param to JS in `WP_Customize_Code_Editor_Control`.
* Add `disabled` class to Custom HTML widget's Save button when linting errors are present.
* Remove redundant `span` inside CodeEditorControl's `label`.

See #41897, #12423, #41872.


git-svn-id: https://develop.svn.wordpress.org/trunk@41957 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Weston Ruter
2017-10-20 16:38:35 +00:00
parent 01c7f2cf7d
commit f5534ec8d5
5 changed files with 40 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/phpunit/tests/widgets/custom-html-widget.php
View File

@@ -263,8 +263,8 @@ class Test_WP_Widget_Custom_HTML extends WP_UnitTestCase {
$widget->enqueue_admin_scripts();
$this->assertTrue( wp_script_is( 'custom-html-widgets', 'enqueued' ) );
$this->assertTrue( wp_script_is( 'code-editor', 'enqueued' ) );
$this->assertTrue( wp_script_is( 'wp-codemirror', 'enqueued' ) );
$this->assertFalse( wp_script_is( 'code-editor', 'enqueued' ) );
$this->assertFalse( wp_script_is( 'wp-codemirror', 'enqueued' ) );
$this->assertFalse( wp_script_is( 'csslint', 'enqueued' ) );
$this->assertFalse( wp_script_is( 'jshint', 'enqueued' ) );
$this->assertFalse( wp_script_is( 'htmlhint', 'enqueued' ) );