From f64f956847a017134506d35917a563f756bf64ae Mon Sep 17 00:00:00 2001 From: Joe McGill Date: Thu, 3 Nov 2016 12:36:01 +0000 Subject: [PATCH] Themes: Improve reliability of URL used in `get_header_image_tag()`. `get_header_image_tag()` relies on the data returned by `get_custom_header()` to build the attributes for the header `` element. However, `get_custom_header()` relies on data from the `header_image_data` theme mod rather than the `header_image` theme mod that `get_header_image()` uses. This can create inconsistencies when no header image is set, but a theme supports a default header image. This fixes the issue by making `get_custom_image_tag()` rely on the URL returned by `get_header_image()` instead. Props bradyvercher. Fixes #38633. git-svn-id: https://develop.svn.wordpress.org/trunk@39121 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/theme.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wp-includes/theme.php b/src/wp-includes/theme.php index 957ee1b00d..450b985879 100644 --- a/src/wp-includes/theme.php +++ b/src/wp-includes/theme.php @@ -1027,8 +1027,9 @@ function get_header_image() { */ function get_header_image_tag( $attr = array() ) { $header = get_custom_header(); + $header->url = get_header_image(); - if ( empty( $header->url ) ) { + if ( ! $header->url ) { return ''; }