vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 22:30:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't allow $field param to be passed to get_term_link().

Browse Source 
The new parameter creates inconsistencies in the signatures of the various
functions for fetching term links (`get_term_feed_link()`,
`get_edit_term_link()`, etc.).

Reverts [32553].

See #14156.

git-svn-id: https://develop.svn.wordpress.org/trunk@33022 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2015-07-01 12:53:05 +00:00
parent e8a16ec322
commit f7b8ff5a2e
2 changed files with 5 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
tests/phpunit/tests/term/getTermLink.php
View File

@@ -54,53 +54,6 @@ class Tests_Term_GetTermLink extends WP_UnitTestCase {
$term = (string) $t1;
$actual = get_term_link( $term, 'wptests_tax', 'id' );
$this->assertContains( 'wptests_tax=foo', $actual );
}
/**
* @ticket 14156
*/
public function test_should_match_field_by_name() {
$t = $this->factory->term->create( array(
'taxonomy' => 'wptests_tax',
'slug' => 'foo',
'name' => 'Bar Term',
) );
$actual = get_term_link( 'Bar Term', 'wptests_tax', 'name' );
$this->assertContains( 'wptests_tax=foo', $actual );
}
/**
* @ticket 14156
*/
public function test_should_match_field_by_tt_id() {
$t = $this->factory->term->create( array(
'taxonomy' => 'wptests_tax',
'slug' => 'foo',
'name' => 'Bar Term',
) );
$actual = get_term_link( 'Bar Term', 'wptests_tax', 'name' );
$this->assertContains( 'wptests_tax=foo', $actual );
}
/**
* @ticket 14156
*/
public function test_numeric_string_should_be_interpreted_as_term_id_if_id_field_is_specified() {
$t1 = $this->factory->term->create( array(
'taxonomy' => 'wptests_tax',
'name' => 'foo',
) );
$t2 = $this->factory->term->create( array(
'taxonomy' => 'wptests_tax',
'slug' => $t1,
) );
$term = (string) $t1;
$actual = get_term_link( $term, 'wptests_tax' );
$this->assertContains( 'wptests_tax=' . $term, $actual );
}