From f8829b3a8de970fcf71ae6923868be6e3ea9f433 Mon Sep 17 00:00:00 2001 From: Anthony Burchell Date: Tue, 26 Jan 2021 05:24:15 +0000 Subject: [PATCH] Media: Remove caching from filter by date in media library. Previously, newly uploaded media attachments were missing when filtering media items by date due to lack of cache invalidation. Props adamsilverstein, teamdnk, afercia, Mista-Flo, joedolson. Fixes #50025. git-svn-id: https://develop.svn.wordpress.org/trunk@50021 602fd350-edb4-49c9-b593-d223f7449a82 --- src/js/media/models/query.js | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/js/media/models/query.js b/src/js/media/models/query.js index 4a6810adf6..2c9fceee46 100644 --- a/src/js/media/models/query.js +++ b/src/js/media/models/query.js @@ -243,13 +243,11 @@ Query = Attachments.extend(/** @lends wp.media.model.Query.prototype */{ var args = {}, orderby = Query.orderby, defaults = Query.defaultProps, - query, - cache = !! props.cache || _.isUndefined( props.cache ); + query; // Remove the `query` property. This isn't linked to a query, // this *is* the query. delete props.query; - delete props.cache; // Fill default args. _.defaults( props, defaults ); @@ -288,14 +286,7 @@ Query = Attachments.extend(/** @lends wp.media.model.Query.prototype */{ // Substitute exceptions specified in orderby.keymap. args.orderby = orderby.valuemap[ props.orderby ] || props.orderby; - // Search the query cache for a matching query. - if ( cache ) { - query = _.find( queries, function( query ) { - return _.isEqual( query.args, args ); - }); - } else { - queries = []; - } + queries = []; // Otherwise, create a new query and add it to the cache. if ( ! query ) {