From f8a460675c1b27acf94b04e4f945310c479d4461 Mon Sep 17 00:00:00 2001 From: Andrew Nacin Date: Thu, 28 Apr 2011 09:47:30 +0000 Subject: [PATCH] In Twenty Eleven: Register the widget from functions.php. Kill create_function. Attach twentyeleven_widgets_init() to widgets_init, rather than init. Eliminate use of the $post global in the widget. see #17198. git-svn-id: https://develop.svn.wordpress.org/trunk@17738 602fd350-edb4-49c9-b593-d223f7449a82 --- wp-content/themes/twentyeleven/functions.php | 9 +++++++-- wp-content/themes/twentyeleven/inc/widgets.php | 10 +++------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/wp-content/themes/twentyeleven/functions.php b/wp-content/themes/twentyeleven/functions.php index 9672fff1be..8f1f1a4ab8 100644 --- a/wp-content/themes/twentyeleven/functions.php +++ b/wp-content/themes/twentyeleven/functions.php @@ -366,9 +366,14 @@ function twentyeleven_page_menu_args( $args ) { add_filter( 'wp_page_menu_args', 'twentyeleven_page_menu_args' ); /** - * Register widgetized area and update sidebar with default widgets + * Register our sidebars and widgetized areas. Also register the default Epherma widget. + * + * @since Twenty Eleven 1.0 */ function twentyeleven_widgets_init() { + + register_widget( 'Twenty_Eleven_Ephemera_Widget' ); + register_sidebar( array( 'name' => __( 'Main Sidebar', 'twentyeleven' ), 'id' => 'sidebar-1', @@ -418,7 +423,7 @@ function twentyeleven_widgets_init() { 'after_title' => '', ) ); } -add_action( 'init', 'twentyeleven_widgets_init' ); +add_action( 'widgets_init', 'twentyeleven_widgets_init' ); /** * Display navigation to next/previous pages when applicable diff --git a/wp-content/themes/twentyeleven/inc/widgets.php b/wp-content/themes/twentyeleven/inc/widgets.php index 60ce8810ce..0ed03af1e4 100644 --- a/wp-content/themes/twentyeleven/inc/widgets.php +++ b/wp-content/themes/twentyeleven/inc/widgets.php @@ -78,13 +78,11 @@ class Twenty_Eleven_Ephemera_Widget extends WP_Widget { echo $title; // Can set this with a widget option, or omit altogether echo $after_title; - global $post; - ?>
    have_posts() ) : $ephemera->the_post(); ?> - ID ) ) : ?> +
  1. @@ -116,7 +114,7 @@ class Twenty_Eleven_Ephemera_Widget extends WP_Widget { echo $after_widget; - // Reset the global $the_post as this query will have stomped on it + // Reset the post globals as this query will have stomped on it wp_reset_postdata(); // end check for ephemeral posts @@ -161,6 +159,4 @@ class Twenty_Eleven_Ephemera_Widget extends WP_Widget {