vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-01 11:14:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Code Modernization: Correct fallback return value in get_the_author().

Browse Source 
If the `$authordata` global is not set, `get_the_author()` returned `null`, causing a PHP 8.1 "null to non-nullable" deprecation notice in `ent2ncr()` hooked via `the_author` filter:
{{{
str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
}}}

This commit updates `get_the_author()` to return an empty string if called before `$authordata` is set, bringing consistency with a few other similar functions which also return an empty string in this case:

* `get_the_author_meta()`
* `get_the_author_posts_link()`
* `get_the_modified_author()`

Follow-up to [695/tests], [2858], [11138], [12284], [20575], [34677], [44616], [53187].

Props Soean, jrf, sabernhardt, salvoaranzulla, antpb, ebai4, sajjad67, tijmensmit, SergeyBiryukov.
Fixes #58157.

git-svn-id: https://develop.svn.wordpress.org/trunk@55755 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2023-05-14 17:56:26 +00:00
parent 02d89bc44d
commit fdd333fa47
5 changed files with 93 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/phpunit/tests/user/getTheAuthor.php
View File

@@ -45,4 +45,13 @@ class Tests_User_GetTheAuthor extends WP_UnitTestCase {
$this->assertSame( $user->display_name, $author_name );
$this->assertSame( 'Test Author', $author_name );
}
/**
* @ticket 58157
*/
public function test_get_the_author_should_return_empty_string_if_authordata_is_not_set() {
unset( $GLOBALS['authordata'] );
$this->assertSame( '', get_the_author() );
}
}

6
tests/phpunit/tests/user/getTheAuthorMeta.php
View File

@@ -61,7 +61,11 @@ class Tests_User_GetTheAuthorMeta extends WP_UnitTestCase {
$this->assertSame( '', get_the_author_meta( 'does_not_exist' ) );
}
public function test_get_the_author_meta_no_authordata() {
/**
* @ticket 20529
* @ticket 58157
*/
public function test_get_the_author_meta_should_return_empty_string_if_authordata_is_not_set() {
unset( $GLOBALS['authordata'] );
$this->assertSame( '', get_the_author_meta( 'id' ) );

9
tests/phpunit/tests/user/getTheAuthorPostsLink.php
View File

@@ -79,4 +79,13 @@ class Tests_User_GetTheAuthorPostsLink extends WP_UnitTestCase {
unset( $GLOBALS['authordata'] );
}
/**
* @ticket 58157
*/
public function test_get_the_author_posts_link_should_return_empty_string_if_authordata_is_not_set() {
unset( $GLOBALS['authordata'] );
$this->assertSame( '', get_the_author_posts_link() );
}
}

59
tests/phpunit/tests/user/getTheModifiedAuthor.php Normal file
View File

@@ -0,0 +1,59 @@
<?php
/**
* @group author
* @group user
*
* @covers ::get_the_modified_author
*/
class Tests_User_GetTheModifiedAuthor extends WP_UnitTestCase {
protected static $author_id = 0;
protected static $post_id = 0;
public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
self::$author_id = $factory->user->create(
array(
'role' => 'author',
'user_login' => 'test_author',
'display_name' => 'Test Author',
'description' => 'test_author',
'user_url' => 'http://example.com',
)
);
self::$post_id = $factory->post->create(
array(
'post_author' => self::$author_id,
'post_status' => 'publish',
'post_content' => 'content',
'post_title' => 'title',
'post_type' => 'post',
)
);
add_post_meta( self::$post_id, '_edit_last', self::$author_id );
}
public function set_up() {
parent::set_up();
$GLOBALS['post'] = self::$post_id;
}
public function test_get_the_modified_author() {
$author_name = get_the_modified_author();
$user = new WP_User( self::$author_id );
$this->assertSame( $user->display_name, $author_name );
$this->assertSame( 'Test Author', $author_name );
}
/**
* @ticket 58157
*/
public function test_get_the_modified_author_should_return_empty_string_if_user_id_does_not_exist() {
update_post_meta( self::$post_id, '_edit_last', -1 );
$this->assertSame( '', get_the_modified_author() );
}
}