vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Meta: Improve ID casting when getting, updating or deleting meta data.

Browse Source 
Blindly casting IDs to absolute integers in `get_metadata_by_mid()`, `update_metadata_by_mid()` and `delete_metadata_by_mid()` can cause unexpected behaviour when a floating or negative number is passed.

Fixes #37746.


git-svn-id: https://develop.svn.wordpress.org/trunk@38699 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Peter Wilson
2016-10-01 06:27:27 +00:00
parent 17ef6d8cfa
commit fe0ba53c44
2 changed files with 47 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/wp-includes/meta.php
View File

@@ -567,12 +567,12 @@ function metadata_exists( $meta_type, $object_id, $meta_key ) {
function get_metadata_by_mid( $meta_type, $meta_id ) {
global $wpdb;
if ( ! $meta_type || ! is_numeric( $meta_id ) ) {
if ( ! $meta_type || ! is_numeric( $meta_id ) || floor( $meta_id ) != $meta_id ) {
return false;
}
$meta_id = absint( $meta_id );
if ( ! $meta_id ) {
$meta_id = intval( $meta_id );
if ( $meta_id <= 0 ) {
return false;
}
@@ -611,12 +611,12 @@ function update_metadata_by_mid( $meta_type, $meta_id, $meta_value, $meta_key =
global $wpdb;
// Make sure everything is valid.
if ( ! $meta_type || ! is_numeric( $meta_id ) ) {
if ( ! $meta_type || ! is_numeric( $meta_id ) || floor( $meta_id ) != $meta_id ) {
return false;
}
$meta_id = absint( $meta_id );
if ( ! $meta_id ) {
$meta_id = intval( $meta_id );
if ( $meta_id <= 0 ) {
return false;
}
@@ -702,12 +702,12 @@ function delete_metadata_by_mid( $meta_type, $meta_id ) {
global $wpdb;
// Make sure everything is valid.
if ( ! $meta_type || ! is_numeric( $meta_id ) ) {
if ( ! $meta_type || ! is_numeric( $meta_id ) || floor( $meta_id ) != $meta_id ) {
return false;
}
$meta_id = absint( $meta_id );
if ( ! $meta_id ) {
$meta_id = intval( $meta_id );
if ( $meta_id <= 0 ) {
return false;
}