From ff0b2f7a6f99f752b0c8ee4c1d597cbd420775c7 Mon Sep 17 00:00:00 2001 From: Jeremy Felt Date: Mon, 23 Feb 2015 02:28:41 +0000 Subject: [PATCH] Provide proper label associations and descriptions throughout the network admin * Add labels previously missing for many inputs throughout the network admin screen. * Add proper `aria-describedby` attributes to provide better descriptions. * Wrap grouped inputs with `fieldset` elements. * Remove now unneeded `title` attributes when appropriate. Props cfoellmann, afercia, rianrietveld. Fixes #38406. git-svn-id: https://develop.svn.wordpress.org/trunk@31517 602fd350-edb4-49c9-b593-d223f7449a82 --- .../includes/class-wp-users-list-table.php | 2 +- src/wp-admin/includes/dashboard.php | 6 +- src/wp-admin/includes/ms.php | 11 ++- src/wp-admin/network/settings.php | 80 ++++++++++++------- src/wp-admin/network/site-info.php | 15 ++-- src/wp-admin/network/site-new.php | 16 ++-- src/wp-admin/network/site-settings.php | 4 +- src/wp-admin/network/site-users.php | 18 ++--- src/wp-admin/network/user-new.php | 8 +- src/wp-admin/network/users.php | 5 +- 10 files changed, 98 insertions(+), 67 deletions(-) diff --git a/src/wp-admin/includes/class-wp-users-list-table.php b/src/wp-admin/includes/class-wp-users-list-table.php index be8270a67e..3b4eed95e9 100644 --- a/src/wp-admin/includes/class-wp-users-list-table.php +++ b/src/wp-admin/includes/class-wp-users-list-table.php @@ -385,7 +385,7 @@ class WP_Users_List_Table extends WP_List_Table { $edit .= $this->row_actions( $actions ); // Set up the checkbox ( because the user is editable, otherwise it's empty ) - $checkbox = '' + $checkbox = '' . ""; } else { diff --git a/src/wp-admin/includes/dashboard.php b/src/wp-admin/includes/dashboard.php index 62f3f70ca2..9f7f558eda 100644 --- a/src/wp-admin/includes/dashboard.php +++ b/src/wp-admin/includes/dashboard.php @@ -379,14 +379,16 @@ function wp_network_dashboard_right_now() {

- + + 'submit_users' ) ); ?>

- + + 'submit_sites' ) ); ?>

diff --git a/src/wp-admin/includes/ms.php b/src/wp-admin/includes/ms.php index 71129bbea3..8ef291a458 100644 --- a/src/wp-admin/includes/ms.php +++ b/src/wp-admin/includes/ms.php @@ -476,8 +476,11 @@ function upload_space_setting( $id ) { ?> - - + + + + + - + 1 ) { $found = false; ?> - userblog_id ) $found = true; diff --git a/src/wp-admin/network/settings.php b/src/wp-admin/network/settings.php index d3d8584f9e..843c2687ea 100644 --- a/src/wp-admin/network/settings.php +++ b/src/wp-admin/network/settings.php @@ -134,8 +134,8 @@ if ( isset( $_GET['updated'] ) ) { - -

+ +

@@ -151,15 +151,16 @@ if ( isset( $_GET['updated'] ) ) { $reg = get_site_option( 'registration' ); ?> +
+


-

- NOBLOGREDIRECT in wp-config.php to a URL you will redirect visitors to if they visit a non-existent site.' ); - ?> -

+ ' . __( 'If registration is disabled, please set NOBLOGREDIRECT in wp-config.php to a URL you will redirect visitors to if they visit a non-existent site.' ) . '

'; + } ?> +
@@ -184,8 +185,8 @@ if ( isset( $_GET['updated'] ) ) { - " size="45" /> -

+ " size="45" /> +

@@ -196,9 +197,9 @@ if ( isset( $_GET['updated'] ) ) { - -

+

@@ -207,9 +208,9 @@ if ( isset( $_GET['updated'] ) ) { - -

+

@@ -222,9 +223,9 @@ if ( isset( $_GET['updated'] ) ) { - -

+

@@ -232,9 +233,9 @@ if ( isset( $_GET['updated'] ) ) { - -

+

@@ -242,9 +243,9 @@ if ( isset( $_GET['updated'] ) ) { - -

+

@@ -252,9 +253,9 @@ if ( isset( $_GET['updated'] ) ) { - -

+

@@ -262,9 +263,9 @@ if ( isset( $_GET['updated'] ) ) { - -

+

@@ -272,8 +273,8 @@ if ( isset( $_GET['updated'] ) ) { - -

+ +

@@ -281,8 +282,8 @@ if ( isset( $_GET['updated'] ) ) { - -

+ +

@@ -293,18 +294,31 @@ if ( isset( $_GET['updated'] ) ) { -