Scott Taylor
46752a491e
When calling unset(), it is unnecessary to immediately precede it with a call to isset().
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32545 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 05:46:47 +00:00
Scott Taylor
e088947cea
In WP_Media_List_Table::get_views(), declare $num_posts explicitly before looping.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32517 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 20:49:59 +00:00
Scott Taylor
17fff532cd
In WP_Comments_List_Table::column_comment(), all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32516 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 20:45:36 +00:00
Dion Hulse
047c2fdadd
Allow plugins to activate other plugins within their Activation hook. Fixes #32368
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32504 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-14 06:57:47 +00:00
Dominik Schilling (ocean90)
ca2cd7405c
List Table: Add placeholder to a plural string.
...
props SergeyBiryukov.
fixes #32034 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32473 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 19:21:38 +00:00
Dominik Schilling (ocean90)
3df6a4a9da
Sites List Table: Replace context with a translators comment for the site name and tagline.
...
props ramiy.
fixes #31849 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32472 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 19:18:00 +00:00
Dominik Schilling (ocean90)
ff4f261101
Merge similar error strings.
...
props pavelevap.
fixes #32327 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32471 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 18:26:37 +00:00
Gary Pendergast
733e06315a
Upgrades: If a table has already been converted to utf8mb4, there's no need to try and convert it again.
...
Props gabrielperezs for the initial patch.
See #32310 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32456 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 12:21:18 +00:00
Michael Adams (mdawaffe)
80238b81d6
Upgrade: Since MySQL may auto-expand column widths when changing a column's character set, we must do our length-based comment checks prior to the character set changes.
...
Props jorbin, et alii.
See #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32440 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 01:10:05 +00:00
Michael Adams (mdawaffe)
89b384a05a
Upgrade: $wpdb->get_col_length() sanity check: bail on unexpected return value.
...
See #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32429 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 23:10:18 +00:00
Michael Adams (mdawaffe)
a42401d0c9
Upgrade: Ensure unintelligible DB schemas don't result in content loss.
...
See #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32417 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 21:45:58 +00:00
Aaron Jorbin
1417929e0d
When upgrading WordPress remove genericons example.html files
...
Props @dd32, @boone, @johnjamesjacoby, @drewapicture, @jorbin
--This line,build.wordpress-develop.dea and those below, will be ignored--
M src/wp-admin/includes/update-core.php
git-svn-id: https://develop.svn.wordpress.org/trunk@32385 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 18:36:48 +00:00
Sergey Biryukov
2b8e7270d5
Multisite: Add translator comments to default email messages with non-typical placeholders.
...
props yoavf.
fixes #32263 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32381 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 09:11:18 +00:00
Gary Pendergast
9e12deeb9c
Fix an incorrect version number check in [32378].
...
See #32099 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32379 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 07:40:36 +00:00
Gary Pendergast
ca11cafb07
Upgrades: When converting to utf8mb4, we were trying to change the wrong index on wp_signups, causing the conversion to later fail.
...
Props kovshenin, pento.
See #32099 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32378 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 07:33:53 +00:00
Gary Pendergast
2ce97b2984
WPDB: When checking that a string can be sent to MySQL, we shouldn't use mb_convert_encoding(), as it behaves differently to MySQL's character encoding conversion.
...
Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.
See #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32364 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 02:59:50 +00:00
Drew Jaynes
3ca1ff6b72
Fix documentation syntax and formatting for the media_sideload_image() DocBlock.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32352 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:19:47 +00:00
Drew Jaynes
7138b7e1bd
Add two changelog entries for functional changes introduced in 4.2.0.
...
Props dimadin.
See #31925 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32350 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:15:27 +00:00
Drew Jaynes
eea4111667
Add a missing DocBlock for wp_caption_input_textarea().
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32341 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:12:12 +00:00
Drew Jaynes
b7bce33748
Add a missing @return tag to the DocBlock for `uninstall_plugin().
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32340 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:07:47 +00:00
Drew Jaynes
5a45289302
Add a missing @return tag to the DocBlock for site_admin_notice().
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32339 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:05:48 +00:00
Drew Jaynes
511ce10e53
Clarify accepted types for the $args and $context parameters in WP_Filesystem().
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32338 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:03:08 +00:00
Sergey Biryukov
2848b8a911
Replace echo __() with _e().
...
props marsjaninzmarsa.
fixes #32239 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32333 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-03 16:17:06 +00:00
Scott Taylor
625e7135f3
After [32258], restore the parts of [31620] and [31626] that weren't changes to the UI, but were improvements to existing code.
...
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.
See #31139 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32330 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 21:39:52 +00:00
Sergey Biryukov
345d34cad9
Bulk Edit: Properly associate the Format select with its label.
...
props afercia.
fixes #32210 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32329 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 16:03:06 +00:00
Dion Hulse
342989657f
When creating a temporary file treat the / directory properly, to prevent it ending up in an endless self-calling loop.
...
Props hnle, taka2. Fixes #32135 . See #31811
git-svn-id: https://develop.svn.wordpress.org/trunk@32322 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 03:16:06 +00:00
Gary Pendergast
0b868edb8e
When deleting suspicious comments, do so permanently.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32310 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:10:50 +00:00
Gary Pendergast
ae1f6413c9
[32308] was for 4.3, not 4.2.1.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32309 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:07:20 +00:00
Gary Pendergast
0224286861
When upgrading to 4.2.1, delete suspicious comments.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32308 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:03:48 +00:00
Dominik Schilling (ocean90)
2abf4c39ef
Don't focus input fields outside of the request filesystem credentials form.
...
props valendesigns.
fixes #32055 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32266 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:23:57 +00:00
Dominik Schilling (ocean90)
ca11d4c876
Don't return empty themes in wp_prepare_themes_for_js().
...
see #32002 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32264 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:10:40 +00:00
Andrew Ozz
925682e2d1
Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
...
Props iseulde. Fixes #31139 , fixes #32006 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32258 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 22:40:23 +00:00
Helen Hou-Sandi
b7d25c00e2
Rename the pre_wp_prepare_themes_for_js filter to pre_prepare_themes_for_js.
...
props DrewAPicture.
fixes #31789 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32246 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:22:15 +00:00
Gary Pendergast
05710aaa41
Ensure post titles are correctly escaped on the Dashboard.
...
Props helen, ocean90, dd32, pento.
git-svn-id: https://develop.svn.wordpress.org/trunk@32175 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 07:38:29 +00:00
Sergey Biryukov
3c28d7b1f6
Press This: Update documentation for press_this_save_redirect filter after [31992].
...
props kraftbj.
fixes #31996 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32143 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-19 01:34:01 +00:00
Dominik Schilling (ocean90)
7fba67e4b7
Customizer: Escape theme preview URLs.
...
props johnbillion, ocean90.
see #31896 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32134 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 16:32:03 +00:00
Scott Taylor
91143924cd
Move the built media JS files up a directory to their previous location and naming convention. This fidgets with part of [31373] and will maintain BC for those who were loading those files directly (not using the enqueue system).
...
Props iseulde, ocean90.
Fixes #31912 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32125 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-14 15:30:16 +00:00
Andrew Ozz
f3033a9f5a
Press This: do not show the bookmarklet upgrade notice when accessing directly press-this.php.
...
Props kraftbj. Fixes #31968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32122 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-14 05:44:08 +00:00
Dominik Schilling (ocean90)
b0d6757918
Use HTTPS URLs for codex.wordpress.org.
...
see #27115 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32116 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-12 21:28:58 +00:00
Gary Pendergast
b806e118c6
When dbDelta() is checking whether an index is defined in a CREATE TABLE statement, don't worry if MySQL has a subpart defined on an index, but the CREATE TABLE doesn't.
...
Fixes #31869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32108 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-11 10:39:49 +00:00
Andrew Ozz
301bb0b9da
Press This: check the bookmarklet version and add the update notice from PHP.
...
Fixes #31942 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32106 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-10 21:07:42 +00:00
Andrew Ozz
6cf43dfc06
Press This: add ARIA attributes to the alerts container.
...
Props afercia. Fixes #31942 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32102 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-09 23:44:50 +00:00
Andrew Ozz
47754dfc55
Press This: change the link text to Standard Editor.
...
Props Michael-Arestad. See #31923 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32093 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 23:27:04 +00:00
Andrew Ozz
bd8cb111ed
Press This:
...
- When saving a draft change the text of the Save Draft button to Saving...
- On success, hide the button and show Edit Post link in its place. If the user focuses the title or the editor, hide the link and show the button again.
Fixes #31923 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32092 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 23:13:35 +00:00
Boone Gorges
7d18785497
Don't allow whitespace-only image captions from the Media modal.
...
Captions containing only whitespace trick `image_add_caption()` into thinking
a caption is required, but the empty caption text confuses wpeditimage into
stripping the 'align' class specified by the user.
Fixes #21848 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32079 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 17:10:53 +00:00
Aaron Jorbin
852937d006
Update placeholder for FTP credentials
...
Two changes:
* Remove superfluous __ function call
* Update domain used
Fixes #31922
Props Tmeister
git-svn-id: https://develop.svn.wordpress.org/trunk@32077 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 16:49:22 +00:00
Aaron Jorbin
43623c464c
Enable users to initiate a shiny update from plugin detail modal
...
The plugin detail modal can contain a link to update a plugin. When it does, we should initiate a shiny update.
This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on. These are the same users that can't use the customizer.
Fixes #31739
git-svn-id: https://develop.svn.wordpress.org/trunk@32062 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 03:08:38 +00:00
Helen Hou-Sandi
2f368bf396
Insert from URL: Make sure the link text is actually used.
...
Turns out there were more pieces to renaming the field.
props iseulde.
fixes #29476 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32055 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-06 18:24:53 +00:00
Helen Hou-Sandi
f64bf71719
Update more instances of default admin blues and grays.
...
props hugobaeta.
fixes #31234 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32051 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 21:19:54 +00:00
Sergey Biryukov
0e236b6e72
wp_install_maybe_enable_pretty_permalinks() should have a consistent @return value.
...
props DrewAPicture.
fixes #6481 . see #31888 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32027 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 14:48:23 +00:00