Commit Graph
183 Commits
Author SHA1 Message Date
Drew Jaynes 5cf0ef170a Docs: Standardize capitalization of Ajax throughout core documentation per the core spelling guide.
Ajax, while considered an acronym for Asynchronous JavaScript and XML, is most commonly capitalized only in the first character.

Part props ocean90.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@38028 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-10 00:50:21 +00:00
Drew Jaynes 871fadef86 Docs: Improve usefulness of DocBlocks for ajax-actions.php functions introduced in 4.6.
See #37318.


git-svn-id: https://develop.svn.wordpress.org/trunk@38022 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-09 13:22:57 +00:00
Sergey Biryukov 83e3bc084b Text Changes: Remove duplicate string, use the one we already have.
See #34521.

git-svn-id: https://develop.svn.wordpress.org/trunk@37960 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-04 22:09:32 +00:00
Sergey Biryukov f4d197c534 Text Changes: Remove duplicate string, use the one we already have.
See #34521.

git-svn-id: https://develop.svn.wordpress.org/trunk@37956 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-04 21:36:55 +00:00
Gary Pendergast b3a6124e3d General: Remove the Pragma header from responses.
`Pragma` is supposed to be a request header, but we've been including it in responses since the beginning of time.

This is a relic dating all the way back to b2, probably originally added because Internet Explorer version 5 and earlier didn't understand the `Cache-Control` header in responses, but they did (incorrectly) obey the `Pragma` header.

Internet Explorer 6 and 7 will obey the `Pragma` response header only if no other cache-related response headers are present (in our case, they are always present), and all other browsers ignore the `Pragma` response header.

Props geekysoft.
Fixes #37250.



git-svn-id: https://develop.svn.wordpress.org/trunk@37944 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-04 04:01:19 +00:00
Dominik Schilling (ocean90) 206380180e Text Changes: Unify permission error messages.
The new format looks like "Sorry, you are not allowed to <action>.". This provides a consistent experience for all error messages related to missing permissions. It also reduces the number of similar strings and allows translators to provide a consistent style in their language.

Props ramiy, Presskopp.
Fixes #34521.

git-svn-id: https://develop.svn.wordpress.org/trunk@37914 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-29 15:15:40 +00:00
ocean90 3715a70613 Posts: In wp_ajax_inline_save(), do not apply level for non-hierarchical post types.
Props Offereins.
Fixes #35010.

git-svn-id: https://develop.svn.wordpress.org/trunk@37913 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-29 14:06:01 +00:00
Rachel Baker f28d567989 Revisions: Change the capability needed to view revision diffs to edit_post.
git-svn-id: https://develop.svn.wordpress.org/trunk@37779 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-21 14:19:26 +00:00
Rachel Baker cf783103fc Comments: Wrap or unwrap the List Table comment_date as comment status changes via Ajax.
Introduced in [36521].

Fixes #36742.
Props imath, adamsilverstein.

git-svn-id: https://develop.svn.wordpress.org/trunk@37743 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-17 21:47:58 +00:00
Andrew Ozz faf7576562 Editor: after inserting a link detect if the URL is broken, first run.
Props iseulde, azaozz.
See #36638.

git-svn-id: https://develop.svn.wordpress.org/trunk@37741 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-17 20:40:04 +00:00
Konstantin Obenland 4dd1d9bef9 Update/Install: Shiny Updates v2.
Gone are the days of isolation and feelings of "meh", brought on by The Bleak Screen of Sadness. For a shiny knight has arrived to usher our plugins and themes along their arduous journey of installation, updates, and the inevitable fate of ultimate deletion.

Props swissspidy, adamsilverstein, mapk, afragen, ocean90, ryelle, j-falk, michael-arestad, melchoyce, DrewAPicture, AdamSoucie, ethitter, pento, dd32, kraftbj, Ipstenu, jorbin, afercia, stephdau, paulwilde, jipmoors, khag7, svovaf, jipmoors, obenland.
Fixes #22029, #25828, #31002, #31529, #31530, #31773, #33637, #35032.



git-svn-id: https://develop.svn.wordpress.org/trunk@37714 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-15 16:36:07 +00:00
Peter Wilson db0195c936 DOCS: Replace HTTP links with HTTPS.
Replaces unsecure links in documentation and translator comments with their secure versions.

Props johnpgreen, netweb

Fixes #36993


git-svn-id: https://develop.svn.wordpress.org/trunk@37674 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-10 04:49:09 +00:00
Rachel Baker 8910870205 Comments: Fix pagination totals in the response of the inline delete actions when filtering the List Table by comment_type.
Within the Ajax action `_wp_ajax_delete_comment_response()` if the comment_type query var is set, fallback to the previous `$total - 1` value instead of getting an incorrect value from `wp_comment_count()`.

Fixes #36991.

git-svn-id: https://develop.svn.wordpress.org/trunk@37664 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-09 02:21:27 +00:00
Rachel Baker 3ba3c42728 Comments: Display approved comments on the Edit Post screen to users without the edit_comment capability.
Matches logic in `wp_dashboard_recent_comments()` where we display approved comments regardless of the edit permission.

Props jfarthing84 for initial patch.
Fixes #24648. 



git-svn-id: https://develop.svn.wordpress.org/trunk@37584 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-27 14:09:29 +00:00
Drew Jaynes 2111185ab9 Docs: Apply inline @see tags to hooks referenced in DocBlocks for wp-admin/* files.
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.


git-svn-id: https://develop.svn.wordpress.org/trunk@37537 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-23 17:27:19 +00:00
Drew Jaynes 1cd420af5e Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37488 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 18:00:23 +00:00
Drew Jaynes 195572596b Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.


git-svn-id: https://develop.svn.wordpress.org/trunk@37431 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-13 18:40:19 +00:00
Dominik Schilling (ocean90) 153610292d Media: Remove an extra quote when sending a link of a media file to the editor.
Introduced in [37035].

Props joemcgill, swissspidy, boonebgorges.
Fixes #36578.

git-svn-id: https://develop.svn.wordpress.org/trunk@37288 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 21:20:26 +00:00
Aaron Jorbin 565ac1efc6 Remove Debugging code introduced in [37145]
git-svn-id: https://develop.svn.wordpress.org/trunk@37148 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 18:57:26 +00:00
Aaron Jorbin bd0c3bf0c7 Add Nonce to updating wporg_favorites user meta field
git-svn-id: https://develop.svn.wordpress.org/trunk@37145 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 18:35:37 +00:00
Nikolay Bachiyski f1680acb86 Add nonce to AJAX action for script compression setting
git-svn-id: https://develop.svn.wordpress.org/trunk@37143 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 18:20:31 +00:00
Andrew Ozz 058a2f558d Media: fix erroneously inserting a rel attribute in get_image_send_to_editor(). Reverts most of [34259] and [34260] and adds a unit test.
Props joemcgill, azaozz.
Fixes #36084.

git-svn-id: https://develop.svn.wordpress.org/trunk@37035 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-18 20:04:19 +00:00
Drew Jaynes 3aaf9506ce Docs: Mark two private functions as such in wp-admin/ajax-actions.php.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36472 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-03 20:16:42 +00:00
Ella Iseulde Van Dorpe b780792d87 TinyMCE: add inline link dialog
First run.
Links the advanced button to the "old" dialog for now.

See #33301.


git-svn-id: https://develop.svn.wordpress.org/trunk@36384 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-23 00:07:29 +00:00
John Blackbourn aaa61e80e4 Docs: Correct the parameter docs for various Heartbeat filters and functions.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36231 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 01:36:45 +00:00
Ella Iseulde Van Dorpe 14c3f3c871 Make date format consistent across the admin
The 'date_format' and 'time_format' options shouldn't affect the backend.

See #30864



git-svn-id: https://develop.svn.wordpress.org/trunk@35811 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-07 04:25:53 +00:00
Boone Gorges ded2547b57 Show user_login in Dashboard user dropdowns.
User dropdowns in wp-admin have traditionally shown the users' display names.
However, this causes ambiguity when users share display names. To correct this,
we now show the unique user_login in parentheses after the display name.

The new `display_name_with_login` value for the `show` parameter of
`wp_dropdown_users()` enables this functionality. The default value of `show`
has not been changed, for backward compatibility, but all instances of
`wp_dropdown_users()` in core wp-admin have been switched.

This changeset also reduces some duplicated logic when assembling a user list
when `include_selected` is true.

Props krogsgard, boonebgorges.
Fixes #31251.

git-svn-id: https://develop.svn.wordpress.org/trunk@35790 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:56:11 +00:00
Helen Hou-Sandi 3e85312bbf Media: Avoid rel="rel=" situations.
props lucymtc, swissspidy.
fixes #34826. see #32074.


git-svn-id: https://develop.svn.wordpress.org/trunk@35760 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-03 17:16:57 +00:00
Mark Jaquith baa1da6c57 Do not pass FALSE as second parameter in variable class_exists() checks
Because these are generally plugin-provided, we want plugins to be
able to use autoloaders.

fixes #20523

git-svn-id: https://develop.svn.wordpress.org/trunk@35749 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-30 04:14:31 +00:00
Dominik Schilling (ocean90) 32d4eec670 Themes: Check if the browse view is set in wp_ajax_query_themes() to avoid a PHP notice when searching for new themes.
Introduced in [35527].

See #34206.

git-svn-id: https://develop.svn.wordpress.org/trunk@35646 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 19:46:37 +00:00
Sergey Biryukov 1631a99336 Themes: Add a Favorites tab to the Add Themes screen.
You can now browse and install your wordpress.org theme favorites from the theme installer, just like with plugins.

Props swissspidy.
Fixes #34206.

git-svn-id: https://develop.svn.wordpress.org/trunk@35527 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 21:48:43 +00:00
Dominik Schilling (ocean90) 5ee5029109 List Tables: Define the global $mode variable for Quick Edit savings.
Also remove two unused global imports for `$mode`.

Fixes #34577.

git-svn-id: https://develop.svn.wordpress.org/trunk@35518 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 21:28:55 +00:00
Scott Taylor a18feed6bd Nav Menus: show custom post type Archive item at the top of the View All tab for the post type on the legacy Nav Menu screen.
Props aaroncampbell, DrewAPicture, seanchayes, hlashbrooke, paulwilde, ericlewis, raulillana
See #16075.


git-svn-id: https://develop.svn.wordpress.org/trunk@35382 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 17:45:11 +00:00
dd32 f935d4c26b Updates: Add a generic failure case to the ajax update endpoint for when the WP_Error value hasn't been found.
See #34403


git-svn-id: https://develop.svn.wordpress.org/trunk@35371 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 07:34:02 +00:00
Andrew Ozz 7ba408c93e Widgets: add a button to delete all inactive widgets simultaneously for better UX.
Props cdog.
Fixes #19159.

git-svn-id: https://develop.svn.wordpress.org/trunk@35317 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 05:22:52 +00:00
Drew Jaynes c163beb1db Docs: Standardize file header summary for wp-admin/includes/ajax-actions.php.
See #33701.

[ci skip]


git-svn-id: https://develop.svn.wordpress.org/trunk@35168 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 22:48:24 +00:00
Sergey Biryukov 975c16f4b2 Use wp_star_rating() on Add Themes screen:
* It works correctly for RTL
* Requires less CSS styling
* Is visually consistent with plugin ratings
* Is more accessible

Fixes #34080.

git-svn-id: https://develop.svn.wordpress.org/trunk@35006 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 06:50:35 +00:00
Jeremy Felt 599fb50e09 Revert [34778], continue using _site_option() for the current network.
The `_network_option()` parameter order will be changing to accept `$network_id` first. The `_site_option()` functions will remain in use throughout core as our way of retrieving a network option for the current network.

See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34912 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 17:11:01 +00:00
Jeremy Felt 3c177b8c6f MS: Use *_network_option() functions throughout core.
Replaces all uses of `*_site_option()` with the corresponding "network" function.

This excludes one usage in `wp-admin/admin-footer.php` that needs more investigation.

Props spacedmonkey.
See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34778 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-02 19:07:23 +00:00
Drew Jaynes a774dfbb08 Widgets: Introduce a delete_widget action, which fires after a widget has been marked for deletion.
Props afercia for the initial patch.
Fixes #27444.


git-svn-id: https://develop.svn.wordpress.org/trunk@34714 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-30 03:20:41 +00:00
Scott Taylor c0ebd3b5e2 Comments: update Comment counts dynamically in the Right Now widget based on moderation actions in the Activity widget.
Fixes #10422.


git-svn-id: https://develop.svn.wordpress.org/trunk@34500 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 15:52:41 +00:00
Scott Taylor ed7d34cb13 Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload().
Fixes #20523.


git-svn-id: https://develop.svn.wordpress.org/trunk@34348 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:51:55 +00:00
Dominik Schilling (ocean90) 0c642e4730 Use correct @since tag for wp_ajax_generate_password().
See #33450.

git-svn-id: https://develop.svn.wordpress.org/trunk@34313 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:18:22 +00:00
Scott Taylor 1299974e7d Profile: when clicking "Cancel" after clicking "Generate Password", request and generate a new password to present to the user.
Props adamsilverstein, wonderboymusic.
Fixes #33450.


git-svn-id: https://develop.svn.wordpress.org/trunk@34312 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:13:34 +00:00
Sergey Biryukov 039ce30818 Include placeholder in translator comment.
See #31864.

git-svn-id: https://develop.svn.wordpress.org/trunk@34305 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 19:00:20 +00:00
Scott Taylor de077ac377 Don't use HTML tags in translation strings in wp_ajax_add_user().
Props ramiy.
Fixes #31864.


git-svn-id: https://develop.svn.wordpress.org/trunk@34302 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:50:04 +00:00
Scott Taylor 189bc9b5aa Media: In wp_ajax_send_attachment_to_editor(), the fallback logic for $html should be tucked into an else statement so it isn't run needlessly and overwritten.
Props tychay.
Fixes #32072.


git-svn-id: https://develop.svn.wordpress.org/trunk@34260 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 05:54:56 +00:00
Scott Taylor c0d850878a Create a function, get_preview_post_link(), to DRY the logic for applying the 'preview_post_link' filter to a URL.
Props TomHarrigan, wonderboymusic.
Fixes #24345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34170 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 04:14:23 +00:00
Scott Taylor 577fea566a Don't ever use the guid value when retrieving URLs for media, use wp_get_attachment_url(). Use get_attached_file() for path to file.
Fixes #33386.


git-svn-id: https://develop.svn.wordpress.org/trunk@34163 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 02:49:12 +00:00
Scott Taylor 5c85369bb6 In _wp_ajax_delete_comment_response(), read the new 'all' prop returned by get_comment_count() via wp_count_comments() when setting $total. 'all' doesn't include spam in its count.
Updates unit tests.

Props dipesh.kakadiya.
Fixes #32362.


git-svn-id: https://develop.svn.wordpress.org/trunk@34161 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 01:46:51 +00:00