Commit Graph

2136 Commits

Author SHA1 Message Date
Scott Taylor
14ddc6c9c0 If IMAGE_EDIT_OVERWRITE is defined as true, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical).
Props hew.
Fixes #30394.


git-svn-id: https://develop.svn.wordpress.org/trunk@31043 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-04 02:51:20 +00:00
Scott Taylor
621e909a9b Improve the handling of comma-separated mime-types in wp_match_mime_types(), particularly as pertains to the mime-type selector on the Media list table screen.
Props mdgl.
Fixes #30788.


git-svn-id: https://develop.svn.wordpress.org/trunk@31042 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-04 02:31:29 +00:00
Scott Taylor
efc61d054e After [31037], ensure that the library is passed as a map to the Media Grid instance. Remove useless query vars.
Fixes #30584.


git-svn-id: https://develop.svn.wordpress.org/trunk@31041 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-04 02:06:04 +00:00
Scott Taylor
5df9963414 Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library.
Fixes #30584.


git-svn-id: https://develop.svn.wordpress.org/trunk@31037 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-03 08:23:06 +00:00
Scott Taylor
ca8fe1a7a4 Use the 'not_found' label when there are no items for a taxonomy in the terms list table.
Props SergeyBiryukov.
Fixes #30586.


git-svn-id: https://develop.svn.wordpress.org/trunk@31035 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-03 06:19:46 +00:00
Scott Taylor
47f2c42528 Inline <script>s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need CDATA comments.
Props tw2113 for the initial patch.
See #18788.


git-svn-id: https://develop.svn.wordpress.org/trunk@31034 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-03 05:45:17 +00:00
Scott Taylor
d5328fc674 When outputting JS with a Content-Type header:
`text/javascript` is obsolete, `application/x-javascript` was experimental. `application/javascript` is the recommended type per RFC 4329.

Props sergej.mueller.
Fixes #29196.


git-svn-id: https://develop.svn.wordpress.org/trunk@31029 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-03 02:56:14 +00:00
Andrew Ozz
95fd7b1590 Move the (recently added) .notice admin notices below the first H2, same as the .updated and .error notices. Props sippis, fixes #30885.
git-svn-id: https://develop.svn.wordpress.org/trunk@31023 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-02 18:51:52 +00:00
Scott Taylor
64784baa95 WP_List_Table's constructor registers an 'admin_footer' callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when wp_comment_reply() invokes the class constructor without checking for the existing instance via the $wp_list_table global.
We shall check the `$wp_list_table` global in `wp_comment_reply()`.

Props sorich87.
Fixes #17413.


git-svn-id: https://develop.svn.wordpress.org/trunk@31019 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-01 19:54:53 +00:00
Scott Taylor
be8211beac Support chromeless Vimeo via MEjs:
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
6f9a78e008/src/js/me-shim.js (L631)

Fixes #29267.


git-svn-id: https://develop.svn.wordpress.org/trunk@31016 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-31 20:40:05 +00:00
Aaron Jorbin
43edd17097 Set the type attribute of the buttons for logging out of all sessions to buttons
By not setting this attribute, the buttons default to submit and as the first
submit button on the page, it causes pressing the enter key to log you out of
all sessions. This change restores the pre 4.1 behavior where pressing enter
while focused on a form field submits the form.

props ocean90
fixes #30871 for trunk



git-svn-id: https://develop.svn.wordpress.org/trunk@31010 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-31 17:32:39 +00:00
Andrew Nacin
25e332e473 Use correct function name in docs for get_plugin_data().
props eliorivero.
fixes #30699.


git-svn-id: https://develop.svn.wordpress.org/trunk@31008 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-31 08:07:09 +00:00
Boone Gorges
e85543f68b When no plugins are active, return an empty array from validate_active_plugins().
This creates parity with the behavior of the function when plugins *are* active,
but none are invalid. It also makes it possible to write unit tests for the
function.

Props sgrant.
Fixes #30860.

git-svn-id: https://develop.svn.wordpress.org/trunk@31003 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-30 19:30:07 +00:00
Boone Gorges
a441150c17 Fix incorrect @since tag introduced in [30998].
Props dimadin.
See #25853.

git-svn-id: https://develop.svn.wordpress.org/trunk@30999 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-29 17:17:09 +00:00
Boone Gorges
51d9fc0ad1 Apply 'taxonomy_parent_dropdown_args' filter when editing terms.
Added in WP 3.7 [25123], the 'taxonomy_parent_dropdown_args' filter affected
only the term creation interface. This changeset introduces parity by ensuring
that it is applied when editing terms as well.

The new `$context` parameter indicates whether the filter is being applied in
a 'new' or 'edit' context.

Props TimothyBlynJacobs, DrewAPicture.
Fixes #29853.

git-svn-id: https://develop.svn.wordpress.org/trunk@30998 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-29 15:26:51 +00:00
Dominik Schilling (ocean90)
f3d83c3f6c Customizer: Use correct event variable when moving widgets to another widget area.
Fixes "ReferenceError: event is not defined error." in Firefox.

props tywayne.
fixes #30818.

git-svn-id: https://develop.svn.wordpress.org/trunk@30992 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-23 17:23:16 +00:00
Dominik Schilling (ocean90)
c05e46e4d1 Customizer: Improve IE 8 compatibility.
* Use square bracket notation for `default` keywords.
* Use Underscores `indexOf` for arrays.

props westonruter, ocean90.
fixes #30781 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@30991 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-23 17:04:47 +00:00
Scott Taylor
061bfddda9 Comment List Tables:
* Declare `$extra_items` property
* Since `->get_column_info()` overrides its parent's method, it doesn't need to set `_column_headers`, which is an undeclared property that is only used for caching the lookup after the first run in the parent class, which isn't called in the child class.
* `$_args` in `WP_List_Table` has to be `protected` for `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as is and should probably be only available via a getter.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30984 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 23:27:00 +00:00
Scott Taylor
44fe0ebf75 Correct the @param docs for arguments that are truthy/falsey.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30983 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 23:03:21 +00:00
Scott Taylor
218dd4fd6b For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30982 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:46:53 +00:00
Scott Taylor
91dcf8796b In image_size_input_fields():
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30981 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:18:12 +00:00
Scott Taylor
a75c7977b9 In wp_import_handle_upload():
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30980 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 21:09:11 +00:00
Scott Taylor
f6f12912e2 Improve some docs for @param. Remove an unneeded $wpdb global import.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30979 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 20:55:21 +00:00
Scott Taylor
04ed6499cd Improve some wp-admin/includes/class-wp-filesystem-*.php docs for @param.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30978 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 20:39:41 +00:00
Andrew Ozz
6695ac3bab Editor: when switching editor-expand off for the first time use the default editor height. Props avryl, fixes #30760 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@30977 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 19:33:01 +00:00
Andrew Nacin
26eeb623a6 About page: CDN images.
git-svn-id: https://develop.svn.wordpress.org/trunk@30971 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-18 17:54:43 +00:00
Helen Hou-Sandi
908a2e87c8 Ensure inline code examples stay LTR, punctuation and all.
props alex-ye.
see #30748.


git-svn-id: https://develop.svn.wordpress.org/trunk@30952 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:21:54 +00:00
Helen Hou-Sandi
d34709eaa5 About page: Don't allow tab text to wrap.
Some language, browser, and OS combinations (notably Arabic, Chrome, and Windows) were wrapping.

see #30743.


git-svn-id: https://develop.svn.wordpress.org/trunk@30951 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:01:42 +00:00
Dominik Schilling (ocean90)
fabd47a2ff About: Fix the WordPress badge.
`css-clean` (minifies our CSS) has an issue when using multiple backgrounds and background position together. Instead of relying on browser support for multiple backgrounds to display the WP logo as SVG, use the `.svg` CSS class.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30946 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:53:25 +00:00
Dominik Schilling (ocean90)
7560f4cf8c Pass locale to wordpress.org theme/plugin API.
In the future this will be used to return localized plugin/theme info.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30944 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:38:52 +00:00
Andrew Nacin
b4dc6629cd Last about page string. props celloexpressions. fixes #30435.
git-svn-id: https://develop.svn.wordpress.org/trunk@30929 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 21:26:34 +00:00
John Blackbourn
9189fbcff9 Make the DFW paragraph on the About page narrower to mitigate an orphan in Firefox.
See #30435
Props melchoyce


git-svn-id: https://develop.svn.wordpress.org/trunk@30921 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 20:01:56 +00:00
John Blackbourn
2069d52fa1 Move a <code> tag out of a localised string on the About page.
Props pavelevap
See #30435


git-svn-id: https://develop.svn.wordpress.org/trunk@30903 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 14:03:53 +00:00
Andrew Nacin
daf16cdb63 Call it 'Distraction-free writing mode' and update the help string. fixes #30657.
git-svn-id: https://develop.svn.wordpress.org/trunk@30890 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 10:06:17 +00:00
Andrew Nacin
855ff22a53 Update/add plugin recommendation strings.
Update [30887], add a translation function to the Vine string.

fixes #30337. see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30889 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 10:05:09 +00:00
Andrew Nacin
07e7f03373 Updates to the 'Log out everywhere' implementation.
* Include a message and a disabled button when you're only logged in at one location.
 * Avoid leaking the session token in HTML.
 * Simplify, simplify, simplify.

see #30264.


git-svn-id: https://develop.svn.wordpress.org/trunk@30888 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 09:15:01 +00:00
Andrew Nacin
82d0ba4b60 Finalize two more about page strings. see #30435.
git-svn-id: https://develop.svn.wordpress.org/trunk@30887 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 08:57:11 +00:00
Dominik Schilling (ocean90)
c959c4d4b3 Customizer: Add _wp_attachment_is_custom_background meta to uploaded background images.
Adds `$type` property to `WP_Customize_Background_Image_Control` (PHP) and introduces `wp.customize.BackgroundControl` (JS).

see #30707.

git-svn-id: https://develop.svn.wordpress.org/trunk@30885 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 23:27:17 +00:00
Dominik Schilling (ocean90)
d5299a9522 Autoprefixer for [30857].
see #30435.

git-svn-id: https://develop.svn.wordpress.org/trunk@30884 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 23:19:06 +00:00
John Blackbourn
0533e9bd8c Correct the height of the search type select element when searching the plugin directory.
See #30719
Props pavelevap, eliorivero


git-svn-id: https://develop.svn.wordpress.org/trunk@30879 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 22:31:35 +00:00
Dominik Schilling (ocean90)
663d12c8f8 Customizer: Remove date filter from the Header/Background Image upload frames.
Adds an option to `wp.media.view.AttachmentsBrowser` to hide the date filter added in [29813].

see #30689.

git-svn-id: https://develop.svn.wordpress.org/trunk@30872 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 20:26:54 +00:00
Dominik Schilling (ocean90)
c17317912a Customizer: Import missing wp.customize.Control.prototype._toggleActive.
Check also if `completeCallback` is set before calling it.

props westonruter.
see #30701.

git-svn-id: https://develop.svn.wordpress.org/trunk@30871 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 19:53:55 +00:00
Dion Hulse
28e22a4ec4 Background Updates: Pass back whether Group Writable support is being leveraged for an update to the WordPress.org API.
See #30245


git-svn-id: https://develop.svn.wordpress.org/trunk@30860 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 14:07:35 +00:00
Andrew Nacin
5c04326ba6 About page design for 4.1.
props melchoyce and ryelle, who again outdid themselves.
see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30857 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 10:46:43 +00:00
Andrew Nacin
b38c603682 Rename _wp_clear_update_cache() to wp_clean_update_cache().
This makes it match most cache-clearing functions, including the ones it wraps. Also no need for it to be prefixed as "private."

wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear.

see #30369.


git-svn-id: https://develop.svn.wordpress.org/trunk@30856 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 08:54:14 +00:00
Andrew Nacin
0375edc8c6 No need for wp_get_password_hint() to be prefixed as if it is private.
see #21243.


git-svn-id: https://develop.svn.wordpress.org/trunk@30855 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 08:33:48 +00:00
Andrew Ozz
34a2576fd6 Editor, new DFW: fix fading out for the right sidebar in IE. Fixes #30714.
git-svn-id: https://develop.svn.wordpress.org/trunk@30853 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 03:08:12 +00:00
Andrew Ozz
284bfd81b9 Improve the fix for menu shakiness when over-scrolling. Recalculate heights on editor auto-resize.
See #30692.

git-svn-id: https://develop.svn.wordpress.org/trunk@30852 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 00:10:18 +00:00
Dominik Schilling (ocean90)
326d7f8c5f Customizer: Re-add the possibility to remove and restore a default background image.
see #21483.
fixes #30683 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@30849 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-14 19:36:27 +00:00
Andrew Ozz
35c763f795 Fix menu shakiness when over-scrolling in Chrome and Safari on MacOS.
See #30692.

git-svn-id: https://develop.svn.wordpress.org/trunk@30844 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-14 01:46:39 +00:00