Boone Gorges
086f2b9dbd
Fix database schema update introduced in [30121].
...
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.
Fixes #22023 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30134 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:10:04 +00:00
Scott Taylor
0ae3ac0c05
Revisions modules should not rely on global settings:
...
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax
Props ericlewis, wonderboymusic.
Fixes #30219 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30131 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:38:21 +00:00
Scott Taylor
8d2595d7ff
Set revision.settings via short-circuit check for window property: window._wpRevisionsSettings || {}
...
Props ericlewis.
Fixes #30218 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30130 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:19:17 +00:00
Scott Taylor
ee56980498
Add a single responsibility function for outputting Revisions JS templates: wp_print_revision_templates().
...
Use it in `wp-admin/revision.php`.
Props ericlewis.
Fixes #30220 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30129 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:14:45 +00:00
Scott Taylor
c684779022
Allow revision Backbone classes to be used on pages other than revision.php.
...
Props ericlewis.
Fixes #30221 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30128 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:07:34 +00:00
Scott Taylor
55613648fd
Add some JSDoc blocks to revisions.js.
...
Props ericlewis.
See #30222 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30127 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 23:54:50 +00:00
Dominik Schilling (ocean90)
40adc7ae16
Customizer: Improve ColorControl's wpColorPicker to update UI based on setting changes.
...
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.
props westonruter.
fixes #30031 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30126 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 20:44:19 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd
Correct references of @uses $wpdb in core documentation to use @global.
...
See #30191 , [30105].
Fixes #30217 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 17:55:39 +00:00
Boone Gorges
5073448de6
Bump db_version and add upgrade routine for schema change in [30056].
...
Fixes #22023 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30121 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 16:02:08 +00:00
Sergey Biryukov
f9dc501655
Use correct file name in a hook comment.
...
props wedi.
fixes #30200 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30117 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 18:34:03 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0
Remove redundant and erroneous @uses tag from most core inline documentation.
...
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.
Fixes #30191 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 01:04:55 +00:00
Dominik Schilling (ocean90)
e999d15f44
Customizer: Fix missing newly added widgets in the preview after [29905].
...
props westonruter.
fixes #29983 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30104 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:56:53 +00:00
Dominik Schilling (ocean90)
90182015e7
Improve/introduce Customizer JavaScript models for Controls, Sections, and Panels.
...
* Introduce models for panels and sections.
* Introduce API to expand and focus a control, section or panel.
* Allow deep-linking to panels, sections, and controls inside of the Customizer.
* Clean up `accordion.js`, removing all Customizer-specific logic.
* Add initial unit tests for `wp.customize.Class` in `customize-base.js`.
https://make.wordpress.org/core/2014/10/27/toward-a-complete-javascript-api-for-the-customizer/ provides an overview of how to use the JavaScript API.
props westonruter, celloexpressions, ryankienstra.
see #28032 , #28579 , #28580 , #28650 , #28709 , #29758 .
fixes #29529 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30102 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:50:21 +00:00
Mark Jaquith
037e00fb15
Fix weird HiDPI screen rendering issue with theme install preview toolbar
...
fixes #28898
props ocean90
git-svn-id: https://develop.svn.wordpress.org/trunk@30101 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:35:27 +00:00
John Blackbourn
6fcb1bf817
Add a hidden submit button to the Appearance -> Header screen so keyboard users can submit the form correctly when a default image provided by the theme is in use.
...
Fixes #20880 .
Props kovshenin, joedolson.
git-svn-id: https://develop.svn.wordpress.org/trunk@30095 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 21:40:58 +00:00
John Blackbourn
32d38fc080
Introduce some actions and filters which aid plugins in revisioning post meta.
...
* `wp_save_post_revision_post_has_changed` filter which can be used to determine if a post has been changed, and therefore if a revision should be created for a post.
* `wp_get_revision_ui_diff` filter which can be used to filter the fields displayed in the post revision diff UI.
* `wp_creating_autosave` action which is fired just before an autosave is created.
See #20564 .
Props mattheu, adamsilverstein.
git-svn-id: https://develop.svn.wordpress.org/trunk@30091 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 19:01:15 +00:00
Mark Jaquith
7f0f887357
Increase both mystery and humanism
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30089 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 03:19:45 +00:00
Aaron Jorbin
233946b852
Update images based on grunt imagemin
...
The new version of imagemin that was added in r30059 condenses some images more.
see #30141
git-svn-id: https://develop.svn.wordpress.org/trunk@30079 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 22:01:12 +00:00
Scott Taylor
45a635d8c2
In _wp_handle_upload(), if test_upload is set to false in the array of dangerous overrides that the function allows, the only thing that happens when an upload fails is more potential breakage.
...
`$test_uploaded_file` lets is know if `$file['tmp_name']` exists, which allows to exit with an error, instead of continuing to attempt to move the file.
`$test_upload` override is now a noop.
Fixes #28208 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30076 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:16:06 +00:00
Boone Gorges
ad4aa0b7e0
Remove UNIQUE key from 'slug' column of terms table.
...
Each slug is a unique and beautiful snowflake, but let's enforce that
uniqueness elsewhere.
Props hotchkissconsulting.
Fixes #22023 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30056 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:36:57 +00:00
Gary Pendergast
0e68ecc0b6
Add wp_json_encode(), a wrapper for json_encode() that ensures everything is converted to UTF-8.
...
Change all core calls from `json_encode()` to `wp_json_encode()`.
Fixes #28786 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30055 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:34:16 +00:00
John Blackbourn
3d35d8bc5d
Add a missing Oxford comma to the install screen. Fixes #30107 . Props Ankit K Gupta.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30054 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:31:19 +00:00
Sergey Biryukov
a32ed9e1ea
Remove one-time loop and redundant isset() checks in do_meta_boxes().
...
See [30022] for do_accordion_sections().
props ipm-frommen.
fixes #30093 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30040 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 12:57:24 +00:00
Sergey Biryukov
6c69eec02d
Make sure the validator list on Credits screen floats correctly with longer names.
...
props kosvrouvas.
fixes #30066 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30037 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 02:32:23 +00:00
Drew Jaynes (DrewAPicture)
aae8ddf48f
Add a missing asterisk in the DocBlock for write_post().
...
Also removes several `@uses` tags, which are no longer leveraged as part of the inline documentation standard.
Props tareq1988.
Fixes #30118 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30034 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 23:55:16 +00:00
John Blackbourn
bc1168e953
Rename _wp_password_hint() to _wp_get_password_hint() to bring it inline with core terminology. Fixes #21243 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30033 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 23:29:11 +00:00
Jeremy Felt
42773dc11b
Optimize site query when performing network database upgrades
...
We only use `blog_id` from the query, so we don't need a wildcard.
props marcosf
Fixes #30097
git-svn-id: https://develop.svn.wordpress.org/trunk@30029 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 22:09:46 +00:00
John Blackbourn
5567318f63
Introduce an edit_form_before_permalink action which gets fired after the title field but before the permalink fields. Fixes #29691 . Props captaintheme
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30028 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 21:48:38 +00:00
John Blackbourn
e6483ffab5
Add labels to the Personal Options input fields on the user profile editing screen. Fixes #30101 . Props Ankit K Gupta
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30027 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 21:28:50 +00:00
Sergey Biryukov
79a5303f68
Fix JSHint errors introduced in [30014].
...
props adamsilverstein.
see #29572 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30024 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 12:05:58 +00:00
Sergey Biryukov
36ee6ba8be
Remove one-time loop and redundant isset() checks.
...
props ipm-frommen.
fixes #30093 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30022 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 16:33:45 +00:00
Sergey Biryukov
8e3a90887e
Fix a copy/paste issue in Custom_Image_Header::get_header_dimensions() introduced in [27497].
...
props ipm-frommen.
fixes #30095 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30021 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 15:55:37 +00:00
Sergey Biryukov
f9101c1de9
Users screen in network admin:
...
* Remove unused $key variables.
* Rename $val to $user_id for clarity.
props ipm-frommen.
fixes #30096 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30020 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 13:51:36 +00:00
Drew Jaynes (DrewAPicture)
c61e074530
Fix an invalid type for the $section parameter in the do_settings_fields() DocBlock.
...
Props ipm-frommen.
See #30098 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30018 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 13:37:59 +00:00
John Blackbourn
37a3642183
Add the ability for a customizer control to render its controls via a JavaScript template. Switches the default color picker control to a JavaScript template. See #29572 . Props celloexpressions
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30014 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 16:31:54 +00:00
Jeremy Felt
c7ad092b1d
Deprecate admin_created_user_subject()
...
When `admin_created_user_subjec()` was merged from MU, the accompanying filter was left behind. As it has never been used by WordPress core, and is not an otherwise useful function, it can be deprecated.
Fixes #29915
git-svn-id: https://develop.svn.wordpress.org/trunk@30005 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 04:48:31 +00:00
Andrew Ozz
1880bf988c
Editor: use <button> instead of <a> for the Visual/Text buttons, make them focusable. Props afercia, fixes #27553
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30002 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 01:20:42 +00:00
Andrew Ozz
2ba822f6f1
Script-loader: remove 'heartbeat' dependency for post.js and inline-edit-post.js, fix dependencies for autosave.js. Fixes #30008
...
git-svn-id: https://develop.svn.wordpress.org/trunk@29989 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-22 03:40:13 +00:00
John Blackbourn
368bc7b468
Add a focus outline to the widget control toggle arrows. Fixes #27953 . Props TomHarrigan.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@29983 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-21 17:39:02 +00:00
Andrew Ozz
8288e31417
Admin menu:
...
- Fix scrolling the pinned menu with a mouse wheel.
- Fix pinning when the menu is only slightly taller than the viewport.
- Disable pinning on IE8, updating CSS top makes it jump when scrolling with a mouse wheel.
See #29806
git-svn-id: https://develop.svn.wordpress.org/trunk@29978 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-21 06:11:07 +00:00
Sergey Biryukov
4ea9070f8a
Fix copy/paste errors in [27769].
...
props Corphi.
fixes #30054 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29977 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 21:34:51 +00:00
Dion Hulse
f2b727f333
Filesystem: Fix the move() method of the SSH2 transport, which was using the SSH2 link rather than the SFTP link.
...
Props nobleclem. Fixes #29405
git-svn-id: https://develop.svn.wordpress.org/trunk@29970 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 07:45:52 +00:00
Dion Hulse
98c438048d
Avoid a PHP Notice in the PemFTP Library by adding a missing function parameter. This parameter is unused by WordPress.
...
Props hugodelgado. Fixes #29628
git-svn-id: https://develop.svn.wordpress.org/trunk@29969 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 07:40:41 +00:00
Boone Gorges
5bc62ad1e4
Allow apostrophes in email addresses when adding users via the Dashboard.
...
Email addresses entered in a number of interfaces were not being stripslashed
properly, with the result that the emails were not being recognized as valid.
Fixes #18039 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29966 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-19 20:29:33 +00:00
Sergey Biryukov
512ea93ae4
Live-update site title in toolbar when changing the corresponding field in General Settings.
...
props celloexpressions, avryl.
fixes #28682 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29963 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-19 09:12:11 +00:00
Sergey Biryukov
5ab446aab7
Move password hint text to a function. Add 'password_hint' filter.
...
props convissor.
fixes #21243 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29962 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 20:20:56 +00:00
Sergey Biryukov
ac90567ef1
Use proper functions for escaped translations.
...
pros jcastaneda.
fixes #30012 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29961 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 20:10:47 +00:00
Sergey Biryukov
0caa0b1dbf
In wp.updates.decrementCount(), only display the count if it's a valid non-negative integer.
...
props jdgrimes.
fixes #29527 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29960 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 19:54:40 +00:00
Sergey Biryukov
d7955317f3
Theme install:
...
* Move the "based on" string below the rating to avoid wrapping to a second line.
* Reduce the gap between the theme screenshot and description.
* Fix Install button height on mobile.
props obenland, ocean90.
fixes #28148 . see #29556 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29959 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 19:42:12 +00:00
Sergey Biryukov
97b07876cb
Themes: Make "Live Preview" the primary action and "Activate" secondary.
...
props celloexpressions.
fixes #26899 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29957 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 18:16:23 +00:00