Commit Graph
28 Commits
Author SHA1 Message Date
Drew Jaynes 6a2eaf6448 Embeds: Introduce print_embed_comments_button(), print_embed_sharing_button(), and print_embed_sharing_dialog(), which respectively output the comments button, sharing buttons, and sharing dialog elements in the embed template.
This change hooks these new output functions to existing hooks in the embed template, allowing for more straightforward display control of these elements.

Leaves the embed header and footer intact pending further modularization in a future release.

Props juliobox, swissspidy, DrewAPicture.
See #34561.


git-svn-id: https://develop.svn.wordpress.org/trunk@35689 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 20:50:53 +00:00
Ryan McCue 6ad5ee9786 REST API: Update tests for [35653]
See #34551.


git-svn-id: https://develop.svn.wordpress.org/trunk@35654 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-17 05:26:30 +00:00
Gary Pendergast 6b9ba5893f Embeds: Fix support for embedding in non-WordPress sites.
This moves the last of the iframe message code from PHP to JavaScript, so it can be included in any site, without needing to rely on any of WordPress' internal behaviour.

Props swissspidy.

Fixes #34451.



git-svn-id: https://develop.svn.wordpress.org/trunk@35577 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-09 00:07:03 +00:00
Drew Jaynes d74794fdde Docs: Correctly notate that the default $width and $height embed dimensions are passed to the embed_defaults filter as a compacted array, and not two distinct parameters.
Props swissspidy.
Fixes #34522.


git-svn-id: https://develop.svn.wordpress.org/trunk@35485 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 15:41:28 +00:00
Sergey Biryukov fbd0b570fc Embeds: In get_post_embed_html(), move the optional $post argument after the required $width and $height.
Props swissspidy.
Fixes #34523.

git-svn-id: https://develop.svn.wordpress.org/trunk@35472 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 15:50:23 +00:00
Sergey Biryukov 29f940c5b2 Embeds: In get_oembed_response_data(), make the $post argument required.
`get_oembed_response_data()` is called by the API endpoint controller and never in a context where it makes sense to use the global post object.

Props swissspidy.
See #34523.

git-svn-id: https://develop.svn.wordpress.org/trunk@35471 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 15:42:01 +00:00
Gary Pendergast 47e6c78d88 Embeds: Add fallbacks for IE7-9.
Older IE versions need just that little bit of extra tender care to keep them going.

Props peterwilsoncc, swissspidy, pento.

Fixes #34204.



git-svn-id: https://develop.svn.wordpress.org/trunk@35466 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 04:37:41 +00:00
Gary Pendergast 63d9e9df96 Embeds: Provide a cached text fallback.
Sometimes, embedded sites might suffer from less than 100% uptime. Instead of leaving the embedding site with a big blank space where the embed should be, let's fall back to a link to the embedded post, so there's at least some context for the post.

Fixes #34462.



git-svn-id: https://develop.svn.wordpress.org/trunk@35437 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 23:10:46 +00:00
Gary Pendergast 4832d8d933 Embeds: Who put this REST API infrastructure in my WordPress?
Well, while it's here, we probably should make use of it. The oEmbed endpoint now uses the REST API infrastructure, instead of providing its own.

Props swissspidy.

Fixes #34207.



git-svn-id: https://develop.svn.wordpress.org/trunk@35436 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 22:50:13 +00:00
Sergey Biryukov 391b67356a Embeds: Include post name in "Continue reading" links to provide a readable link for screenreaders.
Props swissspidy.
Fixes #34481.

git-svn-id: https://develop.svn.wordpress.org/trunk@35432 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 13:20:04 +00:00
Gary Pendergast 9387dff5af Embeds: Add a CDATA and HTML comment wrapper around the JavaScript included in the embed HTML. This ensures that user agents which naively strip unwanted tags, without also stripping the content within those tages (for example, Slack), don't show the embed as a mess of JavaScript.
Props peterwilsoncc.

Fixes #34429.



git-svn-id: https://develop.svn.wordpress.org/trunk@35406 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 23:54:04 +00:00
Gary Pendergast 887e88d7d0 Docs: Fix a typo in the print_embed_scripts() function header.
Props brainstormforce.

Fixes #34445.



git-svn-id: https://develop.svn.wordpress.org/trunk@35394 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 05:18:48 +00:00
Scott Taylor a19a0e6e72 oEmbed: if SimpleXMLElement does not exist, return an HTTP Error 501 Not implemented response.
Props swissspidy.
Fixes #34274.


git-svn-id: https://develop.svn.wordpress.org/trunk@35354 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 16:37:31 +00:00
Sergey Biryukov 8c19030438 Embeds: After [35235], replace some missed oembed references with embed.
Props peterwilsoncc.
Fixes #34272.

git-svn-id: https://develop.svn.wordpress.org/trunk@35253 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 23:25:56 +00:00
Sergey Biryukov 9b591d6b09 Embeds: Rename files, functions, and hooks added in [34903] to make it more clear what is oEmbed-specific and what isn't.
See https://core.trac.wordpress.org/ticket/34272#comment:7 for full list of renamed functions and hooks.

Props swissspidy.
Fixes #34272.

git-svn-id: https://develop.svn.wordpress.org/trunk@35235 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 01:20:19 +00:00
Sergey Biryukov 7b6454bf6b Embeds: In print_oembed_embed_styles(), load non-minified file if SCRIPT_DEBUG is true.
This is consistent with `print_oembed_embed_scripts()`.

Props MikeHansenMe.
Fixes #34321.

git-svn-id: https://develop.svn.wordpress.org/trunk@35228 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 22:42:47 +00:00
Drew Jaynes 654b633cb3 Docs: Add a missing @since version to the hook doc for the the_excerpt_embed filter, introduced in [34903].
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34975 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 23:24:28 +00:00
Drew Jaynes 85d0dfc45c Embeds: Rename the $return parameter in wp_filter_oembed_result() to $result to provide better context on what is being filtered.
See #32522.


git-svn-id: https://develop.svn.wordpress.org/trunk@34974 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 23:21:49 +00:00
Drew Jaynes f2444857eb Embeds: Combine the oembed_minwidth and oembed_maxwidth filters into one, similar to how the existing oembed_defaults works for width and height.
See #32522. See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34972 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 23:08:40 +00:00
Drew Jaynes 7c300ef221 Docs: Add missing @since versions for the oembed_minwidth and oembed_maxwidth filters, introduced in [34903].
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34971 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 22:54:14 +00:00
Drew Jaynes 2585c20b35 Docs: Adjust third-person singular verbs in DocBlock summaries for oEmbed functions introduced in [34903].
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34970 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 22:49:27 +00:00
Drew Jaynes c959cb8b9b Embeds: Fix syntax on instantiating a new WP_oEmbed_Controller instance and cross-reference in the DocBlock for wp_oembed_parse_query().
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34969 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 22:39:52 +00:00
Drew Jaynes bceea32c67 Docs: Adjust the summary for the oembed_discovery_links hook doc to mention that the filter is for HTML output.
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34968 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 22:38:10 +00:00
Drew Jaynes 43431fd8b3 Docs: Clarify the file header summary for wp-includes/embed-functions.php, and add missing parameter information for wp_oembed_parse_query(), introduced in [34903].
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34967 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 22:37:03 +00:00
John Blackbourn 6705184dcc Correctly encode the url parameter that gets passed to WordPress' own oEmbed endpoint URL.
Fixes #34193
Props ocean90


git-svn-id: https://develop.svn.wordpress.org/trunk@34915 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 21:42:36 +00:00
Gary Pendergast a170c1f67e Embeds: After [34903], remove an accidentally included text domain, and exclude a test failing in PHP 5.2.
git-svn-id: https://develop.svn.wordpress.org/trunk@34904 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 11:00:59 +00:00
Gary Pendergast 43bd3d46c9 Embeds: Add oEmbed provider support.
For the past 6 years, WordPress has operated as an oEmbed consumer, allowing users to easily embed content from other sites. By adding oEmbed provider support, this allows any oEmbed consumer to embed posts from WordPress sites.

In addition to creating an oEmbed provider, WordPress' oEmbed consumer code has been enhanced to work with any site that provides oEmbed data (as long as it matches some strict security rules), and provides a preview from within the post editor.

For security, embeds appear within a sandboxed iframe - the iframe content is a template that can be styled or replaced entirely by the theme on the provider site.

Props swissspidy, pento, melchoyce, netweb, pfefferle, johnbillion, extendwings, davidbinda, danielbachhuber, SergeyBiryukov, afercia

Fixes #32522.



git-svn-id: https://develop.svn.wordpress.org/trunk@34903 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 10:35:18 +00:00
Scott Taylor 3eb876d7e9 Embeds: move some functions from media.php to a new file, embed-functions.php, via svn cp
See #32522.


git-svn-id: https://develop.svn.wordpress.org/trunk@34851 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-06 03:58:42 +00:00