Commit Graph

150 Commits

Author SHA1 Message Date
Sergey Biryukov
920f29616a Docs: Use 3-digit, x.x.x-style semantic versioning for _doing_it_wrong(), _deprecated_function(), _deprecated_argument(), and _deprecated_file() throughout core.
Props metodiew.
Fixes #36495.

git-svn-id: https://develop.svn.wordpress.org/trunk@37985 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-06 12:39:01 +00:00
Sergey Biryukov
4eab8aab82 Users: wp_signon() expects an array as the $credentials argument, not a string.
If an empty string was passed, redeclare it as an empty array to avoid a warning and a fatal error in PHP 7.1.0 Alpha 1.

Props simonvik.
Fixes #37071.

git-svn-id: https://develop.svn.wordpress.org/trunk@37697 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-14 15:33:06 +00:00
Drew Jaynes
9531107084 Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

Fixes #36921.


git-svn-id: https://develop.svn.wordpress.org/trunk@37544 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-23 19:01:40 +00:00
Drew Jaynes
e16029e958 Docs: Standardize filter docs in wp-includes/user.php to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37503 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 18:29:11 +00:00
Drew Jaynes
c7bed4f8c6 Docs: Remove inline @see tags from function, class, and method references in inline docs.
Known functions, classes, and methods are now auto-linked in Code Reference pages following #meta1483.

Note: Hook references are still linked via inline `@see` tags due to the unlikelihood of reliably matching for known hooks based on a RegEx pattern.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@37342 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-02 03:59:56 +00:00
Jeremy Felt
32dfe766e8 Multisite: Add the pre_get_blogs_of_user filter
This allows a plugin to short circuit `get_blogs_of_user()` in cases where the default behavior of the function is unnecessary or slow. (e.g. A user is a member of thousands of sites.)

Props jsternberg.
See #31746, Fixes #36707.


git-svn-id: https://develop.svn.wordpress.org/trunk@37326 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-29 15:52:34 +00:00
Jeremy Felt
28d12c612e Users: Prevent spammy users from resetting their passwords in multisite
Props r-a-y, websupporter.
Fixes #24617.


git-svn-id: https://develop.svn.wordpress.org/trunk@37317 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-27 05:54:40 +00:00
Jeremy Felt
534f0e92a0 Users: Provide a full user object when checking for a spammy multisite user
`is_user_spammy()` falls back to the current user if one is not provided. There is no current user during authentication, so the result is always `false`. Pass a user to fill the void.

Adds tests for `wp_authenticate_spam_check()`.

Props websupporter.
Fixes #36546.


git-svn-id: https://develop.svn.wordpress.org/trunk@37316 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-27 05:35:37 +00:00
Sergey Biryukov
80601ba5f7 Docs: Reflect the new 'user' option for wp_new_user_notification()'s $notify parameter added in [37276] in wp_send_new_user_notifications() docs as well.
Props ocean90.
Fixes #36009.

git-svn-id: https://develop.svn.wordpress.org/trunk@37278 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 12:00:44 +00:00
Drew Jaynes
65277b77b6 Docs: Clarify the use of the get_currentuserinfo() for backward compatibility purposes in the DocBlock description for _wp_get_current_user(), introduced in [36651].
See #19615. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@37008 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-16 16:20:14 +00:00
Drew Jaynes
af6d494b00 Docs: Use a third-person singular verb in the DocBlock summary for wp_authenticate_email_password(), introduced in [36617].
See #9568. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@37007 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-16 16:17:04 +00:00
Dominik Schilling (ocean90)
9a7488aaf8 Spelling: Standardize on "front end"/"back end" (noun) and "front-end"/"back-end" (adjective).
Props obrienlabs, thewanderingbrit.
Fixes #34887.

git-svn-id: https://develop.svn.wordpress.org/trunk@36709 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-25 12:52:33 +00:00
Drew Jaynes
f90a37805d Docs: Make a few syntactical improvements to the DocBlock for _wp_get_current_user(), introduced in [36651].
Includes a cross reference from the DocBlock for `wp_get_current_user()`, which itself is pluggable, but the new internal function is not.

See #19615. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36705 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-25 05:06:39 +00:00
Pascal Birchler
7fdb345958 Users: Introduce _wp_get_current_user() for improved backward compatibility.
This new helper function is used by the pluggable functions `wp_get_current_user()` and `get_currentuserinfo()`, which was previously being called by the former before [36311]. Without it, infinite loops could be caused when plugins implement these functions, as they are now called the other way around.

Fixes #19615.

git-svn-id: https://develop.svn.wordpress.org/trunk@36651 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-23 22:25:32 +00:00
Dominik Schilling (ocean90)
12cf07c669 Authentication: Allow users to log in using their email address.
Introduces `wp_authenticate_email_password()` which is hooked into `authenticate` after `wp_authenticate_username_password()`.

Props Denis-de-Bernardy, ericlewis, vhomenko, MikeHansenMe, swissspidy, ocean90.
Fixes #9568.

git-svn-id: https://develop.svn.wordpress.org/trunk@36617 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-22 23:14:27 +00:00
Drew Jaynes
2caad3f7b2 Docs: Improove the DocBlock summary for wp_signon().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36501 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-07 08:10:47 +00:00
Boone Gorges
3ed7c823c9 When updating a user, invalidate its 'userslugs' cache.
`user_nicename` can be changed via `wp_update_user()`, so we invalidate just
to be safe.

Props thebrandonallen.
Fixes #35750.

git-svn-id: https://develop.svn.wordpress.org/trunk@36482 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-05 19:02:51 +00:00
Pascal Birchler
ee60e36a2c Users: Decode special characters in password and email change notification emails.
Fixes #35283.

git-svn-id: https://develop.svn.wordpress.org/trunk@36306 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-15 07:28:48 +00:00
Eric Andrew Lewis
2670f66c76 Login is not a verb, change "login" to "log in".
See #35387


git-svn-id: https://develop.svn.wordpress.org/trunk@36246 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 21:07:44 +00:00
Eric Andrew Lewis
fb1852fe5c Users: Fix incorrect docs for user authentication and login functions.
Fixes #35387


git-svn-id: https://develop.svn.wordpress.org/trunk@36245 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 20:51:13 +00:00
Sergey Biryukov
bcc607689b Docs: Correct @return type for count_user_posts().
Props nofearinc.
Fixes #35222.

git-svn-id: https://develop.svn.wordpress.org/trunk@36085 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-25 20:17:55 +00:00
Gary Pendergast
c54bcc4d39 User: Don't continue checking a password reset key, if the hash is empty.
An empty reset key hash will never be valid, so we can skip seeing if it can be used to validate the given key, and return a failure early.

This fixes a warning in the unit tests under HHVM.

See #33926.




git-svn-id: https://develop.svn.wordpress.org/trunk@36084 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-24 02:48:29 +00:00
Drew Jaynes
b56bcec8cc Docs: Add missing parameter and return descriptions to the DocBlock for _wp_get_user_contactmethods().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35986 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 16:40:18 +00:00
John Blackbourn
4ae4883372 Correct a parameter name for the allow_password_reset filter so its entry on developer.wordpress.org displays correctly.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35969 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 19:19:26 +00:00
Gary Pendergast
3025e87fa2 The the Docs: Fix the the dittography
Sometimes, it's easy to to type the the same word twice, especially if if it's a simple word. We probably shouldn't do do do (do do do doo) it, though.

(I've excluded external libs from this change.)

Fixes #34885.



git-svn-id: https://develop.svn.wordpress.org/trunk@35793 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:22:10 +00:00
Boone Gorges
ded2547b57 Show user_login in Dashboard user dropdowns.
User dropdowns in wp-admin have traditionally shown the users' display names.
However, this causes ambiguity when users share display names. To correct this,
we now show the unique user_login in parentheses after the display name.

The new `display_name_with_login` value for the `show` parameter of
`wp_dropdown_users()` enables this functionality. The default value of `show`
has not been changed, for backward compatibility, but all instances of
`wp_dropdown_users()` in core wp-admin have been switched.

This changeset also reduces some duplicated logic when assembling a user list
when `include_selected` is true.

Props krogsgard, boonebgorges.
Fixes #31251.

git-svn-id: https://develop.svn.wordpress.org/trunk@35790 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:56:11 +00:00
Boone Gorges
a1f89f4e86 Use 'invalid_username' error code when tripping 'illegal_user_logins'.
This gives us better compatibility with existing errors thrown by
`sanitize_user()`, especially in Multisite, where user_login has more
restrictions on allowed characters.

Props markjaquith.
Fixes #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35772 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 23:24:56 +00:00
Dominik Schilling (ocean90)
5f4902605e Reset Password: Add a missing new operator for WP_Error in get_password_reset_key().
Missed in [34923].

Fixes #34180.


git-svn-id: https://develop.svn.wordpress.org/trunk@35764 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 15:30:17 +00:00
Dominik Schilling (ocean90)
daa3fe4d26 Users: Allow to create users without sending an email to the new user.
This adds a checkbox to `wp-admin/user-new.php` to prevent sending an email with the username and a password reset link to the new user. Restores the behavior of pre-4.3.

Fixes #33504.
Props tharsheblows, SergeyBiryukov, DrewAPicture, ocean90.

git-svn-id: https://develop.svn.wordpress.org/trunk@35742 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-25 22:37:35 +00:00
Sergey Biryukov
3e634c753e After [35718], update the location of some files in This filter is documented in docs.
Partially reverts [33954].

Fixes #33413.

git-svn-id: https://develop.svn.wordpress.org/trunk@35725 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-22 03:50:32 +00:00
Andrew Nacin
8220d04e6d Simplify the include graph after work to split out classes.
see #33413. More details there.


git-svn-id: https://develop.svn.wordpress.org/trunk@35718 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-20 07:23:04 +00:00
Drew Jaynes
88a5649234 Docs: The User API is singular.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34397 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:02:25 +00:00
Drew Jaynes
8cc0808e3b Docs: Clarify the file header summary for wp-includes/user.php, the top-level file for the core Users API.
Also adds inline DocBlocks for the `require_once()` calls that now bring in core users functionality and the `WP_User_Query` class, as of [33749].

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33897 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:32:59 +00:00
Scott Taylor
7b58399a45 Users: move WP_User_Query into its own file. user.php loads the new files, so this is 100% BC if someone is loading user.php directly (a lot of plugins do). New files created using svn cp.
Creates: 
`class-wp-user-query.php` 
`user-functions.php` 

`user.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33749 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 04:19:32 +00:00
Drew Jaynes
bc9e25d053 Docs: Clarify the return description for wp_create_user() to illustrate that a WP_Error object will be returned on failure.
Props jmayhak
Fixes #33321.


git-svn-id: https://develop.svn.wordpress.org/trunk@33725 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 22:22:33 +00:00
Drew Jaynes
3969554606 Docs: Better clarify that the $post_type parameter for the get_usernumposts filter and count_user_posts() can accept either a single post type or array of post types.
Props tyxla
See #33481. Fixes #33520.


git-svn-id: https://develop.svn.wordpress.org/trunk@33716 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 17:45:51 +00:00
Boone Gorges
6c3449b710 Pass the $public_only value to 'get_usernumposts' filter.
[32523] introduced the `$public_only` parameter to `count_user_posts()`. That
changeset was supposed to pass `$public_only` to the 'get_usernumposts' filter
at the end of the function, but only the documentation was modified, not the
filter itself.

This changeset also fixes an incorrect variable name in the docblock for
the same filter.

Props swisspidy, tmatsuur.
Fixes #33481 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33710 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 18:58:18 +00:00
Scott Taylor
7e894153a4 In wp_insert_user(), add a filter: insert_user_meta, to filter a user's meta values and keys before the user is created or updated.
Props tharsheblows, chriscct7, DrewAPicture.
Fixes #31549.


git-svn-id: https://develop.svn.wordpress.org/trunk@33708 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 17:11:42 +00:00
Drew Jaynes
31e802293c Docs: Fix a typo in the DocBlock description for _get_additional_user_keys(), introduced in [33687].
Props dimadin
See #29120.


git-svn-id: https://develop.svn.wordpress.org/trunk@33690 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 16:00:35 +00:00
Drew Jaynes
143c3e8a87 Docs: Clarify the DocBlock summary and add a description and return description for _get_additional_user_keys().
As noted in the description, returned keys being set is dependent on the existence of those keys in user meta at the point where `_get_additional_user_keys()` is called in `wp_update_user()`.

Fixes #29120.


git-svn-id: https://develop.svn.wordpress.org/trunk@33687 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 05:32:53 +00:00
Konstantin Obenland
e7a203cdf2 Passwords: Restore second parameter for wp_new_user_notification().
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.



git-svn-id: https://develop.svn.wordpress.org/trunk@33620 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 14:24:43 +00:00
Mark Jaquith
2a25f9ce22 Change send_pass_change_email to send_password_change_email (better name).
see #32430

git-svn-id: https://develop.svn.wordpress.org/trunk@33486 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 14:51:52 +00:00
Drew Jaynes
e7e337c4e6 Fix the same typo again in the hook doc summary for the send_pass_change_email filter.
I speak English, I do.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33248 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:26:34 +00:00
Drew Jaynes
02e3c99234 Fix a typo in the hook docs summary for the send_pass_change_email filter.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33247 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:24:24 +00:00
Drew Jaynes
ce8944600a Fix the inline documentation syntax in the hook docs for the email_change_email filter, introduced in 4.3.
Also update the filter summary to reflect that the file is for an "email" change, not a "password" change.

See [32820]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33245 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:14:45 +00:00
Drew Jaynes
a15b51fc6f Fix the inline documentation syntax in the hook docs for the password_change_email filter, introduced in 4.3.
See [32820]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33244 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:10:49 +00:00
Drew Jaynes
9a0034bb78 Fix the inline documentation syntax in the hook docs for the send_email_change_email filter, added in 4.3.
See [32820]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33243 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:07:19 +00:00
Drew Jaynes
8f5107f7dc Fix the inline documentation syntax in the hook docs for the send_pass_change_email filter, added in 4.3.
See [32820]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33242 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:04:42 +00:00
Drew Jaynes
1094410e1a Wrap a long changelog entry description in the DocBlock for count_user_posts().
Also clarify the description for the new `$public_only` parameter, added in [32523].

See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33241 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:02:20 +00:00
Scott Taylor
5de7ee67ce After [32980], update the docs to reflect that display_name is now included when searching for users in some scenarios.
Fixes #27304.


git-svn-id: https://develop.svn.wordpress.org/trunk@33116 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 19:38:30 +00:00