vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
34,337 Commits 1 Branch 0 Tags 243 MiB
194583a770
Commit Graph

289 Commits

Author SHA1 Message Date
Drew Jaynes
194583a770 Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files. 
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.


git-svn-id: https://develop.svn.wordpress.org/trunk@37543 602fd350-edb4-49c9-b593-d223f7449a82
 2016-05-23 19:00:41 +00:00
Drew Jaynes
b9f3c04720 Docs: Standardize filter docs in wp-includes/media.php to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37505 602fd350-edb4-49c9-b593-d223f7449a82
 2016-05-22 18:31:20 +00:00
Andrew Ozz
33947e4ba6 Responsive Images: the src of the image has to be first in the srcset, because of a bug in iOS8. Update the unit tests to reflect the changes. 
Props jaspermdegroot, joemcgill, azaozz.
Fixes #35030.

git-svn-id: https://develop.svn.wordpress.org/trunk@37034 602fd350-edb4-49c9-b593-d223f7449a82
 2016-03-18 19:44:50 +00:00
John Blackbourn
f1af2813d3 Media: When generating the base URL to be used in the srcset attribute, use an https scheme when the image base URL's host matches that of the current host, and the request is being served over HTTPS. This prevents mixed content warnings caused by http embedded media. 
See #34945
Props joemcgill


git-svn-id: https://develop.svn.wordpress.org/trunk@37022 602fd350-edb4-49c9-b593-d223f7449a82
 2016-03-16 22:48:13 +00:00
Dominik Schilling (ocean90)
ab8ff0dee1 Responsive images: Skip images with a missing $image_meta['file'] value. 
Props joemcgill.
See [37002].
Fixes #35480.

git-svn-id: https://develop.svn.wordpress.org/trunk@37018 602fd350-edb4-49c9-b593-d223f7449a82
 2016-03-16 17:47:41 +00:00
Andrew Ozz
1046806376 Responsive images: do not attempt to create srcset when the image meta is missing or corrupted. 
Props overclokk, jaspermdegroot, joemcgill.
Fixes #35480.

git-svn-id: https://develop.svn.wordpress.org/trunk@37002 602fd350-edb4-49c9-b593-d223f7449a82
 2016-03-16 02:17:19 +00:00
Dominik Schilling (ocean90)
6a8cb09f86 Media: Change wording for media files which aren't attached. 
The media library can contain files which aren't attached yet. When attaching a file you currently get "Media attachment reattached.", or the opposite "Media attachment detached.". That's redundant and can be inaccurate. It's also not easy to translate in some languages.

This change generalizes the strings to refer to a "media file" instead.

Props SergeyBiryukov, ocean90, netweb.
Fixes #36089.

git-svn-id: https://develop.svn.wordpress.org/trunk@36887 602fd350-edb4-49c9-b593-d223f7449a82
 2016-03-08 17:42:45 +00:00
Andrew Ozz
bb49a958d2 Replace wp_upload_dir() with the new wp_get_upload_dir() in all cases where a file is not being uploaded. Deprecate _wp_upload_dir_baseurl(), and replace it with wp_get_upload_dir(). 
See #34359.

git-svn-id: https://develop.svn.wordpress.org/trunk@36569 602fd350-edb4-49c9-b593-d223f7449a82
 2016-02-18 00:23:04 +00:00
Rachel Baker
e8402e5572 Media: Fix inline docs typo inside wp_calculate_image_srcset() function. 
mathces -> matches.

Props neoxx.

Fixes #35714.

git-svn-id: https://develop.svn.wordpress.org/trunk@36517 602fd350-edb4-49c9-b593-d223f7449a82
 2016-02-12 18:14:03 +00:00
swissspidy
0002ff515b Media: After [36240], remove some unneeded whitespace. 
Props ocean90.
See #35367.

git-svn-id: https://develop.svn.wordpress.org/trunk@36241 602fd350-edb4-49c9-b593-d223f7449a82
 2016-01-09 14:28:02 +00:00
Pascal Birchler
54134dd49b Media: Fix wp_audio_shortcode and wp_video_shortcode attributes handling. 
Although documented, the `class` and `style` attributes were simply ignored.
Adds unit tests.

Fixes #35367.

git-svn-id: https://develop.svn.wordpress.org/trunk@36240 602fd350-edb4-49c9-b593-d223f7449a82
 2016-01-09 14:17:02 +00:00
Andrew Ozz
8686ab4a7a Responsive images: fix the check whether the attachment meta matches the image src to work with http/https and CDNs. 
Props webaware, joemcgill, azaozz.
Fixes #35045 and #35102 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36121 602fd350-edb4-49c9-b593-d223f7449a82
 2015-12-30 01:03:11 +00:00
Andrew Ozz
f39a799718 Responsive images: add compatibility for versions < 2.7 when the full image path was stored in the metadata. Introduces _wp_get_attachment_relative_path() and uses it in wp_get_attachment_url(). 
Props dd32, SergeyBiryukov.
Fixes #35106 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36120 602fd350-edb4-49c9-b593-d223f7449a82
 2015-12-30 00:05:07 +00:00
Andrew Ozz
9b9d310c74 Responsive images: when creating srcset do not exclude the image size which is in the src attribute even when it is larger than max_srcset_image_width. 
Props joemcgill.
Fixes #35108 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36110 602fd350-edb4-49c9-b593-d223f7449a82
 2015-12-28 02:28:53 +00:00
Andrew Ozz
58b7d3e136 Responsive images: fix calculations when determining whether to include particular image file in srcset. 
Props joemcgill.
Fixes #34955 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36031 602fd350-edb4-49c9-b593-d223f7449a82
 2015-12-20 02:38:34 +00:00
Mike Schroder
5b025834f9 Media: Don't generate responsive image attributes if src does not match ID in wp-image- class. 
We rely on the `wp-image-` class to quickly find an attachment ID to add responsive image attributes.
To avoid incorrect images being displayed, do not add these attributes if the `src` does not match the
meta from the attachment ID in the class.

Props azaozz, kovshenin, joemcgill.
Fixes: #34898.


git-svn-id: https://develop.svn.wordpress.org/trunk@35820 602fd350-edb4-49c9-b593-d223f7449a82
 2015-12-07 20:07:37 +00:00
Ella Iseulde Van Dorpe
14c3f3c871 Make date format consistent across the admin 
The 'date_format' and 'time_format' options shouldn't affect the backend.

See #30864



git-svn-id: https://develop.svn.wordpress.org/trunk@35811 602fd350-edb4-49c9-b593-d223f7449a82
 2015-12-07 04:25:53 +00:00
Scott Taylor
a8523ae92a Responsive Images: Currently images are included in the srcset if the aspect ratio difference is smaller than 0.01. This number is too high, set it to 0.002 
Props joemcgill.
Fixes #34810.


git-svn-id: https://develop.svn.wordpress.org/trunk@35755 602fd350-edb4-49c9-b593-d223f7449a82
 2015-12-01 20:57:42 +00:00
Scott Taylor
69900349ca Media: don't use get_media_embedded_in_content() in wp_make_content_images_responsive(). 
Adds unit test.

Props azaozz.
Fixes #34807.


git-svn-id: https://develop.svn.wordpress.org/trunk@35753 602fd350-edb4-49c9-b593-d223f7449a82
 2015-12-01 20:49:13 +00:00
Sergey Biryukov
3e634c753e After [35718], update the location of some files in This filter is documented in docs. 
Partially reverts [33954].

Fixes #33413.

git-svn-id: https://develop.svn.wordpress.org/trunk@35725 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-22 03:50:32 +00:00
Sergey Biryukov
583a84b1db Docs: Remove redundant type strings from the wp_calculate_image_srcset filter DocBlock. 
Props DH-Shredder, joemcgill.
See #34733.

git-svn-id: https://develop.svn.wordpress.org/trunk@35716 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-20 06:15:19 +00:00
SergeyBiryukov
a5a5200bcb Docs: Add @see tags for wp_get_attachment_image_srcset() and wp_get_attachment_image_sizes(). 
Update `@see` tags for `wp_make_content_images_responsive()` and `wp_image_add_srcset_and_sizes()`.

Props jaspermdegroot.
See #34733.

git-svn-id: https://develop.svn.wordpress.org/trunk@35715 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-20 06:12:01 +00:00
Drew Jaynes
03a4df50c7 Docs: Clarify some parameter and return descriptions in the DocBlocks for wp_get_attachment_image_srcset() and wp_calculate_image_srcset(), wp_get_attachment_image_sizes(), and the wp_calculate_image_srcset filter. 
Props joemcgill.
See #34733.


git-svn-id: https://develop.svn.wordpress.org/trunk@35696 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-18 22:43:05 +00:00
Scott Taylor
4aa34cf092 Media: when making images responsive, check if they already have a sizes attribute. 
Adds unit test.

Props jaspermdegroot.
Fixes #34678.


git-svn-id: https://develop.svn.wordpress.org/trunk@35678 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-18 19:47:11 +00:00
Drew Jaynes
8e44704e5f Docs: Properly mark optional parameters as such in the DocBlock and function signature for wp_calculate_image_sizes(). 
Also updates the subsequent hook docs for the `wp_calculate_image_sizes` filter.

Props joemcgill.
Fixes #34612.


git-svn-id: https://develop.svn.wordpress.org/trunk@35672 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-18 18:52:15 +00:00
Drew Jaynes
fec164e485 Docs: Remove an empty line from the hook doc for the wp_calculate_image_srcset filter, introduced in [35592]. 
Props kraftbj.
See #34612.


git-svn-id: https://develop.svn.wordpress.org/trunk@35601 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-10 17:14:33 +00:00
Drew Jaynes
a21b20c3f6 Docs: Fix some formatting in the hook doc for the wp_calculate_image_srcset filter and clarify the summary. 
See #34612.


git-svn-id: https://develop.svn.wordpress.org/trunk@35592 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-09 23:33:06 +00:00
Andrew Ozz
57f41cc1ec Responsive images: properly arrange the parameters for the wp_calculate_image_srcset filter and add fix the inline documentation. 
Props joemcgill.
Fixes #34612.

git-svn-id: https://develop.svn.wordpress.org/trunk@35591 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-09 23:29:56 +00:00
Andrew Ozz
edf5d8bb36 Responsive images: make the new functions and filters signatures more consistent. 
Props joemcgill.
Fixes #34612.

git-svn-id: https://develop.svn.wordpress.org/trunk@35569 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-07 21:35:34 +00:00
Scott Taylor
7301c115aa Accessibility: add missing alt attributes to a gaggle of <img>s. 
Props afercia.
Fixes #34583.


git-svn-id: https://develop.svn.wordpress.org/trunk@35567 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-07 16:11:38 +00:00
Andrew Ozz
3b5433eb2e Responsive images: omit full size images from srcset attributes when the original file is an intermediate sized GIF so we don't accidentally add animation to an otherwise flat image. Update the tests to cover this case. 
Props joemcgill, H-Shredder, SergeyBiryukov.
Fixes #34528.

git-svn-id: https://develop.svn.wordpress.org/trunk@35561 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-07 02:09:56 +00:00
Andrew Ozz
611ddaf9bf Responsive images: do not generate srcset for GIFs that are inserted at full size. Prevents breaking animated GIFs. 
Props joemcgill.
Fixes #34528.

git-svn-id: https://develop.svn.wordpress.org/trunk@35524 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-04 21:43:44 +00:00
Andrew Ozz
01e9de382e Responsive images: 
- Fix `_wp_upload_dir_baseurl()` to cache by blog_id.
- Replace `path_join()` with `trailingslashit()`, it's much faster.
- Rename $image_url to $image_src for consistency (used at about 50 other places).
- Couple of tests fixes.

See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35498 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-04 00:21:23 +00:00
Andrew Ozz
d037ebdb31 Responsive images: 
- More fixes to inline docs.
- Replace the last `wp_get_attachment_metadata()` with `get_post_meta()`.
- For consistency only accept array or named size in `wp_get_attachment_image_sizes()`.

Props jaspermdegroot.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35491 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-03 00:18:07 +00:00
Andrew Ozz
f64bc40f69 Responsive images: add $image_url parameter to wp_get_attachment_image_sizes() and use it in the filter. This allows themes and plugins to identify the image. 
Props joemcgill.
Fixes #34477.

git-svn-id: https://develop.svn.wordpress.org/trunk@35481 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-31 22:48:08 +00:00
Scott Taylor
bd7bf83886 Media: add a new image size, medium_large. Bumps db version to add new options. 
Adds unit tests.

Props DH-Shredder, joemcgill, azaozz.
Fixes #34196.


git-svn-id: https://develop.svn.wordpress.org/trunk@35479 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-31 20:49:26 +00:00
Andrew Ozz
62c0557b90 Responsive images: few more inline docs fixes. 
Props jaspermdegroot.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35465 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-30 23:35:14 +00:00
Andrew Ozz
98a63f523f Responsive images: 
- Merge `wp_image_srcset_attr()` into `wp_calculate_image_srcset()`.
- Remove the `wp_image_srcset` filter.
- Fix the tests for the above changes. 

See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35464 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-30 23:26:44 +00:00
Andrew Ozz
63b27d209a Responsive images: add inline docs for private functions. 
Props swissspidy.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35426 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-28 21:54:04 +00:00
Andrew Ozz
2fadc857de Responsive images: 
- Check if wp_get_attachment_metadata() has returned an array to prevent errors when using SVGs.
- Only add the srcset attribute if there will be a sizes attribute.
- Better filter names.
- Some more inline docs fixes.

Props jaspermdegroot.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35419 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-28 20:00:14 +00:00
Andrew Ozz
855ba2518b Responsive images: 
- Introduce `wp_calculate_image_srcset()` that replaces `wp_get_attachment_image_srcset_array()` and is used as lower level function for retrieving the srcset data as array.
- Use the new function when generating `srcset` and `sizes` on the front-end. This is faster as no (other) image API functions are used.
- Change the `wp_get_attachment_image_srcset()`. Now it is meant for use in templates and is no longer used in core.
- A few logic fixes and improvements.
- Some names changed to be (hopefully) more descriptive.
- Fixed/updated tests.

Props joemcgill, jaspermdegroot, azaozz.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35412 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-28 05:40:04 +00:00
Sergey Biryukov
c608146996 After [35402], don't unnecessary run wp_get_attachment_metadata(), wp_get_attachment_image_srcset(), and wp_get_attachment_image_sizes() in wp_img_add_srcset_and_sizes(). 
See #34379.

git-svn-id: https://develop.svn.wordpress.org/trunk@35405 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-26 18:41:31 +00:00
Sergey Biryukov
aeca8fcfd8 After [35402], don't unnecessary run wp_get_attachment_image_srcset() and wp_get_attachment_image_sizes() in wp_get_attachment_image() if srcset is passed as an argument. 
See #34379.

git-svn-id: https://develop.svn.wordpress.org/trunk@35404 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-26 18:40:01 +00:00
Sergey Biryukov
9b29cf2574 Remove assignments from conditions in wp_get_attachment_image() and wp_img_add_srcset_and_sizes(). 
See #34379.

git-svn-id: https://develop.svn.wordpress.org/trunk@35402 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-26 16:28:27 +00:00
Sergey Biryukov
558984a8ab Docs: After [34453], correct inline comments in wp_get_attachment_image_sizes(). 
Props jaspermdegroot.
Fixes #34453.

git-svn-id: https://develop.svn.wordpress.org/trunk@35401 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-26 16:16:52 +00:00
Andrew Ozz
2c1f21190d Responsive Images: fix typo in r35358. 
Props aduth.
See #34341.

git-svn-id: https://develop.svn.wordpress.org/trunk@35378 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-23 17:37:35 +00:00
Andrew Ozz
5aa7a8ce78 Responsive Images: limit the size of images included in srcset attributes. Introduce max_srcset_image_width filter to adjust the limit. 
Props joemcgill.
Fixes #34341.

git-svn-id: https://develop.svn.wordpress.org/trunk@35358 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-22 19:30:12 +00:00
Scott Taylor
6a3b784104 Media: in wp_get_attachment_image_sizes(), to streamline and for performance: 
* Change the 3rd arg from `args` to `width`
* Change `wp_image_sizes_args` filter to `wp_get_attachment_image_sizes`

Updates unit tests.

Props joemcgill.
Fixes #34379.


git-svn-id: https://develop.svn.wordpress.org/trunk@35355 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-22 16:45:37 +00:00
Drew Jaynes
a28e35e462 Filesystem: Following the introduction of the KB|MB|GB|TB_IN_BYTES constants in [35286], use them in various places in core. 
Props sudar.
Fixes #22405.


git-svn-id: https://develop.svn.wordpress.org/trunk@35325 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 14:02:59 +00:00
Drew Jaynes
1ed7489957 Media: Introduce the image_get_intermediate_size filter to its like-named function, making it possible to manipulate returned intermedia image size data. 
Covers both the default and meaningful short-circuit return cases. Also adds a hash notation to the return documentation in the DocBlock.

Props A5hleyRich, DH-Shredder, wonderboymusic.
Fixes #34124.


git-svn-id: https://develop.svn.wordpress.org/trunk@35289 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 07:23:18 +00:00