Commit Graph

3386 Commits

Author SHA1 Message Date
Scott Taylor
1c5f85e1a4 When applying the 'editable_slug' filter, add a second param that provides more context.
Props MikeSchinkel, jesin.
Fixes #31568.


git-svn-id: https://develop.svn.wordpress.org/trunk@34319 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 05:48:30 +00:00
Dominik Schilling (ocean90)
7eb0317968 Don't use <code> in translation strings in wp-admin/options.php.
Props ramiy, wonderboymusic.
Fixes #31861.

git-svn-id: https://develop.svn.wordpress.org/trunk@34315 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:42:20 +00:00
Dominik Schilling (ocean90)
f5eacb71d6 Don't use <code> in translation strings in wp-admin/includes/plugin.php.
Props ramiy.
Fixes #31856.

git-svn-id: https://develop.svn.wordpress.org/trunk@34314 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:28:23 +00:00
Dominik Schilling (ocean90)
0c642e4730 Use correct @since tag for wp_ajax_generate_password().
See #33450.

git-svn-id: https://develop.svn.wordpress.org/trunk@34313 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:18:22 +00:00
Scott Taylor
1299974e7d Profile: when clicking "Cancel" after clicking "Generate Password", request and generate a new password to present to the user.
Props adamsilverstein, wonderboymusic.
Fixes #33450.


git-svn-id: https://develop.svn.wordpress.org/trunk@34312 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:13:34 +00:00
Scott Taylor
b0b36bc346 Add a 'get_sample_permalink' filter.
Props SergeyBiryukov, wenthemes, JustinSainton.
Fixes #22338.


git-svn-id: https://develop.svn.wordpress.org/trunk@34309 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 19:27:24 +00:00
Sergey Biryukov
c43a62bde7 Include placeholder in translator comment.
See #31863.

git-svn-id: https://develop.svn.wordpress.org/trunk@34306 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 19:02:37 +00:00
Sergey Biryukov
039ce30818 Include placeholder in translator comment.
See #31864.

git-svn-id: https://develop.svn.wordpress.org/trunk@34305 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 19:00:20 +00:00
Sergey Biryukov
21a41c100f Include placeholders in translator comments.
See #31857.

git-svn-id: https://develop.svn.wordpress.org/trunk@34304 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:57:01 +00:00
Scott Taylor
394e9ac21a Don't use HTML tags in translation strings in edit-tags.php.
Props ramiy.
Fixes #31863.


git-svn-id: https://develop.svn.wordpress.org/trunk@34303 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:52:48 +00:00
Scott Taylor
de077ac377 Don't use HTML tags in translation strings in wp_ajax_add_user().
Props ramiy.
Fixes #31864.


git-svn-id: https://develop.svn.wordpress.org/trunk@34302 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:50:04 +00:00
Sergey Biryukov
5cfdae8b2b Add missing translator comment after [34295].
See #31853.

git-svn-id: https://develop.svn.wordpress.org/trunk@34301 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:49:40 +00:00
Sergey Biryukov
bcc165791f Add missing translator comments after [34294].
See #31852.

git-svn-id: https://develop.svn.wordpress.org/trunk@34300 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:45:40 +00:00
Sergey Biryukov
48c6d925cd Add missing translator comment after [34292].
See #31840.

git-svn-id: https://develop.svn.wordpress.org/trunk@34299 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:39:20 +00:00
Sergey Biryukov
f90ee7b348 Add missing translator comments after [34293].
See #31851.

git-svn-id: https://develop.svn.wordpress.org/trunk@34298 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:38:54 +00:00
Scott Taylor
310dc18167 Don't use HTML tags in translation strings for "In Reply To" links for comments in the admin.
Props ramiy.
Fixes #31857.


git-svn-id: https://develop.svn.wordpress.org/trunk@34297 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:35:16 +00:00
Scott Taylor
13889763af Don't use HTML tags in translation strings in wp-admin/includes/update.php.
Props ramiy.
Fixes #31855.


git-svn-id: https://develop.svn.wordpress.org/trunk@34296 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:30:26 +00:00
Scott Taylor
c10019ec70 Don't use <code> in translation strings in edit-form-comment.php.
Props ramiy.
Fixes #31853.


git-svn-id: https://develop.svn.wordpress.org/trunk@34295 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:27:29 +00:00
Scott Taylor
df149fddff Don't use <code> in translation strings in options-general.php.
Props ramiy, SergeyBiryukov.
Fixes #31852.


git-svn-id: https://develop.svn.wordpress.org/trunk@34294 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:23:19 +00:00
Scott Taylor
d2b4e0c728 Don't use <code> in translation strings in wp-admin/includes/schema.php.
Props ramiy.
Fixes #31851.


git-svn-id: https://develop.svn.wordpress.org/trunk@34293 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:20:46 +00:00
Scott Taylor
f6d2c30fa7 Network Setup: don't use <code> in translation strings in wp-admin/network files.
Props ramiy.
Fixes #31840.


git-svn-id: https://develop.svn.wordpress.org/trunk@34292 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:17:26 +00:00
Aaron Jorbin
308179c232 Remove support for my-hacks.php
For the last 10 years, my-hacks has been deprecated and has been throwing a deprecation notice. For the last six years, you haven't been able to enable my-hacks.php in the admin UI. That should be enough time to give developers notice. Plugins and themes seem like they might have staying power.

Fixes #33741
Props bobbingwide



git-svn-id: https://develop.svn.wordpress.org/trunk@34291 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 17:05:28 +00:00
Dominik Schilling (ocean90)
7f562dd69f Theme Editor: Change file descriptions of header.php and footer.php.
`header.php` is now "Theme Header" and `footer.php` is "Theme Footer". This prevents a clash with other "Header" strings in the context of "Custom Header".

Props ramiy.
Fixes #32975.

git-svn-id: https://develop.svn.wordpress.org/trunk@34290 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 16:02:24 +00:00
Sergey Biryukov
7851406626 Network Admin: Include IDs for users and sites on their respective views.
Props danielbachhuber, wonderboymusic.
Fixes #18661.

git-svn-id: https://develop.svn.wordpress.org/trunk@34289 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 15:57:47 +00:00
Dion Hulse
09f373d582 Updates: FTP: Add a missing PCRE modifer in [34281].
See #16026, #33432x


git-svn-id: https://develop.svn.wordpress.org/trunk@34282 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 08:22:17 +00:00
Dion Hulse
b114866bbf Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE).
Props enshrined, aaroncampbell
Fixes #16026, #33432


git-svn-id: https://develop.svn.wordpress.org/trunk@34281 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 08:19:18 +00:00
Scott Taylor
50419ff08d List Tables: ensure that sortable list table column headers have the same padding/line-height as non-sortable headers.
Props drozdz.
Fixes #27945.


git-svn-id: https://develop.svn.wordpress.org/trunk@34276 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 03:25:32 +00:00
Scott Taylor
ace6756081 Editor: add hide-if-no-js class to <td id="wp-word-count">. Word Count no worky with no JavaScript.
Props chriscct7.
Fixes #33379.


git-svn-id: https://develop.svn.wordpress.org/trunk@34275 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 02:31:23 +00:00
Scott Taylor
73c1ac8b26 Posts List Table: Use a more robust technique for calculating $total_items so that pagination still appears when items are removed on the last page of results and ->max_num_pages decreases.
Props A5hleyRich.
Fixes #29870.


git-svn-id: https://develop.svn.wordpress.org/trunk@34271 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 21:17:16 +00:00
Weston Ruter
5ea07785b3 Customize: Reduce peak memory usage by JSON-encoding settings and controls individually.
When there are hundreds of settings and controls (e.g. nav menu items and widget instances) the resulting object that is JSON-encoded can become very large, and `wp_json_encode()` can consume a lot of memory to serialize it. By breaking down the serialization into multiple calls the peak memory usage can be kept in line.

Moves logic out of `wp-admin/customize.php` into the `WP_Customize_Manager` class with new methods:

 * `is_ios()`
 * `get_document_title_template()`
 * `get_preview_url()`/`set_preview_url()`
 * `get_return_url()`/`set_return_url()`
 * `get_autofocus()`/`set_autofocus()`
 * `customize_pane_settings()`

Includes unit tests for these methods, for which the logic was formerly untestable in `customize.php`.

Fixes #33898.


git-svn-id: https://develop.svn.wordpress.org/trunk@34269 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 19:41:35 +00:00
Helen Hou-Sandi
3531c0bc10 Superglobals: Revert [34059] until further notice.
see #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34265 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 12:32:20 +00:00
Sergey Biryukov
f9ff998d01 Revert unintended change from [34262].
See #33910.

git-svn-id: https://develop.svn.wordpress.org/trunk@34263 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 09:08:14 +00:00
Sergey Biryukov
45610f9464 Docs: Expand the DocBlock for get_default_post_to_edit().
Props rabmalin.
Fixes #33910.

git-svn-id: https://develop.svn.wordpress.org/trunk@34262 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 09:05:44 +00:00
Scott Taylor
189bc9b5aa Media: In wp_ajax_send_attachment_to_editor(), the fallback logic for $html should be tucked into an else statement so it isn't run needlessly and overwritten.
Props tychay.
Fixes #32072.


git-svn-id: https://develop.svn.wordpress.org/trunk@34260 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 05:54:56 +00:00
Scott Taylor
337c87e7c7 Media: In get_image_send_to_editor(), allow a custom value for $rel.
Props tychay.
Fixes #32074.


git-svn-id: https://develop.svn.wordpress.org/trunk@34259 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 05:45:31 +00:00
Scott Taylor
a1805ecada Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query.
Related to the toolbar view, remove the `wp_admin_canonical_url()` action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.

Fixes #29744.


git-svn-id: https://develop.svn.wordpress.org/trunk@34256 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 02:29:22 +00:00
Boone Gorges
de7c9b6015 Move new user notification emails to add_action() callbacks.
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.

This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.

Props dshanske, thomaswm, boonebgorges.
Fixes #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34251 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 22:18:33 +00:00
Sergey Biryukov
7c9c635a04 Add a missing Oxford comma on Export screen.
Props juhise.
Fixes #33906.

git-svn-id: https://develop.svn.wordpress.org/trunk@34249 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 21:33:29 +00:00
Scott Taylor
d2bb55ee92 wp-admin/includes/template.php is now a loader for 3 files made via svn cp:
* `Walker_Category_Checklist` class
* `WP_Internal_Pointers` class
* `template-functions.php`

This is BC for plugins that are loading `wp-admin/includes/template.php` for fun.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34241 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 15:34:17 +00:00
Sergey Biryukov
1d4b8ffd1d Docs: Expand the DocBlock for the WP_Theme::get_edit_link() method, introduced in [34084].
Fixes #32376.

git-svn-id: https://develop.svn.wordpress.org/trunk@34238 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 15:00:04 +00:00
Drew Jaynes
7682e433fc Docs: Put "it's" in its place (again).
Props kitchin.
Fixes #33894.


git-svn-id: https://develop.svn.wordpress.org/trunk@34234 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 12:45:51 +00:00
Sergey Biryukov
557d160ca1 Comments: Fix a fatal error in Comments meta box after [34223].
Props tyxla.
Fixes #33893. See #33413.

git-svn-id: https://develop.svn.wordpress.org/trunk@34231 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 11:36:35 +00:00
Drew Jaynes
3b3a034c11 Docs: Remove markdown from the DocBlock summary for WP_List_Table::get_primary_column(), introduced in [34166].
The PHP inline documentation standards for [https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description summaries] call for not using an markup or markdown. Also, using the full Class::method() in this context allows for better clarity in what is being referenced.

See #33854. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34229 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 10:50:21 +00:00
Drew Jaynes
f83abcbf3e Docs: Add a changelog entry for the switch to using wp_get_attachment_url() instead of the guid for determining the header image URL in Custom_Image_Header::step_3().
The change was introduced in [34188].

See #33319.


git-svn-id: https://develop.svn.wordpress.org/trunk@34228 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 10:42:08 +00:00
Scott Taylor
05cd237d5e Move WP_Post_Comments_List_Table to its own file.
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34223 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 06:52:35 +00:00
Weston Ruter
1975b0a084 Customizer: Smooth animation for closing accordions in the available nav menu items pane.
Props tyxla.
Fixes #33360 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@34219 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 23:39:23 +00:00
Boone Gorges
0adb6877b2 Improve validation of user_login and user_nicename length.
The `user_login` field only allows 60 characters, and `user_nicename` allows
50. However, there are no protections in the interface, and few in the code,
that prevent the creation of users with values in excess of these limits. Prior
to recent changes in `$wpdb`, users were generally created anyway, MySQL
having performed the necessary truncation. More recently, the `INSERT`s and
`UPDATE`s simply fail, with no real feedback on the nature of the failure.

This changeset addresses the issue in a number of ways:
* On the user-new.php and network/user-new.php panels, don't allow input in excess of the maximum field length.
* In `wp_insert_user()`, throw an error if the value provided for `'user_login'` or `'user_nicename'` exceeds the maximum field length.
* In `wp_insert_user()`, when using `'user_login'` to generate a default value for `'user_nicename'`, ensure that the nicename is properly truncated, even when suffixed for uniqueness (username-2, etc).

Props dipesh.kakadiya, utkarshpatel, tommarshall, boonebgorges.
Fixes #33793.

git-svn-id: https://develop.svn.wordpress.org/trunk@34218 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 22:13:51 +00:00
John Blackbourn
1a352d56f9 Implement wp_login_url() and wp_registration_url() in places where wp-login.php is currently hard-coded.
See #31495
Props GregLone


git-svn-id: https://develop.svn.wordpress.org/trunk@34213 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 17:10:24 +00:00
wonderboymusic
2a1ee1a235 Don't redirect to the Term list table after submitting the form on the Edit Term page.
Props chiragswadia, UmeshSingla, rhyswynne, afercia.
Fixes #17455.


git-svn-id: https://develop.svn.wordpress.org/trunk@34202 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 15:58:04 +00:00
Scott Taylor
acbeef27b9 Similar to #33386, don't use guid when retrieving URL for a cropped header image in the Customizer.
Props polevaultweb.
Fixes #33319.


git-svn-id: https://develop.svn.wordpress.org/trunk@34188 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 14:45:59 +00:00