vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
28,077 Commits 1 Branch 0 Tags 243 MiB
1eca0cb442
Commit Graph

51 Commits

Author SHA1 Message Date
Drew Jaynes (DrewAPicture)
325c0622c9 Update the changelogs for the comment hook parameters added in [30092]. 
Parameters were added to the `get_comment_author`, `comment_author`, `get_comment_author_email`, `author_email`, `comment_email`, `get_comment_author_link`, `get_comment_author_IP`, `get_comment_author_url`, `comment_url`, `get_comment_excerpt`, `comment_excerpt`, `get_comment_ID`, and `get_comment_type` filters.

Fixes #22380.


git-svn-id: https://develop.svn.wordpress.org/trunk@30111 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-30 03:51:28 +00:00
Peter Westwood
ed19e5a1f3 Comment Template Tags: Improve the availability of context information in comment template tag filters. 
Fixes #22380 props momo360modena, tareq1988.


git-svn-id: https://develop.svn.wordpress.org/trunk@30092 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-29 19:07:00 +00:00
Sergey Biryukov
2672e35d43 Add 'comment_reply_link_args' filter for get_comment_reply_link() arguments. 
props joedolson, aaroncampbell, DrewAPicture.
fixes #10569.

git-svn-id: https://develop.svn.wordpress.org/trunk@30039 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-27 11:44:40 +00:00
Boone Gorges
348c8958da Use the comment API rather than direct SQL queries in comments_template(). 
`comments_template()` is used by most themes to display a post's comments. It
shows all comments that have been approved, and also shows all pending comments
by the current visitor (as determined by the comment cookies). However, the
comments API previously had no way of querying for "all comments that are
either approved, or are unapproved but written by foo@example.com". The
workaround was a direct SQL query: uncached, not subject to the same filters as
other comment queries, and just generally icky.

The new `include_unapproved` parameter for `WP_Comment_Query` accepts an array
of user IDs or email addresses. Pending comments associated with users in this
array will be included in query results, regardless of the value of the 'status'
parameter. In `comments_template()`, we leap from direct SQL queries to
`get_comments()` plus `include_unapproved', striving to put right what once
went wrong.

Props boonebgorges, simonwheatley, hardy101, jesin.
Fixes #19623.

git-svn-id: https://develop.svn.wordpress.org/trunk@29965 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-19 19:38:16 +00:00
Dominik Schilling (ocean90)
5d7e30e7d9 Comments: Don't print an empty HTML markup when comment_reply_link() returns no link. 
props obenland.
fixes #29895.

git-svn-id: https://develop.svn.wordpress.org/trunk@29908 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-15 21:55:31 +00:00
Sergey Biryukov
564598f068 Add aria-describedby attributes to comment_form(). 
props joedolson, bramd.
fixes #24148.

git-svn-id: https://develop.svn.wordpress.org/trunk@29846 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-06 22:10:08 +00:00
Sergey Biryukov
dc62eeff36 Make link construction in get_comment_reply_link() and get_post_reply_link() more readable. 
see #16433.

git-svn-id: https://develop.svn.wordpress.org/trunk@29823 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 20:44:34 +00:00
Sergey Biryukov
07cf5c5c76 Add an aria-label attribute with commenter's name to get_comment_reply_link(). 
props joedolson, merty, andrewryno.
fixes #16433.

git-svn-id: https://develop.svn.wordpress.org/trunk@29822 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 20:40:35 +00:00
Sergey Biryukov
6dca7d1023 Add a class attribute for submit button in comment form. 
props bainternet.
fixes #20446.

git-svn-id: https://develop.svn.wordpress.org/trunk@29809 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 01:43:32 +00:00
Scott Taylor
f0318988c4 Correct a few @param docs for $walker. 
Props dnaber-de.
Fixes #29011.


git-svn-id: https://develop.svn.wordpress.org/trunk@29293 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-24 22:24:07 +00:00
Drew Jaynes (DrewAPicture)
551f829c55 Inline documentation cleanup for 4.0 audit. 
Various improvements:
* Adds `@see` reference for `wp_list_comments()` in 'wp_list_comments_args' filter docs, added in [28285]
* Various phpDoc tweaks for the 'run_wptexturize' filter docs, added in [28715]
* Sentence and wrapping changes for `is_https_url()`, added in [28894]
* Documents the `$args` parameter for `wp_dropdown_languages()`, added in [29007]
* Adds a period to the parameter description for `_update_posts_count_on_delete()`, added in [28835]
* Documents a global in `is_customize_preview()`, added in [28999]
* phpDoc tweaks, adds an access modifier for `wpdb::esc_like()`, added in [28711]

See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29163 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 01:01:22 +00:00
Scott Taylor
3cda5caafd Revert [28563]. See #18298. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29044 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 18:06:54 +00:00
Drew Jaynes (DrewAPicture)
b1b454c7a0 Remove backticks on $post variables in some short parameter descriptions. 
See [28653], [28654].
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28976 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 19:27:54 +00:00
Scott Taylor
be32c3485a Add a function, get_comments_number_text(), that returns instead of echoing. comments_number() wraps it. 
Props kapeels, nbachiyski.
Fixes #10177.


git-svn-id: https://develop.svn.wordpress.org/trunk@28912 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 23:12:34 +00:00
Scott Taylor
73fe9d548b Ensure that a has_children parameter is given to Walker::start_el(). 
Adds unit tests.

Props scribu, obenland.
Fixes #14041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28824 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-24 17:05:56 +00:00
Scott Taylor
76bd35fa79 In comment_form(), allow name_submit to be passed to change the name attribute of the submit button. 
Props obenland.
Fixes #22792.


git-svn-id: https://develop.svn.wordpress.org/trunk@28813 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-24 00:09:51 +00:00
Drew Jaynes (DrewAPicture)
d068c888f3 Ensure $post_id is documented as optional where applicable. 
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28654 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-03 04:43:47 +00:00
Scott Taylor
3d48e21248 Fix an error caused by [28604] in get_comments_number() unit tests. 
Props SergeyBiryukov.
Fixes #26240.



git-svn-id: https://develop.svn.wordpress.org/trunk@28638 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 19:46:05 +00:00
Dominik Schilling (ocean90)
0af37cccdb Pass $post->ID to get_comments_number filter. 
Also fixes indentation and a typo in corresponding filter docs.

see #26240.

git-svn-id: https://develop.svn.wordpress.org/trunk@28604 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 22:35:21 +00:00
Drew Jaynes (DrewAPicture)
d201ded99e Fix parameter description for the $post_id argument in get_comments_number() to note that it is optional. 
Also fixes the corresponding filter docs, as `$post_id`, not `$post` is passed to the filter.

See [27156]. Fixes #26240.


git-svn-id: https://develop.svn.wordpress.org/trunk@28602 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 22:04:59 +00:00
Scott Taylor
70f735669a Replaces all uses of TEMPLATEPATH and STYLESHEETPATH in core with get_template_directory() and get_stylesheet_directory(). 
Add `@deprecated` annotations to `TEMPLATEPATH` and `STYLESHEETPATH` definitions.

Props obenland, aaroncampbell. 
Fixes #18298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28563 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 20:11:08 +00:00
Scott Taylor
1061a15eaf Allow get_comments_number() to officially accept $post or $post_id. Adds unit tests. 
Props coffee2code, JanHenkG.
Fixes #26240.


git-svn-id: https://develop.svn.wordpress.org/trunk@28558 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 17:43:03 +00:00
Scott Taylor
f716ff94e4 Add missing access modifiers to methods/members in Walker and subclasses. Add a magic __get() method. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28514 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:59:07 +00:00
Scott Taylor
4aa28e9cdc Eliminate use of extract() in get_comment_reply_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28431 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 15:34:37 +00:00
Scott Taylor
e06aa222ea Eliminate the use of extract() in get_post_reply_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28429 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 06:48:16 +00:00
Scott Taylor
2a5a75e6d3 Eliminate the use of extract() in wp_list_comments(). All unit tests pass. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28428 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 06:42:19 +00:00
Scott Taylor
5530fe4c11 In wp-includes/comment-template.php, remove dead code: 
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`. 
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used. 

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28323 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:14:35 +00:00
Sergey Biryukov
d7a159bf81 Add a filter for wp_list_comments() arguments. 
props greenshady, hlashbrooke.
fixes #19581.

git-svn-id: https://develop.svn.wordpress.org/trunk@28285 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 11:57:36 +00:00
Drew Jaynes (DrewAPicture)
b5612f8b80 Priority fixes for various existing hook documentation. 
Props kpdesign.
See #26869


git-svn-id: https://develop.svn.wordpress.org/trunk@28083 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 00:00:32 +00:00
Drew Jaynes (DrewAPicture)
e9f0de0951 Remove a blank line and @global reference in the PHPDoc for comment_author_email_link(). 
Props norcross, ocean90.
Fixes #27655.


git-svn-id: https://develop.svn.wordpress.org/trunk@27943 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 04:35:20 +00:00
Andrew Nacin
d686c73525 Pass walker arguments to get_comment_link() so pagination works when wp_list_comments() is used outside the comment template. 
props SergeyBiryukov.
fixes #27007.


git-svn-id: https://develop.svn.wordpress.org/trunk@27799 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-28 02:37:33 +00:00
Sergey Biryukov
96b39f3363 Avoid a notice in trackback_rdf() if user agent is not set. 
props joostdevalk.
fixes #27374.

git-svn-id: https://develop.svn.wordpress.org/trunk@27514 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-12 12:53:49 +00:00
nacin
fb317e3d70 Pass the comment object to the get_comment_date and get_comment_time. 
props SergeyBiryukov.
fixes #19849.


git-svn-id: https://develop.svn.wordpress.org/trunk@27283 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-26 16:40:03 +00:00
Drew Jaynes
647f80595d Remove all @package and @subpackage PHPDoc tags not at the file- or class-levels in core. 
See #27200.


git-svn-id: https://develop.svn.wordpress.org/trunk@27262 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-25 17:13:08 +00:00
Drew Jaynes
ef099f8082 Fix a typo in the PHPDoc for comment_author_email_link(). 
See #27083.


git-svn-id: https://develop.svn.wordpress.org/trunk@27157 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-10 04:06:36 +00:00
Drew Jaynes
3d67904bc7 Inline documentation cleanup in wp-includes/comment-template.php. 
This cleanup follows [25567] and brings the docs in-line with standards that at the time had not yet been finalized.

These changes include
* Moving in-line `@see` tags to their own lines
* Using docs-specific variables in hook docs
* Fixing line-wrapping throughout
* Typos and punctuation
* Converting hash notation values to variables per the standard

Fixes #27083. See #20495.


git-svn-id: https://develop.svn.wordpress.org/trunk@27156 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-10 03:19:13 +00:00
Drew Jaynes
bd39e26032 First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin. 
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.


git-svn-id: https://develop.svn.wordpress.org/trunk@26868 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-24 18:56:05 +00:00
Andrew Nacin
b63ab1ec9e Add echo arguments to wp_list_comments() and Walker_Comment, allowing non-echo usage. 
props mikelittle.
fixes #10948.


git-svn-id: https://develop.svn.wordpress.org/trunk@26353 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-24 14:58:48 +00:00
Sergey Biryukov
bc6c0c9b0f Correct @since values for various hooks. fixes #25766. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25991 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-30 03:19:16 +00:00
Drew Jaynes
e62fb3972b Inline documentation for the Walker_Comment class in wp-includes/comment-template.php 
Fixes #25388.


git-svn-id: https://develop.svn.wordpress.org/trunk@25588 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 23:28:41 +00:00
Drew Jaynes
b8a50e4cdd Inline documentation for hooks in wp-includes/comment-template.php. 
Fixes #25396.


git-svn-id: https://develop.svn.wordpress.org/trunk@25584 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 21:20:48 +00:00
Drew Jaynes
b00509f3b0 Inline documentation for comment_form() argument defaults missed in [25573]. 
See #25388.


git-svn-id: https://develop.svn.wordpress.org/trunk@25575 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 17:29:54 +00:00
Drew Jaynes
9297d23d5a Improve inline documentation of arguments for comment_form(). 
See #25388.


git-svn-id: https://develop.svn.wordpress.org/trunk@25573 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 17:16:01 +00:00
Drew Jaynes
9e36d580e1 Inline documentation improvements for wp-includes/comment-template.php. 
Changes include:
- Existing phpdoc block improvements
- Inclusion of defaults for optional parameters
- Hash-notated argument arrays
- Removal of unnecessary or redundant tagging.

Also standardization of int|WP_Post function parameters.

These changes clear the way toward less redundancy for hook docs in a future ticket.

Still left: Fully documented arguments in `comment_form()` and a pass through Walker_Comment.

See #20495. See #25388.


git-svn-id: https://develop.svn.wordpress.org/trunk@25567 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 04:15:41 +00:00
Dominik Schilling (ocean90)
a2cd165b61 Replace !$user_ID with !is_user_logged_in(). props garyc40. see #15508. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25562 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-22 10:15:38 +00:00
Scott Taylor
0d5bebfe0e Add an $args parameter to comment_text and get_comment_text filters. Adds filter docs. Improve docblocks for get_comment_text() and comment_text(). 
Props simonwheatley, ericlewis, DrewAPicture.
Fixes #14856. 



git-svn-id: https://develop.svn.wordpress.org/trunk@25555 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 18:17:22 +00:00
Drew Jaynes
090b527065 Clarify phpdoc for get_comment_author_link(). 
props nofearinc. Fixes #24508.


git-svn-id: https://develop.svn.wordpress.org/trunk@25494 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 05:55:01 +00:00
Sergey Biryukov
631d5edf3a Inline documentation for get_comment_reply_link() and 'comment_reply_link' filter. 
props DrewAPicture.
fixes #25310.

git-svn-id: https://develop.svn.wordpress.org/trunk@25428 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 19:19:45 +00:00
Sergey Biryukov
1d00e1d88a Make sure $args is an array before treating it as such. fixes #25151 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25151 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-28 05:27:03 +00:00
Andrew Nacin
2b280c5761 Ensure a user exists in get_comment_author(). 
props azaozz.
see #24084.


git-svn-id: https://develop.svn.wordpress.org/trunk@25136 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-27 13:16:34 +00:00