Commit Graph

736 Commits

Author SHA1 Message Date
Scott Taylor
2003fcae83 In Media Views, use this.listenTo( this.model, .... ) instead of this.model.on( .... ) to fix garbage collection and to avoid "ghost views."
Fixes #30896.


git-svn-id: https://develop.svn.wordpress.org/trunk@31045 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-04 05:24:24 +00:00
Scott Taylor
6d858cc6e2 In Media Grid, don't immediately load full size images if the requested size passed to wp.media.view.Attachment.imageSize() does not exist, look for other suitable sizes.
Fixes #30861.


git-svn-id: https://develop.svn.wordpress.org/trunk@31039 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-03 21:31:23 +00:00
Scott Taylor
d5328fc674 When outputting JS with a Content-Type header:
`text/javascript` is obsolete, `application/x-javascript` was experimental. `application/javascript` is the recommended type per RFC 4329.

Props sergej.mueller.
Fixes #29196.


git-svn-id: https://develop.svn.wordpress.org/trunk@31029 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-03 02:56:14 +00:00
Scott Taylor
be8211beac Support chromeless Vimeo via MEjs:
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
6f9a78e008/src/js/me-shim.js (L631)

Fixes #29267.


git-svn-id: https://develop.svn.wordpress.org/trunk@31016 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-31 20:40:05 +00:00
Andrew Ozz
8298e94bfe TinyMCE wpView: when clicking on the Edit button, move the focus back to the editor before opening the modal. This is needed for IE so TinyMCE can save the proper DOM "bookmark", and makes it possible to move the focus to the modal after it is opened.
See #30817.

git-svn-id: https://develop.svn.wordpress.org/trunk@30986 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-22 21:30:16 +00:00
Scott Taylor
c9707a4a31 In response to regressions on .com, fix MEjs styles for screen reader text and overflow on the volume slider.
Props obenland.
See #30281.


git-svn-id: https://develop.svn.wordpress.org/trunk@30907 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 15:12:35 +00:00
Dominik Schilling (ocean90)
8f323ecf9a Customizer: Export Preview instance to wp.customize.preview.
see #30409, #30726.

git-svn-id: https://develop.svn.wordpress.org/trunk@30891 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 11:52:38 +00:00
Andrew Nacin
daf16cdb63 Call it 'Distraction-free writing mode' and update the help string. fixes #30657.
git-svn-id: https://develop.svn.wordpress.org/trunk@30890 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 10:06:17 +00:00
Dominik Schilling (ocean90)
663d12c8f8 Customizer: Remove date filter from the Header/Background Image upload frames.
Adds an option to `wp.media.view.AttachmentsBrowser` to hide the date filter added in [29813].

see #30689.

git-svn-id: https://develop.svn.wordpress.org/trunk@30872 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 20:26:54 +00:00
Andrew Ozz
276a69d6f9 TinyMCE: add another Edit translatable string for the tooltip of the Edit button on the image toolbar. Props pavelevap, see #30694.
git-svn-id: https://develop.svn.wordpress.org/trunk@30839 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-13 00:46:20 +00:00
Andrew Ozz
3fb7f40445 TinyMCE: remove reposition delay on showing the image toolbar. Not needed when no animation. Fixes #30670.
git-svn-id: https://develop.svn.wordpress.org/trunk@30829 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-12 00:09:29 +00:00
Dominik Schilling (ocean90)
e91efcca38 Fix JSHint error introduced in [30780].
see #30608.

git-svn-id: https://develop.svn.wordpress.org/trunk@30792 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-08 22:06:22 +00:00
Scott Taylor
0b157bf069 Incorporate https://github.com/johndyer/mediaelement/pull/1385 into our custom build of MediaElement 2.16.2.
Props bradyvercher.
Fixes #30281.


git-svn-id: https://develop.svn.wordpress.org/trunk@30783 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 23:58:46 +00:00
Andrew Ozz
8719a8a8b0 Media: ensure the toolbar is shown after leaving iframe-based content. Props mcsf, fixes #30608.
git-svn-id: https://develop.svn.wordpress.org/trunk@30780 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 21:11:23 +00:00
Scott Taylor
a0c600a121 When using the spacebar to select something in "bulk select" mode, don't scroll the page.
Props avryl.
Fixes #30622.


git-svn-id: https://develop.svn.wordpress.org/trunk@30777 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 20:10:56 +00:00
Andrew Ozz
1a8c0b9254 TinyMCE: return focus to the editor after closing the image toolbar. Props afercia, see #27642.
git-svn-id: https://develop.svn.wordpress.org/trunk@30775 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 20:07:22 +00:00
Andrew Ozz
08021593f3 TinyMCE, improve accessibility:
- Return focus to the editor on pressing Escape while the image toolbar is focused.
- Add a Close button to the Help modal and close it on Escape.
- Override the title on the editor iframe (read by screen reader apps), replace with the Alt+Shift+H shortcut.
- Add focus shortcuts descriptions to the Help modal.
Fixes #27642.

git-svn-id: https://develop.svn.wordpress.org/trunk@30757 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 23:52:25 +00:00
Andrew Ozz
6f43327574 TinyMCE: manually fire ExecCommand when aligning images as we do preventDefault() on BeforeExecCommand for them. Props avryl, fixes #30565.
git-svn-id: https://develop.svn.wordpress.org/trunk@30748 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 00:32:18 +00:00
Scott Taylor
2ec473b538 Monkey-patch MediaElement to restore H264 support to Chromium.
Documented here:
https://core.trac.wordpress.org/ticket/30281#comment:9

See #30281.


git-svn-id: https://develop.svn.wordpress.org/trunk@30736 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-04 00:58:13 +00:00
John Blackbourn
a4db31f9a4 Prevent scrolling beneath modals on mobile devices by removing overflow from #wpwrap when a modal is open.
Fixes #29909
Props avryl


git-svn-id: https://develop.svn.wordpress.org/trunk@30707 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 08:08:25 +00:00
Drew Jaynes (DrewAPicture)
205a43ed05 Correctly capitalize JavaScript throughout core docs.
Fixes #30569.


git-svn-id: https://develop.svn.wordpress.org/trunk@30695 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 00:30:59 +00:00
Andrew Ozz
4eb3c5960f TinyMCE: update the wpView toolbar to look the same as the new image toolbar.
Fixes #30561.

git-svn-id: https://develop.svn.wordpress.org/trunk@30694 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 00:25:15 +00:00
John Blackbourn
fe4b0c7f14 Remove the sortable functionality from the selection editing toolbar at the bottom of the media manager.
Fixes #29934
See #24352
Props jessepollak


git-svn-id: https://develop.svn.wordpress.org/trunk@30686 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 04:17:53 +00:00
Andrew Ozz
45f4403dd0 TinyMCE: update to 4.1.7, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt. Fixes #30560.
git-svn-id: https://develop.svn.wordpress.org/trunk@30675 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 23:27:23 +00:00
Scott Taylor
7d95a91c5b When creating audio and video MCE views, listen to the players within each iframe to capture the "play" event. When a player plays, pause the players in every other iframe sandbox.
Fixes #29384.


git-svn-id: https://develop.svn.wordpress.org/trunk@30642 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 08:44:21 +00:00
Scott Taylor
ac2c986831 When deleting media grid attachments, wait until the server responds before removing the model from its collection.
Props 5um17.
Fixes #30457.


git-svn-id: https://develop.svn.wordpress.org/trunk@30638 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 06:18:07 +00:00
Scott Taylor
6d7bbcbc04 Upgrade to MediaElement 2.16.2
https://github.com/johndyer/mediaelement/compare/2.15.1...2.16.2

Fixes #30281.


git-svn-id: https://develop.svn.wordpress.org/trunk@30634 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 05:57:25 +00:00
Andrew Ozz
f078fc3e99 Editor: use the Alt+Shift+W keyboard shortcut for new DFW from both the Visual and Text editors. Props afercia, fixes #30450.
git-svn-id: https://develop.svn.wordpress.org/trunk@30593 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 01:43:56 +00:00
Andrew Ozz
9fe0de6c42 Remove unused CSS and JS from wp-mce-help.php, see #30517.
git-svn-id: https://develop.svn.wordpress.org/trunk@30584 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-26 23:22:33 +00:00
Mark Jaquith
3fb3ffbc78 Remove old DFW width adjustment help text.
fixes #30517

git-svn-id: https://develop.svn.wordpress.org/trunk@30582 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-26 22:29:57 +00:00
Andrew Ozz
d4946a7904 Editor:
- Add CSS reset for the TinyMCE fullscreen mode when used on the Edit Post screen.
- Fix loading of the old and new DFW buttons, use another arg. passed to WP_Editors.
- Reset editor-expand when exiting TinyMCE fullscreen mode.
Fixes #30453.

git-svn-id: https://develop.svn.wordpress.org/trunk@30573 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-26 02:49:41 +00:00
Dominik Schilling (ocean90)
836ef75b8e Update embedded.png after running grunt imagemin.
After [30059] and [30079] we still had four images which could be minified. Three of them are handled by [30562], the last one by this.

fixes #30141.

git-svn-id: https://develop.svn.wordpress.org/trunk@30563 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 14:08:56 +00:00
Andrew Ozz
a6b7826831 TinyMCE: don't hide the image toolbar when the iframe window fires onresize. There is a bug in several browsers that triggers onresize when a tooltip is shown, only in RTL mode. Also use better variable name. Fixes #30147.
git-svn-id: https://develop.svn.wordpress.org/trunk@30560 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 04:30:31 +00:00
Andrew Ozz
c2c0eee75a TinyMCE: use the actual image node when calculating the position of the toolbar. Fixes a bug in old IE. See #30147.
git-svn-id: https://develop.svn.wordpress.org/trunk@30558 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 01:21:35 +00:00
Dominik Schilling (ocean90)
bc53a39130 Remove incorrect documentation for wp.media().
props ericlewis.
fixes #30090.

git-svn-id: https://develop.svn.wordpress.org/trunk@30556 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 23:11:54 +00:00
Helen Hou-Sandi
a8821f6b57 Admin notices: Add more variety and make more generically usable.
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.

Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.

props avryl, melchoyce.
fixes #27418.


git-svn-id: https://develop.svn.wordpress.org/trunk@30505 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 16:40:29 +00:00
Andrew Ozz
9998091278 TinyMCE: change the default font size from 100% to 16px to fix some back-compat issues, fixes #30038.
git-svn-id: https://develop.svn.wordpress.org/trunk@30490 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 22:22:55 +00:00
Helen Hou-Sandi
00053abb4c Media a11y: Don't set role=checkbox for the attachment details view.
Some unnecessary attributes were inherited from the attachment view, which created difficulties with screen readers.

fixes #30390.


git-svn-id: https://develop.svn.wordpress.org/trunk@30483 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 17:14:11 +00:00
Dominik Schilling (ocean90)
e1d16e8080 Simplify selectors in [30374].
props wonderboymusic, adamsilverstein.
see #29326.

git-svn-id: https://develop.svn.wordpress.org/trunk@30461 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 15:36:20 +00:00
Andrew Nacin
45d6c62707 TinyMCE: Verify HTML in captions. props azaozz
git-svn-id: https://develop.svn.wordpress.org/trunk@30435 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 13:48:20 +00:00
Andrew Ozz
7137f26a5b TinyMCE: update to the latest dev. version, 4.1.6+. Fixes #30411.
git-svn-id: https://develop.svn.wordpress.org/trunk@30397 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 00:49:38 +00:00
Andrew Ozz
5740d2206b TinyMCE: fix the tooltip for 'alignnone' button on the image toolbar. Props johnbillion, see #30147.
git-svn-id: https://develop.svn.wordpress.org/trunk@30385 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-19 17:26:18 +00:00
John Blackbourn
8c25a14aa0 Update the inline docs for the keyEvent callback in the media grid.
Props adamsilverstein
See #29725


git-svn-id: https://develop.svn.wordpress.org/trunk@30378 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-18 04:28:51 +00:00
John Blackbourn
0297a3c4f6 Avoid re-registering the keydown event controller in the media grid so arrow controls don't skip media items.
Fixes #30348
Props UmeshSingla


git-svn-id: https://develop.svn.wordpress.org/trunk@30377 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-18 04:27:12 +00:00
John Blackbourn
01ef72efa4 Improve Thickbox's close button so it can be announced by screen readers.
Fixes #29455
Props SergeyBiryukov


git-svn-id: https://develop.svn.wordpress.org/trunk@30376 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-18 03:54:19 +00:00
John Blackbourn
92ae13f0ee Improve keyboard control of Edit Selection mode in the media manager.
See #29326
Props adamsilverstein


git-svn-id: https://develop.svn.wordpress.org/trunk@30374 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-18 03:33:11 +00:00
Andrew Ozz
34e409ddd8 Fix typo in [30361], see #30147.
git-svn-id: https://develop.svn.wordpress.org/trunk@30362 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 23:14:49 +00:00
Andrew Ozz
d2b8163078 TinyMCE: don't show image toolbar for placeholder images. See #30147.
git-svn-id: https://develop.svn.wordpress.org/trunk@30361 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 23:11:14 +00:00
Andrew Ozz
256db7c4cb TinyMCE: fix the cursor appearance while it is outside the editor body. Props miyauchi, fixes #30112.
git-svn-id: https://develop.svn.wordpress.org/trunk@30349 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-15 01:20:41 +00:00
Mark Jaquith
78f0186866 Introduce Distraction-Free Writing v2, a re-think of DFW that uses the main editor instance
* the "DFW" button is now an auto/off toggle
* defaulting to auto during beta, decide later for release
* "auto" means that DFW gets enabled as you start typing in editor
* tabbing and mousing out will bring the full interface back
* there is a slight grace period during which your mouse can quickly return

Feature plugin work happened here: https://github.com/avryl/focus

props avryl, azaozz, Michael Arestad
fixes #29806

git-svn-id: https://develop.svn.wordpress.org/trunk@30338 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 22:30:55 +00:00