Commit Graph

1806 Commits

Author SHA1 Message Date
Scott Taylor
220fda0095 In $wpdb->update(), prevent explosions when $where is empty.
Adds unit tests.

Props UmeshSingla, wonderboymusic.
Fixes #26106


git-svn-id: https://develop.svn.wordpress.org/trunk@28814 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:23:09 +00:00
Scott Taylor
76bd35fa79 In comment_form(), allow name_submit to be passed to change the name attribute of the submit button.
Props obenland.
Fixes #22792.


git-svn-id: https://develop.svn.wordpress.org/trunk@28813 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:09:51 +00:00
Sergey Biryukov
2120ede170 Remove mbstring_binary_safe_strlen(). Use mbstring_binary_safe_encoding() and reset_mbstring_encoding() directly.
fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28808 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 22:20:23 +00:00
Scott Taylor
0adec3db8a Use the proper height property when calculating video size in wp_underscore_video_template().
Props Fab1en.
See #28190.


git-svn-id: https://develop.svn.wordpress.org/trunk@28807 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 20:34:14 +00:00
Sergey Biryukov
4fd715c937 Introduce a binary-safe wrapper for strlen() and use it in seems_utf8(), utf8_uri_encode(), and wp_read_image_metadata().
Use binary-safe POMO_Reader::strlen() in MO::export_to_file_handle().

fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28806 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 14:47:08 +00:00
Sergey Biryukov
b11b6f2f2b Simplify the code for calculating plugin API check timeout.
props leewillis77.
fixes #28600.

git-svn-id: https://develop.svn.wordpress.org/trunk@28805 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 14:30:14 +00:00
Sergey Biryukov
21cf4d1ab4 Don't kill an empty search query.
see #11330.

git-svn-id: https://develop.svn.wordpress.org/trunk@28804 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 13:33:39 +00:00
Sergey Biryukov
f7d7ecd0a6 Prevent multiple hierarchical posts with the same slug from being displayed in single post template.
fixes #28611.

git-svn-id: https://develop.svn.wordpress.org/trunk@28803 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 13:14:39 +00:00
Sergey Biryukov
1c7bfc7ed1 Revert [28776] and use a correct variable instead.
props miqrogroove.
fixes #28575.

git-svn-id: https://develop.svn.wordpress.org/trunk@28802 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-22 22:12:47 +00:00
Sergey Biryukov
256de085ec Fix MediaElement i18n.
props Namibia, eherman24.
fixes #28366 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@28801 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-22 14:15:55 +00:00
Andrew Ozz
31da18f841 TinyMCE: revert 158b742410 and 576fa77aa2 as they may cause selection restore problems in old IE. See #28391.
git-svn-id: https://develop.svn.wordpress.org/trunk@28795 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-21 01:14:43 +00:00
Andrew Nacin
c45a47efdd Stop denying wp-includes/* in our default robots.txt.
props joostdevalk.
fixes #28604.


git-svn-id: https://develop.svn.wordpress.org/trunk@28794 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 21:01:29 +00:00
Andrew Nacin
18d069703b Fix documentation for wp_create_nonce() which wrongly suggests these tokens are actually numbers used once.
git-svn-id: https://develop.svn.wordpress.org/trunk@28793 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 20:46:13 +00:00
Scott Taylor
304f4f5ba9 Posts in the Trash should not drag attachment pages down with them.
Props ericlewis.
Fixes #14639.


git-svn-id: https://develop.svn.wordpress.org/trunk@28791 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 19:13:39 +00:00
Scott Taylor
e447c8f823 Add Animoto to the list of oEmbed providers. Example video: http://animoto.com/play/MlRRgXHhoT8gOZyHanM6TA.
Props lritter.
Fixes #28265.



git-svn-id: https://develop.svn.wordpress.org/trunk@28790 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:56:11 +00:00
Scott Taylor
4540455f95 Whitespace in navMenuL10n after [28707].
Fixes #23076.



git-svn-id: https://develop.svn.wordpress.org/trunk@28789 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:29:44 +00:00
Scott Taylor
a7c1728f2e Reinstate the changes from [28579] with some adjustments:
* Check `! empty( $postarr['file'] )` before calling `update_attached_file()`
* Add a unit test: `test_update_attachment_fields()`
* Run the same logic for empty `guid` for attachments that always ran in `wp_insert_post()`, as per #18310. This fixes a unit test that would have broken when this ticket was marked closed.
* Updated the unit test in `Tests_Media::test_wp_prepare_attachment_for_js()` to account for `url` no longer being empty

Props kovshenin, wonderboymusic.
See #21963.


git-svn-id: https://develop.svn.wordpress.org/trunk@28788 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:26:17 +00:00
Scott Taylor
05abd7e56f Cleanup wp_widget_rss_form() after [28734]. "$$input used sanitized variables which contained actual values, unlike $inputs[$input] which in that context contains data about which input fields are hidden."
Props kovshenin.
Fixes #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28787 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:28:12 +00:00
Scott Taylor
33275a0826 Cleanup after [28671]:
* Set better defaults in `paginate_links()`, so that themes don't have to calculate them on their own, like Twenty Fourteen does now.
* Don't set page 1 to `?page=1` or `/page/1/` - that will force a canonical redirect.
* Add and cleanup unit tests

Props obenland, SergeyBiryukov, wonderboymusic.
Fixes #24606.


git-svn-id: https://develop.svn.wordpress.org/trunk@28785 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:11:14 +00:00
Scott Taylor
eb289835f7 Further adjustments after [8364], listen to an editor instance event instead of delegating a body click when attempting to pause all players belonging to a particular MCE view.
Props avryl.
Fixes #27971.


git-svn-id: https://develop.svn.wordpress.org/trunk@28784 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 16:29:47 +00:00
Scott Taylor
5ec545d5ab Revert [28613] and [28664]. A good idea, but too much BC baggage.
See #28099.



git-svn-id: https://develop.svn.wordpress.org/trunk@28783 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 16:20:35 +00:00
John Blackbourn
dbc30e94b3 Increase the timeout for plugin and theme update checks based on how many are being checked. Props dd32. Fixes #25788
git-svn-id: https://develop.svn.wordpress.org/trunk@28782 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 23:20:15 +00:00
John Blackbourn
036c2b5fca Remove SSL verification by default for requests to wp-cron.php. Props sivel, rhurling. Fixes #12609.
git-svn-id: https://develop.svn.wordpress.org/trunk@28781 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 22:52:35 +00:00
Sergey Biryukov
4306de30e3 Move preg_match() that should only run once out of the loop.
props dllh.
fixes #28575.

git-svn-id: https://develop.svn.wordpress.org/trunk@28776 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 00:00:27 +00:00
Scott Taylor
9642d17ff8 Diambiguate type and shortcode in TinyMCE view classes and their attached view.View class. Has the added feature of not causing JS errors.
See #28532.


git-svn-id: https://develop.svn.wordpress.org/trunk@28775 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 23:02:10 +00:00
Andrew Nacin
39cf46851b Allow a language to be chosen before installing WordPress. First pass.
* Checks WordPress.org for available languages.
* In get_locale(), starts using the WPLANG option that has existed in multisite since the MU days.
* Adds new argument to wp_install() for setting WPLANG.

see #28577. 


git-svn-id: https://develop.svn.wordpress.org/trunk@28774 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 19:57:21 +00:00
Scott Taylor
0688f9eb49 In wptexturize() + tests:
* Allow well-formed HTML inside of shortcode attributes
* Restrict recursion. HTML is allowed but ignored.
* Do not allow exotic HTML comments in shortcode attributes.
* Continue to ignore the [ and ] chars if they appear in any HTML attribute.
* Update related regex patterns.
* Update unit tests.

Props miqrogroove.
Fixes #28564.


git-svn-id: https://develop.svn.wordpress.org/trunk@28773 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 19:48:46 +00:00
Sergey Biryukov
550d0f0aea Don't generate adjacent links in wp_head() for attachments.
props kovshenin.
fixes #21658.

git-svn-id: https://develop.svn.wordpress.org/trunk@28770 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 00:04:14 +00:00
Sergey Biryukov
566fd5da8d Pass WP_Customize_Setting instance to 'customize_save_*' action.
props danielbachhuber.
fixes #27979.

git-svn-id: https://develop.svn.wordpress.org/trunk@28769 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:57:19 +00:00
Andrew Ozz
b8fd9d997e TinyMCE: update to 4.0.28+. Includes all changes until 09-06-2014: 32cb108d41. Changelog: 32cb108d41/changelog.txt.
See #28391.

git-svn-id: https://develop.svn.wordpress.org/trunk@28768 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:49:00 +00:00
Sergey Biryukov
f1172ba195 Pass WP_Customize_Setting instance to 'customize_preview_*' and 'customize_update_*' actions.
props dustyn, DrewAPicture.
fixes #27979.

git-svn-id: https://develop.svn.wordpress.org/trunk@28767 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:34:31 +00:00
Scott Taylor
b11edb94d9 Fix abbreviations mixed with quotes, example: '99% of people'.
Add/alter unit tests.

Props miqrogroove.
Fixes #26850.


git-svn-id: https://develop.svn.wordpress.org/trunk@28765 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 20:18:38 +00:00
Scott Taylor
1f4d925102 In wptexturize(), adjust for the treatment of abbreviated years at the end of quotations.
Silence some unit tests that have never passed and may no longer be applicable.

Props miqrogroove.
Fixes #18549.


git-svn-id: https://develop.svn.wordpress.org/trunk@28764 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 20:13:54 +00:00
Scott Taylor
6f658551d6 Add unit tests to confirm that --- is properly converted to — by wptexturize() where appropriate.
Props miqrogroove.
Fixes #28483.


git-svn-id: https://develop.svn.wordpress.org/trunk@28763 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 18:06:12 +00:00
Scott Taylor
14f3b15d69 Add Unit Tests for i18n and wptexturize(). Don't confuse closing single quotes and apostrophes.
See #27426.


git-svn-id: https://develop.svn.wordpress.org/trunk@28762 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 17:56:08 +00:00
Scott Taylor
03a6e5f1fb wptexturize() adjustments:
* Only place an apostrophe before a number when it has exactly two digits.
* Never match '99' with the single prime pattern.
* Always assume '99' is an abbreviated year at the end of a quotation.
* Add unit tests.
* Resolves the unit test broken in [28721] for #8775.

See #26850.


git-svn-id: https://develop.svn.wordpress.org/trunk@28761 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 17:40:07 +00:00
Sergey Biryukov
abddfc4b99 Prevent get_post_class() and get_body_class() from returning duplicate classes.
props Compute.
fixes #28541.

git-svn-id: https://develop.svn.wordpress.org/trunk@28760 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 15:17:36 +00:00
Andrew Ozz
ed4a159498 TinyMCE wpView: fix selecting all of view's "text" in Safari, props avryl, fixes #28088
git-svn-id: https://develop.svn.wordpress.org/trunk@28755 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-16 00:11:45 +00:00
Andrew Ozz
ed07c215dc wpView: improve handling of embed errors/error messages, see #28195
git-svn-id: https://develop.svn.wordpress.org/trunk@28754 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-15 22:52:45 +00:00
Sergey Biryukov
084cc046ac Correct @return value for term_exists().
props simonwheatley.
fixes #28538.

git-svn-id: https://develop.svn.wordpress.org/trunk@28753 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-14 14:56:21 +00:00
Scott Taylor
69ecca0b6a Add "edit" mode for [embed] and URL media previews.
See #28532.


git-svn-id: https://develop.svn.wordpress.org/trunk@28752 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-13 21:41:20 +00:00
Sergey Biryukov
a67759c545 wpLink: use simpler expressions to detect email address or URL. We are not validating user input here, just suggesting.
see #19992.

git-svn-id: https://develop.svn.wordpress.org/trunk@28751 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-13 21:25:16 +00:00
Andrew Ozz
8ed6fd2d50 wpLink: use the proper instance of the editor when looking at the selection. Move the email and URL regexp to variables. See #19992
git-svn-id: https://develop.svn.wordpress.org/trunk@28750 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-13 21:13:15 +00:00
Andrew Ozz
09d4b541fb wpView:
- Don't wrap single-line URLs in [embed]. Use them directly in generating a view.
- If the embedding HTML contains a script, "sandbox" it in an iframe to prevent it from changing the editor DOM.
- Automatically add toolbar and overlay when needed.
- Try to embed single-line URLs only if they are pasted in an empty paragraph.
Props avryl, see #28195

git-svn-id: https://develop.svn.wordpress.org/trunk@28748 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-12 02:48:17 +00:00
Scott Taylor
0675902ec8 Don't use variable variables in wp_salt().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28741 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:35:42 +00:00
Scott Taylor
0d0cdfe1c7 Don't use variable variables in wp_insert_user().
Add a local array, `$meta`, to provide substantial disambiguation among variables. 

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28740 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:20:57 +00:00
Scott Taylor
35af75077b Don't use variable variables in plugins_url().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28739 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:17:52 +00:00
Scott Taylor
ce8cff84aa Don't use variable variables in WP_Comment_Query::query().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28738 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:57:39 +00:00
Scott Taylor
f2b3e0c4e4 Don't use variable variables in WP_Query::get_posts().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28737 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:49:07 +00:00
Scott Taylor
5fe5f8f3ad Don't use variable variables in get_terms().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28736 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:40:11 +00:00