This better utilizes the available screen space on wider screens.
Props mblach, hedgefield, Clorith.
Fixes#52966.
git-svn-id: https://develop.svn.wordpress.org/trunk@50833 602fd350-edb4-49c9-b593-d223f7449a82
Replace infinitely autoloading behavior on scroll with a user-controlled load more button. Fix a long standing accessibility issue in the media library. Infinite scroll poses a wide range of problems for accessibility, usability, and performance.
This change modifies the library to load 40 items in the initial view, with a load more button to load the next 40 items and a button to move focus from the load more region to the first of the most recently added items.
The text for communicating the jump target was broadly discussed, agreeing that the text incorporated here would most concisely and clearly convey the purpose of the button, and any further detail is learnable from use.
Props afercia, adamsilverstein, joedolson, audrasjb, francina
Fixes#50105. See #40330.
git-svn-id: https://develop.svn.wordpress.org/trunk@50829 602fd350-edb4-49c9-b593-d223f7449a82
This officially removes support for Internet Explorer 11 in the CSS files run through the build process in Core.
Individual tickets should be opened for removing each manually maintained area of the code base targeting IE11.
The resulting changes to CSS files are included in this commit.
Fixes#53077.
git-svn-id: https://develop.svn.wordpress.org/trunk@50784 602fd350-edb4-49c9-b593-d223f7449a82
This updates the `caniuse-lite` database to the most recent version (`1.0.30001214`) by running `npx browserslist@latest --update-db`.
The resulting changes after running `grunt precommit:css` are also included in this commit.
See #52624.
git-svn-id: https://develop.svn.wordpress.org/trunk@50782 602fd350-edb4-49c9-b593-d223f7449a82
Allow developers to extend the Site Health screen with their own custom navigation tabs and pages.
This implements a new filter, `site_health_navigation_tabs`, which takes an associated array of tab identifiers/slugs, and tab labels, allowing developers to add their own subpage to the Site Health interface as new tabs.
To output a custom page, or add to an existing page, the `site_health_tab_content` action is triggered whenever the `tab` query argument is present and not empty. This action includes the current tab as its argument, which a developer would match against to only output content when relevant.
Props ramiy for initial patch.
Fixes#47225.
git-svn-id: https://develop.svn.wordpress.org/trunk@50764 602fd350-edb4-49c9-b593-d223f7449a82
This makes the CSS selector used to right align certain form related elements more specific. This prevents any error messages from being right aligned.
Props sabernhardt, audrasjb.
Fixes#52989.
git-svn-id: https://develop.svn.wordpress.org/trunk@50712 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that contrast between text color and background meets the WCAG 2.0 AA recommended value. The following locations were changed:
- Network List Tables: Use lighter background colors for site status indicator.
- Nav Menus: Use a lighter background color for invalid menu items.
- Pointers: Use a darker background for pointer header.
- Themes: Use darker background on filter button hover.
- Customizer: Use darker background for selected widget.
Follow-up to [50025], [50571].
Props kebbet, melchoyce, peterwilsoncc.
Fixes#52760.
git-svn-id: https://develop.svn.wordpress.org/trunk@50687 602fd350-edb4-49c9-b593-d223f7449a82
Replace the float CSS removed in [50569], which is used to align the login & register buttons.
Props mukesh27, audrasjb.
Fixes#52834.
git-svn-id: https://develop.svn.wordpress.org/trunk@50577 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.
Follow-up to [50025], [50525].
Props sabernhardt, ryelle.
Fixes#52760.
git-svn-id: https://develop.svn.wordpress.org/trunk@50571 602fd350-edb4-49c9-b593-d223f7449a82
Prevent misalignment of "generate password" and "save password" buttons on the password reset screen on narrow screens and in languages requiring longer text than English.
Props audrasjb, grapplerulrich, ryelle.
Fixes#52834.
git-svn-id: https://develop.svn.wordpress.org/trunk@50569 602fd350-edb4-49c9-b593-d223f7449a82
On narrow screens allow the text to wrap in the copy buttons on the privacy policy guide screen to avoid horizontal overflow of the parent container.
Props audrasjb, davidbaumwald, jaymanpandya, paaljoachim, palmiak, sabernhardt, SergeyBiryukov, sumitsingh.
Fixes#52751.
git-svn-id: https://develop.svn.wordpress.org/trunk@50568 602fd350-edb4-49c9-b593-d223f7449a82
When collapsed or on a small screen, these styles would override the color schemes, causing a dark background to appear regardless of the color scheme's settings. This change also uses `focus-within` to show or hide the menu item's arrow, consistent with how the arrow behaves on hover.
Props afercia, Bueltge.
Fixes#32579.
git-svn-id: https://develop.svn.wordpress.org/trunk@50549 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.
Follow-up to [50025].
Props sabernhardt, Otshelnik-Fm, audrasjb.
Fixes#52760.
git-svn-id: https://develop.svn.wordpress.org/trunk@50525 602fd350-edb4-49c9-b593-d223f7449a82
Removing `display: block` from the element allows the `.hide-if-no-js` class to have the intended effect.
Follow-up to [34275].
Props sabernhardt, mukesh27.
Fixes#52662.
git-svn-id: https://develop.svn.wordpress.org/trunk@50512 602fd350-edb4-49c9-b593-d223f7449a82
Adds a more obviously interactive comparison for viewing the color scheme differences. Improvements on RTL and IE11. Update strings to be more clear and consistent. Switch to the CDN for loading images.
Props sarahricker, desrosj, melchoyce, SergeyBiryukov, tikifez, clorith, marybaum, audrasjb, francina, hellofromTonya.
Fixes#52693. See #52347.
git-svn-id: https://develop.svn.wordpress.org/trunk@50478 602fd350-edb4-49c9-b593-d223f7449a82
This is the start of the WordPress 5.7 about page.
Props audrasjb, metalandcoffee, melchoyce, hedgefield, francina, webcommsat, lukecarbis, meher, sarahricker, marybaum.
See #52347.
git-svn-id: https://develop.svn.wordpress.org/trunk@50418 602fd350-edb4-49c9-b593-d223f7449a82
In #50547, the admin color schemes were added to the customizer UI, but at some point specificity changed and the colors were overridden by the defaults. This brings the color schemes back into the customizer, using the button color as a highlight, with the link color for text to keep things readable.
Follow up to [48371].
Props audrasjb, peterwilsoncc.
Fixes#52230.
git-svn-id: https://develop.svn.wordpress.org/trunk@50386 602fd350-edb4-49c9-b593-d223f7449a82
This brings its styling inline with other meta boxes in the admin area.
Props antonlukin, kburgoine, grzim, sabernhardt, pbiron, audrasjb
Fixes#48782
git-svn-id: https://develop.svn.wordpress.org/trunk@50357 602fd350-edb4-49c9-b593-d223f7449a82
The color palette changes in #49999 introduced some contrast issues on buttons, input elements, and links. This change ensures that all interactive elements have an appropriate contrast ratio.
Follow-up to [50025].
Props audrasjb, joedolson.
Fixes#52402.
git-svn-id: https://develop.svn.wordpress.org/trunk@50278 602fd350-edb4-49c9-b593-d223f7449a82
When the color change was done, the background of plugins with updates had to be manually changed. This section was missed, which caused a visual bug. This fix also removes some redundant CSS for the same element.
Follow-up to [50025].
Props afragen.
Fixes#52452.
git-svn-id: https://develop.svn.wordpress.org/trunk@50237 602fd350-edb4-49c9-b593-d223f7449a82
Consolidating `border`, `padding`, and `margin` instances where the shorthand can be used to improve readability.
Props ankitmaru, audrasjb, sabernhardt, mukesh27, hellofromTonya.
Fixes#52148.
git-svn-id: https://develop.svn.wordpress.org/trunk@50162 602fd350-edb4-49c9-b593-d223f7449a82
The Privacy settings pages now use the same design patterns as the Site Health screen. Additionally, each privacy policy guide is now contained in an accordion to make the page easier to navigate when multiple plugins are in use.
Props xkon, hedgefield, garrett-eclipse, hellofromTonya, paaljoachim, joedolson.
Fixes#49264.
git-svn-id: https://develop.svn.wordpress.org/trunk@50161 602fd350-edb4-49c9-b593-d223f7449a82
This adds a form option to skip the admin email alert when exporting personal data.
Props xkon, azaozz, TZ-Media, iandunn, desrosj, iprg, allendav, wesselvandenberg, karmatosed, birgire, davidbaumwald, estelaris, paaljoachim, hellofromTonya.
Fixes#43890.
git-svn-id: https://develop.svn.wordpress.org/trunk@50159 602fd350-edb4-49c9-b593-d223f7449a82
This also removes a CSS rule in the light scheme which was flagged as temporary and overrides the hover text color.
Fixes#52229.
git-svn-id: https://develop.svn.wordpress.org/trunk@50125 602fd350-edb4-49c9-b593-d223f7449a82
Make the navigation menu footer sticky so a Save Menu button is always available in the viewport. Improves usability and effectiveness of the interface when in a responsive view.
Props garrett-eclipse, audrasjb, maxpertici, sabernhardt, kburgoine, poena
Fixes#51631
git-svn-id: https://develop.svn.wordpress.org/trunk@50115 602fd350-edb4-49c9-b593-d223f7449a82
The update icon rotation should not occur when the user has opted to reduce motion, for example by selecting the "Reduce motion" option in macOS' preferences or unselecting "Show animations in Windows" in Windows' preferences.
Follow-up to [47813], [50027].
Props xkon, audrasjb, johnbillion.
Fixes#52263. See #51476.
git-svn-id: https://develop.svn.wordpress.org/trunk@50028 602fd350-edb4-49c9-b593-d223f7449a82
This is part of a larger project in cleaning up core's admin CSS. This collapses all colors used in the CSS to one of 12 blues, greens, reds, and yellows, 13 grays, pure black, and pure white. The colors are perceptually uniform from light to dark, half of each range has a 4.5 or higher contrast against white, the other half has a 4.5 or higher contrast against black.
Standardizing on this set of colors will help contributors make consistent, accessible design decisions. The full color palette can be seen here: https://codepen.io/ryelle/full/WNGVEjw
Props notlaura, danfarrow, kburgoine, drw158, audrasjb, Joen, hedgefield, ibdz, melchoyce.
See #49999.
git-svn-id: https://develop.svn.wordpress.org/trunk@50025 602fd350-edb4-49c9-b593-d223f7449a82
This removes instances of the `-moz-user-select` property, which was required until Firefox 68.
Firefox is currently in version 84, so these can safely be removed.
Fixes#52332.
git-svn-id: https://develop.svn.wordpress.org/trunk@49991 602fd350-edb4-49c9-b593-d223f7449a82
This removes extra margin from the Select button and ensures the checkboxes in the Menu Settings section are fully visible.
Props sabernhardt, passoniate, mukesh27, afercia, audrasjb, Boniu91, ravipatel, jomisica.
Fixes#49245, #51706.
git-svn-id: https://develop.svn.wordpress.org/trunk@49964 602fd350-edb4-49c9-b593-d223f7449a82
This adds a border along the side of admin menu links when hovering or focusing on them, as color should not be the only indicator of link state.
Props accessiblejoe florianziegler afercia rianrietveld michael-arestad ryan hedgefield audrasjb ibdz.
Fixes#28599.
git-svn-id: https://develop.svn.wordpress.org/trunk@49961 602fd350-edb4-49c9-b593-d223f7449a82
If every single label is emphasized with a `<strong>` tag, none of them is really emphasized anymore.
This removes the tags in favor of CSS styling, for consistency with the other labels on the screen.
Props chemiker, audrasjb, mukesh27, paaljoachim, estelaris, ibdz, SergeyBiryukov.
Fixes#52232.
git-svn-id: https://develop.svn.wordpress.org/trunk@49958 602fd350-edb4-49c9-b593-d223f7449a82
This joyous marriage means that users will no longer find a selected top bulk action on a list table unexpectedly being applied instead of their selected bottom bulk action. The top and bottom controls for changing user roles are equally wedded forever too.
Props clayray, subrataemfluence, garrett-eclipse, pbiron, hareesh-pillai
Fixes#46872
git-svn-id: https://develop.svn.wordpress.org/trunk@49944 602fd350-edb4-49c9-b593-d223f7449a82
Also removes an unnecessary `!important` rule introduced in [49772] when fixing a similar issue.
Props vladytimy, mukesh27.
Fixes#51980.
See [49772].
git-svn-id: https://develop.svn.wordpress.org/trunk@49921 602fd350-edb4-49c9-b593-d223f7449a82
This brings the accessibility improvements previously made for other areas of the admin in WordPress 5.3 to the installation screens too.
Follow-up to [46241-46244], [46247], [46248], [46293], [46425].
Props Maigret, audrasjb.
Fixes#51854.
git-svn-id: https://develop.svn.wordpress.org/trunk@49907 602fd350-edb4-49c9-b593-d223f7449a82
This adds clearer messages about what your current settings mean for updates, uses a more compact link-based action instead of a checkbox to change the setting, and respects constants and filters.
Props audrasjb, karmatosed, helen, azaozz, hedgefield, marybaum.
Fixes#51742.
git-svn-id: https://develop.svn.wordpress.org/trunk@49587 602fd350-edb4-49c9-b593-d223f7449a82
Sets a defined size for text alongside the media browser uploader button fixing alignment on popular browsers.
Props krupajnanda, mikeschroder, aaroncampbell, lucagrandicelli, andraganescu, samful, sabernhardt, andystitt829, kburgoine.
Fixes#41648
git-svn-id: https://develop.svn.wordpress.org/trunk@49553 602fd350-edb4-49c9-b593-d223f7449a82
Fix cropped container around playhead time in audio player.
Props ravipatel, sabernhardt, audrasjb, SergeyBiryukov,
Fixes#51685
git-svn-id: https://develop.svn.wordpress.org/trunk@49550 602fd350-edb4-49c9-b593-d223f7449a82
- Add a label to the readonly password input.
- Handle focus loss after revoking app passwords.
- Handle focus loss after dismissing notices.
- Mark app name as `aria-required`.
- Use `aria-label` for detailed revoke button text instead of `title`.
- Use `-1` for `tabindex` instead of `0`.
Props alexstine, afercia, sabernhardt, audrasjb, joedolson, TimothyBlynJacobs.
Fixes#51580.
git-svn-id: https://develop.svn.wordpress.org/trunk@49549 602fd350-edb4-49c9-b593-d223f7449a82
Standardize on "Go to..." as a more appropriate option for most cases.
Props garrett-eclipse, kharisblank, audrasjb, ramiy, valentinbora.
Fixes#47235.
git-svn-id: https://develop.svn.wordpress.org/trunk@49539 602fd350-edb4-49c9-b593-d223f7449a82
This only applies to the standalone menu screen; fixes for the customizer will be handled separately.
Props audrasjb, garrett-eclipse.
See #49375.
git-svn-id: https://develop.svn.wordpress.org/trunk@49346 602fd350-edb4-49c9-b593-d223f7449a82
