Commit Graph

229 Commits

Author SHA1 Message Date
Sergey Biryukov
87b1101b49 Inline documentation for hooks in wp-admin/includes/class-wp-comments-list-table.php.
props siobhyb, kpdesign.
fixes #25662.

git-svn-id: https://develop.svn.wordpress.org/trunk@26138 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 19:46:20 +00:00
Helen Hou-Sandi
e84e1e8791 Merge the color schemes component from MP6. Introduces Light, Blue, and Midnight.
Color scheme selection on your own profile page gives you a preview and autosaves the selection.

Also introduces the usage of a preprocessor for core files, namely Sass. For 3.8, we will not expand its implementation past the color schemes. This does require Ruby as well as Sass 3.3.0+ due to the usage of the sourcemap option.

Note that only the default color scheme is available when running out of src. Use build to test the rest as well as the color picker.

props ryelle, melchoyce, tillkruess, drw158, littlethingsstudio, helen. see #25858, #22862.


git-svn-id: https://develop.svn.wordpress.org/trunk@26137 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 19:37:10 +00:00
Sergey Biryukov
39d55fddb8 Use get_current_site() instead of the $current_site global when possible.
props jeremyfelt.
fixes #25158.

git-svn-id: https://develop.svn.wordpress.org/trunk@26120 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 03:22:48 +00:00
Sergey Biryukov
7cd8d225a3 Use case-insensitive comparison for email addresses. fixes #25779.
git-svn-id: https://develop.svn.wordpress.org/trunk@26115 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 02:40:28 +00:00
Andrew Ozz
88138fbf3a Fix the X-UA-Compatible header for IE8, fixes #25575
git-svn-id: https://develop.svn.wordpress.org/trunk@26089 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-11 18:01:40 +00:00
Sergey Biryukov
a2aed7b119 Fix docblock formatting. fixes #25893.
git-svn-id: https://develop.svn.wordpress.org/trunk@26081 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-11 13:31:19 +00:00
Sergey Biryukov
c815622e87 Pass correct 'type' parameter to 'upgrader_process_complete' action in Theme_Upgrader.
props bamadesigner.
fixes #25882 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@26049 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 17:03:19 +00:00
Andrew Ozz
859516cd19 Add X-UA-Compatible meta tag in the admin, locking the compatibility mode in IE to the highest supported document mode. Fixes #25575.
git-svn-id: https://develop.svn.wordpress.org/trunk@26029 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 23:48:02 +00:00
Sergey Biryukov
2564c74a57 Fix inverted logic for displaying the 'Broken Theme' string. props pavelevap. fixes #25465.
git-svn-id: https://develop.svn.wordpress.org/trunk@26027 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 22:39:35 +00:00
Sergey Biryukov
cd7deb0e7b Make Twenty Fourteen the default theme. props markmcwilliams. fixes #25702.
git-svn-id: https://develop.svn.wordpress.org/trunk@26024 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 20:01:54 +00:00
Dion Hulse
34fa8af8bb Core Upgrader: Include an unmodified $wp_version in Core_Upgrader::upgrade(). This protects against cases where the global $wp_version has been modified. See #25772
git-svn-id: https://develop.svn.wordpress.org/trunk@26017 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 06:22:23 +00:00
Dion Hulse
18e173ae80 Core Upgrader success statistics: Pass the version of WordPress we're upgrading from, as well as the version being upgraded to. Props nacin. See #25772 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@26016 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 06:19:05 +00:00
Dion Hulse
83754e1636 Remove dead code from the Plugin Upgrader class. Props jdgrimes. Fixes #25470
git-svn-id: https://develop.svn.wordpress.org/trunk@26015 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 05:47:41 +00:00
Dion Hulse
58e4a21f07 When checking filesystem permissions for core updates, only check the permissions of the files which we need to alter. Props nacin for initial patch. Fixes #25771 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@26014 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 05:42:23 +00:00
Dion Hulse
43d50e9c9e Add a filter to the Background Updates debug email, matches the filter used on the non-debug post-update emails. Props pento. Fixes #25756
git-svn-id: https://develop.svn.wordpress.org/trunk@26013 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 02:14:34 +00:00
Scott Taylor
5643e3ca17 Pass $args to the export_wp action in export_wp(), which is currently passed no arguments.
Props nickdaugherty.
Fixes #25574.



git-svn-id: https://develop.svn.wordpress.org/trunk@26011 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 01:26:49 +00:00
Sergey Biryukov
6fa1c89458 Pass comment ID and comment post ID to get_comment_class() in WP_Comments_List_Table::single_row().
props drozdz.
fixes #25814.

git-svn-id: https://develop.svn.wordpress.org/trunk@26001 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 10:59:58 +00:00
Sergey Biryukov
bc6c0c9b0f Correct @since values for various hooks. fixes #25766.
git-svn-id: https://develop.svn.wordpress.org/trunk@25991 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 03:19:16 +00:00
Andrew Nacin
78f8c980da Use correct variable in WP_Automatic_Updater::send_email().
props pento.
see #25757 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25977 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 13:45:17 +00:00
Sergey Biryukov
2e50c871ab Avoid a PHP warning in wp_generate_attachment_metadata() if $metadata is not an array. props asakurayoh. fixes #25649.
git-svn-id: https://develop.svn.wordpress.org/trunk@25968 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 16:42:36 +00:00
Sergey Biryukov
267b476885 Fix a copy/paste error in wp_update_theme() description. props Caspie. fixes #25742.
git-svn-id: https://develop.svn.wordpress.org/trunk@25964 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 10:55:50 +00:00
Drew Jaynes
3a26e383ae Inline documentation for hooks in wp-admin/includes/theme.php.
Props l10n for the initial patch.
Fixes #25732.


git-svn-id: https://develop.svn.wordpress.org/trunk@25961 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 22:45:32 +00:00
Andrew Nacin
1694272bff When an HTTPS request to api.wordpress.org fails, try an insecure HTTP request and issue a warning.
Certain versions of cURL appear to claim OpenSSL support but fail to work. We need to not trap users on older versions while we work this out, and instead fall back to an insecure request.

see #25716 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25956 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 21:08:25 +00:00
Drew Jaynes
acb441a519 Inline documentation for hooks in wp-admin/includes/schema.php.
Props johnafish, kpdesign.
Fixes #25498.


git-svn-id: https://develop.svn.wordpress.org/trunk@25938 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-26 20:28:34 +00:00
Drew Jaynes
eef2e83b13 Inline documentation for hooks in wp-admin/includes/nav-menu.php.
Props Faison.
Fixes #25474.


git-svn-id: https://develop.svn.wordpress.org/trunk@25935 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-26 17:47:33 +00:00
Andrew Nacin
9a2bf56fc3 Avoid a notice for an undefined $checksums variable when updating from pre-3.7 to post-3.7.
props GaryJ.
fixes #25689 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25915 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-25 20:14:23 +00:00
Andrew Nacin
7508e7c03b Add editimage.min.js to $_old_files. see #24999.
git-svn-id: https://develop.svn.wordpress.org/trunk@25897 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-24 19:26:11 +00:00
Andrew Nacin
391b22a4de Confirm delete_site_option() exists before calling it during an update.
This function won't yet exist when updating from 2.7 [sic].

fixes #25682 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25893 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-24 18:17:41 +00:00
Andrew Nacin
9c5420d74d Remove debug code from WP_Automatic_Updater::send_email().
props markmcwilliams for initial patch.
see #25678.


git-svn-id: https://develop.svn.wordpress.org/trunk@25891 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-24 01:50:09 +00:00
Andrew Nacin
3d2776d023 Introduce a send_core_update_notification_email filter to control whether to send update notifications.
Currently, this is dependent on whether the automatic updater is enabled (generally). This is likely to be decoupled in a future release.

This refocuses the auto_core_update_send_email filter to specifically be for success/fail emails for auto updates, while the new filter is more general.

see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25882 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 19:46:33 +00:00
Ryan Boren
30f822b8ee Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@25880 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 14:37:54 +00:00
Andrew Nacin
ff69fb4b8f Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version.
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.

This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.

fixes #25654.


git-svn-id: https://develop.svn.wordpress.org/trunk@25873 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 21:18:09 +00:00
Andrew Nacin
aab4ffb29d Show the nag we show for a stuck .maintenance file when an auto update failed.
see #25654.


git-svn-id: https://develop.svn.wordpress.org/trunk@25872 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 21:14:06 +00:00
Andrew Nacin
ddbc271329 "some files" instead of "certain files". Less stuffy.
props markjaquith.
see #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25871 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 18:40:20 +00:00
Andrew Nacin
f36fbb550c New, better error message when we realize we won't be able to copy a file and continue with the update.
fixes #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25870 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 18:20:51 +00:00
Andrew Nacin
1a7bfffd0b Only enforce disk free space checks when doing background updates.
see #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25869 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 18:17:13 +00:00
Andrew Nacin
c87ad6023d Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.


git-svn-id: https://develop.svn.wordpress.org/trunk@25868 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 17:21:32 +00:00
Andrew Nacin
ea7d0de723 Updates: Disable maintenance mode once we've finished copying files, to minimize disruption.
props dd32.
fixes #25655.


git-svn-id: https://develop.svn.wordpress.org/trunk@25866 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 17:19:48 +00:00
Andrew Nacin
d0d07cf614 Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative.
props dd32 for initial patch.
fixes #25657.


git-svn-id: https://develop.svn.wordpress.org/trunk@25863 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 09:48:36 +00:00
Andrew Nacin
bce2656e6d Move upgrader_process_complete for core to its proper place in Core_Upgrader.
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.


git-svn-id: https://develop.svn.wordpress.org/trunk@25861 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 04:36:54 +00:00
Andrew Nacin
597e82e94c Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.)
fixes #25653. Also:
 * Fully document all new hooks, methods, and classes in the upgrader.
 * Rename 'language' to 'translation' inside the upgrader.
 * Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.


git-svn-id: https://develop.svn.wordpress.org/trunk@25859 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-21 22:28:07 +00:00
Andrew Nacin
d96b64c116 Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED.
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25851 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 21:23:43 +00:00
Andrew Nacin
fda5b39db2 Use correct variable. fixes #10787.
git-svn-id: https://develop.svn.wordpress.org/trunk@25843 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 17:15:36 +00:00
Andrew Nacin
0b22aae62d Notify administrators of successful, failed, and pending core updates.
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.

fixes #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25841 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 16:29:16 +00:00
Andrew Nacin
142d8c3d30 Delete expired transients on database upgrades.
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.


git-svn-id: https://develop.svn.wordpress.org/trunk@25838 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 07:47:44 +00:00
Andrew Nacin
92c2bc7797 Introduce email templates for automatic background updates.
The four templates are:
 1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
 2. We are not configured to update their site, so we notify them of the new release. ('notify')
 3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2, plus one sentence. ('fail')
 4. We tried to update their site, and failed while copying files. ('critical')

With assistance from markjaquith.

see #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25837 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 06:32:27 +00:00
Andrew Nacin
aa4635548d set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin.
fixes #25622.


git-svn-id: https://develop.svn.wordpress.org/trunk@25836 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 23:23:42 +00:00
Andrew Nacin
8cb344e237 In automatic background updates, standardize on 'update'.
New, final filter names:
 * auto_update_{$type} (plugin, theme, core, language)
 * automatic_updates_is_vcs_checkout
 * automatic_updates_disabled

New class name is WP_Automatic_Updater. Method names include update() and should_update().

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25835 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 23:20:56 +00:00
Dion Hulse
3ce626a96b Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check).
See #25576, #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25831 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 18:39:04 +00:00
Dion Hulse
d2d9b963a2 For Background updates, ensure that only one update process runs at the same time by using the options table as a lock.
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25828 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 05:23:35 +00:00