Commit Graph
36 Commits
Author SHA1 Message Date
Scott Taylor af97ffd81c Plugins: add dismissible notices to update failures.
Adds unit test.

Props afercia, mehulkaklotar.
Fixes #33465.


git-svn-id: https://develop.svn.wordpress.org/trunk@35681 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 20:09:21 +00:00
Andrea Fercia 83fd029f6d Accessibility: update a jQuery selector used for the Plugin Cards after [35009].
When updating a plugin from its details modal dialog, focus should be moved back to the plugin title which now is a H3 heading.

Fixes #33818.

git-svn-id: https://develop.svn.wordpress.org/trunk@35155 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 15:26:31 +00:00
Scott Taylor 9b37cc043c Correct typo in JSDoc for wp.updates.decrementCount
Props mt8.biz.
Fixes #33363.


git-svn-id: https://develop.svn.wordpress.org/trunk@33638 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-18 21:46:19 +00:00
Dion Hulse 672f394b57 Updates: When an update fails (and it's not during the credential form) allow further updates to continue, with the assumption that the error only affects a single plugin.
Props magicroundabout. Fixes #32110 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@32780 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 04:27:37 +00:00
Dion Hulse a5ed63c86f Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.
Fixes #32435, #32473


git-svn-id: https://develop.svn.wordpress.org/trunk@32779 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 03:47:54 +00:00
Dion Hulse 7805a509f3 Updates: Better handling when the credential form is long (such as when SSH is active). This adds scrolling to the dialogue, and hides the SSH-specific fields when not using the SSH handler.
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32777 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 03:19:30 +00:00
Dion Hulse d72005f6d0 Updates: When a connection failure occurs, and no credential form is present client side, allow it to fall through to the normal failure handlers.
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32776 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 02:47:19 +00:00
Dominik Schilling (ocean90) 5e371ea458 Don't try to focus disabled input fields in the request filesystem credentials form.
fixes #32064.

git-svn-id: https://develop.svn.wordpress.org/trunk@32267 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:56:36 +00:00
Aaron Jorbin 686b4af44d Move wp-plugin-update-success event to after lock is released
Fixes #31978
See #31819
Props DavidAnderson



git-svn-id: https://develop.svn.wordpress.org/trunk@32133 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 14:36:04 +00:00
Aaron Jorbin 73479254bc Use named function instead of anonymous function
The named function is testable and replaceable.

Fixes #31964
Props DavidAnderson, adamsilverstein, jorbin




git-svn-id: https://develop.svn.wordpress.org/trunk@32126 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-14 16:41:24 +00:00
Aaron Jorbin 583a13344c Disable shiny updates from modal based on parent window
The QS method added in [32067] and modified in [32080] doesn't work when the user changes the tab inside the modal.  Instead, let's use the parent window's location.

Fixes #31739




git-svn-id: https://develop.svn.wordpress.org/trunk@32082 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 17:37:38 +00:00
Aaron Jorbin 7e4fa157a7 Fix logic for details based shiny updates.
This fixes two problems.  TB seems to sometimes strip window.location.search variables after tb ones, so we need to move it forward.  Also fixes logic error.

See #31739



git-svn-id: https://develop.svn.wordpress.org/trunk@32080 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 17:26:05 +00:00
Aaron Jorbin 6078d22a0a Disable modal initiated shiny updates on wp-admin/update-core.php
We don't have links to update a single plugin on wp-admin/update-core.php so we can't initiate a shiny update there.

Fixes #31739



git-svn-id: https://develop.svn.wordpress.org/trunk@32067 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 04:47:59 +00:00
Aaron Jorbin 38f0420e12 Use dashes instead of dots as separator for jQuery events in shiny updates
`.` is used for namespaces, so better to use dashes.

see #31819
props iseulde 



git-svn-id: https://develop.svn.wordpress.org/trunk@32063 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 03:12:01 +00:00
Aaron Jorbin 43623c464c Enable users to initiate a shiny update from plugin detail modal
The plugin detail modal can contain a link to update a plugin.  When it does, we should initiate a shiny update.

This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on.  These are the same users that can't use the customizer. 

Fixes #31739




git-svn-id: https://develop.svn.wordpress.org/trunk@32062 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 03:08:38 +00:00
Aaron Jorbin c7956dcae0 Trigger events upon the completion of a shiny update
Plugins need to be able to do actions when a shiny update completes. While we don't have complete javascript actions and filters, we do have jQuery events that we can fire to assist plugin authors.  

See #31819



git-svn-id: https://develop.svn.wordpress.org/trunk@32061 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 02:31:43 +00:00
Aaron Jorbin f78df13277 Remove Shiny Bulk Updates
Bulk updates don't need to be ajaxified so let's revert.

See #31770, #29820,



git-svn-id: https://develop.svn.wordpress.org/trunk@32053 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-06 01:20:23 +00:00
Aaron Jorbin 91518f0070 Conditionally add AYS to leaving shiny updates
When a shiny update is happening or pending, we should make sure users don't accidentally leave the page. This simple notification should help prevent users from accidentally not updating when they want to update.

See #31769
Props ericlewis and adamsilverstein for initial patch



git-svn-id: https://develop.svn.wordpress.org/trunk@32052 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-06 00:59:16 +00:00
Aaron Jorbin dc502287ef Update aria-label when doing a shiny plugin update
Also updates it again when the shiny plugin update is finished.
Also updates it if the shiny update fails

props mehulkaklotar, afercia
Fixes #31722




git-svn-id: https://develop.svn.wordpress.org/trunk@31982 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 05:30:13 +00:00
Aaron Jorbin 5b676b4f8e Fix colors for activated and updated plugins
If we don't have the updated class on the TR for he update message, then the message is red and red is scary and they just updated, they should be happy and celebrating, not scared. 

See #31608




git-svn-id: https://develop.svn.wordpress.org/trunk@31969 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 21:30:50 +00:00
Aaron Jorbin 9932d7973d Refine UI for FTP modal and shiny updates
Numerous changes to make the FTP modal experience a good one.  These include:
 * Update HTML used by both the form here and the form on the standalone screen
 * Allow users to cancel FTP install
 * Focus locking in the modal
 * Focus on modal form on load
 * ARIA Attributes
 * Style Enhancements
 * Add low screen height (such as phone and some tablets) friendly experience for entering credentials

Props ericlewis, afercia 
Fixes #31608



git-svn-id: https://develop.svn.wordpress.org/trunk@31949 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 02:47:55 +00:00
Aaron Jorbin 9ab336e309 More clean up from removal of Shiny Plugin Installs
See #31773, #29820
Unprops Jorbin, Pento



git-svn-id: https://develop.svn.wordpress.org/trunk@31900 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-26 16:29:09 +00:00
Aaron Jorbin 359ba47700 Remove Shiny Plugin Installs
See #31773, #29820



git-svn-id: https://develop.svn.wordpress.org/trunk@31897 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-26 02:29:52 +00:00
Aaron Jorbin cc0e582a67 Ensure that we target the correct plugin row for update updates
The DOM traversal of the plugins list table was less than ideal. By switching to data attributes, we can better target the DOM elements we want to update.

Props ericlewis
Fixes #31621




git-svn-id: https://develop.svn.wordpress.org/trunk@31831 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 05:26:00 +00:00
Aaron Jorbin 08ac58e160 Request FTP and SSH credentials when needed during shiny updates
This is a restoration of [31749] which was reverted in [31755].

It includes a number of enhancements from the original version.  Namely:
 * Not doing a credential check in src/wp-includes/script-loader.php
 * Add new function `wp_print_request_filesystem_credentials_modal`
 * update the version number in the list table when a plugin is updated

UI still needs further work, but this basic version should enable more testing

Props ericlewis, jorbin
See #31528



git-svn-id: https://develop.svn.wordpress.org/trunk@31811 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 03:17:59 +00:00
Dominik Schilling (ocean90) 94768cad74 Revert [31749], see #31528.
git-svn-id: https://develop.svn.wordpress.org/trunk@31755 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-12 17:50:54 +00:00
Sergey Biryukov a2abc13285 Shiny Updates: Disable body scrolling when filesystem request modal is open.
props ericlewis.
fixes #31607.

git-svn-id: https://develop.svn.wordpress.org/trunk@31753 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-12 14:56:34 +00:00
Aaron Jorbin b857ff6083 Request FTP and SSH credentials when needed during shiny updates
This is a first pass at requesting FTP and SSH credentials when needed during shiny updates. Styling and some UX improvements are still needed, but we do show the prompt and use the passed data when doing plugin installs and updates for shiny updates.  There are also a couple of areas that we could improve code wise such how we create the requestFilesystemCredentials part of the localized _wpUpdatesSettings. Over the past half century, we've split the atom, we've spliced the gene and we've roamed Tranquility Base. We've reached for the stars and never have we been closer to having them in our grasp. That has nothing to do with shiny updates. 

Props ericlewis, jorbin, and drewapicture for testing
Fixes #31528



git-svn-id: https://develop.svn.wordpress.org/trunk@31749 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-12 08:52:42 +00:00
Andrew Ozz 0778a17875 Add wp.a11y.speak() for audible alerts/updates in screen readers. Props afercia, GrahamArmfield (for the idea), iseulde. Fixes #31368.
git-svn-id: https://develop.svn.wordpress.org/trunk@31594 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-01 19:10:58 +00:00
Gary Pendergast e2c7cd4677 Shiny Updates: Replace $.post() calls with wp.ajax.post(), and clean up a bunch of the now unnecessary code.
See #29820



git-svn-id: https://develop.svn.wordpress.org/trunk@31409 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-11 05:05:13 +00:00
Boone Gorges cc6ef67db7 jshint fixes for shiny updates JS.
As introduced in [31333].

Props iseulde.
See #29820.

git-svn-id: https://develop.svn.wordpress.org/trunk@31341 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-05 19:51:42 +00:00
Gary Pendergast 748d595b5c Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page.
This also includes JS architecture that can be expanded to support theme, core and language pack updates.

Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture

See #29820



git-svn-id: https://develop.svn.wordpress.org/trunk@31333 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-05 04:18:57 +00:00
Sergey Biryukov 0caa0b1dbf In wp.updates.decrementCount(), only display the count if it's a valid non-negative integer.
props jdgrimes.
fixes #29527.

git-svn-id: https://develop.svn.wordpress.org/trunk@29960 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 19:54:40 +00:00
Sergey Biryukov de80cc6780 Avoid displaying a negative number of plugin updates in admin menu.
fixes #28073.

git-svn-id: https://develop.svn.wordpress.org/trunk@28254 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 09:38:36 +00:00
Andrew Nacin 0fe3ffaf59 Remove title attributes on the fly when [27280] makes them incorrect. see #17703.
git-svn-id: https://develop.svn.wordpress.org/trunk@27281 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-26 07:36:05 +00:00
Andrew Nacin 9ddf03c0bb Decrement update count bubbles as plugins/themes are updated, live.
props gcorne, mitchoyoshitaka.
fixes #17703.


git-svn-id: https://develop.svn.wordpress.org/trunk@27280 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-26 06:54:26 +00:00