Commit Graph

39496 Commits

Author SHA1 Message Date
Scott Taylor
43c8ec5f32 Handle more cases (untrailingslashit, HTTPS urls) for sanitizing an author URL for display in the comments list table.
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.


git-svn-id: https://develop.svn.wordpress.org/trunk@33894 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 23:22:32 +00:00
Drew Jaynes
46af2b9cd9 Docs: Add complete file, class, property, and method documentation for the new WP_Comment class, introduced in [33891].
It's important for new functionality, especially something as significant as a new class to have complete documentation upon initial commit – not after the fact.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33893 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 19:57:15 +00:00
Sergey Biryukov
2487080654 Add missing translation functions to the error messages added in [33889].
props kraftbj, GaryJ.
fixes #33684.

git-svn-id: https://develop.svn.wordpress.org/trunk@33892 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 18:36:22 +00:00
Scott Taylor
60ba8b05e4 Introduce WP_Comment class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity.
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33891 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 18:16:35 +00:00
Helen Hou-Sandi
52f31a77e9 UI: Restrict textarea resizing to vertical to prevent ugliness.
props tyxla, MatheusFD.
fixes #33400.


git-svn-id: https://develop.svn.wordpress.org/trunk@33890 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 18:04:27 +00:00
Sergey Biryukov
71d4444ac7 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-includes/class-wp-customize-manager.php.
props kraftbj.
fixes #33684. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33889 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 09:20:40 +00:00
Sergey Biryukov
55bb26c58a Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/network/site-users.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33683. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33888 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 09:02:13 +00:00
Sergey Biryukov
7c32770901 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/includes/bookmark.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33682. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33887 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 08:58:34 +00:00
Sergey Biryukov
190561b89d Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/widgets.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33680. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33886 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 08:55:53 +00:00
Sergey Biryukov
708cd13d77 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/users.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33679. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33885 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 08:53:23 +00:00
Sergey Biryukov
e7beccf78c Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/user-new.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33678. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33884 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 08:44:37 +00:00
Drew Jaynes
03a85947ef Docs: Add inline DocBlocks for the require_once() calls that now bring in top-level HTTP API functionality and HTTP API classes.
Classes brought in from separate files now include:
* `WP_Http`
* `WP_Http_Streams`
* `WP_Http_Curl`
* `WP_HTTP_Proxy`
* `WP_Http_Cookie`
* `WP_Http_Encoding`

See #33413. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33882 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:46:27 +00:00
Drew Jaynes
febec2128e Docs: Clarify the file header summary for wp-includes/http.php, the top-level file for the HTTP Request API.
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33881 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:40:45 +00:00
Drew Jaynes
77a4ee7659 Docs: Add a missing file header for wp-includes/class-http.php.
Also clarifies the class DocBlock summary for `WP_Http` to more clearly describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33880 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:38:45 +00:00
Drew Jaynes
76f63a3b47 Docs: Clarify the file header summary for wp-includes/http-functions.php, introduced in [33748].
Also removes now-moot extra information from the file header description.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33879 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:36:24 +00:00
Drew Jaynes
608957f426 Docs: Add a missing file header to wp-includes/class-wp-http-streams.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_Http_Streams` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33878 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:32:54 +00:00
Drew Jaynes
572a9fa86b Docs: Add a missing file header to wp-includes/class-wp-http-proxy.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_HTTP_Proxy` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33876 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:29:39 +00:00
Drew Jaynes
81e8cc3d7e Docs: Add a missing file header for wp-includes/class-wp-http-encoding.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_Http_Encoding`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33875 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:27:04 +00:00
Drew Jaynes
069668dde9 Docs: Add a missing file header for wp-includes/class-wp-http-curl.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_Http_Curl` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33874 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:22:15 +00:00
Drew Jaynes
b0ea6406a8 Docs: Add a missing file header to wp-includes/class-wp-http-cookie.php, introduced in [33748].
Also clarifies the summary in the class DocBlock for `WP_Http_Cookie`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33873 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:18:20 +00:00
Drew Jaynes
fba0e92dc6 Docs: Clarify the file header summary for wp-includes/widgets.php, the top-level file for the core Widgets API.
Also fixes some minor grammar issues in the file description.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33872 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:13:20 +00:00
Drew Jaynes
50d0b587f6 Docs: Clarify the file header summary for widget-functions.php, introduced in [33746].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33871 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 02:57:10 +00:00
Drew Jaynes
f70c0d7080 Docs: Clarify the file header summary for class-wp-widget-factory.php, introduced in [33746].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33870 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 02:53:19 +00:00
Drew Jaynes
4c5276edcf Docs: Improve the file header for class-wp-widget.php to describe what the file contains.
Also rewrites the class DocBlock summary for `WP_Widget` to better describe the '''purpose''' of the class.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33869 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 02:49:39 +00:00
Drew Jaynes
b75e5cdfd8 Docs: Add a missing summary to the DocBlock for Walker::get_number_of_root_elements().
Props wen-solutions
See #33662.


git-svn-id: https://develop.svn.wordpress.org/trunk@33868 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 19:50:32 +00:00
Scott Taylor
4b9ccd27b1 After [33723], ensure that $i is properly set before looping.
See #16865.


git-svn-id: https://develop.svn.wordpress.org/trunk@33867 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:47:51 +00:00
Sergey Biryukov
5cf9c22518 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/themes.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33677. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33866 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:44:07 +00:00
Sergey Biryukov
45237109dc Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/press-this.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33676. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33865 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:37:28 +00:00
Sergey Biryukov
89fca37568 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/post-new.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33675. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33864 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:35:05 +00:00
Sergey Biryukov
2dcbf39e2d Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/options.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33674. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33863 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:30:58 +00:00
Sergey Biryukov
31caf44a24 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/nav-menus.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33673. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33862 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:20:53 +00:00
Sergey Biryukov
50224510ec Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33671. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33861 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:14:14 +00:00
Sergey Biryukov
0299c00fbb Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit-comments.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33669. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33860 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:03:10 +00:00
Sergey Biryukov
a505ad3382 Set svn:eol-style for the files added in [32806].
see #32576.

git-svn-id: https://develop.svn.wordpress.org/trunk@33859 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 17:54:13 +00:00
John Blackbourn
65c7f9113d Correctly encode spaces in URLs passed to esc_url() instead of removing them.
Fixes #23605
Props enshrined, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33858 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 17:19:29 +00:00
Sergey Biryukov
1ec4b77ac2 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/customize.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33668. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33857 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 17:05:01 +00:00
Andrea Fercia
2ffd8b52cf Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604].
Fixes #33633.

git-svn-id: https://develop.svn.wordpress.org/trunk@33856 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:55:46 +00:00
John Blackbourn
f34a386916 More unit tests for esc_url() and esc_url_raw().
See #23605, #20771, #16859


git-svn-id: https://develop.svn.wordpress.org/trunk@33855 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:50:02 +00:00
Sergey Biryukov
22919f8150 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/custom-header.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33854 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:28:18 +00:00
Sergey Biryukov
1efad51200 Provide more helful feedback than just "Cheatin' uh?" for permission errors in wp-admin/media-upload.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33853 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:20:46 +00:00
Sergey Biryukov
029964a5ed Provide more helful feedback than just “Cheatin’ uh?” for permission errors in wp-admin/edit-tags.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33670. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33852 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:05:07 +00:00
John Blackbourn
4720c6e482 Add some more passing unit tests for esc_url() in preparation for upcoming changes.
See #23605, #20771, #16859


git-svn-id: https://develop.svn.wordpress.org/trunk@33851 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 14:19:21 +00:00
Boone Gorges
7232be7dcd Remove # from @ticket annotation in a unit test.
This improper character was erroneously introduced in [33724].

Props netweb.
Fixes #33532.

git-svn-id: https://develop.svn.wordpress.org/trunk@33850 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 13:39:05 +00:00
John Blackbourn
46c336e78a Introduce wp_removable_query_args(), which returns an array of single-use query variables which can be removed from a URL.
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90


git-svn-id: https://develop.svn.wordpress.org/trunk@33849 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 11:28:11 +00:00
Jeremy Felt
4d2dbebb35 Multisite: Remove duplicate span element output from row actions
Fixes #32961.


git-svn-id: https://develop.svn.wordpress.org/trunk@33848 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 21:50:33 +00:00
DrewAPicture
62230a38e1 Docs: Add missing parameter documentation to the the DocBlock for WP_User::__set().
Props racase for the initial patch.
Fixes #33652.


git-svn-id: https://develop.svn.wordpress.org/trunk@33847 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 21:46:02 +00:00
Scott Taylor
42dcb586ee After [33807], fix unit tests for PHP 5.2
Fixes #17626.


git-svn-id: https://develop.svn.wordpress.org/trunk@33846 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 17:03:13 +00:00
Scott Taylor
a3e0e719d6 De-Jorbin [33814].
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33845 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 15:47:16 +00:00
Sergey Biryukov
622032fece Make curly quotes in playlist item title translatable.
fixes #33391.

git-svn-id: https://develop.svn.wordpress.org/trunk@33844 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 13:49:57 +00:00
Scott Taylor
1e084b6eaa Move widget classes to their own files in wp-includes/widgets:
* `default-widgets.php` now requires all of the individual classes
* Move the functions scattered about this file to `widget-functions.php`, which loads before `default-widgets.php`, which only conditionally loads anyway in `wp_maybe_load_widgets()`, which is hooked on `plugins_loaded` 

See #33413, #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33843 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 13:49:00 +00:00