Sergey Biryukov
dc874c5cd2
General: Ensure bookmark query limits are numeric.
...
Props paulkevan, xknown.
git-svn-id: https://develop.svn.wordpress.org/trunk@53959 602fd350-edb4-49c9-b593-d223f7449a82
2022-08-30 15:14:04 +00:00
Jb Audras
b9c137ceab
Docs: Use third-person singular verbs for function descriptions in Bookmark related files, as per docblock standards.
...
This changeset updates `bookmark.php` and `bookmark-template.php` files.
See #55646 .
git-svn-id: https://develop.svn.wordpress.org/trunk@53566 602fd350-edb4-49c9-b593-d223f7449a82
2022-06-23 22:55:41 +00:00
Sergey Biryukov
3da0ccdc95
General: Ensure consistent type for integer properties of a bookmark object.
...
Previously, these properties could be unexpectedly converted to strings in some contexts.
This applies to the following function:
* `sanitize_bookmark_field()`
and the following properties:
* `$bookmark::link_id`
* `$bookmark::link_rating`
Follow-up to [50935].
See #53235 .
git-svn-id: https://develop.svn.wordpress.org/trunk@50936 602fd350-edb4-49c9-b593-d223f7449a82
2021-05-20 00:03:04 +00:00
Sergey Biryukov
05566e992d
Coding Standards: Use strict comparison for return type checks in a few functions:
...
* `get_bookmark()`
* `get_comment()`
* `get_post()`
* `get_children()`
* `wp_get_recent_posts()`
* `wp_get_post_revision()`
* `wp_get_nav_menu_items()`
Follow-up to [45710] for `get_term()`, [48507] for `wpdb::get_row()` and `wpdb::get_results()`.
See #52627 .
git-svn-id: https://develop.svn.wordpress.org/trunk@50558 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-21 12:39:25 +00:00
Sergey Biryukov
b932c543a2
Docs: Miscellaneous DocBlock corrections.
...
See #49572 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48591 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 21:53:43 +00:00
John Blackbourn
285fa03b3a
Docs: First pass at some inline docs fixes mostly made by PHPCBF.
...
See #49572 , #50744
git-svn-id: https://develop.svn.wordpress.org/trunk@48586 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 19:59:16 +00:00
Sergey Biryukov
6361798918
Docs: Improve documentation for optional parameters per the documentation standards.
...
See #49572 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48197 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-28 11:47:45 +00:00
Sergey Biryukov
5e2ef3d937
Docs: Capitalize "ID", when referring to a post ID, term ID, etc. in a more consistent way.
...
See #49572 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48104 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-20 12:00:07 +00:00
Sergey Biryukov
6742d0d7a6
Coding Standards: Use strict comparison where static strings are involved.
...
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.
Includes minor code layout fixes for better readability.
See #49542 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47808 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-16 18:40:52 +00:00
Sergey Biryukov
0b4e2c4604
Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.
...
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.
Includes minor code layout fixes for better readability.
See #49542 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47550 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-05 03:00:44 +00:00
Sergey Biryukov
130751cda3
Coding Standards: Use Yoda conditions where appropriate.
...
See #49222 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47219 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 16:52:28 +00:00
Sergey Biryukov
cfc3b57488
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47122 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:43:23 +00:00
Sergey Biryukov
79391187c9
Docs: Correct DocBlock formatting for filters accepting the $parsed_args parameter.
...
Follow-up to [45667].
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47096 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-21 15:39:17 +00:00
John Blackbourn
3cdee7a705
Docs: Further improve documentation of known return types, plus other docs fixes.
...
See #48303
git-svn-id: https://develop.svn.wordpress.org/trunk@46661 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 21:25:53 +00:00
Sergey Biryukov
9218e2cc50
Docs: Improve documentation for get_bookmarks().
...
Props pbiron.
Fixes #48053 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46152 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-16 19:54:15 +00:00
Sergey Biryukov
e5a0610d53
Coding Standards: Rename $r variable used with wp_parse_args() to $parsed_args for clarity.
...
Props freewebmentor.
Fixes #45059 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45667 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 00:47:53 +00:00
Gary Pendergast
4503f93961
Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes.
...
See #47632 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45590 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-02 23:41:16 +00:00
Felix Arntz
08564b5a80
General: Fix problematic string to array parsing.
...
WordPress has historically often used code like `preg_split( '/[\s,]+/', $var )` to parse a string of comma-separated values into an array. However, this approach was causing an empty string to not be parsed into an empty array as expected, but rather into an array with the empty string as its sole element.
This was among other areas causing problems in the REST API where passing an empty request parameter could cause that request to fail because, instead of it being ignored, that parameter would be compared against the valid values for it, which typically do not include an empty string.
Props david.binda, sstoqnov.
Fixes #43977 .
git-svn-id: https://develop.svn.wordpress.org/trunk@44546 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-10 21:05:50 +00:00
Gary Pendergast
8f95800d52
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-30 23:09:33 +00:00
John Blackbourn
ca92da24da
General: Use interpolation instead of concatenation for all dynamic hook names.
...
This fixes the rendering of the hook names on developer.wordpress.org.
Props keesiemeijer
Fixes #39148
git-svn-id: https://develop.svn.wordpress.org/trunk@39600 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-14 04:17:38 +00:00
John Blackbourn
9ac95f7650
Docs: Improve the documentation for parameters which accept OBJECT, ARRAY_A, and ARRAY_N as parameters.
...
See #37770
git-svn-id: https://develop.svn.wordpress.org/trunk@39188 602fd350-edb4-49c9-b593-d223f7449a82
2016-11-09 22:59:02 +00:00
Drew Jaynes
6695126f24
Docs: Improve formatting in the DocBlock for sanitize_bookmark_field().
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@37586 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-27 17:15:58 +00:00
Boone Gorges
1d3511ba8c
In get_bookmarks(), don't cache if 'orderby=rand'.
...
Props lukecavanagh, prettyboymp, c3mdigital, MikeHansenMe.
Fixes #18356 .
git-svn-id: https://develop.svn.wordpress.org/trunk@37565 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-25 18:29:01 +00:00
Drew Jaynes
bd1d3f0a8c
Docs: Apply inline @see tags to hooks referenced in DocBlocks in a variety of wp-includes/* files.
...
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.
See #36921 .
git-svn-id: https://develop.svn.wordpress.org/trunk@37542 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-23 18:58:48 +00:00
Drew Jaynes
d11f7ed391
Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.
...
See #36913 .
git-svn-id: https://develop.svn.wordpress.org/trunk@37518 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 18:49:05 +00:00
Drew Jaynes
cb6348b7ce
Docs: Add a missing notation for the $bookmark_id parameter in the DocBlock for clean_bookmark_cache().
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@36009 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:00:07 +00:00
Sergey Biryukov
3e634c753e
After [35718], update the location of some files in This filter is documented in docs.
...
Partially reverts [33954].
Fixes #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35725 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-22 03:50:32 +00:00
Scott Taylor
a4a469d887
After [33843], update the location of some files in This filter is documented in docs
...
Props dimadin.
See #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33954 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 22:16:57 +00:00
Scott Taylor
4eb97de4cf
In bookmark.php, clarify some return docs.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32527 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 20:12:41 +00:00
Scott Taylor
6fd11624d1
The keyword elseif should be used instead of else if so that all control keywords look like single words.
...
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs.
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Scott Taylor
4d46475b3d
Improve various @param docs for src/wp-includes/*.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30681 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 01:33:34 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd
Correct references of @uses $wpdb in core documentation to use @global.
...
See #30191 , [30105].
Fixes #30217 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 17:55:39 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0
Remove redundant and erroneous @uses tag from most core inline documentation.
...
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.
Fixes #30191 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 01:04:55 +00:00
Scott Taylor
0fe756a461
Allow bookmarks to be ordered by link_description in get_bookmarks().
...
Fixes #29763 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29778 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 03:11:55 +00:00
Drew Jaynes (DrewAPicture)
45464b4369
Convert default arguments documentation for get_bookmarks() into a hash notation.
...
Props coffee2code for the initial patch.
See #28841 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29111 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 23:02:51 +00:00
Scott Taylor
84ad12b439
Replace all uses of like_escape() with $wpdb->esc_like().
...
Props miqrogroove.
See #10041 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 00:43:32 +00:00
Scott Taylor
0dd9d3aeff
Eliminate use of extract() in get_bookmarks().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28403 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:57:24 +00:00
Scott Taylor
5df63351b2
In wp-includes/bookmark.php, remove dead code:
...
* In `get_bookmarks()`, `$cache` is set twice before it is used.
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28316 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:21:50 +00:00
Andrew Nacin
66f20812b9
Remove old links_recently_updated_* DB options that never had a UI.
...
fixes #27649 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27916 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 03:09:59 +00:00
Dion Hulse
deda988368
Add some missing braces to get_bookmarks() which was causing an early return. Introduced in [25934]. See #25468 . Fixes #25874
...
git-svn-id: https://develop.svn.wordpress.org/trunk@26046 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 02:19:22 +00:00
Drew Jaynes
3f8c645247
Inline documentation for hooks in wp-includes/bookmark.php.
...
Props ShinichiN, kpdesign.
Fixes #25468 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25934 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-26 16:52:48 +00:00
Andrew Nacin
b43712e0f7
New develop.svn.wordpress.org repository based on the old core.svn repository.
...
* All WordPress files move to a src/ directory.
* New task runner (Grunt), configured to copy a built WordPress to build/.
* svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
* Remove Akismet external from develop.svn. Still exists in core.svn.
* Drop minified files from src/. The build process will now generate these.
props koop.
see #24976 .
and see http://wp.me/p2AvED-1AI .
git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00