Adam Silverstein
856416049d
Media: ensure JavaScript initialized when media edit screen is loaded directly.
...
Fix a JavaScript error when the media edit screen is loaded directly via a url such as `/wp-admin/post.php?post={post_id}&action=edit&image-editor`. Add a check in `imgLoaded` for `this.hold.sizer` which is set up during initialization and required for the cropping tool. Call `init` if this is undefined.
Props NoseGraze.
Fixes #38138 .
git-svn-id: https://develop.svn.wordpress.org/trunk@40020 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-27 18:29:48 +00:00
Andrew Ozz
1a068f2a61
TinyMCE: improve the previews for embedded WordPress posts:
...
- Add option to force a sandbox iframe in wpview.
- Use it to show the embedded post preview.
- Remove the deprecated `wpembed` plugin.js
Fixes #39513 .
git-svn-id: https://develop.svn.wordpress.org/trunk@40019 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-27 04:24:58 +00:00
Weston Ruter
a2ac38016d
Customize: Trim whitespace from nav menu item titles so that the underlying object's original title appears as input placeholder and in the control's title.
...
Whitespace is trimmed from titles in PHP when saved in any case, so this aligns the client-side behavior with what happens on the server.
Amends [38618].
See #38015 .
Fixes #39600 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39994 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-26 18:07:58 +00:00
Dominik Schilling (ocean90)
4c00303955
Press This: Do not show Categories & Tags UI for users who cannot assign terms to posts anyways.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@39968 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-26 13:57:55 +00:00
John Blackbourn
a96089e8e6
Posts, Post Types: When using Excerpt mode on the Posts list table, ensure the excerpt output matches what was manually entered into the Excerpt field.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@39956 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-26 13:40:17 +00:00
Sergey Biryukov
f6938b23b1
Docs: Add missing file header to wp-admin/includes/noop.php, introduced in [34037].
...
Props carl-alberto.
Fixes #39690 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39950 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-25 23:09:37 +00:00
Felix Arntz
ed4e456601
Multisite: Replace is_super_admin() with a proper capability check when showing a notice about WPLANG.
...
In multisite, the notice is displayed to users that have the `manage_network_options` capability. In non-multisite, the notice is displayed to users with the `manage_options` capability.
Props Dhaval Parekh.
Fixes #39207 . See #37616 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39947 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-24 13:12:28 +00:00
Felix Arntz
88c2b69d9e
Multisite: Remove unnecessary is_super_admin() check when adding an existing user to a site.
...
Prior to this change, a super admin user that is added to a site who they are already a member of would still get reinvited.
Props supercoder.
Fixes #39220 . See #37616 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39946 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-24 12:02:25 +00:00
Felix Arntz
34c9399db8
Multisite: Replace is_super_admin() with manage_network_users when trying to import new users.
...
Props bhargavbhandari90.
Fixes #39212 . See #37616 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39945 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-24 11:39:01 +00:00
Felix Arntz
816686b709
Multisite: Replace is_super_admin() with manage_network_users when trying to change the role of oneself.
...
Props abhishek kaushik.
Fixes #39204 . See #37616 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39943 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-24 11:03:07 +00:00
Sergey Biryukov
c9d95475c6
Text Changes: Add a period to the only wp_die() message that didn't have it: "Invalid plugin page".
...
Props Presskopp.
Fixes #39664 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39941 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-22 02:32:57 +00:00
Sergey Biryukov
a37269ee4a
Posts, Post Types: Preserve author filter in list table after entering a page number in paging input.
...
Props sagarprajapati.
Fixes #39523 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39938 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-21 02:20:38 +00:00
Sergey Biryukov
33cf1046db
Users: Preserve role filter in list table after entering a page number in paging input.
...
Props kailanitish90, sagarprajapati.
Fixes #39435 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39937 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-21 02:20:23 +00:00
Sergey Biryukov
34bc9bde36
Docs: After [38672], update $type parameter description for submit_button() and get_submit_button().
...
Remove the mention of `secondary` and `delete` classes as core values, add `small` and `large`.
Props afercia.
Fixes #23477 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39936 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-20 20:36:07 +00:00
Felix Arntz
51c38bec8b
Multisite: Replace is_super_admin() with manage_network_users when trying to add an existing user via username.
...
Props dhanendran.
Fixes #39202 . See #37616 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39935 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-20 17:48:31 +00:00
Felix Arntz
043cf0fc00
Multisite: Replace is_super_admin() with manage_network_users when checking for users autocomplete capabilities.
...
Props ashokkumar24.
Fixes #39201 . See #37616 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39934 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-20 17:42:21 +00:00
Felix Arntz
d0bdcb93f0
Multisite: Replace is_super_admin() with manage_network_options in wp-admin/options.php.
...
Props sathyapulse.
Fixes #39200 . See #37616 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39933 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-20 17:38:15 +00:00
Felix Arntz
60f3612684
Multisite: Do not check for is_super_admin() when trying to set user settings.
...
The checks were introduced in [22256] to prevent user settings to be set for super admins that were not a member of the current site. However the latter should apply to any kind of user, so the `is_super_admin()` check is redundant. Furthermore, removing these checks is necessary for the ongoing effort to get rid of `is_super_admin()` checks in general.
Props chandrapatel for initial patch.
Fixes #39199 . See #37616 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39932 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-20 17:32:13 +00:00
Felix Arntz
efbe7902ce
Multisite: Display correct scheme for the main site in site-info.php.
...
Props greatislander.
Fixes #39365 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39930 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-20 17:02:37 +00:00
Adam Silverstein
3a449139db
Menus: trigger an event when menu items are added or removed.
...
Fire a `menu-item-added` event after a menu item is added to the DOM. Fire a `menu-removing-item` event before a menu item is removed from the DOM. Enables hooking into and responding to menu changes.
Props welcher, adamsilverstein.
Fixes #31218 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39928 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-20 16:14:23 +00:00
Sergey Biryukov
1925fd16e4
Media: Pass the current attachment object to display_media_states filter, for consistency with display_post_states.
...
Props pbiron, chriseverson.
Fixes #39628 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39926 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-20 05:19:26 +00:00
Sergey Biryukov
7a9d5c9ab9
Media: After [36837], check the correct theme modification name for custom logo in _media_states().
...
Props pbiron, mitraval192.
Fixes #39627 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39925 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-19 02:02:39 +00:00
Gary Pendergast
16bbc492a5
dbDelta: Ignore index subparts when checking for duplicate indices.
...
If index lengths change in table definitions, we don't recreate the index - instead, we throw a database error, as `dbDelta()` tries to create a new index with the same name.
It's better to leave the index as is, MySQL doesn't have an efficient process for resizing indices, and dropping/creating is a slow process which we don't want to trigger automatically.
Fixes #34870 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39921 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-17 04:00:09 +00:00
Sergey Biryukov
15346053d6
List Tables: Pass the $which parameter to restrict_manage_posts filter instance in WP_Media_List_Table, missed in [37422].
...
Props wpsmith.
Fixes #38772 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39917 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-17 02:37:14 +00:00
Andrew Ozz
14e5a08f5c
Formatting: fix wpautop() to stop adding paragraph tags around <figcaption>.
...
Fixes #39307 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@39912 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-16 01:05:33 +00:00
Andrew Ozz
f8cc0fda44
Docs: some improvements/fixes for editor.js.
...
See #38933 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39911 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-16 00:48:49 +00:00
Sergey Biryukov
2904099432
I18N: Reference correct placeholder in a translator comment added in [30333].
...
See #30264 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39908 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 08:06:50 +00:00
Sergey Biryukov
fa174e4a06
Users: Display the name of user being edited on Edit User screen.
...
Props seanchayes.
Fixes #28182 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39907 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 07:13:11 +00:00
Sergey Biryukov
1348f5f3fe
Posts, Post Types: Increase the height of post slug input to prevent certain characters from being cut in Firefox on Windows.
...
Props Ankit K Gupta, Presskopp.
Fixes #28084 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39905 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 04:02:26 +00:00
SergeyBiryukov
fa4968e343
Administration: Improve tab character width in Plugins and Themes editor.
...
Props afercia.
Fixes #38684 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39897 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-13 04:40:02 +00:00
Sergey Biryukov
ce89e8dd48
Taxonomy: Add an explanation for "Parent" dropdown for hierarchical custom taxonomies.
...
Props F J Kaiser, raggedrobins, DrewAPicture, diddledan, SergeyBiryukov.
Fixes #23447 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39895 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-13 04:18:16 +00:00
Sergey Biryukov
e9be135754
Docs: Use a consistent description for $plugin parameter in various plugin API functions.
...
See #36333 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39890 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 06:15:23 +00:00
Sergey Biryukov
1c66c0ac3c
Docs: Improve the DocBlock for validate_plugin().
...
Props theMikeD.
Fixes #36333 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39889 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 06:14:31 +00:00
Sergey Biryukov
89f6427e01
I18N: Move "Site Language" setting above "Timezone".
...
This brings all locale-specific site settings closer together and prevents the language setting from being pushed down by unrelated settings added by plugins.
Props johnjamesjacoby.
Fixes #38562 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39885 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 04:27:17 +00:00
Dominik Schilling (ocean90)
ed25ba4f63
Updates: Translate plugin data on the Updates screen.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@39808 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 10:36:59 +00:00
Aaron D. Campbell
506a4c55f8
Add nonce for widget accessibility mode.
...
Props vortfu.
See #23328 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39760 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 01:31:57 +00:00
Sergey Biryukov
cb50dc9e06
Docs: Change @param type for $user_object in WP_Users_List_Table::single_row() from object to WP_User to be more accurate.
...
Props sebastian.pisula.
Fixes #39536 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39757 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-10 12:44:29 +00:00
Sergey Biryukov
26514215a7
Posts, Post Types: Use an existing string for "Invalid post type" error message.
...
Props ramiy.
Fixes #39171 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39756 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-10 02:40:00 +00:00
Sergey Biryukov
efefa1d05e
Docs: Remove incorrect @param tags for admin_print_footer_scripts-{$hook_suffix} and admin_footer-{$hook_suffix} dynamic actiona.
...
Remove `@global` tags as well as they are not suited to describe a function parameter and are documented in the description of the actions.
Props keesiemeijer.
Fixes #39527 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39755 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-09 14:37:55 +00:00
Sergey Biryukov
588290ccee
Docs: Move install_global_terms() DocBlock after the function_exists() call.
...
Props keesiemeijer.
Fixes #39526 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39754 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-09 14:30:47 +00:00
Sergey Biryukov
b2fe8ed9f6
Docs: Use 3-digit, x.x.x style semantic versioning for @since entries in wp-admin/js/image-edit.js.
...
See #38748 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39740 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-06 14:38:11 +00:00
Sergey Biryukov
f216c498c2
Docs: Use 3-digit, x.x.x style semantic versioning for @since entries in wp-admin/js/word-count.js.
...
See #37718 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39739 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-06 14:18:43 +00:00
Sergey Biryukov
795e4a1db5
Docs: Add documentation for wp-admin/js/editor.js.
...
Props terwdan, ireneyoast.
Fixes #38933 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39738 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-06 14:13:44 +00:00
Sergey Biryukov
1601b92164
Docs: Add missing @param tag for show_post_locked_dialog filter.
...
Props keesiemeijer.
Fixes #39479 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39710 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-05 12:36:28 +00:00
Sergey Biryukov
fac3bbb51d
Docs: Move install_network() DocBlock after the function_exists() call.
...
Props keesiemeijer.
Fixes #39478 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39709 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-05 12:33:34 +00:00
Sergey Biryukov
494340c71f
Docs: Add variable to @param entry for whitelist_options filter.
...
Props keesiemeijer.
Fixes #39477 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39708 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-05 11:57:17 +00:00
Dion Hulse
7cfb768da3
Updates: Properly define $filesystemForm to handle error in modals.
...
Ammends [39657].
See #39057 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39689 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-05 07:23:10 +00:00
dd32
134d073f3a
Upgrade: Fix the installation of TwentySeventeen upon upgrade from an early version.
...
This reverts part of [31124] which incorrectly caused `$old_wp_version` to equal the version of WordPress being upgraded to due to global variable access changes.
See #38551 , #30799 .
Fixes #39138 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@39687 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-05 06:12:03 +00:00
westonruter
dcddb45ba0
Customize: Update customize.php URL with changeset_uuid param the instant a change is made instead of deferring until the changeset update request responds.
...
Props asalce.
Fixes #39227 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39686 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-05 05:17:39 +00:00
westonruter
4e549946ba
Customize: Prevent removal of underline upon hover/focus for nav menu deletion links.
...
Props monikarao.
Amends [38503].
See #37527 .
Fixes #39444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@39677 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-04 19:12:39 +00:00