Commit Graph

5506 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
e646bb2dd2 Upgrader: Copy WP_Upgrader subclasses into one file per class.
Part 4/8.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37409 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 11:44:06 +00:00
Dominik Schilling (ocean90)
8fe4831358 Upgrader: Update wp-admin/includes/class-wp-upgrader-skins.php to require_once the new files added in [37406].
Part 3/8.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37408 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 11:41:23 +00:00
Dominik Schilling (ocean90)
d9804f51c0 Upgrader: Update file headers and class DocBlocks for new files added in [37406].
Part 2/8.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37407 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 11:30:18 +00:00
Dominik Schilling (ocean90)
32c731b696 Upgrader: Copy WP_Upgrader_Skin and its subclasses into one file per class.
Part 1/8.
See #36618.

git-svn-id: https://develop.svn.wordpress.org/trunk@37406 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-10 11:10:22 +00:00
Jeremy Felt
356514e994 Multisite: Use the admin-multisite Dashicon for sites
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Uses the more appropriate `dashicons-admin-multisite` when displaying the sites menu item.

Props Ipstenu, ocean90.
Fixes #36754.


git-svn-id: https://develop.svn.wordpress.org/trunk@37365 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-05 17:12:12 +00:00
Jeremy Felt
705b36d63d Revert [37362], which incorrectly changed Dashicons CSS
`dashicons.css` is an external-ish library and the change there is incorrect.

See #36754.


git-svn-id: https://develop.svn.wordpress.org/trunk@37364 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-05 15:28:24 +00:00
Helen Hou-Sandi
2ed0e470ba Revive grunt-rtlcss, which does not appear to enjoy syntax errors.
props netweb.
see #36753, #29792.


git-svn-id: https://develop.svn.wordpress.org/trunk@37363 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-05 15:21:10 +00:00
Jeremy Felt
fdcacb5ca9 Multisite: Use the admin-multisite Dashicon in the admin menu and bar
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Props Ipstenu.
Fixes #36754.


git-svn-id: https://develop.svn.wordpress.org/trunk@37362 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-05 04:28:36 +00:00
Helen Hou-Sandi
0671f3a8d3 Drop Open Sans in the admin in favor of system fonts.
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.


git-svn-id: https://develop.svn.wordpress.org/trunk@37361 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-04 22:06:27 +00:00
Drew Jaynes
1c25b93a97 Links: Rename the $link_id parameter in get_link_to_edit() to $link to better reflect that it can accept a link ID or object.
Props tloureiro for the initial patch.
Fixes #36736.


git-svn-id: https://develop.svn.wordpress.org/trunk@37353 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-02 23:42:27 +00:00
Drew Jaynes
a76767e2ed Links: Clarify documentation for the $link_id parameter to mention that it accepts either an integer or object.
Props tloureiro.
See #36736.


git-svn-id: https://develop.svn.wordpress.org/trunk@37351 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-02 23:39:12 +00:00
Weston Ruter
bef15d72a4 Customize: Allow Esc key to collapse the currently-expanded panel, section (or control).
Pressing Esc collapses any expanded widget or nav menu item controls, or any control that implements the expanding interface. Also improves alignment between `WidgetControl` and `MenuItemControl`, adding the `expanded` state and associated `expand`/`collapse` methods to nav menu items.

Props purcebr, celloexpressions, westonruter.
Fixes #22237.


git-svn-id: https://develop.svn.wordpress.org/trunk@37347 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-02 19:52:01 +00:00
Weston Ruter
a216627419 Customize: Ensure settings modified during an open save request remain dirty when save request completes.
Also disables Save & Publish button while save request is open. After the save request completes, any settings changed during the request can then be saved via an additional click to the button.

Props chandrapatel, westonruter.
Fixes #32941.


git-svn-id: https://develop.svn.wordpress.org/trunk@37346 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-02 19:12:37 +00:00
Drew Jaynes
c7bed4f8c6 Docs: Remove inline @see tags from function, class, and method references in inline docs.
Known functions, classes, and methods are now auto-linked in Code Reference pages following #meta1483.

Note: Hook references are still linked via inline `@see` tags due to the unlikelihood of reliably matching for known hooks based on a RegEx pattern.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@37342 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-02 03:59:56 +00:00
Dominik Schilling (ocean90)
97dc4022c8 Customize: Increase the target size of the expand/collapse button in the customizer.
To improve accessibility on touch devices increase the size of the button in the collapsed view from 24×28 to 44×45 pixel.

Props celloexpressions.
Fixes #36093.

git-svn-id: https://develop.svn.wordpress.org/trunk@37341 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-01 20:28:22 +00:00
Dominik Schilling (ocean90)
5d3bf61e3b Customize: Don't auto-close the customizer when a new theme is activated.
Props celloexpressions.
Fixes #35320.

git-svn-id: https://develop.svn.wordpress.org/trunk@37339 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-01 19:53:13 +00:00
Andrea Fercia
0f983ab261 Themes: restore Theme Installer missing spinner.
Fixes #36730.

git-svn-id: https://develop.svn.wordpress.org/trunk@37336 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-01 15:42:58 +00:00
Sergey Biryukov
8d99819276 Dashboard: Display the comment counts in wp_dashboard_right_now() in the rare initial condition when there are 0 approved comments and only pending comments, so the AJAX count update could work.
Props afercia.
Fixes #35519.

git-svn-id: https://develop.svn.wordpress.org/trunk@37335 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-01 11:05:48 +00:00
Dominik Schilling (ocean90)
c39a438d65 Plugins: In uninstall_plugin() pass the plugin file to wp_register_plugin_realpath().
`wp_register_plugin_realpath()` calls `dirname( $file );` to remove the basename. The basename must be included in the argument or the symlinked directory won't be registered.

Props andy.
Fixes #36709.

git-svn-id: https://develop.svn.wordpress.org/trunk@37331 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-30 15:03:14 +00:00
Andrea Fercia
ee30b90714 Accessibility: improve the Star Ratings hiding empty elements for assistive technologies.
Fixes #36725.

git-svn-id: https://develop.svn.wordpress.org/trunk@37330 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-30 14:32:40 +00:00
Rachel Baker
d73d355250 Widgets: When the Inactive Widgets section is hidden also hide the “Clear Inactive Widgets” button description text.
Props welcher.

Fixes #35592.



git-svn-id: https://develop.svn.wordpress.org/trunk@37323 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-28 20:39:22 +00:00
Michael Arestad
88de2831b9 Component: Administration
Setting the background color on `body` is more flexible than on the `html` element. This patch assigns the background color to `body` instead of the `html` element.

Fixes #35314


git-svn-id: https://develop.svn.wordpress.org/trunk@37321 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-28 03:15:08 +00:00
Rachel Baker
024c8003c9 Users: Remove the “Name” column of the Users table from appearing sortable.
The “Name” column of the Users WP List Table is not sortable because this column displays a concatenation of two optional values, `first_name` and `last_name`. Even if WP_User_Query supported ordering queries in this manner, the resulting sequence would be chaotic.

Fixes #28064.

Props jesin, and rachelbaker.

git-svn-id: https://develop.svn.wordpress.org/trunk@37314 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-26 20:34:05 +00:00
Rachel Baker
7dd7992179 Comments: Add unordered list styling to Comments List Table rows and Moderate Comment screen.
Fixes #36160

Props juanfra.

git-svn-id: https://develop.svn.wordpress.org/trunk@37304 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-22 21:46:06 +00:00
Rachel Baker
9e81e20916 Comments: Keep comments safe in the Edit Post screen.
Warns users that have added a new Comment or began editing an existing without saving their changes, before they press the “update” button which would wipe out their comment changes.

Fixes #32818.

Props polevaultweb.

git-svn-id: https://develop.svn.wordpress.org/trunk@37303 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-22 21:42:38 +00:00
Scott Taylor
e2b9072267 Dashboard: toggle the "View" link for comments when Approving / Unapproving from the Dashboard widget.
Fixes #35518.


git-svn-id: https://develop.svn.wordpress.org/trunk@37302 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-22 21:29:19 +00:00
Sergey Biryukov
0cc8d27fda Text Changes: Consistently refer to https://wordpress.org/plugins/ and https://wordpress.org/themes/ as WordPress Plugin Directory and WordPress Theme Directory, respectively.
Props mpol.
Fixes #35938.

git-svn-id: https://develop.svn.wordpress.org/trunk@37297 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-22 06:56:20 +00:00
Dominik Schilling (ocean90)
153610292d Media: Remove an extra quote when sending a link of a media file to the editor.
Introduced in [37035].

Props joemcgill, swissspidy, boonebgorges.
Fixes #36578.

git-svn-id: https://develop.svn.wordpress.org/trunk@37288 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 21:20:26 +00:00
Dominik Schilling (ocean90)
d434c58404 Themes: Update list of WordPress theme features.
* Remove color tags.
* Layout: Add Grid Layout, remove Fixed Layout, Fluid Layout, and Responsive Layout.
* Features: Add Footer Widgets, remove Blavatar.
* Subject: Add Blog, E-Commerce, Education, Entertainment, Food & Drink, Holiday, News, Photography and Portfolio, remove Photoblogging and Seasonal.

Props grapplerulrich, davewarfel.
Fixes #33407.

git-svn-id: https://develop.svn.wordpress.org/trunk@37287 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 21:10:03 +00:00
Sergey Biryukov
23d737bc53 Administration: Introduce admin_print_footer_scripts-$hook_suffix", a dynamic version of the admin_print_footer_scripts hook.
This is now more consistent with the generic `admin_print_scripts` and the dynamic `admin_print_scripts-$hook_suffix` hooks fired in `wp-admin/admin-header.php`.

Props tfrommen.
Fixes #34334.

git-svn-id: https://develop.svn.wordpress.org/trunk@37279 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 15:16:52 +00:00
Pascal Birchler
c52f851308 Rewrite Rules: After [36953], correctly replace existing rules on IIS when updating them.
Props WiZZarD_.
Fixes #36506 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@37273 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 09:32:42 +00:00
Dominik Schilling (ocean90)
eec3f16b24 Upgrader: Clear plugin/theme caches directly after a plugin/theme has been updated.
`wp_update_plugins()` and `wp_update_themes()` are both hooked into `upgrader_process_complete` with priority 10. But at this stage the caches in `get_plugins()`, `search_theme_directories()`, and `wp_get_themes()` aren't refreshed yet so both functions couldn't fetch any translations for the new plugin/theme.
To reset the caches, `wp_clean_themes_cache()` and `wp_clean_plugins_cache()` are now hooked into `upgrader_process_complete` with priority 9.

This is a follow-up to [34751].

See #34029.
Fixes #36383.

git-svn-id: https://develop.svn.wordpress.org/trunk@37272 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 09:08:11 +00:00
Drew Jaynes
6261a0b439 Docs: Add missing return descriptions for WP_Filesystem_SSH2::chown() and WP_Filesystem_SSH2::run_command().
Fixes #30989.


git-svn-id: https://develop.svn.wordpress.org/trunk@37270 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-21 02:37:36 +00:00
Aaron Jorbin
5ecf38977e Use px instead of in in device preview
Devices are not consistent in how they handle `in` units. `in` was an attempt to cleverly disguise the exact size of the 'tablet'. The PHP code standards mentions avoiding clever code ( https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#clever-code ) but we should extend that idea to the css code as well.

Props celloexpressions
Fixes #36457



git-svn-id: https://develop.svn.wordpress.org/trunk@37247 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-19 20:49:38 +00:00
Boone Gorges
07fa16713d Include taxonomy term metadata in WXR export.
Because term XML nodes now include termmeta and can thus be much larger, this
changeset also includes adds some newlines and indentation to make the XML
easier to read.

Props Chouby.
See #34062.

git-svn-id: https://develop.svn.wordpress.org/trunk@37240 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-18 03:37:04 +00:00
Sergey Biryukov
2f3c1769fa Theme Editor: After [37217], add other embed templates to file descriptions.
Props Frozzare.
Fixes #34561. See #34561.

git-svn-id: https://develop.svn.wordpress.org/trunk@37232 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-18 01:04:15 +00:00
Andrea Fercia
8309ab055f Accessibility: change the close "X" in the Media "Attach to existing content" modal in a button.
Props joedolson.

Fixes #36554.

git-svn-id: https://develop.svn.wordpress.org/trunk@37231 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-17 16:57:54 +00:00
Andrea Fercia
112337ce75 Accessibility: Customizer, improve UI controls in customize.php
- makes the mobile preview/customize toggle a button
- changes the "Close" link hidden text from 'Cancel' to 'Close the Customizer and go back to the previous page'
- adds a missing `type="button"` attribute
- removes unnecessary `keydown` events and `preventDefault()`: buttons don't need a keydown event and when they have a `type="button"` attribute there's no default action to prevent

Props Cheffheid, afercia.

Fixes #31487.

git-svn-id: https://develop.svn.wordpress.org/trunk@37230 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-17 15:40:50 +00:00
Pascal Birchler
3d26146c17 Admin: Fix default avatar handling in Settings -> Discussion.
By passing the `force_default` argument to `get_avatar()` instead of using `preg_replace`, we make it easier for developers to override the output.

Props henry.wright.
Fixes #34744.

git-svn-id: https://develop.svn.wordpress.org/trunk@37227 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-17 10:18:39 +00:00
Andrea Fercia
e4b26366e4 Plugin Install: show the upload form in place rather than sending users to the devoted upload plugin page.
Props Ipstenu, ericlewis, michaelarestad.

Fixes #35429.

git-svn-id: https://develop.svn.wordpress.org/trunk@37221 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-16 16:42:48 +00:00
Sergey Biryukov
021fd49054 Themes: Account for longer strings in Theme Details bar on Themes screen.
Fixes #27939.

git-svn-id: https://develop.svn.wordpress.org/trunk@37219 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-16 13:58:39 +00:00
Sergey Biryukov
a45fb4c863 Plugins: Properly wrap long tab names to a second line in plugin details modal.
Fixes #33221.

git-svn-id: https://develop.svn.wordpress.org/trunk@37218 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-16 13:17:36 +00:00
Sergey Biryukov
25f590a423 Theme Editor: Add embed.php to file descriptions.
Props ramiy.
Fixes #36551.

git-svn-id: https://develop.svn.wordpress.org/trunk@37217 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-16 12:46:26 +00:00
John Blackbourn
f2f356acfe Docs: Clarify possible types passed to the themes_api_result filter.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@37209 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-15 01:42:11 +00:00
Sergey Biryukov
75fe71a13f Bootstrap/Load: Allow for ABSPATH to be defined outside of wp-load.php, e.g. in a script loaded via auto_prepend_file.
Props barry.
Fixes #26592.

git-svn-id: https://develop.svn.wordpress.org/trunk@37207 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-14 17:52:02 +00:00
Konstantin Obenland
6e15892673 Themes: Fix single theme modal on collapsed menu.
Prevents the modal from being displayed off screen, when there is only one
theme available and the menu is collapsed.

Props hardeepasrani for initial patch.
Fixes #36504.



git-svn-id: https://develop.svn.wordpress.org/trunk@37205 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-14 12:19:47 +00:00
Jeremy Felt
137d716ebb Multisite: Remove theme from network allowed themes when deleted
Previously, a deleted theme would remain in the list of allowed themes until manually cleared. This uses `WP_Theme::network_disable_theme()`, added in [37202].

Fixes #34182.


git-svn-id: https://develop.svn.wordpress.org/trunk@37203 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-14 03:49:01 +00:00
Jeremy Felt
a56fc1fba0 Multisite: Introduce WP_Theme methods to network enable/disable themes.
* `WP_Theme::network_enable_theme()` can be used to enable a theme or array of themes on a network.
* `WP_Theme::network_disable_theme()` can be used to disable a theme or array of themes on a network.
* Use these new methods in the network admin vs direct `update_site_option()` calls.
* Add tests.

Props igmoweb.
Fixes #30594.


git-svn-id: https://develop.svn.wordpress.org/trunk@37202 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-14 03:39:45 +00:00
Jeremy Felt
85a6518c57 Multisite: Relocate revoke_super_admin() and grant_super_admin()
Moving these functions to `wp-includes/capabilities.php` allows plugins to access more than just `is_super_admin()` and `get_super_admin()` from the front end without including a file via `wp-admin/`. Add an `is_multisite()` check to prevent use of these on single site environments now that they have left `ms.php`..

Props johnjamesjacoby.
Fixes #21788.


git-svn-id: https://develop.svn.wordpress.org/trunk@37200 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-14 03:34:07 +00:00
Sergey Biryukov
2e6c1d4d6c I18N: Remove <kbd> tags from translatable string in wp-admin/options-writing.php.
Add translator comment.

Props ramiy.
Fixes #36249.

git-svn-id: https://develop.svn.wordpress.org/trunk@37198 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-14 02:24:49 +00:00