vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-09-05 16:40:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
37,966 Commits 1 Branch 0 Tags
31816ccec2358dbdf2a4e03422bd26209d628607
Commit Graph
5506 Commits
Author SHA1 Message Date
Scott Taylor 927ad00bab List Tables: don't render "extra tablenav" if there are no posts. This includes Bulk Actions, Dates Dropdown, Category Dropdowns, Pagination. 
Also ensure that the Months dropdown, when it is shown, shows months from the proper set of posts.

Props egower, CoenJacobs, MikeHansenMe, mehulkaklotar.
Fixes #33824, #21015, #21856.


git-svn-id: https://develop.svn.wordpress.org/trunk@34076 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 08:12:43 +00:00
Scott Taylor 9831fa216c AJAX Reply to Comment: check the edit_comment cap when parent comment will be auto-approved. 
Props rachelbaker.
Fixes #23939.


git-svn-id: https://develop.svn.wordpress.org/trunk@34074 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 07:18:36 +00:00
Scott Taylor 3cbec930bb Edit Comment screen: remove the "View Comment" button (actually a link) from the publish meta box. Mimic the "Edit URL/Permalink" UI from the Edit Post screen to show the comment link below the screen title, but make it an actual link, not a button. 
Props ocean90, DrewAPicture, wonderboymusic.
Fixes #19168.


git-svn-id: https://develop.svn.wordpress.org/trunk@34072 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 03:19:21 +00:00
Scott Taylor 6a262bd6ce Quick Edit: fix an ID attribute name collision by renaming one of the author fields author-name. 
Props afercia.
Fixes #33770.


git-svn-id: https://develop.svn.wordpress.org/trunk@34070 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 02:34:52 +00:00
Scott Taylor 0f2078bc9e When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on commentsBox, ->load(), that resets st (cool name) to the number of visible <tr>s before calling ->get(). This will account for spam'd and trash'd comments when returning comments at the proper offset. 
Props utkarshpatel.
Fixes #33829.


git-svn-id: https://develop.svn.wordpress.org/trunk@34069 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 02:27:50 +00:00
Andrew Ozz f855ddb134 Settings, password field: fix placement of the error icon and removal of the error class. 
Props liljimmi, adamsilverstein.
Fixes #33406 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@34068 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 00:09:09 +00:00
Andrea Fercia 1a333bd537 Bump H3 headings to H2 on the Plugin Editor screen for better accessibility. 
Fixes #33839.

git-svn-id: https://develop.svn.wordpress.org/trunk@34067 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 00:07:23 +00:00
Andrea Fercia 41c74b9bf6 Bump H3 headings to H2 on the Theme Editor screen for better accessibility. 
Props mrahmadawais.
Fixes #33660.

git-svn-id: https://develop.svn.wordpress.org/trunk@34066 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:59:30 +00:00
Andrea Fercia c492832e6a Nav Menus: fix the quick search spinner position on Operating Systems that show scrollbars. 
Fixes #33290.

git-svn-id: https://develop.svn.wordpress.org/trunk@34065 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:51:53 +00:00
Andrea Fercia bc8e3599e6 Quick Edit: fix the Tags auto-suggest tooltip visibility. 
Be sure to hide the `jquery.suggest` Tags textarea tooltip also when using the keyboard to Save/Cancel.

Props rommelxcastro for the initial patch.
Fixes #32580.

git-svn-id: https://develop.svn.wordpress.org/trunk@34064 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:33:43 +00:00
Andrew Ozz e5324c4c91 Settings: properly set the password field label on loading. 
See #33778.

git-svn-id: https://develop.svn.wordpress.org/trunk@34062 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:04:53 +00:00
Andrew Ozz 504d75e4c1 Settings: reassign the label when switching password fields so it always highlights the visible field. 
Props umesh.nevase.
Fixes #33778 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@34061 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 22:51:17 +00:00
Dominik Schilling (ocean90) 28c4ddae7c Passwords: Refresh password fields when content is pasted into fields. 
Use feature detection to determine whether password inputs should use the `keyup` or `input` event.

Props peterwilsoncc, adamsilverstein.
Fixes #33398.

git-svn-id: https://develop.svn.wordpress.org/trunk@34060 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 21:51:31 +00:00
Scott Taylor 33953cb392 Introduce wp_validate_action( $action = '' ), a helper function that checks $_REQUEST for action and returns it, or empty string if not present. If $action is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types. 
Implementing this removes 27 uses of direct superglobal access in the admin.

For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php

See #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34059 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 21:07:45 +00:00
Dominik Schilling (ocean90) 9805723e3d Site Icon: For preview fall back to full size URL when thumbnail size doesn't exist. 
Prevents a JavaScript error for rare cases when cropping is skipped and the image is smaller than `thumbnail`.

Props tyxla.
Fixes #33417.

git-svn-id: https://develop.svn.wordpress.org/trunk@34056 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 20:12:50 +00:00
Dominik Schilling (ocean90) f30a1c86b1 About: Remove period from placeholder. 
The position of periods is different in some languages, like Japanese. This removes the period from the last placeholder for the Template Hierarchy section. It doesn't include a new period to avoid a string change in a minor release.

Props extendwings, chriscct7.
Fixes #33429.

git-svn-id: https://develop.svn.wordpress.org/trunk@34054 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 19:26:02 +00:00
Sergey Biryukov a01c10a3b9 Better align table headers with table cells on success screen after installing. 
Props umesh.nevase.
Fixes #33796.

git-svn-id: https://develop.svn.wordpress.org/trunk@34043 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 11:25:30 +00:00
Scott Taylor 5cce4a3262 After [33961], pass $comment to get_comment_link() where possible to avoid extra cache/db lookups. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34042 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 06:20:56 +00:00
Scott Taylor 4a6a7edf55 After [33961], pass $comment to get_comment_date() where possible to avoid extra cache/db lookups. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34041 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 06:14:04 +00:00
Scott Taylor 9ab431873c After [33961], pass $comment to comment_class() where possible to avoid extra cache/db lookups. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34040 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 06:11:35 +00:00
Scott Taylor db702bc3ea After [33961], pass $comment to get_comment_author_link() where possible to avoid extra cache/db lookups. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34039 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 06:04:22 +00:00
Scott Taylor 4cd30ede79 After [34015], handle orphaned comments in the Dashboard comments widget. Pass full $comment versus just passing the comment ID when possible. 
See #33710.


git-svn-id: https://develop.svn.wordpress.org/trunk@34038 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 05:55:27 +00:00
Scott Taylor 3f557063be Create a new file, wp-admin/includes/noop.php, which loads all of the noop functions for load-script|styles.php and is only loaded by those files. DRYs in the process. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34037 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 05:03:55 +00:00
Scott Taylor da65ac0471 Move ad hoc functions from wp-admin/credits.php to wp-admin/includes/credits.php, which is only included by the former. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34036 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 04:54:20 +00:00
Boone Gorges 5b9d9c7c07 Require numeric IDs in user deletion functions. 
`wp_delete_user()` and `wpmu_delete_user()` both require an `$id` parameter.
Previously, the functions did not verify that the value passed was, in fact,
a number. As such, passing an object or any other entity that would be cast
to int `1` would result in user 1 being deleted. We fix this by enforcing
the requirement that `$id` be numeric.

Props dipesh.kakadiya, utkarshpatel, juliobox.
Fixes #33800.

git-svn-id: https://develop.svn.wordpress.org/trunk@34034 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 02:24:03 +00:00
Gary Pendergast 32b8ff1b14 Schema: Increase the length of wp_options.option_name. 
It's pretty easy to run over the `option_name` length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from `VARCHAR(64)` to `VARCHAR(191)` significantly reduces the risk of this occurring.

Because `option_name` has a `UNIQUE` index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.

Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.

Fixes #13310.



git-svn-id: https://develop.svn.wordpress.org/trunk@34030 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 01:25:21 +00:00
John Blackbourn bdd42a0902 Set the secure flag on the wp-saving-post cookie when using HTTPS. 
This cookie doesn't contain any sensitive information, but this change brings its behaviour in line with all other core cookies.

Fixes #31056


git-svn-id: https://develop.svn.wordpress.org/trunk@34027 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 22:41:08 +00:00
Scott Taylor b1a91e4a28 Move network_settings_add_js() from wp-admin/network/settings.php to wp-admin/includes/ms.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34026 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 22:23:47 +00:00
Scott Taylor 2fe412793e Move confirm_delete_users() from wp-admin/network/users.php to wp-admin/includes/ms.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34025 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 22:22:44 +00:00
Scott Taylor ea07ff2e63 Create wp-admin/includes/network.php via svn cp and only load it in wp-admin/network.php. Move the functions there. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34023 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 22:00:58 +00:00
Scott Taylor ab4fcd20d0 Move ad hoc Options functions to wp-admin/includes/options.php: 
* Move `options_discussion_add_js()` from `wp-admin/options-discussion.php`
* Move `options_general_add_js()` from `wp-admin/options-general.php`
* Move `options_permalink_add_js()` from `wp-admin/options-permalink.php`
* Move `options_reading_add_js()` from `wp-admin/options-reading.php`
* Move `options_reading_blog_charset()` from `wp-admin/options-reading.php`

See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34022 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:44:29 +00:00
Scott Taylor 96a40d6102 Move 2 ad hoc user admin functions: 
* Move `use_ssl_preference()` from `wp-admin/user-edit.php` to `wp-admin/includes/user.php`.
* Move `admin_created_user_email()` from `wp-admin/user-new.php` to `wp-admin/includes/user.php`.

See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34021 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:32:46 +00:00
Scott Taylor d7670b6a38 Move redirect_post() from wp-admin/post.php to wp-admin/includes/post.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34020 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:30:24 +00:00
Scott Taylor 037cdcb412 Move comment_footer_die() from wp-admin/comment.php to wp-admin/includes/comment.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34019 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:28:18 +00:00
Scott Taylor 706cdbc671 Move plugin_sandbox_scrape() from wp-admin/plugins.php to wp-admin/includes/plugin.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34018 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:23:17 +00:00
Scott Taylor 8af9ff0e56 Move wp_widgets_access_body_class() (a hook callback) from wp-admin/widgets.php to wp-admin/includes/widgets.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34017 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:21:27 +00:00
Scott Taylor a55b56c3d2 After [34004], don't break apart the paragraph into multiple translatable strings. 
Fixes #18418.


git-svn-id: https://develop.svn.wordpress.org/trunk@34016 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 20:59:35 +00:00
Scott Taylor 7bf64e0125 Comments/PHP Notices: check that a parent comment exists before displaying an orphan's link to it in the admin. 
Props rachelbaker.
Fixes #33710.


git-svn-id: https://develop.svn.wordpress.org/trunk@34015 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 20:50:12 +00:00
Scott Taylor 7b59221ea1 _wpThemeSettings.l10n.searchPlaceholder is an input placeholder and doesn't handle UTF-8 or HTML entities properly. In lieu of using literal Unicode here, use .... 
See #32875.


git-svn-id: https://develop.svn.wordpress.org/trunk@34014 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 20:35:03 +00:00
Jeremy Felt 9b193ad5a4 Multisite: Display content attribution drop down when deleting a user 
The previous move from `echo()` to `_e()` left some of the output hanging. Introduced in [32333].

Props figureone.
Fixes #33811 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@34012 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 20:25:07 +00:00
Scott Taylor d937112e9f Grunt RTL CSS: swap-dashicons-left-right-arrows in rtlcss:properties expects double-quoted content strings in CSS. It doesn't swap single-quoted values. 
Props Ankit K Gupta, yoavf, netweb.
Fixes #33786.


git-svn-id: https://develop.svn.wordpress.org/trunk@34011 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 20:21:57 +00:00
Scott Taylor be9cd867df In wp_generate_attachment_metadata(), also pass $metadata to the intermediate_image_sizes_advanced filter. 
Props amereservant, wonderboymusic.
Fixes #23401.


git-svn-id: https://develop.svn.wordpress.org/trunk@34007 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 18:03:20 +00:00
Scott Taylor 09df5b81a1 Add a "View" row action for approved comments on the Dashboard screen, remove the link labeled #. 
Props rachelbaker, zeo.
Fixes #18885. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34006 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:48:34 +00:00
Scott Taylor 532baa4c5f In WP_Posts_List_Table::column_date(), the order of status and time should be switched. It doesn't make sense for phrases like "Last Modified" to occur AFTER the date. Should be before. 
Props johnbillion, wonderboymusic.
Fixes #18641. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34005 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:42:55 +00:00
Scott Taylor f5ce2ba96d Cleanup the text for Publish Settings > Publish in the edit-form-advanced help tab. Clarify that Private posts aren't hidden from editors and administrators. 
Props sillybean.
Fixes #18418. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34004 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:35:17 +00:00
Scott Taylor 0a7636cfa3 In wp_media_upload_handler(), replace a lingering instance of media_upload_gallery() with wp_iframe(...) 
Props jeffstieler, antpb.
Fixes #17812. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34003 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:23:23 +00:00
Scott Taylor 7178b67671 media-new.php, when using the browser uploader, if the result of uploading is a WP_Error - wp_die() with the error, instead of redirecting with a generic error. 
Props solarissmoke.
Fixes #16820. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34002 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:17:22 +00:00
Scott Taylor 2deb9565c0 When deleting via User List Table, don't prompt for re-attribution if the user(s) do(es) not have any posts. 
Props rajnikmit, wojtek.szkutnik, benjmay, wonderboymusic.
Fixes #6405. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34000 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 16:46:38 +00:00
Sergey Biryukov 5d8eb77621 Merge two similar strings. 
Props dipesh.kakadiya.
Fixes #33777.

git-svn-id: https://develop.svn.wordpress.org/trunk@33998 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 10:58:58 +00:00
Jeremy Felt ef1f697564 Multisite: Allow users with manage_network_users to edit network users. 
Other users in a network can now be given capabilities to manage users without also having global super admin privileges.

* Users with `manage_network_users` can not edit super admins.
* Users with `manage_network_users` can not promote users to super admin.
* Uses of `is_super_admin()` in `user-new.php` are now updated to `manage_network_users`.

Props daniellandau, chriscct7.
Fixes #16860.


git-svn-id: https://develop.svn.wordpress.org/trunk@33988 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 03:33:22 +00:00