Commit Graph
5506 Commits
Author SHA1 Message Date
Konstantin Obenland 9fe59ced57 Site Icon: Add crop preview to the media modal.
* Monkey patches imgAreaSelect library to support touch events.
* Removes Settings version of Site Icon since it would have been the same flow.
* Removes default value for Customizer setting - there is no default favicon.

Fixes #16434.




git-svn-id: https://develop.svn.wordpress.org/trunk@33329 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 15:56:19 +00:00
Dion Hulse 534386fcaf Allow HTML/entities in the Active Theme Name in the themes.php & Customizer templates.
Props iCaleb
Fixes #33036


git-svn-id: https://develop.svn.wordpress.org/trunk@33327 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 01:45:08 +00:00
Scott Taylor e690aa50ad Ensure that private posts cannot be made sticky via Quick Edit.
DRY the logic for stickies in `wp_xmlrpc_server` by introducing `->_toggle_sticky()`.

Props wonderboymusic, obenland, chriscct7.
Fixes #20662.


git-svn-id: https://develop.svn.wordpress.org/trunk@33325 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-19 18:08:55 +00:00
Andrew Nacin a22368a225 JSHint: Use 'global' rather than 'globals' for inline configuration.
Don't declare a global already listed in .jshintrc.

props johnjamesjacoby.
fixes #33021.


git-svn-id: https://develop.svn.wordpress.org/trunk@33324 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-19 17:08:47 +00:00
Weston Ruter 9ba638910c Customizer: Indicate when there are no nav menu items available for a given type.
Props celloexpressions, valendesigns, rittesh.patel.
Fixes #32810.


git-svn-id: https://develop.svn.wordpress.org/trunk@33323 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-19 00:05:26 +00:00
Ella Iseulde Van Dorpe 16e22cd0aa Editor: word count: count astrals as one character
This makes sure an emoji, for example, is counted as one character.

See #30966.


git-svn-id: https://develop.svn.wordpress.org/trunk@33320 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-18 11:41:25 +00:00
Ella Iseulde Van Dorpe c2c5c5ac27 Editor: word count: exclude shortcodes
Props desaiuditd, adamsilverstein, azaozz and iseulde.
Fixes #27386. See #30966.


git-svn-id: https://develop.svn.wordpress.org/trunk@33299 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 21:08:05 +00:00
Ella Iseulde Van Dorpe 03653fa600 Editor: Add Media should be a button
Props afercia.
Fixes #32969.


git-svn-id: https://develop.svn.wordpress.org/trunk@33298 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 19:37:07 +00:00
Helen Hou-Sandi c40301f1a0 Customizer: Ensure consistent margins in sections.
Since the customizer dynamically changes, `nth-child` selectors are not always a great idea.

props afercia.
fixes #32902.


git-svn-id: https://develop.svn.wordpress.org/trunk@33297 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 19:14:31 +00:00
Ella Iseulde Van Dorpe 524225187f Editor: DFW: hide udate message
Props miqrogroove.
Fixes #32674.


git-svn-id: https://develop.svn.wordpress.org/trunk@33293 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 10:37:44 +00:00
Ella Iseulde Van Dorpe 129a3affe5 Editor: word count: exclude more characters
Also only exclude these characters for the `words` type. They should be counted for other types.
Add the ASCIIOnly option to the uglify config to preserve escaped unicode characters.

See #30966. Fixes #27391.



git-svn-id: https://develop.svn.wordpress.org/trunk@33292 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 09:44:43 +00:00
iseulde e1242b6979 Editor: word count: add all type
This type will count all characters including spaces.

See #30966.


git-svn-id: https://develop.svn.wordpress.org/trunk@33290 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 23:47:02 +00:00
Ella Iseulde Van Dorpe 302a039de1 TinyMCE: fix visual regressions (2)
See #32801.


git-svn-id: https://develop.svn.wordpress.org/trunk@33289 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 23:34:40 +00:00
Ella Iseulde Van Dorpe c0e3449295 TinyMCE: fix visual regressions
See #32801.


git-svn-id: https://develop.svn.wordpress.org/trunk@33285 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 21:30:09 +00:00
Helen Hou-Sandi 9c9b61e7da Toolbar: Ensure icons are colored correctly in alternate schemes.
props ryelle.
fixes #32931. see #29906.


git-svn-id: https://develop.svn.wordpress.org/trunk@33284 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 20:13:47 +00:00
Weston Ruter bfe9cce7f2 Customizer: Defer updating nav menu item tabIndex attributes until pane is reflowed.
Introduces `pane-contents-reflowed` Customizer event.

Props valendesigns, westonruter.
Fixes #32943.


git-svn-id: https://develop.svn.wordpress.org/trunk@33283 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 20:04:41 +00:00
Weston Ruter d9fcddae25 Customizer: Hide the transport list when it's empty, especially for screen readers.
Also prevent invalid markup for `.customize-section-description`.

Props valendesigns.
Fixes #32843.


git-svn-id: https://develop.svn.wordpress.org/trunk@33282 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 19:58:42 +00:00
Konstantin Obenland 9352eb41fb Customize: Provide a default way to save cropped images.
Allows plugins and themes to use `WP_Customize_Cropped_Image_Control` without
having to define their own way of saving the cropped image.

Props celloexpressions for initial patch.
Fixes #29211.



git-svn-id: https://develop.svn.wordpress.org/trunk@33280 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 19:53:23 +00:00
Weston Ruter 87b556a77a Customizer: Fix element focus after menu item is deleted for keyboard accessibility.
Also restores box shadow on focus.

Props valendesigns.
Fixes #32740.


git-svn-id: https://develop.svn.wordpress.org/trunk@33279 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 18:43:50 +00:00
Konstantin Obenland bd6c09724e Update password meter to match new color guidelines.
See: https://make.wordpress.org/design/handbook/foundations/colors/

Props melchoyce.
Fixes #32986.



git-svn-id: https://develop.svn.wordpress.org/trunk@33275 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 00:11:50 +00:00
Scott Taylor 3d1f8f292a After [33148]:
Don't nest `esc_attr()` and `htmlspecialchars()` when escaping the post title on the edit post screen.

Unrevert parts of [32851] and [32850].

Adds/alters unit tests.

Props miqrogroove.
Fixes #17780.


git-svn-id: https://develop.svn.wordpress.org/trunk@33271 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:55:07 +00:00
Scott Taylor aee18d2d38 List Tables:
* In `->handle_row_actions()`, bail immediately if `$primary` and `$column_name` do not match. Saves us a nesting level and avoids declaring code that is unusable.
* In `WP_List_Table::single_row_columns()`, allow `_column_{$name}` to be called dynamically by core to avoid having to override the entirety of `->single_row_columns()` in `WP_MS_Users_List_Table` and `WP_Posts_List_Table`
* In `WP_MS_Sites_List_Table`, `id` is not a column.

Props wonderboymusic, paulwilde.
Fixes #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@33270 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:46:13 +00:00
Konstantin Obenland 32bcd95e37 Media: Don't indent action links if there is no media icon.
See #32254.



git-svn-id: https://develop.svn.wordpress.org/trunk@33269 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:45:55 +00:00
Konstantin Obenland 8ff5bc6f53 Media: Reduce link noise between icons and titles in list view.
Props afercia.
Fixes #32254.



git-svn-id: https://develop.svn.wordpress.org/trunk@33268 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:23:42 +00:00
Helen Hou-Sandi d651f599bf List tables: Even more robust fallback for the primary column.
Since `WP_List_Table::get_default_primary_column()` can be overridden in a subclass and columns can be further filtered, it is possible to end up with a primary column that no longer exists. This is particularly evident in list tables for custom post types that have been altered via filter.

props ocean90.
fixes #32996.


git-svn-id: https://develop.svn.wordpress.org/trunk@33266 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 16:17:06 +00:00
Konstantin Obenland 0db2e4e6f1 Use default parameter when getting the default avatar type.
Props johnjamesjacoby.
Fixes #32997.


git-svn-id: https://develop.svn.wordpress.org/trunk@33264 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 15:38:02 +00:00
Konstantin Obenland 3a696d7d91 Media: Remove post_type variable, unused since [32676].
Fixes #32948.


git-svn-id: https://develop.svn.wordpress.org/trunk@33263 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 15:05:29 +00:00
Dion Hulse 56c51da216 Updates: When performing an ajax plugin update, rely upon wp_update_plugins() to check the contents of the transient and return early if no request needs to be made.
This works around a bug where custom update handlers are injecting an update into an empty transient, malforming the transient and causing update failures.
Fixes #32198 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33257 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 08:00:31 +00:00
Konstantin Obenland 3bafaf7983 Editor: Center-align Publish/Update spinner on small-screen devices.
Props tywayne for initial patch.
Fixes #32947.



git-svn-id: https://develop.svn.wordpress.org/trunk@33252 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 04:01:10 +00:00
Konstantin Obenland 8560ac41f1 Password: Improve display of password meter on login screen.
Fixes #32925.


git-svn-id: https://develop.svn.wordpress.org/trunk@33251 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 03:31:35 +00:00
Konstantin Obenland a48af6ef86 Passwords: Make show/hide toggle translatable.
See #32589.


git-svn-id: https://develop.svn.wordpress.org/trunk@33249 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:34:18 +00:00
Konstantin Obenland 05c4803450 Passwords: New UI for install screen.
Also synchronises the use of `pw_weak` as an input name and removes trailing
periods from checkbox labels.

Props MikeHansenMe, adamsilverstein, obenland.
See #32589.



git-svn-id: https://develop.svn.wordpress.org/trunk@33246 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:21:39 +00:00
Drew Jaynes b7bc240602 Fix summaries and add missing @global descriptions to the upgrade_430_fix_comments() and split_all_shared_terms() functions added in 4.3.
See [33020], [32643]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33212 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 19:55:37 +00:00
Drew Jaynes e7fe7ee764 Add a description for the dynamic portion of the nav_menu_items_{$post_type_name}_recent filter added in 4.3.
See [32833]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33211 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 19:50:41 +00:00
Drew Jaynes 760563a3c5 Fix the summary for the WP_Users_List_Table->get_default_primary_column_name() method added in 4.3.
See [32644]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33210 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 19:48:01 +00:00
Drew Jaynes 0aecc0ce8b Fix inline documentation syntax in the WP_Upgrader->clear_destination() method added in 4.3.
See [32854]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33209 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 19:45:45 +00:00
Konstantin Obenland 62da20af9e Passwords: Add trailing periods in new strings.
Props akibjorklund.
See #32589.



git-svn-id: https://develop.svn.wordpress.org/trunk@33208 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 18:29:58 +00:00
Drew Jaynes 794b64438d Fix summaries for two methods added to WP_Terms_List_Table in 4.3.
See [32644]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33207 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 18:21:24 +00:00
Konstantin Obenland 71ffa6195e Passwords: Improve display of show/hide toggle for touch and small-screen devices.
See #32589.



git-svn-id: https://develop.svn.wordpress.org/trunk@33206 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 18:20:21 +00:00
Drew Jaynes c68c1ade16 Add missing summaries, @access tags, and some parameter descriptions for methods added to WP_Links_List_Table in 4.3.
See [32753]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33204 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 18:02:38 +00:00
Konstantin Obenland 804a008eb1 Site Icon: Add Android-specific app icon.
Falling back to Apple app icons is deprecated behavior and will not work
forever. 192px is the recommended size for that icon.

Props kraftbj.
Fixes #32964.



git-svn-id: https://develop.svn.wordpress.org/trunk@33202 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 17:57:19 +00:00
Drew Jaynes 5251b3406a Add missing summaries, @access tags, and some parameter descriptions for methods added to WP_MS_Sites_List_Table in 4.3.
See [32755]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33199 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 17:52:43 +00:00
Drew Jaynes 60d32793d4 Improving formatting for various pieces of inline documentation in the new WP_Site_Icon class added in 4.3.
See [32994]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33198 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 17:50:41 +00:00
Drew Jaynes f43e6e1d38 Add missing summaries, @access tags, and some parameter descriptions to methods added to WP_Posts_List_Table in 4.3.
See [32740]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33197 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 17:48:07 +00:00
Drew Jaynes 32c3c59944 Fix the DocBlock summary for WP_Plugins_List_Table->get_primary_column_name(), added in 4.3.
See [32644]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33196 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 17:45:16 +00:00
Drew Jaynes 79422e9136 Add missing summaries and parameter descriptions to new methods added to WP_MS_Users_List_Table in 4.3.
See [32757]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33195 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 17:42:41 +00:00
Jeremy Felt 867f582b16 Handle MS Sites bulk action verification separately from individual actions.
After [33173], bulk actions would not process due to broken verification of the `bulk-sites` action. This reintroduces the proper action and treats bulk actions differently than individual site actions.

See #32963.


git-svn-id: https://develop.svn.wordpress.org/trunk@33194 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 17:23:55 +00:00
Drew Jaynes 4d1e0e26bb Add missing summaries to new methods added to WP_MS_Themes_List_Table in 4.3.
See [32756]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33193 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 16:12:58 +00:00
John Blackbourn 28ef7b69e5 Place the locale inside the md5 hash in the dashboard RSS feed widget transient key to prevent the transient timeout option name becoming longer than the allowed field size.
Props andg
Fixes #32804


git-svn-id: https://develop.svn.wordpress.org/trunk@33192 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 15:31:54 +00:00
John Blackbourn 82787b5842 Correct a parameter name in the docs for wp_insert_category().
git-svn-id: https://develop.svn.wordpress.org/trunk@33190 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 12:58:07 +00:00