Commit Graph
5506 Commits
Author SHA1 Message Date
Jeremy Felt 9170edb2b2 Improve information displayed in a network's sites list table
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.

Props @ocean90.
Fixes #32434.


git-svn-id: https://develop.svn.wordpress.org/trunk@32718 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 06:49:38 +00:00
Helen Hou-Sandi 74a6899d0d List tables:
* Avoid notices in custom list tables that manually set `$_column_headers`. Any plugins using this for a specific purpose should update.
* Restore a special class name in the users list table.

props georgestephanis, stephdau.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32717 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 01:45:11 +00:00
Konstantin Obenland c7a40c6847 When inline editing a post, reset password field to be editable by default.
The Quick Edit form is cloned and then populated with post-specific data. If the 
previous post was private, the password field would continue to be disabled for
the next post.

Props afercia.
Fixes #32259.



git-svn-id: https://develop.svn.wordpress.org/trunk@32716 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-09 22:01:06 +00:00
Aaron Jorbin b095afe2db Remove Truthy check from DO_NOT_UPGRADE_GLOBAL_TABLES
Some, but not all, of the checks for DO_NOT_UPGRADE_GLOBAL_TABLES just check if it is defined, so checking for truthiness could cause the issue to not be fully fixed.

In the words of Colonel Jessep: You can't handle the truth!

Introduced in [32714]

Fixes #32011



git-svn-id: https://develop.svn.wordpress.org/trunk@32715 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-09 21:59:51 +00:00
Aaron Jorbin 09340de73e Add error if a user attempts to install WordPress with DO_NOT_UPGRADE_GLOBAL_TABLES defined
The install process runs through migrations to global tables, therefore we cannot install WordPress with this constant defined. This error message prevents a false success screen from being seen.

Fixes #32011.
Props Oxymoron.



git-svn-id: https://develop.svn.wordpress.org/trunk@32714 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-09 17:58:18 +00:00
Konstantin Obenland 99d0d85fb0 Sort screen options for meta boxes according to the meta box's priority.
Props swissspidy.
Fixes #32582.



git-svn-id: https://develop.svn.wordpress.org/trunk@32707 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-08 12:34:03 +00:00
Ella Iseulde Van Dorpe 9eafba9d15 Autoprefixer after autoprefixer-core 5.2 update
grunt-autoprefixer requires ^5.1.7, so this was automatically updated.

See #31700.


git-svn-id: https://develop.svn.wordpress.org/trunk@32704 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-07 20:07:06 +00:00
Helen Hou-Sandi 028c61f1d4 Nav menus: Hidden inputs do not need an ID, especially one that's already in use.
props sagarjadhav.
fixes #31816.


git-svn-id: https://develop.svn.wordpress.org/trunk@32695 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-05 15:35:17 +00:00
Konstantin Obenland 990008aa50 Remove title attributes in user list tables.
They don't add valuable information and are redundant.
Reduces annoyance for screen reader users.

Props afercia.
Fixes #32535.



git-svn-id: https://develop.svn.wordpress.org/trunk@32694 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-05 08:39:26 +00:00
Konstantin Obenland 9dfbd00947 Text improvements for screen readers in list table paginations.
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.

Props afercia, rianrietveld.
Fixes #32028.



git-svn-id: https://develop.svn.wordpress.org/trunk@32693 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-05 05:00:23 +00:00
Helen Hou-Sandi 6c51513a44 Nav menus: hide the title attribute field by default for new users and installs.
It is still available in screen options. This also gives the "Navigation Label", a crucial field, the room it really deserves.

props paulwilde.
fixes #32218.


git-svn-id: https://develop.svn.wordpress.org/trunk@32691 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-04 04:37:02 +00:00
Helen Hou-Sandi 112fc6d369 Nav menus: Provide visual feedback when attempting to add an empty custom link.
props pragunbhutani for the initial patch.
fixes #18517.


git-svn-id: https://develop.svn.wordpress.org/trunk@32690 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-04 04:30:04 +00:00
John Blackbourn e069a38598 Switch to pointer tolerance for improved drag and drop behaviour when reordering widgets.
Props jkudish, MikeHansenMe.
Fixes #20791


git-svn-id: https://develop.svn.wordpress.org/trunk@32689 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 22:58:52 +00:00
Helen Hou-Sandi 2da4d61f95 Media list view: ensure thumbnails are appropriately sized and constrained.
see #29993.


git-svn-id: https://develop.svn.wordpress.org/trunk@32688 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 15:22:14 +00:00
Helen Hou-Sandi 6c60055740 Media: move the thumbnail into the title column in list view.
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.

props bradt for the initial patch.
fixes #29993 and #32255. see #32509 and #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@32687 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 15:12:19 +00:00
Helen Hou-Sandi fa29d5bb80 List tables: tighten up primary column handling for plugins and multisite themes.
These shouldn't be able to have their primary column reassigned by default. Also removes the `has-row-actions` class as these list tables always have row actions visible and the JS for visual toggling conflicts. The `column-primary` class remains.

props stephdau.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32686 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 15:07:22 +00:00
Konstantin Obenland d91e9c98de Use WordPress' default focus styles for links on login screens.
Props afercia.
Fixes #31712.



git-svn-id: https://develop.svn.wordpress.org/trunk@32682 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-02 05:50:33 +00:00
Dominik Schilling (ocean90) 5ae2271098 Customizer: Improve JS templates for Panels and Sections added in [32658].
* Always fall back to using the default template if no custom template exists.
* Provide a set of default params when constructing new `Section` and `Panel` objects.

Includes QUnit tests.

Props celloexpressions, westonruter, ocean90.
Fixes #30737.

git-svn-id: https://develop.svn.wordpress.org/trunk@32681 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 22:46:56 +00:00
Andrew Ozz 40df2f48bf Editor: run autosave when pressing Ctrl or Command + S in the Text editor, same as the Visual editor.
Fixes #31655.

git-svn-id: https://develop.svn.wordpress.org/trunk@32680 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 19:01:53 +00:00
Andrew Ozz 156df52851 Editor:
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949.

git-svn-id: https://develop.svn.wordpress.org/trunk@32677 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 17:37:14 +00:00
Sergey Biryukov 9940e8c16f Revert a part of [32673] that caused a fatal error with SCRIPT_DEBUG disabled.
see #19257.

git-svn-id: https://develop.svn.wordpress.org/trunk@32676 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 04:13:17 +00:00
John Blackbourn 87d5aefe74 Introduce featured_image, set_featured_image, remove_featured_image, and use_featured_image post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases.
Props johnbillion, mordauk, valendesigns.
Fixes #19257.


git-svn-id: https://develop.svn.wordpress.org/trunk@32673 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 16:53:12 +00:00
Scott Taylor 986990163f Add doc blocks to functions that are missing them.
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32672 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 03:17:50 +00:00
Drew Jaynes 492a2ed9a2 Fix inline documentation formatting in wp-admin/includes/admin-filters.php, introduced in [32653].
See #32529.


git-svn-id: https://develop.svn.wordpress.org/trunk@32671 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:59:45 +00:00
Drew Jaynes 563efdc1bb Fix syntax and add a missing return description for inline documentation introduced in [32644] for WP_Users_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32670 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:44:53 +00:00
Drew Jaynes 5e765a3f2f Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for WP_Terms_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32669 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:43:33 +00:00
Drew Jaynes cb1ea6f5c8 Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for WP_Posts_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32668 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:41:28 +00:00
Drew Jaynes cb0fbfa276 Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Plugins_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32667 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:39:22 +00:00
Drew Jaynes b310f8ddc0 Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for WP_MS_Users_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32666 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:37:36 +00:00
Drew Jaynes e24bc6a185 Fix syntax and add a missing return description for inline documentation introduced in [32644] for WP_MS_Themes_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32665 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:35:34 +00:00
Drew Jaynes 78e56cd89b Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for WP_MS_Sites_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32664 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:33:40 +00:00
Drew Jaynes 0041aea872 Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Media_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32663 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:31:11 +00:00
Drew Jaynes e3077edcad Fix formatting and add missing return descriptions for inline documenation introduced in [32644] for WP_List_Table.
Also fixes an error introduced in [32661] for `WP_Links_List_Table`.

See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32662 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:28:28 +00:00
Drew Jaynes 3725befcd8 Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Links_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32661 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:22:28 +00:00
Drew Jaynes 5b06d42c51 Add missing return descriptions and fix formatting of inline documentation introduced in [32644].
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32660 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:17:25 +00:00
Weston Ruter cc19680774 Add JS templates for Customizer Panels and Sections.
This extends the approach taken for Customizer Controls in #29572.

Props celloexpressions, westonruter, ocean90.
See #30737.


git-svn-id: https://develop.svn.wordpress.org/trunk@32658 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-30 00:02:13 +00:00
Scott Taylor c49c139a22 Add @access annotations to methods that have no doc block in wp-admin/includes/*.
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32656 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 21:31:56 +00:00
Scott Taylor 60e5c90e62 Add (more) missing doc blocks to wp-admin/includes/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32655 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 21:16:59 +00:00
Scott Taylor ec5758225c Add missing doc blocks to wp-admin/includes/*.
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32654 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 20:16:22 +00:00
Scott Taylor d55800a4f2 In the style of #30947 and default-filters.php, add 2 new files to wp-admin/includes:
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.


git-svn-id: https://develop.svn.wordpress.org/trunk@32653 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 17:03:13 +00:00
Scott Taylor d5e9f8770a Add missing annotations to ajax-actions.php`
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32652 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 16:00:29 +00:00
Helen Hou-Sandi 923bffda98 Define a primary column for WP_Post_Comments_List_Table.
props boonebgorges.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32651 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 15:51:11 +00:00
Scott Taylor c8a44d437a Add @static* annotations where they are missing.
Initialize all static vars that are not, most to `null`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32650 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 15:42:40 +00:00
Dominik Schilling (ocean90) cced199188 Customizer: Replace accordion behavior of sections with a slide-in navigation.
This allows users to focus on the contents of the active section more easily and separating the navigation from the content/controls in the Customizer.

props valendesigns, celloexpressions.
see #31336.

git-svn-id: https://develop.svn.wordpress.org/trunk@32649 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 13:56:39 +00:00
Helen Hou-Sandi ea9de1aacd After [32644], sanity for a pile of selectors.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32645 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:59:44 +00:00
Helen Hou-Sandi 86c907d2a5 List tables: introduce the concept of a "primary" column.
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32644 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:40:52 +00:00
Scott Taylor f864c1d712 Add @global annotations to (the rest of the?) wp-admin/* files.
Does not include list table file changes.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32643 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:05:26 +00:00
Scott Taylor 23ce2efd12 Add @global annotations for wp-admin/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Helen Hou-Sandi 805d876017 About: Give bottom navigation links the full width.
This will prevent longer strings from wrapping needlessly, and is more semantically correct markup.

props tyxla.
fixes #32391.


git-svn-id: https://develop.svn.wordpress.org/trunk@32636 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 15:38:44 +00:00
Jeremy Felt b1e80f0388 Use site objects rather than get_blog_status() in MS list tables.
Removes several repetitive calls to `get_blog_status()` that are not needed, as the data is already available as part of each site's object.

Fixes #32512.


git-svn-id: https://develop.svn.wordpress.org/trunk@32630 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-27 23:13:04 +00:00