Commit Graph

1596 Commits

Author SHA1 Message Date
Sergey Biryukov
332a618271 Declare the variable before using it.
props danielbachhuber.
fixes #28932.

git-svn-id: https://develop.svn.wordpress.org/trunk@29215 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 22:00:14 +00:00
Scott Taylor
f59a307e10 Merge wp_handle_upload() and wp_handle_sideload() by making them each wrap a new function: _wp_handle_upload().
Props DrewAPicture for docs.
Fixes #23686.


git-svn-id: https://develop.svn.wordpress.org/trunk@29209 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 18:57:26 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Scott Taylor
283fa473e6 In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text.
Props joedolson.
Fixes #28853.


git-svn-id: https://develop.svn.wordpress.org/trunk@29201 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:49:53 +00:00
Drew Jaynes (DrewAPicture)
8a5d825fac Fix a typo in the @access tag for WP_List_Table::__get().
Props joehoyle.
Fixes #28925. See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29199 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:12:11 +00:00
Andrew Nacin
9452f31220 DB schema change: Add comment_author_email(10) index.
props tellyworth, pento.
fixes #21435.


git-svn-id: https://develop.svn.wordpress.org/trunk@29188 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 15:53:14 +00:00
Andrew Ozz
09f5183276 Editor scrolling: better "scroll into view" in the visual editor. Don't override MCE path focus style. Props avryl, see #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29186 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 04:05:13 +00:00
azaozz
12ebd89657 Editor scrolling: also disable in IE < 9. See #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29180 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:36:02 +00:00
Scott Taylor
9e573243cf Add a new AJAX action: parse-media-shortcode. This async call will replace JS rendering of audio/video/playlist shortcodes.
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29178 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:07:16 +00:00
Scott Taylor
bbfdf38a5b Make audio and video URLs/embed handlers work in <iframe>-sandbox'd MCE views.
Introduce:
`get_editor_stylesheets()`
`wp_media_mce_styles()`.

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29176 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 21:50:41 +00:00
Helen Hou-Sandi
0db107498a No-JS fallback for the Media Library grid view. props michalzuber. fixes #28830, see #24716.
git-svn-id: https://develop.svn.wordpress.org/trunk@29175 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 20:44:38 +00:00
Dominik Schilling (ocean90)
4d6759dcf5 Remove unused variable in WP_Theme_Install_List_Table::install_theme_info(). Unused since [26380].
props Corphi.
fixes #28749.

git-svn-id: https://develop.svn.wordpress.org/trunk@29173 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 20:27:37 +00:00
Dominik Schilling (ocean90)
cf673a6985 Fix wrong indentation in [29136].
git-svn-id: https://develop.svn.wordpress.org/trunk@29172 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 20:08:38 +00:00
Dominik Schilling (ocean90)
1b2386e787 Remove plugin_install_details_link filter, which was added in [29047].
see #28785.

git-svn-id: https://develop.svn.wordpress.org/trunk@29171 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 19:49:15 +00:00
Dominik Schilling (ocean90)
60b1befd8e Customizer: Add meta capability customize which is mapped to edit_theme_options.
You can now allow users to access the Customizer, say for any user who can `edit_posts`, via `map_meta_cap` or `user_has_cap` filter. See ticket for examples.

props westonruter, nacin.
fixes #28605.

git-svn-id: https://develop.svn.wordpress.org/trunk@29170 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 19:00:24 +00:00
Scott Taylor
e5a663297c Missed one: WP_MS_Sites_List_Table::display_rows() must be public.
Props extendwings.
Fixes #28894.



git-svn-id: https://develop.svn.wordpress.org/trunk@29166 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 15:41:53 +00:00
Drew Jaynes (DrewAPicture)
7ad77d58ee Add periods to short descriptions for magic methods added in [28501], [28521], and [28524].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29165 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 01:11:55 +00:00
Drew Jaynes (DrewAPicture)
e58a2aae1d Inline documentation cleanup for 4.0 audit.
* phpDoc tweaks for `wp_get_available_translations_from_api()`, `wp_install_download_language_pack()`, and `wp_install_load_language()`, added in [29018]
 
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29154 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:16:36 +00:00
Drew Jaynes (DrewAPicture)
f77584ea2c Inline documentation for the 'plugin_install_details_link' hook added in [29047] should use a 3-digit, x.x.x-style @since version.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29152 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:09:58 +00:00
Drew Jaynes (DrewAPicture)
08fd193850 Inline documentation cleanup for 4.0 audit.
* Alignment for the 'term_search_min_chars' hook docs, added in [28892]
* Globals added for `wp_ajax_parse_embed()`, added [28580]

See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29151 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:05:37 +00:00
Drew Jaynes (DrewAPicture)
49fdc296ba Fill out inline documentation for magic methods added to the Custom_Image_Header class in [28481], [28521], and [28524].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29150 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 23:58:27 +00:00
Drew Jaynes (DrewAPicture)
1db583af25 Fill out inline documentation for magic methods added to the Custom_Background class in [28481], [28521], and [28524].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29149 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 23:57:03 +00:00
Drew Jaynes (DrewAPicture)
1bf87b2c9e Fill out inline documentation for magic methods added to the WP_List_Table class in [28493], [28521], and [28524].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29148 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 23:54:15 +00:00
Drew Jaynes (DrewAPicture)
343c544f6b Fill out inline documentation for magic methods added to the WP_Filesystem_Base class in [28521].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29147 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 23:51:39 +00:00
Scott Taylor
510ad2e1e9 Fix mismatches in access modifiers for WP_List_Table + subclasses.
Fixes #28843, #28879.


git-svn-id: https://develop.svn.wordpress.org/trunk@29137 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 22:08:22 +00:00
Dominik Schilling (ocean90)
1264558022 Media Grid improvements:
* Remove fixed elements.
* Adjusts toolbar and search, fixes #28833.
* Add link to Add New button, fixes #28825.
* Add "Edit Metadata" tab to all items, "Edit Image" only for images
* Make strings translatable.
* First pass for help tab.

see #28850.

git-svn-id: https://develop.svn.wordpress.org/trunk@29136 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 16:15:36 +00:00
Dominik Schilling (ocean90)
cf0e666184 Customizer: Make panel title translatable too.
props michalzuber.
see #27406.

git-svn-id: https://develop.svn.wordpress.org/trunk@29135 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 15:12:00 +00:00
Dominik Schilling (ocean90)
33db0d4ff2 Lists View Switcher: Replace blank image with screen reader text.
props davidakennedy.
fixes #28871.

git-svn-id: https://develop.svn.wordpress.org/trunk@29133 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 11:04:21 +00:00
Dominik Schilling (ocean90)
d198c0bdd5 Remove unused variable in wp_dashboard_plugins_output(). Unused since [26144].
props michalzuber.
see #28872.

git-svn-id: https://develop.svn.wordpress.org/trunk@29130 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 10:30:53 +00:00
Dominik Schilling (ocean90)
1285d1450b Improvements to the plugin information modal:
* Whitespace/braces cleanup for [29040].
* Reduce width of modal to 792px, which is the default banner size.
* Reduce banner height when screen height is smaller than 500px.
* Remove inline CSS.
* Re-use tab var in JS.
* Encode ampersands in links.

props avryl, michalzuber, ocean90.
see #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29125 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 22:07:16 +00:00
Dominik Schilling (ocean90)
c7f2a54dc8 Themes: Don't set background color for the filter icon.
fixes #28860.


git-svn-id: https://develop.svn.wordpress.org/trunk@29124 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 19:48:24 +00:00
Sergey Biryukov
c52f02cc3f Use correct ID for plugin search input label.
Make the search button name and ID consistent with the ones in WP_List_Table::search_box().

props joedolson.
fixes #28856.

git-svn-id: https://develop.svn.wordpress.org/trunk@29123 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 17:44:51 +00:00
Dominik Schilling (ocean90)
7580577e82 Don't use box shadow focus styling for widget arrows, see #28267.
fixes #28834.
props nvwd.

git-svn-id: https://develop.svn.wordpress.org/trunk@29122 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 15:46:27 +00:00
Dominik Schilling (ocean90)
911da56fe8 Improve styling of progress bar on wp-admin/media-new.php.
props Ipstenu for initial patch.
fixes #28838.

git-svn-id: https://develop.svn.wordpress.org/trunk@29121 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 14:51:30 +00:00
Scott Taylor
63cb20cc5a Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses.
Props SergeyBiryukov.
See #28843 and [28583].


git-svn-id: https://develop.svn.wordpress.org/trunk@29118 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 03:26:40 +00:00
Andrew Ozz
dbb367bee8 Editor scrolling: disable on mobile devices and hide the resize handle. See #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29117 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 00:53:08 +00:00
Scott Taylor
d1f4b3a800 Media Grid, for audio files:
* Show `artist` and `album` fields in the Edit Attachment modal
* Sync their values on `change`

See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29104 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 20:54:13 +00:00
Sergey Biryukov
8a45aefe56 Escape taxonomy name when used in attributes in post_categories_meta_box().
props pbearne.
fixes #28836.

git-svn-id: https://develop.svn.wordpress.org/trunk@29099 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 18:55:48 +00:00
Scott Taylor
0f50df6cbd Media Grid, in the Edit Attachment modal:
* Label the fields under the attachment a la the Edit Media page
* Move the audio and video previews above the info
* Remove the audio / video icon display. Unnecessary.
* Ensure that `width` and `max-width` are set for `.mejs-container`

See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29088 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 06:14:31 +00:00
Scott Taylor
ce01c5c760 Media Grid:
* Move the grid down via CSS transition when the Screen Options slide open.
* Remove some unused CSS for grid options.

See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29086 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 05:33:29 +00:00
Sergey Biryukov
d2a246e82c Avoid inadvertently adding admin page titles as classes for admin menu submenu items.
fixes #28817.

git-svn-id: https://develop.svn.wordpress.org/trunk@29083 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 01:09:32 +00:00
Scott Taylor
ee0e7ccbca Media Grid: make registering Screen Options for non-list tables more generic.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29079 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 21:43:49 +00:00
Scott Taylor
d5cbf00457 Media Grid: Screen Options for grid have to play nice with Screen Options for list. This was fun.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29078 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 21:25:49 +00:00
Scott Taylor
3ebde0c4d6 Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29077 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 20:59:12 +00:00
Helen Hou-Sandi
e4f0744b8e Editor scrolling:
* Make sure the background color for tools is only applied to the main editor.
* Fix toolbar width for smaller screens.
* Ensure toolbar doesn't end up in a weird place when scrolling down too fast.
* Avoid JS errors for post types that don't support the editor.

props avryl. see #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29075 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 19:35:32 +00:00
Andrew Nacin
0838b61b1d Unload the current default textdomain in wp_install_load_language().
see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29059 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 09:54:06 +00:00
Andrew Nacin
253e09f192 Install: Don't ask for the user's language a second time if they chose English originally.
see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29058 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 09:24:55 +00:00
Helen Hou-Sandi
466659cee6 Media grid attachment modal:
* Keyboard navigation.
* History and routes for single items and search results.

props adamsilverstein. see #24716.



git-svn-id: https://develop.svn.wordpress.org/trunk@29057 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 06:36:34 +00:00
Sergey Biryukov
c35bd6c927 Revisions: Properly position the spinner on Compare Revisions screen.
props vinod dalvi for initial patch.
fixes #28590.

git-svn-id: https://develop.svn.wordpress.org/trunk@29054 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 01:43:59 +00:00
Sergey Biryukov
ca97e64c50 Revisions: Explicitly set the 'from' handle position when switching from two-handled mode back to single-handled mode.
props adamsilverstein.
fixes #26793.

git-svn-id: https://develop.svn.wordpress.org/trunk@29052 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 00:59:13 +00:00