Commit Graph

32 Commits

Author SHA1 Message Date
Andrea Fercia
ee7f970ffa Administration: Improve the usage of the button CSS classes.
Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

- Adds the `button` class to all primary buttons make them responsive
- Removes all `secondary-button` classes and replaces it with button when needed. `button-secondary` shouldn't be used and exists just for backward compatibility reasons
- Replaces classes inside `submit_button()` with a shorthand for some buttons, and use an empty string for the default `button` class. Passing `button` is unnecessary
- Adjusts `get_submit_button()` to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.


git-svn-id: https://develop.svn.wordpress.org/trunk@38672 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-28 19:53:07 +00:00
Andrew Ozz
7ba408c93e Widgets: add a button to delete all inactive widgets simultaneously for better UX.
Props cdog.
Fixes #19159.

git-svn-id: https://develop.svn.wordpress.org/trunk@35317 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 05:22:52 +00:00
Andrea Fercia
52c2492afb Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy.
Props mrahmadawais, afercia.
Fixes #33659.

git-svn-id: https://develop.svn.wordpress.org/trunk@35015 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 16:33:33 +00:00
Scott Taylor
8df7bd75b6 Ensure that widget carets close when dragging an expanded widget.
Props sdavis2702, mindctrl.
Fixes #33578.


git-svn-id: https://develop.svn.wordpress.org/trunk@34165 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 03:09:35 +00:00
Andrew Ozz
4e7b5dca5b Widgets screen: while dragging a widget over a closed sidebar refresh only the widgets in the current sidebar instead of all widgets in all sidebars.
Props chriscct7. Fixes #33015.

git-svn-id: https://develop.svn.wordpress.org/trunk@33354 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-22 01:24:47 +00:00
Andrew Ozz
0f7208a1ee Fix opening closed widget areas when dragging a widget over them.
Props polevaultweb. Fixes #13524.

git-svn-id: https://develop.svn.wordpress.org/trunk@33088 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-05 18:19:44 +00:00
Konstantin Obenland
016ebf43ed Open closed widget areas when dragging onto them.
Allows dropping Widgets into the correct spot of a given sidebar, no matter
whether that sidebar is open or closed. Removes a step from the setup process
for closed sidebars.

Props polevaultweb.
Fixes #13524.



git-svn-id: https://develop.svn.wordpress.org/trunk@33014 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 00:57:03 +00:00
John Blackbourn
e069a38598 Switch to pointer tolerance for improved drag and drop behaviour when reordering widgets.
Props jkudish, MikeHansenMe.
Fixes #20791


git-svn-id: https://develop.svn.wordpress.org/trunk@32689 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 22:58:52 +00:00
Andrew Ozz
5bf60d981b Widgets:
- Fix dragging to the bottom of the screen.
- Fix hiding of the dragged widget when dragging over a closed sidebar.
- Fix the admin menu position and scrolling when all widget containers are folded.
Fixes #32094 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32480 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-10 00:31:47 +00:00
Helen Hou-Sandi
6983294161 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.


git-svn-id: https://develop.svn.wordpress.org/trunk@31996 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 04:51:18 +00:00
Scott Taylor
69c449963e Replace flagrant instances of .html('') with .empty().
Props OriginalEXE, SergeyBiryukov.
Fixes #27034.


git-svn-id: https://develop.svn.wordpress.org/trunk@31690 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-09 19:43:49 +00:00
Sergey Biryukov
69b97690d5 Widgets: Toggle widget arrow when the widget is closed using Close link.
props senff.
fixes #29617.

git-svn-id: https://develop.svn.wordpress.org/trunk@29726 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-10 17:35:38 +00:00
Dominik Schilling (ocean90)
a54c311e4f Widgets: Toggle widget arrow when widget is open/closed.
props MikeHansenMe.
fixes #26748.

git-svn-id: https://develop.svn.wordpress.org/trunk@28235 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-01 14:08:44 +00:00
Dominik Schilling (ocean90)
ab8f7f7afd Widgets: Trigger jQuery events for widget updates.
* `widget-added` when a widget is added to a sidebar
* `widget-updated` when a widget is updated
A jQuery object of the widget is passed along to the event handler. Same events are used in the Widget Customizer, see [27909].

fixes #19675.

git-svn-id: https://develop.svn.wordpress.org/trunk@27969 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 19:05:03 +00:00
Ryan Boren
cfd5c395bb The Pinking Shears stir from their slumber, awakened by what may seem, to those
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!

One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.

Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.


git-svn-id: https://develop.svn.wordpress.org/trunk@26851 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-11 19:48:29 +00:00
Andrew Ozz
5454336667 Widgets: jshint cleanup of widgets.js, see #25821.
git-svn-id: https://develop.svn.wordpress.org/trunk@26703 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 23:13:22 +00:00
Andrew Nacin
3831c95a04 Widgets: Add click-to-add widgets to the bottom (not top) of the target sidebar.
fixes #25821.


git-svn-id: https://develop.svn.wordpress.org/trunk@26696 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 22:26:45 +00:00
Andrew Nacin
ddc9ed51e8 Widgets: Only scroll to the newly clicked-and-added widget if it is out of the viewport.
props shaunandrews.
see #25821.


git-svn-id: https://develop.svn.wordpress.org/trunk@26695 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 22:21:15 +00:00
Andrew Ozz
f90e3dc450 Widgets: on clicking Add, don't move the chooser out of the widget early as that makes is visible at the bottom of the screen. Remove the cloned copy of it instead. Part-props jeremyfelt, fixes #26417.
git-svn-id: https://develop.svn.wordpress.org/trunk@26651 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 00:01:42 +00:00
Andrew Ozz
28da4145a6 Widgets: highlight all drop zones (open and closed sidebars) on starting to drag a widget to indicate "droppability", fixes #26168.
git-svn-id: https://develop.svn.wordpress.org/trunk@26474 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-29 17:57:05 +00:00
Andrew Ozz
c83ea1d936 Widgets: remove leftover debug bits and fix jshint warnings in widgets.js, see #25952.
git-svn-id: https://develop.svn.wordpress.org/trunk@26427 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-27 01:41:27 +00:00
Andrew Ozz
f4264f9446 Widgets: drop onto closed sidebars.
- Make dropping a widget easier by preventing the source sidebar from resizing while the widget is being dragged.
- Move widgets dropped on closed sidebars to the top. UI Sortable places them randomly near the bottom.
- Fix possible regression in wp_list_widget_controls(), add an optional argument to output the sidebar name inside the sortable container.
- Updated styles for sidebar description and widget-hover class.
Part props shaunandrews, fixes #25952.

git-svn-id: https://develop.svn.wordpress.org/trunk@26426 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-27 01:29:49 +00:00
Andrew Ozz
89d0be9d3d Widgets:
- Don't deactivate "draggable" on the widget when the chooser is open. Makes it possible to still drag the "widget-in-question".
- Change the chooser's HTML id to a class to avoid collisions when cloning.
- Refresh the "sortable" positions when an open widget is dragged. Fixes problems moving the widget up or down in the same sidebar.
See #25821

git-svn-id: https://develop.svn.wordpress.org/trunk@26366 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-24 22:06:13 +00:00
Andrew Ozz
3341352a3d Widgets:
- Prevent dragging of the widget-in-question when the chooser is open.
- Don't show more than one spinner when saving widgets positions.
- Disable selecting of text in the widget title. Prevents selecting/highlighting most of the screen when dragging on slower devices.
See #25821.

git-svn-id: https://develop.svn.wordpress.org/trunk@26306 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-21 19:27:47 +00:00
Sergey Biryukov
09fa0c09bb Fix JSHint errors in widgets.js.
props jorbin.
fixes #26127.

git-svn-id: https://develop.svn.wordpress.org/trunk@26287 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-20 11:11:01 +00:00
Andrew Ozz
b31a5258cd Widgets: split the sidebars in two containers so there are no empty spaces when they are shown in two columns and some are open, other closed. See #25952.
git-svn-id: https://develop.svn.wordpress.org/trunk@26285 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-20 04:44:21 +00:00
Andrew Ozz
8da914b9ec Widgets:
- Fix support for expanding (wide) widgets in the Inactive Widgets area.
- Remove resizing of the sidebars height.
- Stop removing unneeded "for" attributes from labels inside the widgets. Was a fix for IE6 odd behaviour.  

See #26117.

git-svn-id: https://develop.svn.wordpress.org/trunk@26277 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-20 01:34:41 +00:00
Andrew Ozz
e45ca7cc89 Widgets:
- Remove the !important styles that were overriding the widget width when expanded.
- Fix missing border-bottom from widgets when dragged and expanded.
Props shaunandrews, see #26117.

git-svn-id: https://develop.svn.wordpress.org/trunk@26275 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-19 23:46:05 +00:00
Andrew Ozz
fdc08a857e Widgets: move the chooser inside the selected widget so it inherits the width, add some keyboard shortcuts: tab to select, enter to append and escape to cancel. Props shaunandrews, see #25821
git-svn-id: https://develop.svn.wordpress.org/trunk@26271 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-19 18:02:14 +00:00
Matt Thomas
e00060118b Bring in the widgets component of MP6. See #25858.
* A cleaner UI, with a simpler design for available and inactive widgets, and more emphasis on your sidebars.
* Available widgets and sidebars expand to two columns at larger screen sizes making it easier to manage sites with lots of sidebars.
* New dropzone indicator for empty sidebars.

Props shaunandrews, joen, iammattthomas.



git-svn-id: https://develop.svn.wordpress.org/trunk@26140 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 20:05:51 +00:00
Andrew Ozz
8ee904343b Merge the Widgets Area Chooser feature plugin. First run, see #25821
git-svn-id: https://develop.svn.wordpress.org/trunk@26054 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 23:04:35 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00