Commit Graph

19033 Commits

Author SHA1 Message Date
Sergey Biryukov
38891dbbcb Bundled Themes: Remove extra trailing spaces from translatable strings in block patterns.
Follow-up to [49583], [51045].

Props audrasjb, mukesh27.
Fixes #53774.

git-svn-id: https://develop.svn.wordpress.org/trunk@51496 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-27 11:26:23 +00:00
Sergey Biryukov
3207c62104 Docs: Clarify the @return value for WP_Filesystem_Base::getnumchmodfromh().
Follow-up to [9117], [51494].

See #53399.

git-svn-id: https://develop.svn.wordpress.org/trunk@51495 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-27 11:00:25 +00:00
Sergey Biryukov
7bb0a17b46 Docs: Correct @return type for WP_Filesystem_Base::getnumchmodfromh().
Follow-up to [9117].

Props ankitmaru, johnbillion.
Fixes #53793.

git-svn-id: https://develop.svn.wordpress.org/trunk@51494 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-27 09:27:51 +00:00
Peter Wilson
000068f637 Bundled Themes: Version Bump 2010, 2011 and 2012.
Version bump three bundled themes to avoid file not found and fatal errors introduced for child themes during the 5.8 release cycle.

* Twenty Ten: Version 3.5 (fatal error & 404)
* Twenty Eleven: Version 3.9 (404)
* Twenty Twelve: Version 3.5 (404)

These updates will be released mid 5.8.1 cycle due to the severity of the issues.

Follow up to [51482,51483].

Props dd32, peterwilsoncc.
Fixes #53777.



git-svn-id: https://develop.svn.wordpress.org/trunk@51486 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-26 03:13:19 +00:00
Sergey Biryukov
9ea5645ec2 Media: Check the posts_per_page value in wp_ajax_query_attachments() before using it as a divisor.
This avoids a "Division by zero" PHP warning if a plugin changes the `posts_per_page` value to zero.

Follow-up to [51145].

Props 2linctools, kapilpaul, audrasjb.
Fixes #53773.

git-svn-id: https://develop.svn.wordpress.org/trunk@51485 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-25 09:55:33 +00:00
Sergey Biryukov
301eb3c8f6 Media: Remove unused code from wp-admin/includes/media.php.
Folow-up to [7043], [7062].

Props rudlinkon, hellofromTonya.
Fixes #53764.

git-svn-id: https://develop.svn.wordpress.org/trunk@51484 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-24 13:02:29 +00:00
Sergey Biryukov
c696a2f773 Bundled Themes: Use correct path for loading images in block patterns.
By using `get_template_directory_uri()` instead of `get_stylesheet_directory_uri()`, we make sure to include the images from the parent theme.

This avoids displaying missing images in block patterns when using a child theme of Twenty Ten, Twenty Eleven, or Twenty Twelve.

Follow-up to [51033], [51103], [51106].

Props audrasjb.
Fixes #53769.

git-svn-id: https://develop.svn.wordpress.org/trunk@51483 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-24 12:40:28 +00:00
Sergey Biryukov
bedd023c3a Twenty Ten: Use correct path for loading block patterns.
By using `get_template_directory()` instead of `get_stylesheet_directory()`, we make sure to include the `block-patterns.php` file from the parent theme.

This avoids a PHP fatal error when using a child theme of Twenty Ten.

Follow-up to [51106].

Props ryelle, sabernhardt, loranrendel.
Fixes #53752.

git-svn-id: https://develop.svn.wordpress.org/trunk@51482 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-23 13:12:31 +00:00
John Blackbourn
0871a0ddc2 Docs: Miscellaneous docblock corrections and improvements.
See #53399


git-svn-id: https://develop.svn.wordpress.org/trunk@51477 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 16:53:59 +00:00
Sergey Biryukov
41df21e70d Docs: Add a comment about the $title global usage in various admin files.
This should make it clear that the variable is used as part of the HTML `<title>` tag on admin screens.

Props ravipatel, hellofromTonya, sabernhardt, audrasjb, SergeyBiryukov.
Fixes #53729.

git-svn-id: https://develop.svn.wordpress.org/trunk@51475 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 13:51:58 +00:00
Sergey Biryukov
49b11dcad7 Docs: Correct a comment about WebP constants in wp-includes/compat.php.
Follow-up to [50810], [50814].

Props GaryJ, rtm909.
Fixes #53680.

git-svn-id: https://develop.svn.wordpress.org/trunk@51474 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 13:06:55 +00:00
Sergey Biryukov
70c9aabf0d Help/About: Add / character to <img> and <source> tags.
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Follow-up to [47493], [48834], [50556], [51418].

Props radixweb, ankitmaru, TobiasBg, sabernhardt, audrasjb.
Fixes #53716.

git-svn-id: https://develop.svn.wordpress.org/trunk@51473 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 12:57:48 +00:00
Greg Ziółkowski
3f83b50743 I18n: Fix broken loop in WP_Theme_JSON_Resolver
Related issue in Gutenberg: https://github.com/WordPress/gutenberg/issues/33552

The loop in WP_Theme_JSON_Resolver to extract translatable paths was broken, as it contained an immediate and unconditional return. This caused the loop to immediately exit again after the first iteration, thus never actually looping.

Follow-up to [50959].

Props schlessera.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@51472 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 10:05:33 +00:00
Greg Ziółkowski
211d94b710 Editor: Conditionally load registered styles for block variations
In WordPress 5.8 we added the ability to only load styles for blocks when these blocks are rendered. However, these optimizations left out block-styles that get added using the register_block_style() function/API.

Props aristath.
Fixes #53616.



git-svn-id: https://develop.svn.wordpress.org/trunk@51471 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-22 08:36:11 +00:00
Jonathan Desrosiers
09bbc174c0 External Libraries: Correct the underscore version used when registering.
The correct version is `1.13.1`.

Follow up to [50650], [50778].

Props david.binda.
Fixes #53713.

git-svn-id: https://develop.svn.wordpress.org/trunk@51469 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-21 12:32:57 +00:00
Jonathan Desrosiers
ca214a3b4c External Libraries: Correct the jquery-form version used when registering.
The correct version is `4.3.0`.

Follow up to [50546].

Props david.binda.
Fixes #53714.

git-svn-id: https://develop.svn.wordpress.org/trunk@51468 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-21 12:19:26 +00:00
Jonathan Desrosiers
0e08acda70 External Libraries: Correct the hoverIntent version used when registering.
Follow up to [50521].

Props david.binda.
Fixes #53715.

git-svn-id: https://develop.svn.wordpress.org/trunk@51467 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-21 12:16:35 +00:00
John Blackbourn
0167d6dd50 Application Passwords: Improve various user-facing and developer-facing terminology.
Fixes #53503, #53691


git-svn-id: https://develop.svn.wordpress.org/trunk@51463 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-19 21:13:36 +00:00
Jonathan Desrosiers
fd872e56fd Upgrade/Install: Add additional files to $_old_files for 5.8.
Follow up to [51134].

Fixes #53367.

git-svn-id: https://develop.svn.wordpress.org/trunk@51459 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-19 00:58:50 +00:00
Jonathan Desrosiers
2001b2252e Build/Test Tools: Update the caniuse browser data and regenerate CSS.
This includes three minor updates to generated CSS files:

- A single `-webkit-` prefix is removed for `min-width`, which was required for Safari <= 10.1 (0.06% total global usage). WordPress only supports the last two versions.
- 2 instances where the `-o-` prefix are added for `tab-size`. This appears to be for Opera Mobile, which has creeped back over the 1% global usage.

Props peterwilsoncc, jorbin.
Fixes #53686.

git-svn-id: https://develop.svn.wordpress.org/trunk@51456 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-19 00:40:49 +00:00
Jonathan Desrosiers
d69216bf55 Bundled Themes: Bump bundled theme versions for WordPress 5.8.
This bumps the version for all bundle themes in preparation for release with WordPress 5.8. The new versions are as follows:

- Twenty Twenty-One: 1.4
- Twenty Twenty: 1.8
- Twenty Nineteen: 2.1
- Twenty Seventeen: 2.8
- Twenty Sixteen: 2.5
- Twenty Fifteen: 3.0
- Twenty Fourteen: 3.2
- Twenty Thirteen: 3.4
- Twenty Twelve: 3.4
- Twenty Eleven: 3.8
- Twenty Ten: 3.4

Props mukesh27, kapilpaul.
Fixes #53277.

git-svn-id: https://develop.svn.wordpress.org/trunk@51455 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-18 23:03:08 +00:00
Riad Benguella
a74568e96d Block Editor: Backport fixes targetted for WordPress 5.8 RC4.
This includes:

 - Suggestion List: Check if a node exists to scroll into view.
 - Autocomplete: reset state for empty text.
 - Adds auxiliary class names for editor styles in the widgets editor.
 - Extract snackbars into a separate component.
 - Rich text: run input rules after composition end.
 - iframe: load inline styles.
 - Multi select: select all: restore ref callback.
 - Writing flow: allow select all from empty selection.
 - Post Excerpt: Fix excerpt_more filter conflict and remove wordCount attribute.
 - Add the percent unit to the default units in Core.

Props desrosj.
See #53397.


git-svn-id: https://develop.svn.wordpress.org/trunk@51443 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-15 18:53:34 +00:00
Jonathan Desrosiers
025e59a1ef Media: Document edge cases with the new image_editor_output_format filter.
More testing has revealed that the `image_editor_output_format` filter has some interesting edge cases that developers should be aware of when electing to use this filter (see #53667 and #53668).

Because this is a new filter that was intended to be used for experimenting with different ways to handle generating image sizes and has not yet been adopted in the wild, expanding the inline documentation is an acceptable temporary solution while these edge cases are explored further and addressed.

Props mikeschroder, antpb, desrosj, adamsilverstein, ianmjones.
See #5366, #53668, #35725.

git-svn-id: https://develop.svn.wordpress.org/trunk@51442 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-15 17:38:57 +00:00
Joe Dolson
41ba4acb83 Media: Fix JS error in Media Library when infinite scroll enabled.
Wrap call to this.updateLoadMoreView() is wrapped in a check that infinite scroll is disabled to prevent JS errors.

Props wildworks.
Fixes #53672.

git-svn-id: https://develop.svn.wordpress.org/trunk@51440 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-15 16:59:26 +00:00
Andrew Ozz
f17f4f5f7e Media: When resizing WebP images set the compression to "lossy" by default. Fixes a bug where the compression was set to "lossless" when the uploaded WebP images have extended file format (VP8X).
Props adamsilverstein, mikeschroder, mmxxi, linux4me2.
Fixes #53653.

git-svn-id: https://develop.svn.wordpress.org/trunk@51435 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-15 00:41:44 +00:00
Jonathan Desrosiers
256a0eea8a Bundled Themes: Revert the [51372] update to block patterns in bundled themes.
Upon further examination, this change was not great for backwards compatibility, resulting in block validation errors when running on older versions of WordPress.

While there are currently many `console.info()` notices caused by older format block syntax being updated to the current version included in WordPress 5.8, the blocks do not break.

Block patterns do not currently have a versioning mechanism, or a means to indicate which versions of WordPress are supported.

See #53617.

git-svn-id: https://develop.svn.wordpress.org/trunk@51434 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-14 20:01:21 +00:00
Jonathan Desrosiers
906c450e94 Widgets: Prevent widgets unintentionally being moved to the inactive sidebar.
This fixes a bug where widgets are unintentionally moved to the `wp_inactive_widgets` sidebar when batch updates occur through the REST API.

When batch requests are processed, only `$_wp_sidebars_widgets is updated by previous calls to `WP_REST_Widgets_Controller::create_item()`. `$sidebars_widgets` is not aware of the new widget’s intended location, and `retrieve_widgets()` mistakenly flags the widget as inactive.

Calling `wp_get_sidebars_widgets()` before `retrieve_widgets()` ensures both global variables match and is intended as a temporary fix until the root cause of the problem can be fixed.

Props zieladam, htmgarcia, timothyblynjacobs.
Fixes #53657.

git-svn-id: https://develop.svn.wordpress.org/trunk@51432 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-14 16:44:59 +00:00
Jonathan Desrosiers
9f760e96b4 Privacy: Ensure the copy button actually copies the suggested privacy policy text.
Follow up to [50609].

Props walbo, SergeyBiryukov.
Fixes #53652. See #52891.

git-svn-id: https://develop.svn.wordpress.org/trunk@51431 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-14 16:16:41 +00:00
Sergey Biryukov
4eb17be18c Docs: Synchronize the $post_id argument description for some post and attachment functions.
See #53399.

git-svn-id: https://develop.svn.wordpress.org/trunk@51430 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-14 08:12:24 +00:00
Jonathan Desrosiers
a828773635 Editor: Second round of package updates ahead of RC3.
Props ellatrix, peterwilsoncc, get_dave, mcsf, talldanwp, youknowriad, desrosj.

git-svn-id: https://develop.svn.wordpress.org/trunk@51426 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 23:56:18 +00:00
Sergey Biryukov
96d3c4c5e5 Docs: Correct documentation for wp_get_post_parent_id().
The `$post` parameter is required and does not have a default value.

Follow-up to [42397].

Props denisco.
See #53399.

git-svn-id: https://develop.svn.wordpress.org/trunk@51425 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 18:33:10 +00:00
Jonathan Desrosiers
7cb4cc175b Coding Standards: Use the correct formatting for multi-line comments.
Follow up to [51414].

git-svn-id: https://develop.svn.wordpress.org/trunk@51423 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 18:01:58 +00:00
Riad Benguella
bed9d00fbd Block Editor: Include the fixes targetted for WordPress 5.8 RC3.
This includes the following fixes:
 - Safari: see if compositing layer size is more reasonable when position fixed divs are not inserted into content.
 - Site Logo Block: update Site Logo block UI and option syncing.
 - Fix moving inner blocks in the Widgets Customizer.
 - Allow themes to provide empty values for color.duotone and spacing.units
 - Update getTermsInfo() to workaround parsing issue for translatable strings.
 - Specify what settings can be part of settings.layout.
 - Update conditions to hide duotone panel.
 - Prevent entering invalid values in the Query Loop block config.
 - Prevent color panel from showing as empty.
 - Avoid calling gutenberg_ functions within code shipped through WordPress Core.

Props desrosj.
See #53397.


git-svn-id: https://develop.svn.wordpress.org/trunk@51421 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 16:39:05 +00:00
Kelly Choyce-Dwan
16d538c0f8 Help/About: Update the About page for 5.8.
Use a larger image for theme.json on retina screens, and update the spacing of sections on the page.

Props javiarce.
See #52775.



git-svn-id: https://develop.svn.wordpress.org/trunk@51418 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 15:38:12 +00:00
Mike Schroder
84a22c3f98 Customizer: Don’t always set normalizedTransitionendEventName to null.
Reverts [51389].

Unprops mikeschroder.
See #53562.



git-svn-id: https://develop.svn.wordpress.org/trunk@51417 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 14:03:19 +00:00
Peter Wilson
4d616c6665 Widgets: Validate HTML before saving block widgets.
Props talldanwp, noisysocks, kevin940726, peterwilsoncc.


git-svn-id: https://develop.svn.wordpress.org/trunk@51414 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 05:57:04 +00:00
Kelly Choyce-Dwan
7447f866f7 Help/About: Update the About section for 5.8.
Update the image links to use the CDN. Use regular text color for headings. Fix two string issues. Remove unnecessary `wp-components` script & style.

Props nao, audrasjb, karmatosed, desrosj, javiarce, milana_cap.
See #52775.



git-svn-id: https://develop.svn.wordpress.org/trunk@51413 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 00:11:42 +00:00
Jonathan Desrosiers
1bdfffbca3 Docs: Various documentation fixes following [51129].
- Typo corrections in filter descriptions.
- DocBlocks are now now wrapped to the next line after 80 characters, and not extending beyond 120 total characters wide.
- Remove unnecessary repeated references to the suggested replacement hooks.
- Adjustments to the indentation for consistency with other emails in Core, allowing the `phpcs:ignore` comment to be removed.

Props SergeyBiryukov.
Fixes #44314.

git-svn-id: https://develop.svn.wordpress.org/trunk@51410 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-13 00:02:00 +00:00
Jonathan Desrosiers
c732027e76 Widgets: Replace wp.editor references in the legacy text widget.
This changes the references to `wp.editor` in the text widget’s JavaScript to `wp.oldEditor`, which is the new location for the old `editor` script that was previously available at `window.wp.editor`. 

Follow up to [51387-51388,51390].

Props spacedmonkey, zieladam.
Fixes #53437.

git-svn-id: https://develop.svn.wordpress.org/trunk@51409 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-12 23:56:39 +00:00
Jonathan Desrosiers
daea174b3f Widgets: Use wp_sidebar_description() to retrieve a sidebar’s description.
This switches `WP_REST_Sidebars_Controller` to use `wp_sidebar_description()` for retrieving the `description` of a given sidebar instead of referencing the value in the `$wp_registered_sidebars` global variable directly.

`wp_sidebar_description()` uses `wp_kses()` to only allow the default list of `$allowed_tags` to be present in a sidebar’s `description`.

Props timothyblynjacobs, desrosj.
Fixes #53646.

git-svn-id: https://develop.svn.wordpress.org/trunk@51408 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-12 19:02:53 +00:00
Andrew Ozz
2ebdfc16eb TinyMCE: ensure initialization runs in all cases on 'interactive' and 'complete' readyState. Fixes a rare bug when the init code is inserted in the DOM after the page has finished loading.
Props Collizo4sky, azaozz.
Fixes #53632.

git-svn-id: https://develop.svn.wordpress.org/trunk@51402 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-10 23:57:43 +00:00
Sergey Biryukov
e618a5b859 Twenty Fifteen: Use strict comparison in inc/custom-header.php.
Props kapilpaul.
See #53359.

git-svn-id: https://develop.svn.wordpress.org/trunk@51401 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-10 18:42:36 +00:00
Sergey Biryukov
ec70bebfb4 Bundled Themes: Correct comment formatting in inc/block-patterns.php.
Follow-up to [51045], [51103].

Props kapilpaul.
See #53359, #52627.

git-svn-id: https://develop.svn.wordpress.org/trunk@51400 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-10 18:39:19 +00:00
Sergey Biryukov
b3d49483df Coding Standards: Rename the $ID variable to $user_id in wp_insert_user() and wp_update_user().
This fixes a "Variable `$ID` is not in valid snake_case format" WPCS warning.

Follow-up to [2872].

See #53359.

git-svn-id: https://develop.svn.wordpress.org/trunk@51399 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-10 12:20:55 +00:00
Sergey Biryukov
03fa1062f2 Users: Return earlier from wp_update_user() in case of error.
This ensures that if the `wp_insert_user()` call resulted in a `WP_Error` object, it is returned right away without any further actions.

Follow-up to [32820].

Fixes #53627.

git-svn-id: https://develop.svn.wordpress.org/trunk@51398 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-10 12:00:01 +00:00
Sergey Biryukov
cf7cc2843b Code Modernization: Only check collation in wpdb methods if the query is not empty.
This avoids a deprecation notice on PHP 8.1 caused by passing `null` instead of a string to `ltrim()` in `wpdb::check_safe_collation()`, and maintains the current behaviour.

Follow-up to [30345], [32162], [33455].

See #53635.

git-svn-id: https://develop.svn.wordpress.org/trunk@51396 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-10 11:14:46 +00:00
Sergey Biryukov
f81cd31166 Coding Standards: Add missing semicolon to endforeach keywords in media templates.
Follow-up to [27411], [27440].

Props vishitshah, mukesh27, nielslange, sabernhardt.
Fixes #46103.

git-svn-id: https://develop.svn.wordpress.org/trunk@51395 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-10 10:39:44 +00:00
Sergey Biryukov
2999960f51 I18N: Translate _doing_it_wrong() messages in wp_check_widget_editor_deps().
This makes them consistent with other similar messages in core.

Follow-up to [51387], [51388], [51390].

See #53437, #53569.

git-svn-id: https://develop.svn.wordpress.org/trunk@51391 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-09 10:56:49 +00:00
Sergey Biryukov
c7be2d875e Docs: Some documentation improvements for wp_check_widget_editor_deps():
* Add missing short description for the function.
* Correct function names in `_doing_it_wrong()` calls.
* Document the usage of `$wp_scripts` and `$wp_styles` globals.
* Update syntax for multi-line comment per the documentation standards.

Follow-up to [51387], [51388].

See #53437, #53569.

git-svn-id: https://develop.svn.wordpress.org/trunk@51390 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-09 10:49:15 +00:00
Mike Schroder
7de1b7c0ae Customizer: Skip animations when they have no duration.
In addition to skipping animations when a related style doesn't Exist, now checks to see if animation styles are Empty as well.

This resolves a case where the Gutenberg End to End tests were failing, due to running with animations disabled.

This change should also help some users who are intentionally overriding styles to remove animations.

See https://github.com/WordPress/gutenberg/issues/32024 for the original Gutenberg issue.

Props zieladam, isabel_brison, kevin940726, desrosj, mikeschroder.
Fixes #53562.
See #53542.

git-svn-id: https://develop.svn.wordpress.org/trunk@51389 602fd350-edb4-49c9-b593-d223f7449a82
2021-07-09 08:12:29 +00:00