Commit Graph

436 Commits

Author SHA1 Message Date
Sergey Biryukov
39d55fddb8 Use get_current_site() instead of the $current_site global when possible.
props jeremyfelt.
fixes #25158.

git-svn-id: https://develop.svn.wordpress.org/trunk@26120 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 03:22:48 +00:00
Sergey Biryukov
7cd8d225a3 Use case-insensitive comparison for email addresses. fixes #25779.
git-svn-id: https://develop.svn.wordpress.org/trunk@26115 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 02:40:28 +00:00
Sergey Biryukov
c7c382b077 Avoid PHP notices in wp_notify_postauthor() when using a custom comment type.
Use a switch statement for consistency with wp_notify_moderator().

fixes #25880.

git-svn-id: https://develop.svn.wordpress.org/trunk@26114 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 02:31:15 +00:00
Andrew Nacin
b1dfc8ef61 Mark zxcvbn global to avoid JSHint errors.
props jorbin.
fixes #25911.


git-svn-id: https://develop.svn.wordpress.org/trunk@26111 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-12 23:42:17 +00:00
Andrew Nacin
d416108af5 Use CSSJanus via a Grunt task to generate right-to-left CSS.
RTL files are now created on build for core CSS files. These files replace the LTR file completely, rather than being in addition to the existing LTR file.

Benefits:
 * For the user: less CSS is served in RTL, less HTTP requests on the frontend, and less work for the browser.
 * For the core developer: Let the tools do the work.

Notes for core development:
 * The file generation task is `grunt rtl`.
 * `grunt watch` now handles generating RTL files in /build when a CSS file in /src is saved.
 * /src is now locked to LTR. RTL testing must occur via /build. When attempting to run an RTL text direction with /src, an admin notice will display.

Expect RTL bugs. Please report them.

props yoavf.
see #24977.


git-svn-id: https://develop.svn.wordpress.org/trunk@26107 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-12 21:18:45 +00:00
Scott Taylor
5f1180ca0f Change nofollow to follow in wp_robots_noindex(). "The noindex is fine, the nofollow stops any link equity from that URL, so that's actually a bad idea."
Props joostdevalk.
Fixes #22876.



git-svn-id: https://develop.svn.wordpress.org/trunk@26096 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-11 22:26:33 +00:00
Scott Taylor
2ccc101050 Make HTML tag searches for <code> and <pre> case-insensitive in make_clickable().
Props bpetty.
Fixes #23756.



git-svn-id: https://develop.svn.wordpress.org/trunk@26094 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-11 21:53:08 +00:00
Scott Taylor
95a00fb920 Fix canonical redirection of cat as described in #15256 by rolling the cat query var into tax_query, instead of category__in / category__not_in. Top-level categories were only redirecting properly if they had no children.
All unit tests pass. Tests marked for #15256 are no longer skipped.

Fixes #15256.
Props dd32.



git-svn-id: https://develop.svn.wordpress.org/trunk@26090 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-11 18:35:21 +00:00
Sergey Biryukov
a2aed7b119 Fix docblock formatting. fixes #25893.
git-svn-id: https://develop.svn.wordpress.org/trunk@26081 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-11 13:31:19 +00:00
Helen Hou-Sandi
b0c601170c Add spinner images that were inadvertently left out of [26072]. see #25858.
git-svn-id: https://develop.svn.wordpress.org/trunk@26073 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-10 00:39:38 +00:00
Helen Hou-Sandi
17287af965 Say hello to a fresh new look for the WordPress admin.
Still to come: more color schemes, a responsive component, and more.

see #25858.
props iammattthomas, tillkruess, EmpireOfLight, melchoyce, ryelle, joen, mitchoyoshitaka, sirbrillig, andypeatling, isaackeyet, Otto42, dd32, matt, helen.


git-svn-id: https://develop.svn.wordpress.org/trunk@26072 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-10 00:26:50 +00:00
Sergey Biryukov
82878e0859 Add @return for WP_Query::parse_search(). props tivnet. fixes #25894.
git-svn-id: https://develop.svn.wordpress.org/trunk@26061 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-09 16:04:02 +00:00
Sergey Biryukov
8a87a2345b Declare the variable before using it. props tivnet. fixes #25895 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@26060 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-09 15:52:30 +00:00
Scott Taylor
047f7fb8bd Produce proper CAST for DECIMAL and NUMERIC in Meta Query. Adds a bunch of unit tests.
Props ericlewis.
Fixes #23033.



git-svn-id: https://develop.svn.wordpress.org/trunk@26055 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 23:10:41 +00:00
Scott Taylor
cc19bb3a57 Respect the compare operator value in meta_query when value evaluates to null. Adds Unit Test.
Props bradyvercher, gradyetc.
Fixes #22967.



git-svn-id: https://develop.svn.wordpress.org/trunk@26053 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 22:51:03 +00:00
Scott Taylor
0670cf7cc4 Don't convert URLs inside <pre> and <code> tags when parsing string using make_clickable().
Adds Unit Tests.

Props johnjamesjacoby, helen, nacin, adamsilverstein, sirbrillig. 
Fixes #23756.



git-svn-id: https://develop.svn.wordpress.org/trunk@26052 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 22:37:41 +00:00
Sergey Biryukov
9f9bc20bde Remove old debug comment. props nofearinc. fixes #25865.
git-svn-id: https://develop.svn.wordpress.org/trunk@26051 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 22:23:58 +00:00
Scott Taylor
2a8b83fbb0 Split the content to balance open tags when <!--nextpage--> and <!--more.*?--> are used. Needs filter inline docs. The 4 unit tests that were previously failing for ticket 6297 now pass.
See #6297. 
Props devesine.



git-svn-id: https://develop.svn.wordpress.org/trunk@26050 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 22:21:02 +00:00
Dion Hulse
deda988368 Add some missing braces to get_bookmarks() which was causing an early return. Introduced in [25934]. See #25468. Fixes #25874
git-svn-id: https://develop.svn.wordpress.org/trunk@26046 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 02:19:22 +00:00
Sergey Biryukov
bc9ca186e5 Add missing semicolon after wpLink object definition. props mt8.biz. fixes #25862.
git-svn-id: https://develop.svn.wordpress.org/trunk@26033 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 10:41:15 +00:00
Dion Hulse
24c2774076 Fix a case where wp_guess_url() would leave a prefixed path in the generated URL when symlinks were involved. Fixes #25797
git-svn-id: https://develop.svn.wordpress.org/trunk@26031 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 03:33:11 +00:00
Sergey Biryukov
fc8d09e2a6 A negative term parent value should be sanitized to 0, not 1. Fix a regression in sanitize_term_field() caused by [26010].
props mattheu for initial patch.
fixes #25852.

git-svn-id: https://develop.svn.wordpress.org/trunk@26028 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 23:40:46 +00:00
Sergey Biryukov
cd7deb0e7b Make Twenty Fourteen the default theme. props markmcwilliams. fixes #25702.
git-svn-id: https://develop.svn.wordpress.org/trunk@26024 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 20:01:54 +00:00
Sergey Biryukov
3d26edf1fe Remove irrelevant @see references. props mt8.biz. fixes #25843.
git-svn-id: https://develop.svn.wordpress.org/trunk@26022 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 10:16:55 +00:00
Scott Taylor
d8f57f88ad Respect paged when offset is used in WP_Query. Adds unit tests.
Props coffee2code.
Fixes #18897.



git-svn-id: https://develop.svn.wordpress.org/trunk@26012 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 01:34:44 +00:00
Scott Taylor
ed22220a0f Cast proper fields to int when returning from wp_get_object_terms(). Add term_taxonomy_id and object_id to the list in sanitize_term() and sanitize_term_field().
Fixes #17646. Adds unit tests.
Props simonwheatley, dd32, kovshenin.



git-svn-id: https://develop.svn.wordpress.org/trunk@26010 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 01:18:02 +00:00
Scott Taylor
67443e080c Don't globalize version variables twice. See #23685.
git-svn-id: https://develop.svn.wordpress.org/trunk@26009 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 00:57:52 +00:00
Scott Taylor
268667e170 When WordPress is loaded in a function (e.g. unit tests) the variables initialized at the top level aren't globals, but we expect them to be. Explicitly make the version variables global.
Props nbachiyski.
Fixes #23685.



git-svn-id: https://develop.svn.wordpress.org/trunk@26008 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 00:23:38 +00:00
Scott Taylor
0923b7b93a Category and tag are typically checked before checking for a custom taxonomy. If the global query matches category or tag (even if it also has tax_query set), return category/tag as the queried object, instead of arbitrarily returning the first term in the tax_query stack (typically those added with 'pre_get_posts').
Real world example: http://www.emusic.com/17dots/topics/daily-download/ - "tag" page, regionalized for US-only content using `pre_get_posts` passing in the terms "US" and "ALL" for "region" (custom tax). All of the theme functions would output "ALL" as the term name. Even though it was a tag archive, the queried object was an arbitrary term from `tax_query`.

See [26006]. All unit tests pass.
Fixes #20767.




git-svn-id: https://develop.svn.wordpress.org/trunk@26007 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 23:53:55 +00:00
Scott Taylor
5321bc4957 WP_UnitTestCase::go_to() tried its best to clean up global space, but ultimately fell short. Because it was blowing away WP every time it was called, it was dropping all the query vars that were registered for custom taxonomies and custom post types (ouch).
Introduces `_cleanup_query_vars()`. This is a prerequisite for the unit tests on #20767. All unit tests pass with this change.

See #20767.
Fixes #25818.



git-svn-id: https://develop.svn.wordpress.org/trunk@26006 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 22:46:44 +00:00
Sergey Biryukov
acc8ac64b8 Fall back to comment author email in get_avatar() if the user who left the comment no longer exists.
props mauryaratan, lite3.
fixes #25803.

git-svn-id: https://develop.svn.wordpress.org/trunk@26000 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-02 12:19:43 +00:00
Sergey Biryukov
3c625347e6 Correct $user_id parameter description. props mauryaratan, Corphi. fixes #25774.
git-svn-id: https://develop.svn.wordpress.org/trunk@25997 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 20:17:21 +00:00
Andrew Nacin
90202aed35 Explicitly globalize $is_nginx in vars.php.
props johnjamesjacoby.
fixes #25776.


git-svn-id: https://develop.svn.wordpress.org/trunk@25996 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 19:36:39 +00:00
Sergey Biryukov
bc6c0c9b0f Correct @since values for various hooks. fixes #25766.
git-svn-id: https://develop.svn.wordpress.org/trunk@25991 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 03:19:16 +00:00
Sergey Biryukov
a1fe0926b3 Remove incorrect @return value from status_header(). Rename some variables for clarity.
props tivnet for initial patch.
fixes #25451.

git-svn-id: https://develop.svn.wordpress.org/trunk@25990 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 22:43:08 +00:00
Andrew Nacin
23ad7058fb Internal linking: Remove explicit orderby, thus allowing the relevancy improvements in #7394 to work.
see #25763.


git-svn-id: https://develop.svn.wordpress.org/trunk@25988 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 21:20:59 +00:00
Andrew Nacin
1cce2a89fd PHP4 compatibility for files loaded before we bail. fixes #25760.
git-svn-id: https://develop.svn.wordpress.org/trunk@25986 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 20:05:16 +00:00
Sergey Biryukov
e3e3e1d109 Remove docs suggesting that wp_insert_user() can be used to update an existing user. wp_update_user() should be used instead. fixes #25745.
git-svn-id: https://develop.svn.wordpress.org/trunk@25978 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 14:31:07 +00:00
Andrew Nacin
2cac0fde8a Avoid resetting the 'hierarchical' argument in get_pages() when 'parent' is -1, the default.
Fixes a regression introduced in [25270]. Adds unit tests.

props chrisbliss18.
fixes #25750.


git-svn-id: https://develop.svn.wordpress.org/trunk@25974 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 01:46:01 +00:00
Sergey Biryukov
9a5e8acead Restore @see get_next_post_link() reference and move it to next_post_link(). see #25743.
git-svn-id: https://develop.svn.wordpress.org/trunk@25966 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 11:10:28 +00:00
Sergey Biryukov
5674a54940 Fix a copy/paste error in get_next_post_link() description and $format argument. props jim912, ounziw. fixes #25743.
git-svn-id: https://develop.svn.wordpress.org/trunk@25965 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 11:05:26 +00:00
Andrew Nacin
add8bc4e57 Add a $taxonomy argument to each of the adjacent post functions.
Each took an array of category (IDs) when to search. Those can now be term IDs and each function now has $taxonomy = 'category' as an optional argument.

Functions affected: get_previous_post(), get_next_post(), get_adjacent_post(), get_adjacent_post_rel_link(), adjacent_posts_rel_link(), next_post_rel_link(), prev_post_rel_link(), get_boundary_post(), get_previous_post_link(), previous_post_link(), get_next_post_link(), next_post_link(), get_adjacent_post_link(), adjacent_post_link().

props ethitter.
finally fixes #17807.


git-svn-id: https://develop.svn.wordpress.org/trunk@25959 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 21:39:51 +00:00
Andrew Nacin
1694272bff When an HTTPS request to api.wordpress.org fails, try an insecure HTTP request and issue a warning.
Certain versions of cURL appear to claim OpenSSL support but fail to work. We need to not trap users on older versions while we work this out, and instead fall back to an insecure request.

see #25716 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25956 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 21:08:25 +00:00
Andrew Nacin
47c58004fe Query stopwords: Only eliminate single A-Z letters as search terms.
Stop trying to match any single letters that are not East Asian characters, as this requires PCRE with UTF-8 support; and because it doesn't actually work.

fixes #25709.


git-svn-id: https://develop.svn.wordpress.org/trunk@25954 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 20:50:31 +00:00
Drew Jaynes
1c625a49ac Inline documentation for hooks in wp-includes/functions.wp-styles.php.
Props admiralthrawn.
Fixes #25722.


git-svn-id: https://develop.svn.wordpress.org/trunk@25950 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 17:58:32 +00:00
Drew Jaynes
1c127e99bd Inline documentation for hooks in wp-includes/functions.wp-scripts.php.
Props ninio for the initial patch.
Fixes #25720.


git-svn-id: https://develop.svn.wordpress.org/trunk@25949 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 17:50:38 +00:00
Helen Hou-Sandi
b2e15261ba Allow passing false for the meta_box_cb arg in register_taxonomy() to turn off the meta box display entirely. fixes #21543.
git-svn-id: https://develop.svn.wordpress.org/trunk@25948 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 16:28:19 +00:00
Drew Jaynes
5f3883cc8f Revert another instance where a WP property was assigned to a one-time variable for inline docs purposes.
Referencing a non-existent variable only in the docs here would have been the better choice.

See #25495.


git-svn-id: https://develop.svn.wordpress.org/trunk@25946 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 07:58:24 +00:00
Drew Jaynes
0969689efb Fix error introduced in [25940] where $public_query_vars should have only been used as a non-existent inline docs variable in the query_vars filter.
Restores `$this->public_query_vars` to the `query_vars` filter in wp-includes/class-wp.php.

Props mauryaratan.
Fixes #25495. See #25719.


git-svn-id: https://develop.svn.wordpress.org/trunk@25945 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 07:48:34 +00:00
Andrew Ozz
0bb0c068ef Bump the TinyMCE version for 3.8, see #25700.
git-svn-id: https://develop.svn.wordpress.org/trunk@25944 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-26 21:44:39 +00:00