vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
32,030 Commits 1 Branch 0 Tags 243 MiB
39ff95f883
Commit Graph

213 Commits

Author SHA1 Message Date
Drew Jaynes
843cdf1f73 Docs: Update an inline comment in wp_get_attachment_image_sizes(), which came in as part of the Responsive Images merge in [34855]. 
Props joemcgill.
See #33641.


git-svn-id: https://develop.svn.wordpress.org/trunk@34876 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-06 17:46:30 +00:00
Scott Taylor
fabd554bb2 Merge the Responsive Images feature plugin into core, initial commit. See: https://github.com/ResponsiveImagesCG/wp-tevko-responsive-images/ 
New functions in `media.php`:
* `wp_get_attachment_image_srcset_array()` - Returns an array of image candidate string data used to build a `srcset` value for an attachment given an `$attachement_id` and `$size`.
* `wp_get_attachment_image_srcset()` - Returns the `srcset` value for an attachment given an `$attachement_id` and `$size`.
* `wp_get_attachment_image_sizes()` - Returns the `sizes` value for an attachment given an `$attachement_id` and `$size` and optional arguments used to alter its output.
* `wp_make_content_images_responsive()` - A display filter for adding `srcset` and `sizes` to images embedded in content.
* `wp_img_add_srcset_and_sizes()` - A utility function used by `wp_make_content_images_responsive()` to add `srcset` and `sizes` to a single `<img>` element.

Modifies existing core functions:
* Modify `wp_get_attachment_image()` so the HTML returned for an image includes `srcset` and `sizes`.
* Modify `get_media_embedded_in_content()` (sup, 3.6 leftover) by adding `<img>` to the list of accepted tags that can be matched in content. This is used in `wp_make_content_images_responsive()` to find all of the images embedded in content before passing them off to `wp_img_add_srcset_and_sizes()`.

Tests:
* Add a new factory method to `WP_UnitTest_Factory_For_Attachment` named `create_upload_object()`
* Adds unit tests
* Updates unit tests

Props joemcgill, tevko, jaspermdegroot, mdmcginn, barryceelen, peterwilsoncc, fsylum, wonderboymusic, chriscoyier, benjaminpick, jrfnl, #12kingkool68, janhenckens, ryanmarkel, side777, ryelle, wturrell, micahmills, mattbagwell, coliff, DrewAPicture.
See #33641.


git-svn-id: https://develop.svn.wordpress.org/trunk@34855 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-06 04:58:21 +00:00
Scott Taylor
3eb876d7e9 Embeds: move some functions from media.php to a new file, embed-functions.php, via svn cp 
See #32522.


git-svn-id: https://develop.svn.wordpress.org/trunk@34851 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-06 03:58:42 +00:00
Scott Taylor
9d0f206ee1 After [34629], use $size_class instead of $size. 
See #32093.


git-svn-id: https://develop.svn.wordpress.org/trunk@34657 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-28 02:49:05 +00:00
Scott Taylor
b45a72a67c Add size-$size class to <img> in wp_get_attachment_image(). 
Fixes #32093.


git-svn-id: https://develop.svn.wordpress.org/trunk@34629 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-27 17:54:01 +00:00
John Blackbourn
1bb2876fe6 callback is not a valid type in PHP, PSR-5, or phpDocumentor. callable should be used instead. 
Fixes #34032


git-svn-id: https://develop.svn.wordpress.org/trunk@34566 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 23:57:46 +00:00
Scott Taylor
d98165d1c3 Media Modal: move the translation strings for insertIntoPost and uploadedToThisPost to the get_post_type_labels() array as insert_into_item and uploaded_to_this_item. 
Props flixos90.
Fixes #33616.


git-svn-id: https://develop.svn.wordpress.org/trunk@34472 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:21:11 +00:00
Scott Taylor
000b9e2fb3 Include fourth array parameter in return value doc block for wp_get_attachment_image_src(). 
Props kadamwhite.
Fixes #33905.


git-svn-id: https://develop.svn.wordpress.org/trunk@34470 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:13:08 +00:00
Scott Taylor
3c0ecff16e Media: Add a new function, wp_get_attachment_image_url(), which is a shortcut for wp_get_attachment_image_src() - same function signature, but returns just the URL based on $size. 
Adds unit test.

Props dipesh.kakadiya, swissspidy, sebastian.pisula.
Fixes #33878.


git-svn-id: https://develop.svn.wordpress.org/trunk@34372 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:12:44 +00:00
Drew Jaynes
f9e45047c1 Docs: Add a more complete return description for the array of data (or false) returned by image_downsize(). 
If not short-circuited via the `image_downsize` boolean filter, `image_downsize()` returns an array of data including the image URL, width, height, and whether the image size is intermediate, in that order. Otherwise, it returns false.

Fixes #30636.


git-svn-id: https://develop.svn.wordpress.org/trunk@34362 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 10:21:48 +00:00
Scott Taylor
8861e38966 Media: Ensure that HTML5 captions apply the 'img_caption_shortcode_width'. 
Props joemcgill.
Fixes #31053.


git-svn-id: https://develop.svn.wordpress.org/trunk@34261 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 06:03:11 +00:00
Scott Taylor
2e7277b733 Media: In wp_prepare_attachment_for_js(), don't call file_exists() and filesize() to retrieve $bytes if the data is already present in $meta. This is how the same code in attachment_submitbox_metadata() already works. 
Props polevaultweb.
Fixes #33214.


git-svn-id: https://develop.svn.wordpress.org/trunk@34258 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 05:02:52 +00:00
Scott Taylor
577fea566a Don't ever use the guid value when retrieving URLs for media, use wp_get_attachment_url(). Use get_attached_file() for path to file. 
Fixes #33386.


git-svn-id: https://develop.svn.wordpress.org/trunk@34163 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 02:49:12 +00:00
Nikolay Bachiyski
c430a82236 Shortcodes: don't allow unclosed HTML elements in attributes 
git-svn-id: https://develop.svn.wordpress.org/trunk@34134 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:35:22 +00:00
Scott Taylor
a4a469d887 After [33843], update the location of some files in This filter is documented in docs 
Props dimadin.
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33954 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-08 22:16:57 +00:00
Sergey Biryukov
622032fece Make curly quotes in playlist item title translatable. 
fixes #33391.

git-svn-id: https://develop.svn.wordpress.org/trunk@33844 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 13:49:57 +00:00
Scott Taylor
c4b8ad087f Improve the reliability of the crop returned by image_get_intermediate_size(). 
Add a bunch of unit tests to `tests/image/intermediate_size.php`.

Props joemcgill, ericlewis, kitchin, SergeyBiryukov, chipbennett.
Fixes #17626.


git-svn-id: https://develop.svn.wordpress.org/trunk@33807 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 02:40:40 +00:00
Scott Taylor
a70e0183e5 Ensure that attachment_url_to_postid() matches cross-scheme when front-end and back-end schemes are different. 
Adds unit test.

Props welcher.
Fixes #33109.


git-svn-id: https://develop.svn.wordpress.org/trunk@33705 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 16:38:09 +00:00
Scott Taylor
80b6f4efca Playlists, for .wp-playlist-item-title elements: move the curly quotes to CSS pseudo-element content, making them easier to override or remove. 
Fixes #33391.


git-svn-id: https://develop.svn.wordpress.org/trunk@33643 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 05:50:23 +00:00
Helen Hou-Sandi
6b1733c01c Ensure the caption shortcode outputs a valid HTML ID. 
fixes #33179.


git-svn-id: https://develop.svn.wordpress.org/trunk@33489 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 17:58:06 +00:00
Scott Taylor
f8841653ef wp_audio|video_shortcode() doesn't allow you to pass id, the docs shall reflect that. 
Props thorbrink.
See #32855.


git-svn-id: https://develop.svn.wordpress.org/trunk@33025 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-01 15:00:54 +00:00
Konstantin Obenland
b04ea26df1 After [32866], change filter name. 
While filter names generally don't have to be tied to the function in which they 
are applied, the API for media display generally seems to use the
`wp_get_attachment_*` pattern.

Props DrewAPicture.
Fixes #32363.



git-svn-id: https://develop.svn.wordpress.org/trunk@33018 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-01 03:46:23 +00:00
Scott Taylor
afd45937eb After [32866], fix doc blocks. 
Props DrewAPicture.
See #32363.


git-svn-id: https://develop.svn.wordpress.org/trunk@32949 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-25 21:01:56 +00:00
Scott Taylor
6cded9493a In wp_prepare_attachment_for_js(), when setting filename, call wp_basename() on the result of get_attached_file(), not WP_Post->guid. guid can be set to the result get_permalink(), which is not a file path. 
Props daxelrod.
Fixes #32531.


git-svn-id: https://develop.svn.wordpress.org/trunk@32914 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-23 18:29:44 +00:00
Scott Taylor
9123db3dcb Add a filter in wp_get_attachment_image_src() called attachment_image_src. 
Props eclev91, MikeHansenMe.
Fixes #32363.


git-svn-id: https://develop.svn.wordpress.org/trunk@32866 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-19 21:26:30 +00:00
Scott Taylor
7dd8a1364a In the youtube_embed_url embed handler, make embed a non-capturing group that alternately matches for v - YouTube supports both URL paths. 
Add unit test cases.

Props dmchale for some patch work.
Fixes #32161.


git-svn-id: https://develop.svn.wordpress.org/trunk@32787 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-16 00:34:06 +00:00
Sergey Biryukov
3aad7082a3 Avoid a PHP notice in wp_enqueue_media() if $post is null. 
see #19257.

git-svn-id: https://develop.svn.wordpress.org/trunk@32675 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-31 21:53:35 +00:00
John Blackbourn
68e76c1bbf Remove an embed handler accidentally introduced in r32673. 
git-svn-id: https://develop.svn.wordpress.org/trunk@32674 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-31 16:55:29 +00:00
John Blackbourn
87d5aefe74 Introduce featured_image, set_featured_image, remove_featured_image, and use_featured_image post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases. 
Props johnbillion, mordauk, valendesigns.
Fixes #19257.


git-svn-id: https://develop.svn.wordpress.org/trunk@32673 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-31 16:53:12 +00:00
Scott Taylor
0a892c11c8 Fix doc blocks for media*.php 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32609 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-26 19:22:12 +00:00
Dominik Schilling (ocean90)
9cddb0f012 Rename get_media_embedded_in_content_allowed filter to media_embedded_in_content_allowed_types. 
The new name fits better with some other `_allowed_` filters.

props DrewAPicture.
fixes #26675.

git-svn-id: https://develop.svn.wordpress.org/trunk@32113 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-11 21:48:22 +00:00
Drew Jaynes
2b774bf447 Remove unneeded spaces in the hook doc for the attachment_url_to_postid filter. 
See [31867]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32043 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-05 16:06:02 +00:00
Andrew Ozz
fc1d327261 Introduce attachment_url_to_postid filter to let plugins manage the uploads location better. 
Props mattwiebe. Fixes #31717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31867 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-23 17:23:27 +00:00
Drew Jaynes
34a7cdf926 Add hook documentation for the get_media_embedded_in_content_allowed filter, introduced in [31574]. 
Props valendesigns.
Fixes #26675.


git-svn-id: https://develop.svn.wordpress.org/trunk@31851 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-20 19:28:30 +00:00
Scott Taylor
42bcec5061 Introduce a function, wp_attachment_is( $type, $post = 0 ), to collapse the logic for determining whether an attachment is an image, audio, or video. 
This is admittedly a first pass. There needs to be a generic handler for when any other type is passed, but for now it accepts the whitelist.

See #25275.


git-svn-id: https://develop.svn.wordpress.org/trunk@31645 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-06 20:25:09 +00:00
Scott Taylor
65c58832cb Improve get_media_embedded_in_content() so that it returns the media it finds in the same order that it appears in the content. 
Adds unit test, updates another.

Props kopepasah.
See #26675.


git-svn-id: https://develop.svn.wordpress.org/trunk@31574 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-27 16:11:00 +00:00
Drew Jaynes
d44289d6de Clarify a wide variety of function, parameter, and return descriptions in DocBlocks throughout wp-includes/media.php. 
Props stevegrunwell, DrewAPicture.
Fixes #28408.


git-svn-id: https://develop.svn.wordpress.org/trunk@31530 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-24 07:41:24 +00:00
Drew Jaynes (DrewAPicture)
0c783b06fb Add changelog entries to the post_gallery and post_playlist hook docs for the $instance variable that was added in [31304]. 
Props ninnypants for the initial patch.
Fixes #31151.


git-svn-id: https://develop.svn.wordpress.org/trunk@31309 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-31 00:32:09 +00:00
Sergey Biryukov
14c3492ff5 Rename $instances to $instance in wp_audio_shortcode() and wp_video_shortcode() for consistency with gallery_shortcode() and wp_playlist_shortcode(). 
see #31151.

git-svn-id: https://develop.svn.wordpress.org/trunk@31305 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-30 16:05:52 +00:00
Sergey Biryukov
45b0513c1b Pass the current shortcode instance ID to post_gallery and post_playlist filters. 
props justincwatt.
fixes #31151.

git-svn-id: https://develop.svn.wordpress.org/trunk@31304 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-30 16:01:25 +00:00
Sergey Biryukov
a036114a4d attachment_url_to_postid() should always return an integer. 
props nathan_dawson, ashfame.
fixes #31044.

git-svn-id: https://develop.svn.wordpress.org/trunk@31239 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-18 20:32:50 +00:00
Scott Taylor
865185903b There are some random add_action() and add_filter() calls littered around some files in wp-includes/. These should be moved to wp-includes/default-filters.php with the rest of the registered hooks. It seems like this was the best practice for awhile and then we randomly stopped. This file loads way before any of the includes, so the hooks will be registered for any request that loads WordPress, even SHORTINIT - a lot of the hooks registered won't run anyways (that's already the case). 
See #30947.


git-svn-id: https://develop.svn.wordpress.org/trunk@31168 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:39:39 +00:00
Sergey Biryukov
6ffb5feab9 Make a hint on Edit Selection view in media modal more accurate, as it applies to all media files, not just images. 
props pavelevap.
see #30931.

git-svn-id: https://develop.svn.wordpress.org/trunk@31102 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:23:21 +00:00
Scott Taylor
da9057fd6d Use && instead of and in the 3 places where and was used. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31099 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:11:46 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:04:40 +00:00
Scott Taylor
186a94fb78 More-specific docs for wp_embed_handler_youtube(). 
Fixes #30711.


git-svn-id: https://develop.svn.wordpress.org/trunk@31018 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-01 19:20:44 +00:00
Scott Taylor
be8211beac Support chromeless Vimeo via MEjs: 
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
6f9a78e008/src/js/me-shim.js (L631)

Fixes #29267.


git-svn-id: https://develop.svn.wordpress.org/trunk@31016 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 20:40:05 +00:00
Scott Taylor
218dd4fd6b For clarity, initialize some arrays that previously were only assigned via short circuit in loops. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30982 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 22:46:53 +00:00
Scott Taylor
0632a3de68 Improve various @param docs. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30674 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 23:23:37 +00:00
Scott Taylor
35708f61f8 Use round() instead of floor() when resizing image dimensions. 
Updates unit tests.

Props SergeyBiryukov, kitchin.
Fixes #18532.


git-svn-id: https://develop.svn.wordpress.org/trunk@30660 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 19:53:18 +00:00