Commit Graph
195 Commits
Author SHA1 Message Date
Scott Taylor 59658c6547 All duplicate slugs across different post types.
Adds unit test.

Props mboynes, nacin.
Fixes #18962.


git-svn-id: https://develop.svn.wordpress.org/trunk@30158 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:36:23 +00:00
Scott Taylor c8acddfdc8 Improve some post_status-related documentation.
Props ericlewis.
See #30230.


git-svn-id: https://develop.svn.wordpress.org/trunk@30155 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:19:26 +00:00
Drew Jaynes (DrewAPicture) 7cd15026bd Correct references of @uses $wpdb in core documentation to use @global.
See #30191, [30105].
Fixes #30217.


git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 17:55:39 +00:00
Drew Jaynes (DrewAPicture) 3cc10d77a0 Remove redundant and erroneous @uses tag from most core inline documentation.
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.


git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 01:04:55 +00:00
Sergey Biryukov 6cbc9e03e1 When using 'show_in_menu' as a default value for 'show_in_admin_bar' in register_post_type(), cast to boolean instead of requiring a strict match.
props ipm-frommen.
fixes #30092.

git-svn-id: https://develop.svn.wordpress.org/trunk@30041 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 13:07:38 +00:00
Scott Taylor 701dce21b1 In wp_delete_attachment(): account for orphan sizes by looping over the sizes stored in metadata, instead of relying on the current sizes stored in $_wp_additional_image_sizes.
Props JoshuaAbenazer, desrosj, markoheijnen.
Fixes #24518.


git-svn-id: https://develop.svn.wordpress.org/trunk@29816 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 15:31:57 +00:00
Drew Jaynes (DrewAPicture) 191a7ead45 Add some missing information to the inline docs for get_post_types().
* Improves the `@see` reference for `register_post_type()` to mention that it contains information about accepted arguments
* Adds a description of the accepted values for the `$operator` parameter
* Fixes a typo

Fixes #29721.


git-svn-id: https://develop.svn.wordpress.org/trunk@29752 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-21 08:54:37 +00:00
Sergey Biryukov 6e0ca0d8d9 Make sure the $parent argument of wp_insert_attachment() still works as expected after [28579].
prop jesin, dikiy_forester.
fixes #29646 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29745 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-15 14:23:31 +00:00
John Blackbourn fcda873946 Correct the docblock for the registered_post_type action. Fixes #29184.
git-svn-id: https://develop.svn.wordpress.org/trunk@29468 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 21:20:58 +00:00
Scott Taylor d83ac79c38 Unbreak Media Trash after [28788].
Props SergeyBiryukov.
Fixes #29080.


git-svn-id: https://develop.svn.wordpress.org/trunk@29337 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 15:14:56 +00:00
Sergey Biryukov 7ac0669493 Avoid PHP notices in _count_posts_cache_key(), _update_blog_date_on_post_publish(), and _update_blog_date_on_post_delete() if post type is not registered.
props jesin.
fixes #28135.

git-svn-id: https://develop.svn.wordpress.org/trunk@29318 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 00:50:53 +00:00
Drew Jaynes (DrewAPicture) e347ef267d Convert default arguments documentation for get_posts() into a hash notation.
Props coffee2code for the initial patch.
See #28841.


git-svn-id: https://develop.svn.wordpress.org/trunk@29113 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 23:33:33 +00:00
Drew Jaynes (DrewAPicture) f498128aa9 Fix syntax for inline comment line endings and a few line wraps in wp-includes/post.php inline documentation.
Fixes #25412.


git-svn-id: https://develop.svn.wordpress.org/trunk@29097 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 18:34:36 +00:00
Drew Jaynes (DrewAPicture) 93130f6a29 General inline documentation improvements in wp-includes/post.php.
Final-run. Fixes #25412.


git-svn-id: https://develop.svn.wordpress.org/trunk@29094 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 11:15:49 +00:00
Drew Jaynes (DrewAPicture) 51e97631f8 General inline documentation improvements in wp-includes/post.php.
Third-run. See #25412.


git-svn-id: https://develop.svn.wordpress.org/trunk@29093 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 10:27:02 +00:00
Drew Jaynes (DrewAPicture) 479b541dd1 General inline documentation improvements in wp-includes/post.php.
Second-run. See #25412.


git-svn-id: https://develop.svn.wordpress.org/trunk@29092 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 08:15:52 +00:00
Drew Jaynes (DrewAPicture) 628141afbf Convert phpDoc for register_post_type() to use a hash notation for the $args array.
See #25412.


git-svn-id: https://develop.svn.wordpress.org/trunk@29091 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 07:55:38 +00:00
Drew Jaynes (DrewAPicture) c7171e832d General inline documentation improvements in wp-includes/post.php.
First-run. See #25412.


git-svn-id: https://develop.svn.wordpress.org/trunk@29090 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 07:00:38 +00:00
Drew Jaynes (DrewAPicture) b1b454c7a0 Remove backticks on $post variables in some short parameter descriptions.
See [28653], [28654].
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28976 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:27:54 +00:00
Drew Jaynes (DrewAPicture) 2d9bba0a5c Specify the $single parameter default for get_post_meta(). Docs spacing.
See #28708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28955 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 03:29:33 +00:00
Sergey Biryukov 65106eff1f Mark $single parameter of get_post_meta() as optional.
props netweb.
fixes #28708.

git-svn-id: https://develop.svn.wordpress.org/trunk@28954 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 03:25:28 +00:00
Sergey Biryukov 00678ab0df Notify developers when register_post_type() or register_taxonomy() fails because of post type or taxonomy key length.
props mattheweppelsheimer.
fixes #28683.

git-svn-id: https://develop.svn.wordpress.org/trunk@28902 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 21:53:35 +00:00
Scott Taylor cf67d53408 Remove obsolete wp_cache_delete('get_pages', 'posts') from clean_post_cache().
Fixes #27459.


git-svn-id: https://develop.svn.wordpress.org/trunk@28875 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 02:15:45 +00:00
Scott Taylor 304f4f5ba9 Posts in the Trash should not drag attachment pages down with them.
Props ericlewis.
Fixes #14639.


git-svn-id: https://develop.svn.wordpress.org/trunk@28791 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 19:13:39 +00:00
Scott Taylor a7c1728f2e Reinstate the changes from [28579] with some adjustments:
* Check `! empty( $postarr['file'] )` before calling `update_attached_file()`
* Add a unit test: `test_update_attachment_fields()`
* Run the same logic for empty `guid` for attachments that always ran in `wp_insert_post()`, as per #18310. This fixes a unit test that would have broken when this ticket was marked closed.
* Updated the unit test in `Tests_Media::test_wp_prepare_attachment_for_js()` to account for `url` no longer being empty

Props kovshenin, wonderboymusic.
See #21963.


git-svn-id: https://develop.svn.wordpress.org/trunk@28788 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:26:17 +00:00
Scott Taylor 84ad12b439 Replace all uses of like_escape() with $wpdb->esc_like().
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 00:43:32 +00:00
Sergey Biryukov 83bffbc6c7 Correct @return value for get_children().
props ghost1227.
fixes #28422.

git-svn-id: https://develop.svn.wordpress.org/trunk@28677 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 15:52:51 +00:00
Drew Jaynes (DrewAPicture) b884487767 Be more specific that $post_id does not default to the ID of the global $post in some cases.
See [28654]. See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28655 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-03 04:51:05 +00:00
Drew Jaynes (DrewAPicture) d068c888f3 Ensure $post_id is documented as optional where applicable.
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28654 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-03 04:43:47 +00:00
Andrew Nacin 0c7edb2045 Revert [28579] and [28582]. see #21963.
git-svn-id: https://develop.svn.wordpress.org/trunk@28601 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 18:13:55 +00:00
Scott Taylor 7f2cad1809 Fix some inline docs churn in wp_insert_post() after [28579].
Props kpdesign.
See #21963.



git-svn-id: https://develop.svn.wordpress.org/trunk@28582 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 00:23:21 +00:00
Scott Taylor 6cd28991e3 Combine wp_insert_attachment() and wp_insert_post(). wp_insert_attachment() becomes a wrapper. Update inline docs.
Props wonderboymusic, DrewAPicture.
See #21963.


git-svn-id: https://develop.svn.wordpress.org/trunk@28579 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 23:19:03 +00:00
Scott Taylor a4e1ec0b90 Fix parsing in wp_match_mime_types() to allow some mime-types with + in them to appear in the list of filter links shown above the list table on upload.php.
Props _duck.
Fixes #20672.



git-svn-id: https://develop.svn.wordpress.org/trunk@28553 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 21:35:36 +00:00
Scott Taylor 7205796cec Eliminate the use of extract() in get_pages().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28471 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 17:11:23 +00:00
Scott Taylor b76a0d791b Eliminate the use of extract() in wp_insert_attachment().
`wp_insert_attachment()` and `wp_insert_post()` are incredibly similar, but have branched logic. I have annotated many places where they diverge.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28470 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 16:53:44 +00:00
Scott Taylor 9787ea4e2a Eliminate the use of extract() in wp_insert_post().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28469 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 15:52:11 +00:00
Scott Taylor 42d6b5dd1e Eliminate use of extract() in trackback_url_list().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28382 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:43:22 +00:00
Scott Taylor 16a58e34a2 In get_pages(), $cache does not need to be reset to an empty array. update_post_cache( $pages ) takes care of priming.
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used. 

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28332 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:38:23 +00:00
John Blackbourn 2d3568380b Remove some unnecessary abstraction introduced in [28191]. See #27985.
git-svn-id: https://develop.svn.wordpress.org/trunk@28194 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-24 11:54:31 +00:00
johnbillion 34b0686be1 Avoid an expensive attachment counting query on the post editing screen. See #27985, for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28191 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-23 22:04:03 +00:00
Drew Jaynes (DrewAPicture) d2e679179b Part II of inline documentation for hooks in wp-includes/post.php.
Documents all remaining hooks following [28041] and [28042]. Also updates the hash notation style for `wp_insert_post()`.

Props nacin for several hook descriptions.

Fixes #25376.


git-svn-id: https://develop.svn.wordpress.org/trunk@28106 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 23:05:20 +00:00
Drew Jaynes (DrewAPicture) 54e59a0290 Clarify documentation for hooks in sanitize_post_field().
* `edit_post_{$field}` pairs with `edit_{$field}`
* `pre_post_{$field}` pairs with `pre_{$field}`
* `post_{$field}` pairs with `{$field}`

As the above pairs' docs are unnecessarily duplicative, the second sets of docs have been removed. Also, the "duplicates" are purposely not marked as such in this case as the hook names differ. Also remove `@deprecated` tags mistakenly left in in [28041].

See #25376.


git-svn-id: https://develop.svn.wordpress.org/trunk@28042 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 07:40:30 +00:00
Drew Jaynes (DrewAPicture) a3d04ec9ed Part I of inline documenation for hooks in wp-includes/post.php.
Adds docs for the following hooks:
* `get_attached_file`
* `update_attached_file`
* `_wp_relative_upload_path`
* `post_type_labels_{$post_type}`
* `edit_{$field}`
* `{$field_no_prefix}_edit_pre`
* `edit_post_{$field}`
* `pre_{$field}`
* `{$field_no_prefix}_save_pre`
* `pre_post_{$field}`
* `{$field}_pre`
* `$field`
* `post_{$field}`
* `wp_count_posts`
* `wp_count_attachments`
* `post_mime_types`
* `wp_insert_post_empty_content`

See #25376.


git-svn-id: https://develop.svn.wordpress.org/trunk@28041 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 06:48:32 +00:00
Drew Jaynes (DrewAPicture) 01ecedbb0d Fix the wp_count_attachments() PHPDoc to reflect that it returns an object, not array.
See #25412.


git-svn-id: https://develop.svn.wordpress.org/trunk@27807 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-28 05:42:49 +00:00
Scott Taylor 115f291221 Use wp_parse_id_list() when parsing exclude_tree in get_pages(). Add unit tests to ensure a URL string, array with string as value, and array with array as value for exclude_tree can be used to specify multiple IDs.
Props cgaffga, roothorick, hakre, tbrams for patches across the years.
Fixes #9153.



git-svn-id: https://develop.svn.wordpress.org/trunk@27767 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 01:17:41 +00:00
Helen Hou-Sandi ccc5f363c0 Use Dashicon-style images for mime type icons. Actually moving to Dashicons via the font can be explored later, but has theme/plugin implications and requires too many changes to make it for 3.9. props melchoyce for the icons. fixes #26650.
git-svn-id: https://develop.svn.wordpress.org/trunk@27726 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-25 21:09:34 +00:00
Scott Taylor 0697544056 Turn on thumbnail support for attachment:audio and attachment:video. Change conditionals to check for theme OR post type support when determining whether to turn on the Featured Image UI pieces in the admin.
Fixes #27460.



git-svn-id: https://develop.svn.wordpress.org/trunk@27657 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 02:34:39 +00:00
Drew Jaynes 5fde82be76 Better standardize parameter value types in PHPDocs where both a post ID or WP_Post would be acceptable.
Covers cases where previously only `int` or `int|object` types were notated.

Props coffee2code for the original patch.
See #20495.


git-svn-id: https://develop.svn.wordpress.org/trunk@27473 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-08 19:31:51 +00:00
Andrew Nacin 928a972fb5 Rename the new page_templates filter to theme_page_templates, and pass it a post object for proper context.
see #13265.


git-svn-id: https://develop.svn.wordpress.org/trunk@27470 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-08 04:18:30 +00:00
John Blackbourn 54ea3a0cfd Allow get_page_by_path() and get_page_by_title() to accept an array of post types. Fixes #24763. Props zbtirrell.
git-svn-id: https://develop.svn.wordpress.org/trunk@27423 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-05 22:25:31 +00:00