Commit Graph

59 Commits

Author SHA1 Message Date
Konstantin Obenland
32bcd95e37 Media: Don't indent action links if there is no media icon.
See #32254.



git-svn-id: https://develop.svn.wordpress.org/trunk@33269 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:45:55 +00:00
Konstantin Obenland
8ff5bc6f53 Media: Reduce link noise between icons and titles in list view.
Props afercia.
Fixes #32254.



git-svn-id: https://develop.svn.wordpress.org/trunk@33268 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:23:42 +00:00
Helen Hou-Sandi
3e0f839eca List tables: Better accessibility and design for the comments bubble.
It is now plain text in the comments list table's "In Response To" column, where it was visually a bit confusing to have the bubble. For other list tables, it now shows a little notification bubble with the number of pending comments. The bubble and notification become plain text in the responsive list table view. It also shows no bubble when there are no comments at all, reducing some of the visual noise.

props picard102, afercia, karinchristen.
fixes #32152.


git-svn-id: https://develop.svn.wordpress.org/trunk@33155 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-10 21:43:32 +00:00
Dominik Schilling (ocean90)
0d63add172 Customizer: Replace the plus icon for #available-menu-items .item-add with a thinner one, see [33126].
fixes #32734.

git-svn-id: https://develop.svn.wordpress.org/trunk@33152 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-09 22:08:44 +00:00
Dominik Schilling (ocean90)
32ed996622 List tables: Remove a black colored separator in Quick Edit for pages.
fixes #32842.

git-svn-id: https://develop.svn.wordpress.org/trunk@33149 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-09 20:56:30 +00:00
Helen Hou-Sandi
17a5f9f494 List tables: Better focus styling for the row toggle.
This circular focus styling could probably be expanded to other areas of the admin.

props hugobaeta.
see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33146 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-09 19:11:19 +00:00
Helen Hou-Sandi
0e6e1e6612 List tables: Ensure special CSS for the title column gets applied.
This could have some side effects if a custom list table has a title column with a strong element inside that is not the post title, but that is fairly edge and we can address that if it comes up. Also moves the rules into `list-tables.css`.

see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@33105 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 15:20:45 +00:00
Helen Hou-Sandi
6d8f6f8d11 List tables: Account for comments being reused on the post edit screen.
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.

see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33101 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 00:08:46 +00:00
Helen Hou-Sandi
9c1265181c List tables: Get rid of double borders for plugins and themes on narrow screens.
see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33099 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 23:48:16 +00:00
Helen Hou-Sandi
94cd2d47eb List tables: Ensure the no items message appears on narrow screens.
fixes #32900. see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33098 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 23:29:44 +00:00
Helen Hou-Sandi
e5c4c584c0 List tables: A better responsive view.
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.

Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.

props Michael Arestad, helen.
see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33016 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 01:30:23 +00:00
Sergey Biryukov
0916133d43 List tables: Select All should not be a column header.
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.

git-svn-id: https://develop.svn.wordpress.org/trunk@32984 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 05:45:49 +00:00
Scott Taylor
229a9cc434 List tables: when post navigation links point to the current page, use <span>s and text instead of <a>s.
Props afercia.
Fixes #32253.


git-svn-id: https://develop.svn.wordpress.org/trunk@32948 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 20:31:51 +00:00
Scott Taylor
53bc964fc1 After [32796], improve the accessibility and markup for instances of touch_time().
Props rianrietveld, afercia.
Fixes #31714.


git-svn-id: https://develop.svn.wordpress.org/trunk@32945 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:30:00 +00:00
Helen Hou-Sandi
0433b87fdf Media list table: Avoid PHP notices by using the proper variables.
Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32805 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 21:32:53 +00:00
Dion Hulse
5b607d7ff6 Updates: Allow the update row to include the active border styling post-ajax update.
Props TobiasBg. Fixes #32129


git-svn-id: https://develop.svn.wordpress.org/trunk@32782 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 05:12:41 +00:00
Jeremy Felt
9170edb2b2 Improve information displayed in a network's sites list table
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.

Props @ocean90.
Fixes #32434.


git-svn-id: https://develop.svn.wordpress.org/trunk@32718 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 06:49:38 +00:00
Konstantin Obenland
9dfbd00947 Text improvements for screen readers in list table paginations.
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.

Props afercia, rianrietveld.
Fixes #32028.



git-svn-id: https://develop.svn.wordpress.org/trunk@32693 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-05 05:00:23 +00:00
Helen Hou-Sandi
2da4d61f95 Media list view: ensure thumbnails are appropriately sized and constrained.
see #29993.


git-svn-id: https://develop.svn.wordpress.org/trunk@32688 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 15:22:14 +00:00
Helen Hou-Sandi
6c60055740 Media: move the thumbnail into the title column in list view.
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.

props bradt for the initial patch.
fixes #29993 and #32255. see #32509 and #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@32687 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 15:12:19 +00:00
jorbin
8bb46554a8 In List Tables, ensure sorting indicator is visible on focus
In all List Tables, when tabbing through the sortable headers links, the "sorting-indicator" arrows are not displayed. Keyboard users are missing important feedback about the links purpose. 

Happy #GAAD

Props afercia
Fixes #32189



git-svn-id: https://develop.svn.wordpress.org/trunk@32521 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 18:04:03 +00:00
Andrew Ozz
59eb437a35 Fix comments postbox:
- Add comment button text.
- Positioning of the Author, Email, URL fields.
Fixes #32349.

git-svn-id: https://develop.svn.wordpress.org/trunk@32495 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-12 01:21:58 +00:00
Dominik Schilling (ocean90)
297a4eae48 Improve focus styles for the Switch View links in Posts listings and Media Library.
props afercia.
fixes #32294.

git-svn-id: https://develop.svn.wordpress.org/trunk@32485 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-11 19:33:32 +00:00
Helen Hou-Sandi
19c0b3f469 Shiny Updates: Prevent the post-update success message from jumping.
props pareshradadiya, afercia.
fixes #31984.


git-svn-id: https://develop.svn.wordpress.org/trunk@32256 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 20:40:55 +00:00
Helen Hou-Sandi
f64bf71719 Update more instances of default admin blues and grays.
props hugobaeta.
fixes #31234.


git-svn-id: https://develop.svn.wordpress.org/trunk@32051 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 21:19:54 +00:00
Helen Hou-Sandi
6983294161 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.


git-svn-id: https://develop.svn.wordpress.org/trunk@31996 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 04:51:18 +00:00
Dominik Schilling (ocean90)
501aeeaaa6 Improve alignment of labels and inputs in Quick Edit.
props mattheu, valendesigns.
fixes #31408.

git-svn-id: https://develop.svn.wordpress.org/trunk@31890 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 22:24:37 +00:00
Gary Pendergast
1676dd43b1 Taxonomy List Tables: On mobile devices, hide the slug column, to avoid cramping the action links into two rows.
Props MikeNGarrett.

Fixes #29992.



git-svn-id: https://develop.svn.wordpress.org/trunk@31865 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 12:20:11 +00:00
Andrew Ozz
825fa21a22 Improve table footer tab sequence by moving <tfoot> after <tbody>. Props afercia, rianrietveld, DrewAPicture. Fixes #30914.
git-svn-id: https://develop.svn.wordpress.org/trunk@31513 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-22 21:47:30 +00:00
Sergey Biryukov
5e1241d587 Quick Edit: Make date fields a bit wider.
props Ravindra Pal Singh, janhenckens.
fixes #27912.

git-svn-id: https://develop.svn.wordpress.org/trunk@31507 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-22 19:23:59 +00:00
Dominik Schilling (ocean90)
73a85825fb grunt autoprefixer for [31333].
see ##29820.

git-svn-id: https://develop.svn.wordpress.org/trunk@31465 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-15 12:17:41 +00:00
Helen Hou-Sandi
d00ef0f076 Update the default admin color scheme for more unity and refinement.
This removes the red channel from blues and cools the grays a bit for a more cohesive and purposeful color scheme.

props hugobaeta.
fixes #31234.


git-svn-id: https://develop.svn.wordpress.org/trunk@31422 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-11 22:17:02 +00:00
Gary Pendergast
748d595b5c Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page.
This also includes JS architecture that can be expanded to support theme, core and language pack updates.

Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture

See #29820



git-svn-id: https://develop.svn.wordpress.org/trunk@31333 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-05 04:18:57 +00:00
Helen Hou-Sandi
8ab449ae35 List tables: Use CSS :nth-child() selectors for zebra striping.
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.


git-svn-id: https://develop.svn.wordpress.org/trunk@31181 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-14 22:13:03 +00:00
Andrew Ozz
9bda766f54 Fix the search field width in the media modal, media library grid and on the install new plugins screen. Props helen, fixes #30658.
git-svn-id: https://develop.svn.wordpress.org/trunk@30813 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-11 04:11:28 +00:00
Sergey Biryukov
2e58e91dcc Remove unnecessary CSS overriding on Add Plugins screen.
props pavelevap.
fixes #29753.

git-svn-id: https://develop.svn.wordpress.org/trunk@29775 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-28 20:25:33 +00:00
Helen Hou-Sandi
2d07fb1b59 Media: Swap in a new icon for the grid mode.
props melchoyce.
fixes #29353.


git-svn-id: https://develop.svn.wordpress.org/trunk@29702 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-04 14:13:46 +00:00
Helen Hou-Sandi
2cb48c1039 Plugin install: Better styling to accommodate plugin icons.
fixes #29466.


git-svn-id: https://develop.svn.wordpress.org/trunk@29679 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-02 19:46:19 +00:00
Helen Hou-Sandi
cb298d8341 Plugin install: Make sure h3's clear floats to avoid layout problems.
props SergeyBiryukov.
fixes #29465.


git-svn-id: https://develop.svn.wordpress.org/trunk@29676 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-02 18:28:23 +00:00
Andrew Nacin
8564e3a491 Plugin installer: Minor adjustments to aid with discovery.
fixes #29387.


git-svn-id: https://develop.svn.wordpress.org/trunk@29636 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-27 02:52:29 +00:00
Helen Hou-Sandi
ad66613c02 Give pagination controls some breathing room on smaller screens.
props stephdau.
fixes #29369.


git-svn-id: https://develop.svn.wordpress.org/trunk@29627 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 17:06:51 +00:00
Helen Hou-Sandi
ca1c677db5 Fix a CSS typo from [29625]. see #28946.
git-svn-id: https://develop.svn.wordpress.org/trunk@29626 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 17:03:52 +00:00
Helen Hou-Sandi
0c53a2d22d Media library: Unify headers between view modes.
Includes back compat for `views_upload` links. These look a little awkward, but do not appear to be commonly used. Also prevents the view mode links from being dropped on smaller screens so a user doesn't get "stuck" in the list view.

This is different from other list tables, but aligns well with other uploaded content management screens (themes, plugins).

props pento, helen.
fixes #28946.


git-svn-id: https://develop.svn.wordpress.org/trunk@29625 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 15:57:20 +00:00
Andrew Ozz
2f81be2bbc Media modal: when inserting content, prefer the editor id passed while opening the modal. wpActiveEditor can change in the background. (Includes some precommit prefixed selectors.) Fixes #28173
git-svn-id: https://develop.svn.wordpress.org/trunk@29603 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 19:36:12 +00:00
Helen Hou-Sandi
9252fbec58 Only show one search form for the plugin installer.
The field dropdown now appears in the filter bar only when doing a search.

see #28785.


git-svn-id: https://develop.svn.wordpress.org/trunk@29597 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 16:02:43 +00:00
Andrew Nacin
42307f8194 Equal margins for plugin icons. see #28785.
git-svn-id: https://develop.svn.wordpress.org/trunk@29587 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 17:55:05 +00:00
Andrew Nacin
81b52e71e4 Plugin install: Add icons to compatible/incompatible. see #29313.
git-svn-id: https://develop.svn.wordpress.org/trunk@29586 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 17:25:35 +00:00
Andrew Nacin
7a504df72a Introduce plugin icons in the installer.
See http://wp.me/p2AvED-2P8 for the announcement and how to implement these.

props tellyworth.
see #28785.


git-svn-id: https://develop.svn.wordpress.org/trunk@29569 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 19:10:59 +00:00
Helen Hou-Sandi
8b45f96cba Use the word "Count" instead of the post type label in taxonomy list tables to prevent layout issues. It is also more accurate, as it represents a count of all post types, not just one.
props philipjohn, GaVrA, seanchayes. fixes #17209.


git-svn-id: https://develop.svn.wordpress.org/trunk@29343 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:31:52 +00:00
Helen Hou-Sandi
446f78396a Plugin install: display cards in groups if the API returns them with the appropriate information. props tellyworth. fixes #28673.
git-svn-id: https://develop.svn.wordpress.org/trunk@29225 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 19:34:47 +00:00