Commit Graph
250 Commits
Author SHA1 Message Date
Andrew Nacin 3eac3d0380 Parse absolute paths out of error data. see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25780 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 22:24:28 +00:00
Dion Hulse b492ae85f8 Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25779 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 21:54:33 +00:00
Andrew Nacin 67c80dae13 Account for the possible failure of disk_free_space() in update_core().
see #22704, #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25778 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 21:14:39 +00:00
Andrew Nacin d6a1b681d3 Auto updates: Only attempt a roll back when we've hit a critical error code.
Specifically, this means when we've failed in copying files.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25777 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 21:02:46 +00:00
Andrew Nacin b8efab15d8 Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files.
see #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25776 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 20:57:28 +00:00
Andrew Nacin 47e85a9b54 In the upgrader, only print additional error data if it is a string.
As in [25576], we sometimes want to return additional data that is not necessarily meant for UI consumption.

see #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25775 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 20:19:52 +00:00
Andrew Nacin 5db3863d12 In unzip_file(), confirm we have enough available disk space before extracting.
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.

props dd32.
fixes #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25774 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 20:14:13 +00:00
Andrew Nacin bd26f54af2 More specific error codes in the core upgrader when copying language, plugin, and theme files. see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25772 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 19:37:53 +00:00
Dominik Schilling (ocean90) dde2cb32fa Fix typo in wp-admin.css. props wycks. fixes #25589.
git-svn-id: https://develop.svn.wordpress.org/trunk@25771 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 16:13:08 +00:00
Andrew Nacin 7bf44580a9 Add explicit link to the installation being updated in debugging emails. see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25770 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-12 20:17:20 +00:00
Andrew Nacin 9eff9eaebe Silence possible warnings from is_dir(). fixes #25572.
git-svn-id: https://develop.svn.wordpress.org/trunk@25764 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-11 17:10:18 +00:00
Andrew Nacin 2e605e76c6 Refine error codes throughout the upgrader so we can better detect at what stage updates fail.
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25763 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-11 16:05:13 +00:00
Andrew Ozz ee5d2021e0 Upgrade TinyMCE to 3.5.9. Fix the css for the original 'fullscreen' plugin (not enabled by default).
Fixes #25561, fixes #25281.


git-svn-id: https://develop.svn.wordpress.org/trunk@25761 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-10 21:49:23 +00:00
Andrew Nacin 627b25bf50 Auto updates: For follow-up API call when an update fails, send back the version attempted. see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25755 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-10 14:45:55 +00:00
Dion Hulse f0571c02b7 After a upgrade fails, and we successfully rollback to a previous version, Don't send the version we rolled back to to the API, just that it was successful. See [25750]. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25752 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-10 01:56:44 +00:00
Dion Hulse e03279e8b0 In the event that an Automatic Upgrade fails, send a failure status on the next API request to indicate that it failed, and if the rollback was successful.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25750 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-10 01:31:22 +00:00
Andrew Nacin 74f02a6751 Hook documentation for wp-admin/admin.php.
props DrewAPicture for initial patch.
fixes #25442.


git-svn-id: https://develop.svn.wordpress.org/trunk@25747 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-09 21:00:41 +00:00
Andrew Nacin 12cb3a353e Make sure when resizing an image according to ratio we do not end up with a zero-pixel width or height.
props plocha.
fixes #25038.


git-svn-id: https://develop.svn.wordpress.org/trunk@25744 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-09 19:06:56 +00:00
Helen Hou-Sandi 99df61b666 Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410.
git-svn-id: https://develop.svn.wordpress.org/trunk@25741 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-09 18:46:34 +00:00
Dion Hulse 28736216f3 Upgrader: Create Directories with a minimum of 0755 and files with a minimum of 0644 when upgrading, which matches pre-3.7 behaviour. Fixes #20069
git-svn-id: https://develop.svn.wordpress.org/trunk@25739 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-09 16:46:31 +00:00
Drew Jaynes e46830eb0b Inline documentation for hooks in wp-admin/widgets.php.
Props r3df, kpdesign.
Fixes #25501.


git-svn-id: https://develop.svn.wordpress.org/trunk@25734 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-08 20:26:25 +00:00
Scott Taylor 4aa0066736 Use parens to ensure that RegEx OR matches the front when determining that mime-type matches audio|video in attachment_submitbox_metadata().
Props kovshenin.
See #23926.



git-svn-id: https://develop.svn.wordpress.org/trunk@25727 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-08 15:31:32 +00:00
Drew Jaynes f13f18de24 Inline documentation for hooks in wp-admin/maint/repair.php.
Props ben.moody, kpdesign.
Fixes #25500.


git-svn-id: https://develop.svn.wordpress.org/trunk@25725 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-08 00:29:37 +00:00
Drew Jaynes 887af83f53 Inline documentation for hooks in wp-admin/network.php.
Props johnafish.
Fixes #25502.


git-svn-id: https://develop.svn.wordpress.org/trunk@25722 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 23:42:43 +00:00
Andrew Nacin 04f053ce0c Move the revisions upgrade handler to POST, to avoid esoteric metadata stomping.
props SergeyBiryukov.
see #25023.
for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25719 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 18:34:35 +00:00
Drew Jaynes 4a86f70280 Inline documentation for wp-admin/options-reading.php.
Props siobhyb for the initial patch.
Fixes #25430.


git-svn-id: https://develop.svn.wordpress.org/trunk@25717 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 17:18:00 +00:00
Andrew Nacin f4227afa2b Optimize the accessibility JS on the Menus screen to avoid browser crashes with very large menus.
props atimmer.
fixes #25112.


git-svn-id: https://develop.svn.wordpress.org/trunk@25708 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 13:37:00 +00:00
Drew Jaynes 2a2587c6dc Inline documentation for hooks in wp-admin/includes/bookmark.php.
Props johnafish, kpdesign.
Fixes #25494.


git-svn-id: https://develop.svn.wordpress.org/trunk@25706 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 02:18:20 +00:00
Andrew Nacin 40ea01d759 Be as sure as possible that WordPress is not under version control when deciding if we should do automatic updates.
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25700 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 15:45:09 +00:00
Andrew Nacin 0286d7030d Don't modify post_author during a quick edit when the post type doesn't support authors.
props ocean90.
fixes #16645.


git-svn-id: https://develop.svn.wordpress.org/trunk@25698 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 13:14:06 +00:00
Andrew Nacin 9f23f85ae2 Run _fix_attachment_links() when post_status is future or private in addition to publish.
Fixes regression caused by [20308].

props jond3r.
fixes #25268.


git-svn-id: https://develop.svn.wordpress.org/trunk@25697 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 12:55:38 +00:00
Andrew Nacin 352ff49768 Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid.
props garyc40, wonderboymusic.
fixes #14578.


git-svn-id: https://develop.svn.wordpress.org/trunk@25695 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 10:55:42 +00:00
Andrew Nacin c0fb231f92 Hide the "If you take over" string from the post locked dialog when the override_post_lock filter is used to prevent an override.
props azaozz.
fixes #24930.


git-svn-id: https://develop.svn.wordpress.org/trunk@25694 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 10:45:25 +00:00
Andrew Nacin 1b37564f35 Send current SSL status to the plugin information API endpoint so we can render screenshots over SSL if appropriate. fixes #11009.
git-svn-id: https://develop.svn.wordpress.org/trunk@25691 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-05 10:58:20 +00:00
Dominik Schilling (ocean90) d529239d24 Post UI: Increase the trigger width for switching from two columns to one.
props melchoyce, vinod dalvi.
fixes #23904.

git-svn-id: https://develop.svn.wordpress.org/trunk@25688 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 09:36:36 +00:00
Dominik Schilling (ocean90) 4f7760db6f Revert [25622]. fixes #25445. see #25122.
git-svn-id: https://develop.svn.wordpress.org/trunk@25687 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 09:11:45 +00:00
Andrew Nacin 2068a3e6da When determining a frontend, local URL in the theme customizer, match the home URL without a trailing slash.
props SergeyBiryukov.
fixes #25315.


git-svn-id: https://develop.svn.wordpress.org/trunk@25681 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:49:59 +00:00
Andrew Nacin a59daf91cf Ensure we globally replace [ and ] in customizer control IDs, to match the PHP.
props westonruter.
fixes #25238.


git-svn-id: https://develop.svn.wordpress.org/trunk@25680 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:45:39 +00:00
Andrew Nacin 8cd52fe580 Don't let the query string pile up on successive themes.php searches.
props SergeyBiryukov.
fixes #25270.


git-svn-id: https://develop.svn.wordpress.org/trunk@25679 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:25:24 +00:00
Andrew Nacin a2c2641419 Avoid counting auto-drafts in sticky.
props nofearinc.
fixes #25127.


git-svn-id: https://develop.svn.wordpress.org/trunk@25678 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:15:30 +00:00
Andrew Nacin 7a9a26fb84 List tables: When executing a search, reset the Bulk Actions dropdown to avoid the search from failing.
props c3mdigital, vinod-dalvi.
fixes #25034.


git-svn-id: https://develop.svn.wordpress.org/trunk@25677 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:08:13 +00:00
Andrew Nacin 635a1249f5 Post lists table: When counting a user's posts, use get_post_stati() instead of hardcoded internal statuses.
props creativeinfusion.
fixes #24818.


git-svn-id: https://develop.svn.wordpress.org/trunk@25676 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 00:59:12 +00:00
Andrew Nacin df647346b1 Don't use a double negative.
props TobiasBg.
fixes #18201.


git-svn-id: https://develop.svn.wordpress.org/trunk@25674 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:49:34 +00:00
Andrew Nacin 69a17e3469 Links manager: Restrict field length based on DB schema.
props solarissmoke, vinod-dalvi.
fixes #17296, #12264.


git-svn-id: https://develop.svn.wordpress.org/trunk@25670 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:10:24 +00:00
Dominik Schilling (ocean90) 6311fbbfdb Replace use of global $user_ID in favor of get_current_user_id(). fixes #25372.
git-svn-id: https://develop.svn.wordpress.org/trunk@25669 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:09:52 +00:00
Scott Taylor f3722d70c1 Revert [25663] for UX discussion
git-svn-id: https://develop.svn.wordpress.org/trunk@25667 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 20:52:22 +00:00
Andrew Nacin 212dba1113 Show a proper error message on the dashboard when the current theme is broken.
Clean up Appearance -> Themes when we don't have enough information to show for a broken theme.

Clean up broken/ugly "alt" row styling when we are displaying broken themes.

props johnbillion for initial patch.
fixes #21670.


git-svn-id: https://develop.svn.wordpress.org/trunk@25666 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 20:49:59 +00:00
Scott Taylor 415a348999 When Quick Edit'ing a page, checks if edited page has a new parent and moves the row underneath that one. If the parent doesn't exist on this page then it hides the row altogether.
Props solarissmoke, MikeHansenMe.
Fixes #14188.



git-svn-id: https://develop.svn.wordpress.org/trunk@25663 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 20:37:48 +00:00
Scott Taylor a27234c898 Rather than adding a taxonomy arg to get_category(), convert all uses of get_category() in core to get_term(). By doing so, we negate the need to call _make_cat_compat() in a few places that are only looking for a single property.
Fixes #8722.



git-svn-id: https://develop.svn.wordpress.org/trunk@25662 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 19:58:50 +00:00
Andrew Nacin 64d3d53838 More string cleanups.
git-svn-id: https://develop.svn.wordpress.org/trunk@25658 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 18:50:45 +00:00