Commit Graph

4580 Commits

Author SHA1 Message Date
Scott Taylor
fc1980e369 Sanitization: when falling back to (wait for it...) $fallback in sanitize_html_class(), sanitize it as well.
Props MikeHansenMe, wonderboymusic.
Fixes #30967.


git-svn-id: https://develop.svn.wordpress.org/trunk@34377 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:30:11 +00:00
Scott Taylor
90fb9480d1 Widgets: Make the categories widget work with custom taxonomies.
Props fonglh, wonderboymusic, DrewAPicture, kucrut.
Fixes #21165.


git-svn-id: https://develop.svn.wordpress.org/trunk@34376 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:24:53 +00:00
Scott Taylor
5dd7bec848 Multisite: as a precaution, make wp-json a reserved subdirectory name.
Props austinginder.
Fixes #33789.


git-svn-id: https://develop.svn.wordpress.org/trunk@34375 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:20:41 +00:00
Scott Taylor
1352d3473a Media: Add new functions, get_the_post_thumbnail_url() and the_post_thumbnail_url().
Adds unit tests.

Props dipesh.kakadiya, swissspidy, atomicjack.
Fixes #33070.


git-svn-id: https://develop.svn.wordpress.org/trunk@34373 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:14:15 +00:00
Scott Taylor
3c0ecff16e Media: Add a new function, wp_get_attachment_image_url(), which is a shortcut for wp_get_attachment_image_src() - same function signature, but returns just the URL based on $size.
Adds unit test.

Props dipesh.kakadiya, swissspidy, sebastian.pisula.
Fixes #33878.


git-svn-id: https://develop.svn.wordpress.org/trunk@34372 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:12:44 +00:00
Scott Taylor
e75c7651b2 HTTP: Add some new Cookie helper functions:
* `wp_remote_retrieve_cookies( $response )`
* `wp_remote_retrieve_cookie( $response, $name )`
* `wp_remote_retrieve_cookie_value( $response, $name )`

Adds unit tests.

Props johnbillion.
Fixes #33711.


git-svn-id: https://develop.svn.wordpress.org/trunk@34369 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 03:13:13 +00:00
Konstantin Obenland
3cd12045d3 Introduce template functions for comment navigation:
* `get_the_comments_navigation()` and `the_comments_navigation()` for navigation to the next and previous page of comments.
* `get_the_comments_pagination()` and `the_comments_pagination()` for paginated navigation between pages of comments. Uses `paginate_comments_links()`.

This reduces the need for themes to define their own sets of comment navigation
functions, like Twenty Fifteen and others.
Completes the navigation template tag API started in #29808 for posts.

Fixes #30589.



git-svn-id: https://develop.svn.wordpress.org/trunk@34367 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 16:31:19 +00:00
Scott Taylor
c34e94b693 Docs: is_main_query()'s _doing_it_wrong() notice suggests using WP_Query statically (WP_Query::is_main_query()). Use an alternate syntax: WP_Query->is_main_query(), to not confuse.
Props DrewAPicture, micahwave.
Fixes #25680.


git-svn-id: https://develop.svn.wordpress.org/trunk@34366 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 15:30:49 +00:00
Drew Jaynes
81e235444a Docs: The $post parameter has been passed to the preview_post_link since 4.0.0.
Fixes a version mixup introduced in [34170].

Props dimadin.
See #24345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34363 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 13:16:36 +00:00
Drew Jaynes
f9e45047c1 Docs: Add a more complete return description for the array of data (or false) returned by image_downsize().
If not short-circuited via the `image_downsize` boolean filter, `image_downsize()` returns an array of data including the image URL, width, height, and whether the image size is intermediate, in that order. Otherwise, it returns false.

Fixes #30636.


git-svn-id: https://develop.svn.wordpress.org/trunk@34362 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 10:21:48 +00:00
Drew Jaynes
71ce9e812c Docs: Update the docs for WP_User_Query->prepare_query() for ordering by the value of the include argument, allowed since 4.1.
Also adds a changelog entry for the additionally-accepted value.

Props danielbachhuber.
Fixes #33937.


git-svn-id: https://develop.svn.wordpress.org/trunk@34361 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 00:46:08 +00:00
John Blackbourn
ce126c10c0 Remove the ability to view the term editing screen for taxonomies with show_ui set to false. It is unexpected and unintended behaviour that this is allowed.
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_taxonomy()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu` and `show_in_nav_menus` are false.

Fixes #33938


git-svn-id: https://develop.svn.wordpress.org/trunk@34359 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 17:10:55 +00:00
John Blackbourn
2894423f19 Revisions are an exception when it comes to the editing UI. The revision post type cannot have its show_ui argument set to true because this allows access to the post type listing, creation, and editing UI, but get_edit_post_link() needs to return a URL for the editing UI for revisions as that's how the revisions UI works.
Fixes #33763


git-svn-id: https://develop.svn.wordpress.org/trunk@34357 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 16:37:41 +00:00
Drew Jaynes
e3e91dbadc Docs: Add a description for the documented use of the $wpdb global in _prime_comment_caches().
See #8071. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34355 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 09:38:24 +00:00
Dominik Schilling (ocean90)
ce1832f49c Login: Move the "Lost your password?" link into a separate string to reduce HTML tags in translation strings.
Props ramiy.
Fixes #31870.

git-svn-id: https://develop.svn.wordpress.org/trunk@34354 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 09:10:59 +00:00
John Blackbourn
fe80bec9ee Add @since docs for the show_ui argument in register_post_type().
See #33763


git-svn-id: https://develop.svn.wordpress.org/trunk@34353 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 09:04:21 +00:00
Dominik Schilling (ocean90)
ed82c7fb75 Theme Compat: Remove two strings from comments-popup.php.
`theme-compat/comments-popup.php` is a deprecated file. Instead of improving the strings in [34342] remove both superfluous paragraphs.

See #31867.

git-svn-id: https://develop.svn.wordpress.org/trunk@34351 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 08:48:28 +00:00
Scott Taylor
ed7d34cb13 Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload().
Fixes #20523.


git-svn-id: https://develop.svn.wordpress.org/trunk@34348 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:51:55 +00:00
Scott Taylor
0082a438c5 MediaElement, update wp-mediaelement.js:
* create a public `initialize` method on the `wp.mediaelement` namespace
* make it idempotent to prevent nasty side-effects caused by initializing media elements more than once

Props bradyvercher.	
Fixes #32423.


git-svn-id: https://develop.svn.wordpress.org/trunk@34346 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:16:23 +00:00
Scott Taylor
191233f2f9 WP Query: Avoid using HTML tags in translation strings, add translator strings.
Props ramiy.	
Fixes #31868.


git-svn-id: https://develop.svn.wordpress.org/trunk@34345 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:03:28 +00:00
Scott Taylor
067af6b9aa Theme Compat: Avoid using HTML tags in translation strings.
Props ramiy.	
Fixes #31867.


git-svn-id: https://develop.svn.wordpress.org/trunk@34342 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 02:46:42 +00:00
Scott Taylor
a3cb19c52e MediaElement: apply monkey patch to include a PR which fixes a breaking change made upstream on a public interface:
ccba8d0b6a

Props bradyvercher.
Fixes #33798.


git-svn-id: https://develop.svn.wordpress.org/trunk@34339 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 02:30:06 +00:00
Drew Jaynes
12ce04a95e Docs: Add descriptions for $wp_query global phpDoc references in wp-includes/query.php, partially documented in [32620].
Fixes #32139.


git-svn-id: https://develop.svn.wordpress.org/trunk@34337 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 00:04:48 +00:00
Scott Taylor
b55de4e5f8 Feeds/Links: fix feed links for unattached attachments.
Adds unit tests.

Props wonderboymusic, iworks.
Fixes #33693.


git-svn-id: https://develop.svn.wordpress.org/trunk@34336 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 20:09:05 +00:00
Scott Taylor
633b119fd3 Site Icon: for consistency, make all 4 HTML tags in wp_site_icon() self-closing.
Props Corphi.
Fixes #33930.


git-svn-id: https://develop.svn.wordpress.org/trunk@34334 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 19:06:03 +00:00
Scott Taylor
f4445d75c4 Add a 'menu_id' argument to wp_page_menu() so that fallback menus have the same attributes as wp_nav_menu().
Props lancewillett, ocean90, wonderboymusic.
Fixes #31656.


git-svn-id: https://develop.svn.wordpress.org/trunk@34330 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 18:06:49 +00:00
Konstantin Obenland
bfc9fc4040 Menus: Remove whitespace between nav menu items.
Avoids CSS hacks like floating menu items or setting the parent element's
font-size to 0 in order to display nav menus horizontally.

Props jjeaton.
Fixes #27762.



git-svn-id: https://develop.svn.wordpress.org/trunk@34321 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 11:39:39 +00:00
Weston Ruter
7bdfb4917f Customize: Flesh out phpdoc for WP_Customize_Manager.
* Add missing phpdoc for class member variables.
* Supply missing `@return` descriptions from [34269].
* Add missing `@since` tags.
* Remove unused `$customized` protected class member variable.

Fixes #33898.


git-svn-id: https://develop.svn.wordpress.org/trunk@34320 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 06:39:09 +00:00
Scott Taylor
09e3149b7a Add a 'clean_user_cache' action at the end of clean_user_cache(). This is mighty similar to clean_post_cache().
Props elliott-stocks, wonderboymusic.
Fixes #31918.


git-svn-id: https://develop.svn.wordpress.org/trunk@34318 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 05:40:22 +00:00
Andrew Ozz
51078c32ec TinyMCE: remove word-break: break-word; from the default editor CSS to prevent irregular spaces when typing in RTL languages.
Props iehsanir, alireza1375, ankit-k-gupta.
Fixes #33868.

git-svn-id: https://develop.svn.wordpress.org/trunk@34317 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 23:57:56 +00:00
Dominik Schilling (ocean90)
9b546efc1b Theme Compat: Remove commented out code.
See #31867.

git-svn-id: https://develop.svn.wordpress.org/trunk@34316 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 21:37:09 +00:00
Scott Taylor
a5f62a6cd5 Media: add a filter, 'mejs_settings', to allow devs to pass more config settings to MediaElement.
Fixes #33506.


git-svn-id: https://develop.svn.wordpress.org/trunk@34311 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 19:59:43 +00:00
Boone Gorges
2fd81992bc Split the comment query.
`WP_Comment_Query` now fetches comments in two stages: (1) a query to get the
IDs of comments matching the query vars, and (2) a query to populate the
objects corresponding to the matched IDs. The two queries are cached
separately, so that sites with persistent object caches will continue to have
complete cache coverage for normal comment queries.

Splitting the query allows our cache strategy to be more modest and precise, as
full comment data is only stored once per comment. It also makes it possible
to introduce logic for paginated threading, which is necessary to address
certain performance problems.

See #8071.
data is only stored once per comment, instead of along with

git-svn-id: https://develop.svn.wordpress.org/trunk@34310 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 19:27:39 +00:00
Scott Taylor
27eb1ac0da Add title_reply_before and title_reply_after args to comment_form() to allow the "Leave a Reply" heading level to be changed.
Props tyxla.
Fixes #33775.


git-svn-id: https://develop.svn.wordpress.org/trunk@34308 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 19:17:19 +00:00
Scott Taylor
b862280404 After [34280], rename menu_tag arg to container, fix docs.
Props DrewAPicture.
Fixes #10968.


git-svn-id: https://develop.svn.wordpress.org/trunk@34307 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 19:04:18 +00:00
Aaron Jorbin
308179c232 Remove support for my-hacks.php
For the last 10 years, my-hacks has been deprecated and has been throwing a deprecation notice. For the last six years, you haven't been able to enable my-hacks.php in the admin UI. That should be enough time to give developers notice. Plugins and themes seem like they might have staying power.

Fixes #33741
Props bobbingwide



git-svn-id: https://develop.svn.wordpress.org/trunk@34291 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 17:05:28 +00:00
Drew Jaynes
a176e78b64 Docs: Clarify the significance of the $accepted_args parameter value in the documentation for add_filter().
Adds a couple of examples to illustrate callbacks accepting a variable number of arguments.

Fixes #33862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34288 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 14:52:37 +00:00
Drew Jaynes
efc08d508e Docs: Fix some syntactical issues in the DocBlock for set_query_var().
Adds descriptions for the global `WP_Query` instance and the `$value` parameter.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34287 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 10:28:41 +00:00
Drew Jaynes
e889c2e647 Docs: Fix some syntactical issues in the documentation for get_queried_object_id().
Adds descriptions for the global `WP_Query` instance and the return.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34286 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 10:26:58 +00:00
Drew Jaynes
4706230535 Docs: Fix some syntactical isses in the DocBlock for get_queried_object().
Also add descriptions for the return and the `WP_Query` global.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34285 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 10:20:07 +00:00
Drew Jaynes
572e3ddafb Docs: Add documentation to get_query_var() and WP_Query::get() for the optional $default argument, introduced in 3.9 in [27304].
Props swissspidy.
Fixes #33856.


git-svn-id: https://develop.svn.wordpress.org/trunk@34284 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 09:40:51 +00:00
Dion Hulse
6e6d026524 HTTP: Update the Root Certificate bundle.
See #30434


git-svn-id: https://develop.svn.wordpress.org/trunk@34283 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 08:42:24 +00:00
Scott Taylor
30921dd396 Add an argument to wp_page_menu(), 'menu_tag', which defaults to div but can be overridden to allow HTML5 tags like nav.
Props paulwilde, stebbiv, wonderboymusic.
Fixes #10968.


git-svn-id: https://develop.svn.wordpress.org/trunk@34280 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 06:06:17 +00:00
Weston Ruter
d81ca65d4c Customize: Fix live previewing of menu changes on subdirectory installs.
Props adamsilverstein, westonruter.
Fixes #33916.


git-svn-id: https://develop.svn.wordpress.org/trunk@34278 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 05:46:53 +00:00
Scott Taylor
d5e5ca8e93 Comments: in wp_rel_nofollow_callback(), account for the fact that a link might already have a rel attribute. Currently, if a link already has a rel, it will result it duplicate attributes on the element with conflicting values.
Adds unit tests.

Props junsuijin, wonderboymusic.
Fixes #9959.


git-svn-id: https://develop.svn.wordpress.org/trunk@34277 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 04:35:37 +00:00
Scott Taylor
bec1944e44 Widgets: don't show a dropdown if there is only 1 taxonomy or zero taxonomies available to the Tag Cloud widget form. Don't output the widget if there are no terms in the selected taxonomy.
Props GautamGupta, wonderboymusic.
Fixes #16125.


git-svn-id: https://develop.svn.wordpress.org/trunk@34273 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 22:10:46 +00:00
Scott Taylor
2a4eba2eb8 Canonical: redirect URLs that match an attachment masked on the wrong URL to the attachment link for the matched attachment.
Props solarissmoke.
Fixes #19918.


git-svn-id: https://develop.svn.wordpress.org/trunk@34272 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 21:31:21 +00:00
Boone Gorges
504deb52fc Lazy-load comment meta on single post pages.
[34268] introduced cache priming for commentmeta, enabled by default. To
ensure performance on single post pages - where commentmeta is most likely
to cause performance issues - we disable up-front cache-priming. Instead, we
prime commentmeta caches for all comments in the loop the first time
`get_comment_meta()` is called on the page.

Props bradt, dd32, wonderboymusic, boonebgorges.
Fixes #16894.

git-svn-id: https://develop.svn.wordpress.org/trunk@34270 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 20:00:31 +00:00
Weston Ruter
5ea07785b3 Customize: Reduce peak memory usage by JSON-encoding settings and controls individually.
When there are hundreds of settings and controls (e.g. nav menu items and widget instances) the resulting object that is JSON-encoded can become very large, and `wp_json_encode()` can consume a lot of memory to serialize it. By breaking down the serialization into multiple calls the peak memory usage can be kept in line.

Moves logic out of `wp-admin/customize.php` into the `WP_Customize_Manager` class with new methods:

 * `is_ios()`
 * `get_document_title_template()`
 * `get_preview_url()`/`set_preview_url()`
 * `get_return_url()`/`set_return_url()`
 * `get_autofocus()`/`set_autofocus()`
 * `customize_pane_settings()`

Includes unit tests for these methods, for which the logic was formerly untestable in `customize.php`.

Fixes #33898.


git-svn-id: https://develop.svn.wordpress.org/trunk@34269 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 19:41:35 +00:00
Boone Gorges
12329f5ef8 Prime comment meta caches in WP_Comment_Query.
The new 'update_comment_meta_cache' parameter, which defaults to `true`, can
be used to disable this behavior.

`update_comment_cache()` has been updated to support an `$update_meta_cache`
parameter, which also updates to true; this matches the pattern we use for
priming post caches.

See #16894.

git-svn-id: https://develop.svn.wordpress.org/trunk@34268 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 19:29:46 +00:00