Scott Taylor
47287f8d51
After [33961], ensure that comment filters that expect a comment ID are receiving one.
...
Props dimadin.
Fixes #33809 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34008 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 18:09:15 +00:00
Scott Taylor
ad163d3547
In get_page_uri(), do not add parent slugs to orphaned pages.
...
Adds unit test.
Props filosofo, MikeHansenMe, MikeHansenMe, chriscct7.
Fixes #15963 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34001 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 16:53:52 +00:00
Jeremy Felt
9473a479d9
Multisite: Correct ms_not_installed() @since version for new parameters
...
Props dimadin.
See 27264.
git-svn-id: https://develop.svn.wordpress.org/trunk@33999 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 16:20:29 +00:00
Sergey Biryukov
5d8eb77621
Merge two similar strings.
...
Props dipesh.kakadiya.
Fixes #33777 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33998 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 10:58:58 +00:00
Jeremy Felt
837b6c3e3e
Multisite: Add action to handle network not found
...
`ms_network_not_found` fires when the global `$current_site` has not been filled and `ms_not_installed()` is about to fire. It cannot be used to populate `$current_site`, but can be used to capture the request and redirect or present a custom error.
Props rmccue.
Fixes #31702 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33990 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 05:05:14 +00:00
Jeremy Felt
d0706ac9ca
Multisite: Remove $domain and $path globals in ms_not_installed()
...
Further reduces the reliance on these unnecessary globals.
Fixes #27264 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33989 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 03:52:21 +00:00
Jeremy Felt
ef1f697564
Multisite: Allow users with manage_network_users to edit network users.
...
Other users in a network can now be given capabilities to manage users without also having global super admin privileges.
* Users with `manage_network_users` can not edit super admins.
* Users with `manage_network_users` can not promote users to super admin.
* Uses of `is_super_admin()` in `user-new.php` are now updated to `manage_network_users`.
Props daniellandau, chriscct7.
Fixes #16860 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33988 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 03:33:22 +00:00
Andrew Ozz
cc18f258cb
TinyMCE: update to 4.2.5, changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=index&pr_id=1 .
...
Fixes #33782 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@33981 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 19:44:09 +00:00
Drew Jaynes
d651587a0d
Docs: Use the $widget_links_args parameter in the hook doc for the widget_links_args filter, introduced when the args array was split out to a variable in [33971].
...
See #20788 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33978 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 15:44:46 +00:00
Scott Taylor
ab9bbfa9ce
WP_Widget_Links: pass widget instance to widget_links_args filter
...
Props SergeyBiryukov, MikeHansenMe, DrewAPicture.
Fixes #20788 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33971 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:41:21 +00:00
Scott Taylor
d6e73d47e4
Round 2 of: We should use ellipses … / … instead of three dots/periods ... e.g Loading… not Loading...
...
Props yoavf.
Fixes #32875 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33970 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:38:31 +00:00
Scott Taylor
9eefbd1999
Deprecate wp_get_http() - function isn't used anywhere (apart from itself).
...
Props swissspidy.
Fixes #33709 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33969 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:25:24 +00:00
Scott Taylor
4016b77b1a
Add a parameter, $post, to get_{$adjacent}_post_join, get_{$adjacent}_post_where, and get_{$adjacent}_post_sort
...
Props JustinSainton.
Fixes #24597 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33968 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:49:00 +00:00
Scott Taylor
05e249d5ac
Ensure that role is not empty before adding it in add_role() function and methods.
...
Props MikeHansenMe, dannydehaan, michielhab.
Fixes #23746 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33967 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:41:27 +00:00
Scott Taylor
df637648e2
In WP_Comments_List_Table, favor passing WP_Comment instances instead of $comment_ID to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33964 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:59:54 +00:00
Scott Taylor
38d374ab01
After [33891], get_comment() returns global $comment if no args are passed and the global is set (after setting the default to null here). This allows us to ditch global comment imports.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33963 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:50:43 +00:00
Scott Taylor
8088ffafd6
Walker_Comment should be in its own file. Loaded now via wp-includes/comment.php, which makes it 100% BC.
...
See #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33962 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:40:53 +00:00
Scott Taylor
95247e5bd8
After [33891], a lot of comment functions can take WP_Comment instead of only accepting comment_ID. Update the @param docs to reflect this.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33961 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:33:19 +00:00
Scott Taylor
5936394bb6
In WP_User, add @property docs for description, first_name, and last_name. user_firstname and user_lastname only exist for back-compat.
...
See #33491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33958 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 01:12:41 +00:00
Scott Taylor
297df83c5d
WP_Theme has an ad hoc property in WP_MS_Themes_List_Table, $update. This can be set to a default value on the class, as it's not obtained via __get().
...
See #33491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33957 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 01:01:12 +00:00
Scott Taylor
ae16cec9fb
In wpdb::get_col_length(), the final return false is unreachable since the default switch case returns.
...
See #33491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33956 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 00:47:31 +00:00
Andrew Ozz
bb6dee64ae
Formatting: maintain the content of HTML comments when they contain <object> tags. Add more tests for wpaitop().
...
Props miqrogroove.
Fixes #33645 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@33955 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 22:54:08 +00:00
Scott Taylor
a4a469d887
After [33843], update the location of some files in This filter is documented in docs
...
Props dimadin.
See #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33954 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 22:16:57 +00:00
Scott Taylor
f8b6a357a0
Multisite: Don't allow sites to be created with the following reserved slugs: wp-admin, wp-content, wp-includes
...
Props austinginder.
Fixes #33615 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33952 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 19:31:52 +00:00
Scott Taylor
44286b9ac1
After [33814], checked() outputs a leading space, so some extra spaces can be removed in the HTML for default widget forms.
...
See #23012 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33951 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 19:22:19 +00:00
Scott Taylor
ae8a4e496e
Bump the timeout in trackback() to 10 seconds (from 4) to match wp_xmlrpc_server::pingback_ping() and prevent trackback timeouts.
...
Props gnaka08 for the initial patch.
Fixes #10414 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33948 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 18:55:45 +00:00
Scott Taylor
6d0c15836b
After [33840], JS regex needs the g modifier.
...
Add another unit test case.
Props kitchin.
Fixes #22781 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33947 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 16:43:27 +00:00
Dion Hulse
95b3edd4ce
Cron: Reject events when the provided $timestamp is not a valid timestamp.
...
Invalid timestamps were previously accepted by the scheduling functions but would never be run due to our implementation which caused the cron option to forever contain the events.
This rejects such events which most likely only occur due to developer error.
Props utkarshpatel, wonderboymusic, SergeyBiryukov.
See #33423 , Fixes #33475
git-svn-id: https://develop.svn.wordpress.org/trunk@33936 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 02:38:12 +00:00
Dion Hulse
628440fe5d
Favicon: Do not specify a Content-Length: 0 header for our "empty" response to fail more gracefully on environments with extra whitespace on output.
...
This allows for the web server to generate the appropriate `Content-Length` header for the request, allowing for strict clients/proxies/servers to process the response.
Props swissspidy.
Fixes #33626
git-svn-id: https://develop.svn.wordpress.org/trunk@33935 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 02:17:32 +00:00
Sergey Biryukov
4fb57210cd
Update the parameter docs for wp_add_post_tags(), wp_set_post_tags(), and wp_set_post_terms().
...
Props johnbillion.
Fixes #33749 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33931 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-06 00:11:56 +00:00
John Blackbourn
547742f14a
Remove the 'Site Admin' link from the Meta widget if the user doesn't have access to the admin area.
...
See #25162
git-svn-id: https://develop.svn.wordpress.org/trunk@33929 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 23:24:06 +00:00
John Blackbourn
07861df743
Introduce a new $is_edge global for the Microsoft Edge browser.
...
The `$is_IE` and `$is_chrome` globals no longer return `true` for Edge, which is expected as Edge is its own browser and should not be treated like IE. While it might be beneficial for Edge to be treated like Chrome on the client side, it benefits nobody for the `$is_chrome` global to return true.
See #33193
Props gregrickaby, johnbillion
git-svn-id: https://develop.svn.wordpress.org/trunk@33927 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 22:33:01 +00:00
Scott Taylor
542ac152fc
In wp_list_comments(), update the comment meta cache when the comments derive from WP_Query and the new ->comment_meta_cached prop is false.
...
There are no uses of `wp_list_comments()` in Core where `$comments` are passed as the 2nd argument.
Adds unit tests.
Props wonderboymusic, bradt.
Fixes #16894 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33925 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 22:24:16 +00:00
John Blackbourn
dd9722fac0
Bail out early from esc_url() if the URL becomes empty after stripping out disallowed characters.
...
Fixes #28015
Props jesin for the unit test
git-svn-id: https://develop.svn.wordpress.org/trunk@33923 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 21:28:50 +00:00
John Blackbourn
6bfd06d5c8
Function docs for the tax_input and meta_input parameters available for wp_insert_post().
...
See #20451
git-svn-id: https://develop.svn.wordpress.org/trunk@33922 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 21:01:37 +00:00
Sergey Biryukov
f8f8de0ecf
Merge two strings in Walker_Comment::comment() and Walker_Comment::html5_comment().
...
Props pavelevap.
Fixes #33744 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33919 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:45:13 +00:00
Scott Taylor
23f2e79350
Correct the param docs for comment_guid() and get_comment_guid().
...
Props dimadin.
Fixes #32619 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33913 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:59:10 +00:00
Scott Taylor
b8e30f3ec7
Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here).
...
Props afercia.
Fixes #32866 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33912 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:56:15 +00:00
Scott Taylor
38038ccba3
Add Customizer docs.
...
Props ericlewis.
See #33503 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33911 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:52:17 +00:00
Scott Taylor
26dd8b5b08
Allow wp_insert_post() to accept a meta_input argument. Devs should use register_meta() to ensure that specific values specified by key are sanitized properly.
...
Adds unit test.
Props CoenJacobs, swissspidy.
Fixes #20451 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33910 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:49:53 +00:00
Boone Gorges
9dfc5551ee
In get_terms(), allow terms to be ordered by 'term_id'.
...
[29128] introduced updated documentation for the `'orderby'` parameter of
`get_terms()`. The new documentation mistakenly said that 'term_id' was a valid
orderby value. The current changeset makes that fantasy...A REALITY.
Props ixkaito.
Fixes #33726 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33903 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 21:16:11 +00:00
Sergey Biryukov
dfceba6d05
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/js/customize-controls.js.
...
fixes #33685 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33902 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 03:39:33 +00:00
Drew Jaynes
9f5b896fac
Docs: Clarify the file header summary for wp-includes/rewrite-constants.php, introduced in [33751].
...
See #33413 . See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33901 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:51:08 +00:00
Drew Jaynes
a767e01f17
Docs: Clarify the file header summary for wp-includes/comment.php, the top-level file for the core Comments API.
...
Also adds inline DocBlock for the `require_once()` calls that now bring in the `WP_Comment` and `WP_Comment_Query` classes, as well as core comments functionality.
See #33413 . See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33900 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:46:29 +00:00
Drew Jaynes
3abc0933bb
Docs: Clarify the file header summary for wp-includes/comment-functions.php, introduced in [33750].
...
See #33413 . See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33899 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:41:17 +00:00
Drew Jaynes
d615705cec
Docs: Add a missing file header for wp-includes/class-wp-comment-query.php, introduced in [33750].
...
Also clarifies the class DocBlock summary and tags for `WP_Comment_Query`.
See #33413 . See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33898 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:37:23 +00:00
Drew Jaynes
8cc0808e3b
Docs: Clarify the file header summary for wp-includes/user.php, the top-level file for the core Users API.
...
Also adds inline DocBlocks for the `require_once()` calls that now bring in core users functionality and the `WP_User_Query` class, as of [33749].
See #33413 . See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33897 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:32:59 +00:00
Drew Jaynes
68f62a46e5
Docs: Clarify the file header summary for wp-includes/user-functions.php, introduced in [33749].
...
See #33413 . See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33896 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:28:10 +00:00
Drew Jaynes
8b3693c9e0
Docs: Add a missing file header for wp-includes/class-wp-user-query.php, introduced in [33749].
...
Also clarifies the class DocBlock summary for `WP_User_Query` to better describe its purpose.
See #33413 . See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33895 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:25:56 +00:00
Drew Jaynes
46af2b9cd9
Docs: Add complete file, class, property, and method documentation for the new WP_Comment class, introduced in [33891].
...
It's important for new functionality, especially something as significant as a new class to have complete documentation upon initial commit – not after the fact.
See #32619 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33893 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 19:57:15 +00:00