Commit Graph

57 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
479596acda Plugins: Remove slashes from search terms and use urldecode() in non-URL contexts.
Fixes #35712.

git-svn-id: https://develop.svn.wordpress.org/trunk@36560 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-17 20:14:37 +00:00
Pascal Birchler
cc6fe1179d Allow searching for 0 throughout the admin.
Fixes #31025.

git-svn-id: https://develop.svn.wordpress.org/trunk@36302 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 20:05:06 +00:00
Pascal Birchler
5209de6052 Plugins: Prevent a warning when searching in the plugins list table.
After [36182], plugin data contains compatibility info from the API, which is an array and cannot be searched.

Fixes #35461.

git-svn-id: https://develop.svn.wordpress.org/trunk@36301 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 19:59:06 +00:00
Konstantin Obenland
c67abd1c66 Plugins: Avoid ID attribute collisions in plugins list table.
Removes id attributes with non-unique plugin slug and adds a data attribute
with the unique plugin file.

Props khag7.
Fixes #18974.



git-svn-id: https://develop.svn.wordpress.org/trunk@36205 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 22:39:23 +00:00
Helen Hou-Sandi
093707c534 Plugins: Provide a link to searching the plugin directory when no search results are found.
Many new users do not know the difference between managing installed plugins and those found in the plugin directory. This helps with discoverability. The link is not provided in multisite installs because we assume that somebody with that kind of power in a network is experienced enough not to need it. This can always be reconsidered later.

props mordauk for the initial patch.
fixes #29865.


git-svn-id: https://develop.svn.wordpress.org/trunk@35808 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 22:22:11 +00:00
Sergey Biryukov
bb045e4e3c Replace a second instance of <code> in translatable string left in [35440].
Props ramiy.
See #34498.

git-svn-id: https://develop.svn.wordpress.org/trunk@35445 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:55:49 +00:00
Sergey Biryukov
9e8e68f001 Add <code> tag missed in [35440].
See #34498.

git-svn-id: https://develop.svn.wordpress.org/trunk@35441 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:11:53 +00:00
Sergey Biryukov
540e4b5edd Don't use <code> in translatable strings in wp-admin/includes/class-wp-plugins-list-table.php.
Add translator commments.

Props ramiy.
Fixes #34498.

git-svn-id: https://develop.svn.wordpress.org/trunk@35440 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:07:11 +00:00
Scott Taylor
c6354d6bfd Plugins: after [35151], set default $restrict_network_* values to prevent notices.
Props johnjamesjacoby.
Fixes #20104.


git-svn-id: https://develop.svn.wordpress.org/trunk@35361 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:55:30 +00:00
Drew Jaynes
5a0fd03f95 Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35241 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 15:12:48 +00:00
John Blackbourn
b5c3abcdfa Include network-active plugins and inactive network-only plugins on the Plugins listing screen for individual sites on Multisite.
These plugins are only shown to users with the `manage_network_plugins` capability, which is Super Admins by default. This new feature lowers the blood pressure of Super Admins who may browse or search the Plugins listing screen of an individual site, having forgotten that a particular plugin is network-active. Showing inactive network-only plugins here also reduces friction when searching the Plugins listing screen on individual sites.

This change introduces a `show_network_active_plugins` filter which controls whether the network-active plugins and inactive network-only plugins are shown. This can be used to enable this functionality for regular site admininstrators, or, indeed, to disable this functionality for Super Admins.

Fixes #20104


git-svn-id: https://develop.svn.wordpress.org/trunk@35151 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 22:11:36 +00:00
Jeremy Felt
599fb50e09 Revert [34778], continue using _site_option() for the current network.
The `_network_option()` parameter order will be changing to accept `$network_id` first. The `_site_option()` functions will remain in use throughout core as our way of retrieving a network option for the current network.

See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34912 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 17:11:01 +00:00
John Blackbourn
780460af28 Remove the unnecessary dynamic prefix used in the plugin_action_links filter name, and in those of its brethren. This way, network_admin_plugin_action_links gets listed as a separate filter.
Fixes #34117


git-svn-id: https://develop.svn.wordpress.org/trunk@34786 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-02 23:43:20 +00:00
Jeremy Felt
3c177b8c6f MS: Use *_network_option() functions throughout core.
Replaces all uses of `*_site_option()` with the corresponding "network" function.

This excludes one usage in `wp-admin/admin-footer.php` that needs more investigation.

Props spacedmonkey.
See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34778 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-02 19:07:23 +00:00
John Blackbourn
a6a00a3625 Implement 'Recently Active' functionality for network-wide plugins in the Network Admin.
Fixes #20468
Thanks to WordCamp RI attendees for testing!


git-svn-id: https://develop.svn.wordpress.org/trunk@34551 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-25 19:15:08 +00:00
Scott Taylor
2ddc438111 List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.
Props wonderboymusic, Viper007Bond.
Fixes #21249.


git-svn-id: https://develop.svn.wordpress.org/trunk@34383 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 06:05:39 +00:00
Scott Taylor
ab7ca361dd In WP_List_Table, make a new public method, ->get_primary_column(), and revert [34101] due to BC issues.
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34128 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 20:28:29 +00:00
Scott Taylor
5a93988ca3 Make WP_List_Table::get_primary_column_name() public in list table classes that have it.
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34101 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 01:11:44 +00:00
Drew Jaynes
32c3c59944 Fix the DocBlock summary for WP_Plugins_List_Table->get_primary_column_name(), added in 4.3.
See [32644]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33196 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 17:45:16 +00:00
Helen Hou-Sandi
41705c3e7c Ensure error messages look like, well, errors.
props obenland, rachelbaker.
fixes #32475.


git-svn-id: https://develop.svn.wordpress.org/trunk@33117 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 23:10:57 +00:00
Sergey Biryukov
ade1ffde80 Plugins list table: Add an aria-label attribute with the plugin name to plugin action links to provide context for screen reader users.
props bramd, rianrietveld, afercia.
fixes #26167.

git-svn-id: https://develop.svn.wordpress.org/trunk@33087 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-05 15:02:04 +00:00
Sergey Biryukov
056fcf6162 Plugins list table: Use case-insensitive sorting.
props GaryJ.
fixes #32735.

git-svn-id: https://develop.svn.wordpress.org/trunk@33076 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 21:52:46 +00:00
Dominik Schilling (ocean90)
454d8682d0 Plugins list table: Sort plugins by Name by default so translated plugin names get correctly sorted.
props swissspidy.
fixes #32735.

git-svn-id: https://develop.svn.wordpress.org/trunk@33010 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 22:30:19 +00:00
Helen Hou-Sandi
c2ed5b170d List tables: Use a class instead of inline styles for hidden columns.
fixes #32608.


git-svn-id: https://develop.svn.wordpress.org/trunk@32724 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 19:46:39 +00:00
Helen Hou-Sandi
c296d882a8 List tables:
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.

see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32723 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 19:30:22 +00:00
Helen Hou-Sandi
fa29d5bb80 List tables: tighten up primary column handling for plugins and multisite themes.
These shouldn't be able to have their primary column reassigned by default. Also removes the `has-row-actions` class as these list tables always have row actions visible and the JS for visual toggling conflicts. The `column-primary` class remains.

props stephdau.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32686 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 15:07:22 +00:00
Drew Jaynes
cb0fbfa276 Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Plugins_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32667 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:39:22 +00:00
Scott Taylor
ec5758225c Add missing doc blocks to wp-admin/includes/*.
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32654 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 20:16:22 +00:00
Scott Taylor
c8a44d437a Add @static* annotations where they are missing.
Initialize all static vars that are not, most to `null`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32650 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 15:42:40 +00:00
Helen Hou-Sandi
86c907d2a5 List tables: introduce the concept of a "primary" column.
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32644 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:40:52 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Sergey Biryukov
ecad13044d Fix a typo in [31872].
see #31738.

git-svn-id: https://develop.svn.wordpress.org/trunk@31873 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 17:32:47 +00:00
Aaron Jorbin
0d35447647 Fill $plugins['upgrade'] with extra info for use in list table
Shiny updates depends upon information from the update_plugins site transient in order to set data- attributes which are used by JavaScript. Since /wp-admin/plugins.php?plugin_status=upgrade uses `$plugin['upgrade']` rather than `$plugins['all']`, we need to fill that information in both places.   

Fixes #31738.



git-svn-id: https://develop.svn.wordpress.org/trunk@31872 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 17:29:32 +00:00
Aaron Jorbin
757ee0684c Fix notice that exists for plugins with no slug
Not all plugins have a slug, especially plugins not from the WordPress.org repository. 

Props imath for initial patch. 
Fixes #31694



git-svn-id: https://develop.svn.wordpress.org/trunk@31834 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 17:47:30 +00:00
Aaron Jorbin
cc0e582a67 Ensure that we target the correct plugin row for update updates
The DOM traversal of the plugins list table was less than ideal. By switching to data attributes, we can better target the DOM elements we want to update.

Props ericlewis
Fixes #31621




git-svn-id: https://develop.svn.wordpress.org/trunk@31831 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 05:26:00 +00:00
Scott Taylor
c0045bda84 Improve various @param docs for List Tables.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30679 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:32:19 +00:00
Drew Jaynes (DrewAPicture)
f45fd382b3 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30648 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 11:27:19 +00:00
Andrew Nacin
ca32a2d410 Pinking shears.
git-svn-id: https://develop.svn.wordpress.org/trunk@29707 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-04 15:22:58 +00:00
Andrew Nacin
e8d8b21cec Plugins: Only show details link if user can install plugins.
fixes #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29595 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 15:27:45 +00:00
Dominik Schilling (ocean90)
e4717c19c1 Apply accessibility improvements to Plugins screen too.
props SergeyBiryukov.
fixes #29342.

git-svn-id: https://develop.svn.wordpress.org/trunk@29583 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:21:20 +00:00
Drew Jaynes (DrewAPicture)
39ba840e04 Add @access tags to constructor docblocks in list table classes.
See #28679. See [29459].


git-svn-id: https://develop.svn.wordpress.org/trunk@29460 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:21:56 +00:00
Drew Jaynes (DrewAPicture)
126147a877 Document default arguments for the WP_List_Table class. Also add referenced docblocks to extending class constructors.
Props mikejolley for the initial patch.
Fixes #28679. See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@29459 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:17:14 +00:00
Dominik Schilling (ocean90)
e8e0880851 WP_Plugins_List_Table::bulk_actions() method declaration should match WP_List_Table, see [29440].
props imath.
fixes #29148.

git-svn-id: https://develop.svn.wordpress.org/trunk@29453 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 14:45:20 +00:00
Andrew Nacin
be026764a3 Move plugin details link into the description area.
fixes #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29371 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 18:48:07 +00:00
Scott Taylor
ced3f94927 Adds <label>s to current page selector and bulk actions <select> field so that screen readers have an explicit label.
Props joedolson.
Fixes #28867.


git-svn-id: https://develop.svn.wordpress.org/trunk@29294 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:19:21 +00:00
Andrew Nacin
b00097b758 Add 'Details' links to installed plugins.
Installed plugins that are up to date are now returned in the update-check API response.

props tellyworth.
see #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29226 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 20:48:28 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Scott Taylor
510ad2e1e9 Fix mismatches in access modifiers for WP_List_Table + subclasses.
Fixes #28843, #28879.


git-svn-id: https://develop.svn.wordpress.org/trunk@29137 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 22:08:22 +00:00
Scott Taylor
63cb20cc5a Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses.
Props SergeyBiryukov.
See #28843 and [28583].


git-svn-id: https://develop.svn.wordpress.org/trunk@29118 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 03:26:40 +00:00
Sergey Biryukov
7f3b20c45d Remove redundant 'Visit author homepage' title attributes for plugins and themes.
props joedolson.
fixes #26554.

git-svn-id: https://develop.svn.wordpress.org/trunk@28673 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 04:51:55 +00:00