Sergey Biryukov
4a5585e09d
Accessibility: bump headings one level up on Credits screen for a better headings hierarchy.
...
Props afercia.
Fixes #34263 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35126 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 06:49:00 +00:00
Sergey Biryukov
d884c65485
Remove obsolete code from `WP_Users_List_Table::get_sortable_columns().
...
Sorting by post count was disabled in [17024].
Props jdgrimes.
See #15861 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35110 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 02:24:12 +00:00
Sergey Biryukov
e654f82ce5
Replace get_bloginfo( 'wpurl' ) with admin_url() for plugin activation error message.
...
Use `add_query_arg()` instead of constructing the URL manually.
Props johnbillion.
Fixes #34280 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35109 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 02:11:30 +00:00
Sergey Biryukov
a326105ade
Replace get_bloginfo( 'wpurl' ) with admin_url() in plugin editor.
...
Use `add_query_arg()` instead of constructing the URL manually.
Props johnbillion.
See #34280 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35107 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 02:04:14 +00:00
Scott Taylor
3616fe5939
Widgets: add a function, is_registered_sidebar() - helps us avoid touching the $wp_registered_sidebars global.
...
Props GaryJ, wonderboymusic.
Fixes #24878 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35102 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:32:27 +00:00
Scott Taylor
32b604de00
Color Picker: when opening and closing, toggle a wp-picker-active class on the wrapper.
...
Props norcross.
Fixes #29471 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35099 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:07:21 +00:00
Drew Jaynes
44a4978535
Plugins: Introduce the delete_plugin transactional hook, which fires immediately after a plugin deletion attempt occurs.
...
Props Veraxus for the initial patch.
Fixes #26904 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35094 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 00:56:32 +00:00
Drew Jaynes
6e6d9f9830
Docs: Specify the default image size in the $size parameter description for the image_send_to_editor hook.
...
See #34257 . See #32246 . See [35058].
git-svn-id: https://develop.svn.wordpress.org/trunk@35080 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 17:17:19 +00:00
Drew Jaynes
dd7b3a62fd
Docs: Normalize spacing in the DocBlock for get_image_send_to_editor() following [35056].
...
See #34257 . See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35079 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 17:15:16 +00:00
Drew Jaynes
8749c5fa18
Docs: Adjust documentation for the $size parameter in the admin_post_thumbnail_size hook doc to clarify the required order of width and height values when an array is passed.
...
See #34257 . See #28512 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35060 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:21:57 +00:00
Drew Jaynes
6db985862a
Docs: Normalize spacing in the image_send_to_editor hook doc following [35058].
...
See #34257 . See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35059 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:18:32 +00:00
Drew Jaynes
59db8cfe93
Docs: Adjust documentation for the $size parameter in the image_send_to_editor hook doc to clarify the required order of width and height values when an array is passed.
...
Also adds the `array` type to the parameter documentation (already supported).
See #34257 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35058 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:16:35 +00:00
Drew Jaynes
25c0710f4c
Docs: Fix syntax and properly mark optional parameters as such in the DocBlock for get_image_send_to_editor().
...
Also fixes the return description, and adds the `$size` default value, missed in [35055].
See #34257 . See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35056 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:10:44 +00:00
Drew Jaynes
4d967258f2
Docs: Adjust documentation for the $size parameter in get_image_send_to_editor() to clarify the required order of width and height values when passing an array.
...
Also adds the `array` type to the parameter documentation (already supported).
See #34257 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35055 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 16:07:25 +00:00
Drew Jaynes
ff65d77908
Docs: Wrap a couple of hook name references in inline @see tags in the hook docs for custom_menu_order and menu_order.
...
Inline `@see` tags in the context of hooks are parsed as links to hook pages in the Code Reference.
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35027 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 03:38:11 +00:00
Jeremy Felt
c8019610c8
MS: Reflect falsy values for upload_space_check_disabled in UI.
...
If the network option for `upload_space_check_disabled` is missing or an empty string, we should reflect how it will be treated elsewhere in the UI.
Props stephenharris.
Fixes #33986 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35026 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-12 00:00:28 +00:00
Drew Jaynes
16f56f4114
Media: Remove logic for unnecessarily overloading the $content_width global when passing default dimensions used to display the post thumbnail image in the 'Featured Image' meta box.
...
Updates documentation for the `$size` parameter in `admin_post_thumbnail_size` filter doc.
See #28512 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35023 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-11 17:09:33 +00:00
Drew Jaynes
4d98b99cc3
Media: Introduce the admin_post_thumbnail_size filter, which enables manipulation of the image size used to display the post thumbnail in the 'Featured Image' meta box.
...
This filter has no effect on the image size used to display post thumbnails on the front-end.
Props dboulet, DrewAPicture.
Fixes #28512 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35022 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-11 16:53:35 +00:00
Drew Jaynes
bf0fa3a570
Docs: Fix some syntactical issues in property DocBlocks for WP_List_Table.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35021 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-11 03:33:50 +00:00
Jeremy Felt
d5e572f992
MS: Handle the possibility of 0 when checking a user's upload quota.
...
Upload space of 0 is now more possible via r35016 and should be respected rather than modified to a default of 10MB.
Fixes #34037 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35017 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 23:17:01 +00:00
Andrea Fercia
52c2492afb
Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy.
...
Props mrahmadawais, afercia.
Fixes #33659 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35015 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 16:33:33 +00:00
Scott Taylor
5e85a8b55a
Admin JS: after [34977], avoid variable names conflicts with e.
...
Props afercia.
Fixes #18590 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35014 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 15:49:56 +00:00
Scott Taylor
c123726ba0
Docs: some @global object vernaculars should be converted to the actual object type.
...
See #33491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35013 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 15:44:16 +00:00
Scott Taylor
5200642cc5
Users List Table: after [35011], just use wp_roles(), no global import. #winning
...
See #22959 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35012 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 15:35:26 +00:00
Scott Taylor
aa9b423cf4
Users List Table: after [34963], remove unused code/add doc for global import.
...
See #22959 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35011 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 15:25:08 +00:00
Scott Taylor
b98303ae58
WP Screen: after [34991], avoid unnecessary nesting levels and remove unused global import.
...
See #33646 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35010 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 15:19:54 +00:00
Andrea Fercia
e69aca18dc
Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy.
...
Fixes #33818 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35009 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 15:16:04 +00:00
Sergey Biryukov
437bbeead5
Users: Remove redundant error message when password is only entered once.
...
"Please enter the same password in both password fields" should cover all the scenarios.
Props MikeHansenMe, jmayhak, desrosj, gounder.
Fixes #33101 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35008 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 13:21:30 +00:00
Sergey Biryukov
975c16f4b2
Use wp_star_rating() on Add Themes screen:
...
* It works correctly for RTL
* Requires less CSS styling
* Is visually consistent with plugin ratings
* Is more accessible
Fixes #34080 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35006 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 06:50:35 +00:00
Sergey Biryukov
9487469f80
Add echo parameter for wp_star_rating().
...
See #34080 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35005 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 06:42:19 +00:00
Drew Jaynes
aacde02ed4
Docs: Fix some minor formatting in the $query_args parameter description for the `` filter doc.
...
See #8243 . See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35004 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 06:38:24 +00:00
Drew Jaynes
a521a4e7f6
Dashboard: Introduce the dashboard_recent_drafts_query_args filter, making it possible to manipulate the post query arguments used in the 'Recent Drafts' dashboard widget.
...
Props iamfriendly.
Fixes #8243 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35003 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 06:32:51 +00:00
Sergey Biryukov
fc9f0b229e
Merge two database update strings for consistency.
...
Props pavelevap.
Fixes #33514 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35000 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 05:13:57 +00:00
Jeremy Felt
ecb75a16be
MS: Show an error if a new site slug conflicts with an existing username.
...
Props utkarshpatel, dipesh.kakadiya.
Fixes #33804 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34996 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 01:41:43 +00:00
Sergey Biryukov
b374a081a9
Remove stray closing tag in wp-admin/themes.php.
...
Props tfrommen.
Fixes #34237 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34994 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 21:16:46 +00:00
Andrea Fercia
4b5f84295a
Administration: Convert H5 usage in Screen Options to use fieldsets and legends.
...
These H5 (heading level 5) don't allow for a good headings hierarchy and shouldn't be headings in the first place. Each group of options has now its own fieldset and legend.
In `render_screen_options()`, introduce two new "render" methods: `render_meta_boxes_preferences()` and `render_list_table_columns_preferences()` for consistency with already existing render methods and cleaner code.
Props joedolson, afercia.
Fixes #33646 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34991 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 18:04:18 +00:00
Drew Jaynes
ccfda7703c
Install: Match existing tonal style in setup-config.php by converting strings containing 'do not' and 'does not' to instead use contractions.
...
The 'do not' is converted to "don't" because "you" is third-person plural, and 'does not' is converted to "doesn't" because `localhost` is third-person singular. While both are "negative" contractions, we often write this way in WordPress to provide a friendlier tone. That's your English grammar lesson for the day.
Props ankit-k-gupta, iamfriendly.
Fixes #30317 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34987 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 15:42:33 +00:00
Sergey Biryukov
d58bcae1ad
Media: Return early from media_sideload_image() if $file didn't match the pattern for images.
...
Props MikeHansenMe, serpent7776.
Fixes #32755 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34984 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 04:46:00 +00:00
Sergey Biryukov
fc966fd45d
Dashboard: Display year in Activity widget if the post date year is not the same as the current one.
...
Props GaryJ, chriscct7.
Fixes #26502 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34980 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 04:25:23 +00:00
Sergey Biryukov
b39b5b8758
My Sites: Make "Create a New Site" link consistent with other "Add New" links.
...
Props JeffMatson.
Fixes #34179 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34979 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 03:49:24 +00:00
Sergey Biryukov
fb6d5f4aba
After [34529], if a compatible termmeta table is found on database upgrade, convert it to utf8mb4 collation.
...
Props dboulet.
Fixes #34224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34978 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 02:06:15 +00:00
Andrew Ozz
5a55add794
JS: in event callbacks replace the very outdated return false with preventDefault().
...
Props adamsilverstein.
Fixes #18590 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34977 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 01:26:46 +00:00
Helen Hou-Sandi
c010db6ae4
Revisions: Update slider handle styling.
...
This brings them in line with updated buttons as done in [34948] for #31459 . It also gives it secondary action styling as opposed to primary, as restoring is considered the primary action.
props hugobaeta.
fixes #34220 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34976 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 00:24:36 +00:00
John Blackbourn
8a7f8602b3
Remove HTML escaping for the plugin name and author fields that are displayed when deleting a plugin.
...
While it might seem counter-intuitive to remove HTML escaping, these fields are already safe (they originate in `_get_plugin_data_markup_translate()` which handles sanitization and escaping), and the AuthorName field actually allows some HTML. This change prevents escaped HTML from appearing here.
Fixes #25422
git-svn-id: https://develop.svn.wordpress.org/trunk@34973 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 23:13:00 +00:00
John Blackbourn
bc043c51e8
Introduce the ability to filter the Users admin listing screen by users with no role, if such users exist.
...
Fixes #22993
Props spmlucas, johnbillion
git-svn-id: https://develop.svn.wordpress.org/trunk@34965 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 22:06:46 +00:00
John Blackbourn
b02c884370
On the Users list table, show all the roles of a user in a comma-separated list if they have more than one role. This prevents role obfuscation in situations where a user has had more than one role programmatically assigned to them.
...
Fixes #22959
Props scribu, JustinSainton, DrewAPicture, johnbillion
git-svn-id: https://develop.svn.wordpress.org/trunk@34963 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 21:58:34 +00:00
Drew Jaynes
e215ca23f4
Docs: Normalize documentation spacing in the DocBlocks for add_meta_box() and remove_meta_box() following [34951].
...
Fixes #15000 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34952 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 19:12:25 +00:00
Drew Jaynes
a6e9d49467
Administration: Add the ability to pass an array of screen IDs to add_meta_box() and remove_meta_box().
...
The `$screen` parameter in both functions can now accept a single screen ID, `WP_Screen` object, or an array of screen IDs.
Adds tests.
Props coffee2code, iamfriendly, madalinungureanu, mordauk, igmoweb, meloniq, DrewAPicture.
See #15000 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34951 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 19:06:32 +00:00
Helen Hou-Sandi
df1b726ed0
Buttons: Update styles and colors.
...
* Aligns with the color standards. See https://make.wordpress.org/design/handbook/foundations/colors/
* Creates a consistent interaction experience between states.
* Improves contrast and accessibility.
props hugobaeta, afercia, melchoyce, michael-arestad.
fixes #31459 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34948 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 17:30:57 +00:00
Dominik Schilling (ocean90)
f771be9e2c
Term Meta: Prevent a "Multiple primary key defined" error during database upgrades.
...
You must have two spaces between the words `PRIMARY KEY` and the definition of your primary key. Yes, seriously.
See [34529].
Fixes #34210 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34936 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-08 11:08:15 +00:00