vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
40,756 Commits 1 Branch 0 Tags 243 MiB
4b60e6a0db
Commit Graph

3284 Commits

Author SHA1 Message Date
Sergey Biryukov
4b60e6a0db Site Health: Add a test for PHP default timezone. 
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.

WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.

Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692.

git-svn-id: https://develop.svn.wordpress.org/trunk@46797 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-28 15:46:45 +00:00
Dominik Schilling
c2413a4711 Upgrade/Install: Provide a default label for "Continue" button in language selection form. 
Prevents an empty continue button if a translation isn't yet available.

Props sathyapulse.
Fixes #48776.

git-svn-id: https://develop.svn.wordpress.org/trunk@46784 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-26 15:17:30 +00:00
SergeyBiryukov
dc486308e6 Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined: 
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box

Split "Manage widgets or menus" into separate items for consistency with other links.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone

Props afercia, audrasjb, karmatosed.
Fixes #48406.

git-svn-id: https://develop.svn.wordpress.org/trunk@46770 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-24 19:55:01 +00:00
Sergey Biryukov
fec3976927 Docs: Add missing @since tags for functions in wp-admin/includes/update.php. 
Props sathyapulse, zodiac1978.
Fixes #48777.

git-svn-id: https://develop.svn.wordpress.org/trunk@46763 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-23 18:49:59 +00:00
Sergey Biryukov
065a181fc0 I18N: Correct translator comment for By %s string in Plugins list table. 
Follow-up to [44541].

See #45898.

git-svn-id: https://develop.svn.wordpress.org/trunk@46755 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-21 00:06:32 +00:00
Andrea Fercia
5e574eb45f Accessibility: Add an aria-current attribute to the Media Library switch links. 
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.

Props mayanksonawat, afercia.
Fixes #48271.


git-svn-id: https://develop.svn.wordpress.org/trunk@46746 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-18 16:49:42 +00:00
Sergey Biryukov
e68601875e Docs: Update broken source code link in WP_Filesystem_SSH2 class. 
Props mryoga, finchps.
Fixes #48467.

git-svn-id: https://develop.svn.wordpress.org/trunk@46742 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-17 16:14:37 +00:00
Sergey Biryukov
7bb2a562a6 Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages. 
Props garrett-eclipse.
Fixes #48676.

git-svn-id: https://develop.svn.wordpress.org/trunk@46739 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-17 07:41:49 +00:00
SergeyBiryukov
24de36bc5a Docs: Fix typo in wp_credits_section_title() description. 
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.

Props hareesh-pillai.
Fixes #48674.

git-svn-id: https://develop.svn.wordpress.org/trunk@46738 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-16 21:02:02 +00:00
Sergey Biryukov
6cf77dbbb6 Docs: Remove incorrect @return tags. 
Props diddledan.
Fixes #48613, #48614.

git-svn-id: https://develop.svn.wordpress.org/trunk@46732 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-14 09:55:21 +00:00
Sergey Biryukov
895ec7224b Help/About: Update the 5.3 About page. 
* Remove extra padding on the Credits tab.

Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46709 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-11 20:43:48 +00:00
Sergey Biryukov
cde71eed52 Docs: In various @return tags, list the expected type first, instead of WP_Error. 
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46696 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-11 02:41:15 +00:00
Sergey Biryukov
63a534030e Docs: Miscellaneous docblock corrections in wp-admin/includes/plugin.php. 
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46695 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-11 00:03:53 +00:00
Sergey Biryukov
84540ab336 Docs: Improve documentation for deactivate_plugins() and activate_plugins(). 
Props marekdedic, spenserhale, SergeyBiryukov.
Fixes #48352.

git-svn-id: https://develop.svn.wordpress.org/trunk@46694 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-10 23:03:34 +00:00
Sergey Biryukov
36994ef153 Coding Standards: Fix WPCS issue in [46684]. 
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46687 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-09 13:31:07 +00:00
Sergey Biryukov
26dec96b21 Docs: Use the {@see ...} tag for the replacement in @deprecated tags, so that Developer Reference could automatically link to the replacement. 
Props jrf.
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46685 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-09 13:03:02 +00:00
Sergey Biryukov
ae2ebb8b18 Coding Standards: Consistently use do_action_deprecated() and apply_filters_deprecated() for deprecated hooks. 
Props jrf.
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46684 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-09 12:57:27 +00:00
Sergey Biryukov
4a73b562a3 Docs: Correct description for $recursive parameter of ::chmod() and ::delete() methods in WP_Filesystem implementations. 
Props skithund.
Fixes #48422.

git-svn-id: https://develop.svn.wordpress.org/trunk@46679 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-08 22:54:33 +00:00
Andrew Ozz
698aa0e564 Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in wp_get_missing_image_subsizes(). Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold. 
Props desrosj, azaozz.
Fixes #48518 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@46677 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-07 18:49:17 +00:00
John Blackbourn
46581088d5 Docs: Docs on docs. Further improve documentation of known return types, plus other docs fixes. 
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46662 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-05 21:28:51 +00:00
Andrew Ozz
63d4dcd10a Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image. 
Props ianmjones, azaozz.
Fixes #48453 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@46658 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-05 20:51:12 +00:00
Andrew Ozz
9ed5e8c9f7 Upload: Ensure the new image meta is always saved before starting post-processing of an uploaded image, even if there was an error while scaling or rotating it. 
See #48472.

git-svn-id: https://develop.svn.wordpress.org/trunk@46651 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-04 17:05:53 +00:00
Sergey Biryukov
ec5f1035fe Docs: Correct some array hash notations added in [46644]. 
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46647 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-04 09:35:59 +00:00
John Blackbourn
27b67d5624 Docs: Fix some incorrect return tags in docblocks. 
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46644 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-03 22:21:20 +00:00
Jake Spurlock
84c794ba41 Login and Registration: Allow email logins to be more flexible. 
Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen.

Fixes #38744
Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake.



git-svn-id: https://develop.svn.wordpress.org/trunk@46640 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-03 20:10:23 +00:00
Sergey Biryukov
00384f94db Docs: Update URLs in some @link tags and switch them to HTTPS. 
Props tsuyoring.
Fixes #48479.

git-svn-id: https://develop.svn.wordpress.org/trunk@46626 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-01 14:55:51 +00:00
John Blackbourn
669cefe587 Docs: Correct some incorrect docblock tags. 
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46623 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-31 17:49:12 +00:00
Sergey Biryukov
fe9b176aef Docs: Add @since tag for the $context parameter added to wp_generate_attachment_metadata filter in [46621]. 
See #48472.

git-svn-id: https://develop.svn.wordpress.org/trunk@46622 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-31 00:11:20 +00:00
Andrew Ozz
b9c02b3729 Upload: 
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting post-processing.

Fixes #48472 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@46621 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-30 21:08:32 +00:00
John Blackbourn
c6c46a5a48 Docs: Miscellaneous docblock corrections. 
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46610 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-28 19:46:13 +00:00
John Blackbourn
b422cc2ef6 Docs: Correct invalid hook docblocks. 
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46603 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-27 19:09:10 +00:00
John Blackbourn
3559504161 Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection. 
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46597 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-26 23:14:59 +00:00
John Blackbourn
4f281f1650 Docs: Switch more docs over to typed array notation, plus some fixes. 
See #48303, #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@46596 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-26 21:07:10 +00:00
John Blackbourn
a2e08032dc Docs: Miscellaneous docblock fixes and improvements. 
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46594 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-26 20:42:00 +00:00
Sergey Biryukov
21ce200edb Docs: Improve formatting of various WP_Screen DocBlocks. 
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46591 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-26 00:34:10 +00:00
Sergey Biryukov
d490968297 Docs: Improve documentation for WP_Screen::add_help_tab(). 
Props atachibana.
Fixes #48395.

git-svn-id: https://develop.svn.wordpress.org/trunk@46590 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-26 00:32:20 +00:00
Sergey Biryukov
db4e52b923 Posts, Post Types: Remove unintended change from [46578]. 
See #48384.

git-svn-id: https://develop.svn.wordpress.org/trunk@46579 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-25 12:52:46 +00:00
Sergey Biryukov
9a9abc0fb8 Date/Time: Correct the logic in WP_Posts_List_Table::column_date() and WP_Media_List_Table::column_date() to check for a valid post timestamp. 
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384.

git-svn-id: https://develop.svn.wordpress.org/trunk@46578 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-25 12:49:40 +00:00
Sergey Biryukov
7ee1e12715 Administration: Relax the default value check for the $position argument added to add_submenu_page() and related functions in [46197]. 
Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues.

A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type.

Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249.

git-svn-id: https://develop.svn.wordpress.org/trunk@46570 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-22 17:50:45 +00:00
Andrew Ozz
c424187b6e Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append scaled- to the file names of the scaled images to make them easier to recognize. 
Props kraftbj, azaozz.
Fixes #48304.

git-svn-id: https://develop.svn.wordpress.org/trunk@46565 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-21 21:41:09 +00:00
Jonathan Desrosiers
3e6c0fb95e Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing. 
This allows update failures caused when the native PHP JSON extension is missing to be distinguished from updates that fail because the site does not meet the minimum PHP requirements.

Follow up of [46455].

Reviewed by desrosj, jorbin, johnbillion.
Fixes #47699.

git-svn-id: https://develop.svn.wordpress.org/trunk@46560 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-16 21:01:22 +00:00
Andrew Ozz
5df589ddf6 Media: Do not store error messages in the image meta. The initial idea was to (be able to) display these errors in the UI but it wasn't implemented as these errors are mostly helpful for low-level bedugging. 
Fixes #40439.

git-svn-id: https://develop.svn.wordpress.org/trunk@46507 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-14 20:03:01 +00:00
Sergey Biryukov
7cd21b7bd0 I18N: Don't capitalize "Extension" in update_core(), for consistency with other strings. 
Follow-up to [46455].

See #47699.

git-svn-id: https://develop.svn.wordpress.org/trunk@46464 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-12 02:40:43 +00:00
Sergey Biryukov
e21792cb37 Docs: Add requires_php to the list of fields returned by plugins_api(). 
Props ediamin.
Fixes #48291.

git-svn-id: https://develop.svn.wordpress.org/trunk@46463 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-12 02:33:13 +00:00
Mike Schroder
68729adb57 Media: Update fallback previews to support _wp_make_subsizes() 
Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.

Props azaozz, antpb, progremzion, mikeschroder.
See #48111.

git-svn-id: https://develop.svn.wordpress.org/trunk@46459 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-11 07:52:12 +00:00
Jonathan Desrosiers
1bcd41b7c1 Upgrade/Install: Detect the presence of the native PHP JSON extension before updating. 
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]).

However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues.

Props jrf, jorbin, dd32, desrosj.
Fixes #47699.

git-svn-id: https://develop.svn.wordpress.org/trunk@46455 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-09 22:20:37 +00:00
Sergey Biryukov
8ec0a21161 Docs: Add a @since note about new parameters with the spread operator added to function signatures. 
Props jrf.
See #47678.

git-svn-id: https://develop.svn.wordpress.org/trunk@46451 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-09 04:26:22 +00:00
John James Jacoby
0a818ec0fc Network Admin: Improve Site States in List Table rows. 
This commit switches a comparison to a Yoda condition, performs a more strict `intval()` check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.)

Fixes #37684. Props pbiron.

git-svn-id: https://develop.svn.wordpress.org/trunk@46441 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-08 17:44:42 +00:00
Sergey Biryukov
357a18da2b Docs: Add missing @deprecated tags in the file docblock of some deprecated files. 
Props jrf.
Fixes #48254.

git-svn-id: https://develop.svn.wordpress.org/trunk@46439 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-08 17:17:07 +00:00
Andrew Ozz
022119d1a6 Upload: Set custom header with the attachment ID for all uploads from media_handle_upload(). Let the REST API endpoint set it separately. 
Props timothyblynjacobs.
Fixes #48200.

git-svn-id: https://develop.svn.wordpress.org/trunk@46421 602fd350-edb4-49c9-b593-d223f7449a82
 2019-10-07 15:28:29 +00:00