Commit Graph

56 Commits

Author SHA1 Message Date
Drew Jaynes
4e86eb7cd4 Docs: Add missing DocBlock summaries to three functions in wp-admin/includes/plugin.php.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34825 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-05 02:54:56 +00:00
Drew Jaynes
f5066a38f2 Docs: Document the plugin data array returned by get_plugin_data() with a hash-notation.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34818 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-04 19:05:38 +00:00
Jeremy Felt
3c177b8c6f MS: Use *_network_option() functions throughout core.
Replaces all uses of `*_site_option()` with the corresponding "network" function.

This excludes one usage in `wp-admin/admin-footer.php` that needs more investigation.

Props spacedmonkey.
See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34778 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-02 19:07:23 +00:00
John Blackbourn
1bb2876fe6 callback is not a valid type in PHP, PSR-5, or phpDocumentor. callable should be used instead.
Fixes #34032


git-svn-id: https://develop.svn.wordpress.org/trunk@34566 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-25 23:57:46 +00:00
Dominik Schilling (ocean90)
f5eacb71d6 Don't use <code> in translation strings in wp-admin/includes/plugin.php.
Props ramiy.
Fixes #31856.

git-svn-id: https://develop.svn.wordpress.org/trunk@34314 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:28:23 +00:00
Scott Taylor
706cdbc671 Move plugin_sandbox_scrape() from wp-admin/plugins.php to wp-admin/includes/plugin.php.
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34018 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 21:23:17 +00:00
Scott Taylor
3b8c5529cb foreach is a statement, not a function.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:27:56 +00:00
Scott Taylor
550763988b ob_get_contents() followed by ob_end_clean() can be replaced by ob_get_clean().
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32965 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 01:11:45 +00:00
Drew Jaynes
64da56c543 Fix a typo in the DocBlock for get_plugins().
Props onnimonni, swissspidy.
Fixes #32758.


git-svn-id: https://develop.svn.wordpress.org/trunk@32927 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 12:21:57 +00:00
Scott Taylor
7af8195803 In unregister_setting(), search for $option_name in a segment of $new_whitelist_options keyed by $option_group.
Props nofearinc.
Fixes #26479.


git-svn-id: https://develop.svn.wordpress.org/trunk@32905 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 20:50:30 +00:00
Scott Taylor
986990163f Add doc blocks to functions that are missing them.
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32672 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 03:17:50 +00:00
Scott Taylor
d55800a4f2 In the style of #30947 and default-filters.php, add 2 new files to wp-admin/includes:
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.


git-svn-id: https://develop.svn.wordpress.org/trunk@32653 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 17:03:13 +00:00
Scott Taylor
f864c1d712 Add @global annotations to (the rest of the?) wp-admin/* files.
Does not include list table file changes.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32643 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:05:26 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Dion Hulse
047c2fdadd Allow plugins to activate other plugins within their Activation hook. Fixes #32368
git-svn-id: https://develop.svn.wordpress.org/trunk@32504 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-14 06:57:47 +00:00
Drew Jaynes
b7bce33748 Add a missing @return tag to the DocBlock for `uninstall_plugin().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32340 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:07:47 +00:00
Scott Taylor
5deee71273 Remove unused local vars in delete_plugins(), delete_theme(), WP_Date_Query->validate_date_values(), global_terms(), and WP_Text_Diff_Renderer_Table->_changed().
This will clear out the "Unused Code" label in the next Scrutinizer report.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31217 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 21:18:52 +00:00
Scott Taylor
0c37f866f2 After [31105], don't ditch the isset() calls for BC. Declare $page_hook as null so it is initialized for all execution paths but will still fail isset() checks.
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31106 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 22:51:30 +00:00
Scott Taylor
c4e2ad04a2 Properly declare $hook_suffix, $plugin_page, $typenow, and $taxnow as globals in wp-admin/admin.php.
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31105 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 22:14:58 +00:00
Scott Taylor
1ca58614b2 In wp-includes/plugin.php, collapse 3 else-newline-tab-if statements.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31091 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:12:42 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Andrew Nacin
25e332e473 Use correct function name in docs for get_plugin_data().
props eliorivero.
fixes #30699.


git-svn-id: https://develop.svn.wordpress.org/trunk@31008 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-31 08:07:09 +00:00
Boone Gorges
e85543f68b When no plugins are active, return an empty array from validate_active_plugins().
This creates parity with the behavior of the function when plugins *are* active,
but none are invalid. It also makes it possible to write unit tests for the
function.

Props sgrant.
Fixes #30860.

git-svn-id: https://develop.svn.wordpress.org/trunk@31003 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-30 19:30:07 +00:00
Scott Taylor
3008fe1060 Improve the @param docs for src/wp-admin/includes/plugin.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30668 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:22:33 +00:00
Drew Jaynes (DrewAPicture)
f45fd382b3 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30648 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 11:27:19 +00:00
Drew Jaynes (DrewAPicture)
5f574c7ec8 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `wp_salt()`
* Backtick-escape inline code in the return description for `get_avatar()`
* Various markdown formatting in the description for `add_filter()`
* Markdown-indent a code snippet in the description for `apply_filters()`
* Backtick-escape inline code in the `@see` description for `apply_filters_ref_array()`
* Backtick-escape inline code in the description for `do_action()`
* Backtick-escape variables in the parameter and return descriptions for `do_action_ref_array()`
* Various markdown formatting in the description for `get_plugin_data()`

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30544 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 06:04:10 +00:00
Scott Taylor
884d27ea00 Fill in the @param types for the args for functions missing them in wp-admin/includes/plugin.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30199 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:58:14 +00:00
Sergey Biryukov
4ea9070f8a Fix copy/paste errors in [27769].
props Corphi.
fixes #30054.

git-svn-id: https://develop.svn.wordpress.org/trunk@29977 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 21:34:51 +00:00
Dominik Schilling (ocean90)
e9be4237ba Language packs: Remove translations when deleting a theme or a plugin.
This is for translation files in WP_LANG_DIR which are installed through a language pack.
Change `wp_get_installed_translations()` to only return a translation if the .mo file also exists.

fixes #29860.

git-svn-id: https://develop.svn.wordpress.org/trunk@29856 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 19:04:05 +00:00
Scott Taylor
dcef5d4583 In activate_plugin(), do not re-run the activation routine for already-active network-wide plugins.
Adds unit test.

Props jbrinley.
Fixes #28651.


git-svn-id: https://develop.svn.wordpress.org/trunk@29818 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 15:55:51 +00:00
Mark Jaquith
be8a0c6f89 Use HTTPS URLs for trac.wordpress.org (and use core.trac.wordpress.org)
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29789 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:36:38 +00:00
Sergey Biryukov
502e9b675a In add_submenu_page(), avoid inadvertently copying classes of a menu item to the first submenu item.
fixes #28936.

git-svn-id: https://develop.svn.wordpress.org/trunk@29326 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 16:07:59 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Sergey Biryukov
7f3b20c45d Remove redundant 'Visit author homepage' title attributes for plugins and themes.
props joedolson.
fixes #26554.

git-svn-id: https://develop.svn.wordpress.org/trunk@28673 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 04:51:55 +00:00
Sergey Biryukov
c04daa1ade Avoid stomping of the $plugin variable in activate_plugin().
fixes #28102.

git-svn-id: https://develop.svn.wordpress.org/trunk@28644 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 22:07:43 +00:00
Scott Taylor
1b4e4e665a hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' )
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28479 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 20:51:44 +00:00
Sergey Biryukov
819ad5babc Deprecate unused argument of delete_plugins(). Clarify @return value.
props jdgrimes for initial patch.
fixes #28111.

git-svn-id: https://develop.svn.wordpress.org/trunk@28256 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 10:23:16 +00:00
Andrew Nacin
50d900aa5f Fix docs for hooks in deactivate_plugins() and activate_plugin(). see #27189, #27188.
git-svn-id: https://develop.svn.wordpress.org/trunk@27769 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 02:01:29 +00:00
Drew Jaynes (DrewAPicture)
6308a3c93d Fix docs for the deactivate_$plugin and deactivated_plugin hooks.
Props wpsmith for the original patch.
Fixes #27189


git-svn-id: https://develop.svn.wordpress.org/trunk@27491 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-10 21:33:54 +00:00
Dominik Schilling (ocean90)
292f70aba3 Admin Menu: Set default value of $icon_url in add_menu_page() to dashicons-admin-generic, fixes #26630.
git-svn-id: https://develop.svn.wordpress.org/trunk@27482 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-09 11:12:35 +00:00
Andrew Nacin
b7be4e98fe Detect and handle symlinking of plugins in plugin_basename().
props rmccue, MikeSchinkel, jdgrimes.
see #16953.


git-svn-id: https://develop.svn.wordpress.org/trunk@27158 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 22:59:40 +00:00
Dominik Schilling (ocean90)
88277b4dba Remove unused code. props nofearinc. fixes #26205.
git-svn-id: https://develop.svn.wordpress.org/trunk@27033 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 00:11:18 +00:00
Sergey Biryukov
0b3022708b Use correct example of a Dashicons helper class in add_menu_page() and register_post_type() docs.
props Rarst.
fixes #26617 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@26884 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-31 10:32:18 +00:00
Drew Jaynes
bd39e26032 First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.


git-svn-id: https://develop.svn.wordpress.org/trunk@26868 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-24 18:56:05 +00:00
Ryan Boren
cfd5c395bb The Pinking Shears stir from their slumber, awakened by what may seem, to those
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!

One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.

Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.


git-svn-id: https://develop.svn.wordpress.org/trunk@26851 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-11 19:48:29 +00:00
Andrew Nacin
006045395c Allow for Dashicons and base64-encoded data:image/svg+xml URIs when specifying menu icons.
Both of these icons can be colored to match the color scheme, including hover states.
Both are accepted for register_post_type()'s menu_icon argument, and also add_menu_page()'s $icon_url argument.

To use a Dashicon, pass the name of the helper class, e.g. 'dashicons-piechart'.
To use an SVG, pass a valid data URI string starting with 'data:image/svg+xml;base64,'.

props helen.
fixes #25147.


git-svn-id: https://develop.svn.wordpress.org/trunk@26664 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 06:37:20 +00:00
Andrew Nacin
57bede1005 Use current_user_can('manage_network_plugins') in validate_active_plugins() instead of is_super_admin().
props jdgrimes.
fixes #26068.


git-svn-id: https://develop.svn.wordpress.org/trunk@26590 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-03 21:11:21 +00:00
Dion Hulse
71bc2a38fa Add braces around a conditional hook. This wasn't causing an issue as if ( conditional ) /* multiline comment */ command(); is perfectly OK, but left open doubt and potential future bugs. See #25229
git-svn-id: https://develop.svn.wordpress.org/trunk@26509 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-01 23:12:38 +00:00
Dion Hulse
520840e84c Plugin Deletion: Properly clear the cache when multiple plugins are deleted. Props jdgrimes. Fixes #26065
git-svn-id: https://develop.svn.wordpress.org/trunk@26262 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-19 04:07:47 +00:00
Ryan Boren
30f822b8ee Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@25880 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 14:37:54 +00:00