Commit Graph

20 Commits

Author SHA1 Message Date
Adam Silverstein
856416049d Media: ensure JavaScript initialized when media edit screen is loaded directly.
Fix a JavaScript error when the media edit screen is loaded directly via a url such as `/wp-admin/post.php?post={post_id}&action=edit&image-editor`. Add a check in `imgLoaded` for `this.hold.sizer` which is set up during initialization and required for the cropping tool. Call `init` if this is undefined.

Props NoseGraze.
Fixes #38138.


git-svn-id: https://develop.svn.wordpress.org/trunk@40020 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-27 18:29:48 +00:00
Sergey Biryukov
b2fe8ed9f6 Docs: Use 3-digit, x.x.x style semantic versioning for @since entries in wp-admin/js/image-edit.js.
See #38748.

git-svn-id: https://develop.svn.wordpress.org/trunk@39740 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-06 14:38:11 +00:00
Adam Silverstein
8948847eb1 Docs: Add inline documentation for image-edit.js.
Adds JSDoc DocBlocks to the imageEdit methods.

Props: andizer, rensw90.
Fixes #38748.


git-svn-id: https://develop.svn.wordpress.org/trunk@39493 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-04 21:34:11 +00:00
Dominik Schilling
727b070c60 Media: Improve form validation errors handling when editing images.
* Use the same check for a numeric value used on the crop fields on all the other fields: don't display "NaN", just empty the field.
* Remove the inline script that runs the initialization of the image editor and call it after the editor UI is fully ready.

Props afercia.
Fixes #36316.

git-svn-id: https://develop.svn.wordpress.org/trunk@37966 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-05 13:36:59 +00:00
Andrea Fercia
05934ebd87 Media: make the Image Editor usable with a keyboard.
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.

Fixes #28864.

git-svn-id: https://develop.svn.wordpress.org/trunk@36223 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 19:12:11 +00:00
Andrea Fercia
a12087bf0f Media: set the image editor spinner on the smallest possible area.
When using spinners as background images, the re-painted area should be the smallest
possible one. See similar performance issue in #31196, #33311, #33322, and #34951.

Fixes #35296.

git-svn-id: https://develop.svn.wordpress.org/trunk@36162 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-03 16:48:47 +00:00
Scott Taylor
7301c115aa Accessibility: add missing alt attributes to a gaggle of <img>s.
Props afercia.
Fixes #34583.


git-svn-id: https://develop.svn.wordpress.org/trunk@35567 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-07 16:11:38 +00:00
Helen Hou-Sandi
6983294161 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.


git-svn-id: https://develop.svn.wordpress.org/trunk@31996 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 04:51:18 +00:00
Scott Taylor
baf230c80f Media Grid/Modal Keyboard navigation improvements:
* Add focus to arrows on Next/Previous in the grid's modal on left/right keypress, and add the necessary CSS for `:focus`
* When in a disabled input in the grid modal, allow the left/right keys to work
* Make the image editor return a `$.Deferred` so that there isn't a race condition with UI loading. 
* Assign focus when the edit image mode is rendered so that the modal can be closed on Esc press

Props wonderboymusic, adamsilverstein (for the initial patch).
See #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@29560 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 02:34:23 +00:00
Dominik Schilling (ocean90)
f5c0cf95e0 Fix jshint errors introduced in [29259]. see #11325.
git-svn-id: https://develop.svn.wordpress.org/trunk@29269 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 20:02:34 +00:00
Sergey Biryukov
ac17007b10 Remove requirement for a minimum image size in the image editor.
props ericlewis, solarissmoke.
fixes #11325.

git-svn-id: https://develop.svn.wordpress.org/trunk@29259 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-21 19:09:44 +00:00
Scott Taylor
804b82bd11 Make the image editor less jumpy when opening.
Props eddiemoya, ericlewis.
Fixes #22793.



git-svn-id: https://develop.svn.wordpress.org/trunk@28639 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:52:35 +00:00
Sergey Biryukov
b597b02515 Fix closing tag in image editor.
props t4k1s.
fixes #28130.

git-svn-id: https://develop.svn.wordpress.org/trunk@28255 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 10:16:14 +00:00
Andrew Nacin
1c3f9e542b Restyle the image editor so it looks way less hideous.
props avryl.
see #27544.


git-svn-id: https://develop.svn.wordpress.org/trunk@27842 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 08:50:57 +00:00
Andrew Ozz
4b760ff840 Editing image file: properly refresh the view after restoring the original image or rescaling the image. Props gcorne, see #21811
git-svn-id: https://develop.svn.wordpress.org/trunk@27644 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-20 23:24:43 +00:00
Helen Hou-Sandi
55e1b4c982 At long last, a first pass at bringing the image editor into the media modal. props gcorne, DH-Shredder, tomauger. see #21811.
git-svn-id: https://develop.svn.wordpress.org/trunk@27445 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-06 22:54:32 +00:00
Sergey Biryukov
60a28aa61a Fix the ability to save changes made to an image.
props markoheijnen.
fixes #26000.

git-svn-id: https://develop.svn.wordpress.org/trunk@26425 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-26 23:30:59 +00:00
Sergey Biryukov
a25d658720 Fix JSHint errors in image-edit.js.
props dougwollison.
fixes #26000.

git-svn-id: https://develop.svn.wordpress.org/trunk@26292 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-20 22:46:43 +00:00
Dominik Schilling (ocean90)
b3c66e7bd0 Image Edit: Replace deprecated $.load() and $.error() methods to prevent warnings by jQuery Migrate, fixes #25371.
git-svn-id: https://develop.svn.wordpress.org/trunk@25547 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-21 11:23:32 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00