Commit Graph
1308 Commits
Author SHA1 Message Date
Konstantin Obenland e59592f87e Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@32974 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 15:40:27 +00:00
Scott Taylor 550763988b ob_get_contents() followed by ob_end_clean() can be replaced by ob_get_clean().
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32965 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 01:11:45 +00:00
Scott Taylor f162be6046 For doc block types, favor bool over the few remaining booleans
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32964 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 01:02:12 +00:00
Scott Taylor 2a5278e2dd Some doc blocks should use bool instead of true|false
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32963 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 00:44:21 +00:00
Scott Taylor 297b615b99 In WP_Filesystem_Base::chdir|chgrp|chmod() (all mock abstract methods), modify @return to include string so that subclass @returns match.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32962 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 00:42:43 +00:00
Scott Taylor 229a9cc434 List tables: when post navigation links point to the current page, use <span>s and text instead of <a>s.
Props afercia.
Fixes #32253.


git-svn-id: https://develop.svn.wordpress.org/trunk@32948 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 20:31:51 +00:00
Scott Taylor 53bc964fc1 After [32796], improve the accessibility and markup for instances of touch_time().
Props rianrietveld, afercia.
Fixes #31714.


git-svn-id: https://develop.svn.wordpress.org/trunk@32945 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:30:00 +00:00
Andrew Ozz ae029a133e Press This: better screen reader text for the arrow part of the split button.
Props afercia. See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32944 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:23:54 +00:00
Scott Taylor f335ef9a66 Remove unused code from WP_Press_This::html().
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32939 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:37:56 +00:00
Scott Taylor 1bae0bb006 Remove unused code from WP_MS_Sites_List_Table::display_rows().
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32938 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:35:51 +00:00
Andrew Ozz 6d6a1980b2 Press This: support passing i parameter to add an image src.
Props stephdau, azaozz. Fixes #32173.

git-svn-id: https://develop.svn.wordpress.org/trunk@32936 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 03:05:47 +00:00
Andrew Ozz e06cc095b4 Press This, split button: wrap the sub-buttons in an unordered list to aid accessibility.
Props afercia. See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32934 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 01:54:36 +00:00
John Blackbourn dd419b74cc Introduce a no_terms label for taxonomies. This label is used when indicating that there are no terms in the given taxonomy associated with an object.
Fixes #32150
Props afercia


git-svn-id: https://develop.svn.wordpress.org/trunk@32933 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 00:15:46 +00:00
Drew Jaynes 64da56c543 Fix a typo in the DocBlock for get_plugins().
Props onnimonni, swissspidy.
Fixes #32758.


git-svn-id: https://develop.svn.wordpress.org/trunk@32927 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 12:21:57 +00:00
Dion Hulse b1b9db161f WP Filesystem: Correctly set the @since for WP_Filesystem_Base::getchmod() added in r32923.
This is 2.5.0 as that's when the function become available in all subclasses.
See #29548


git-svn-id: https://develop.svn.wordpress.org/trunk@32924 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 04:51:16 +00:00
Dion Hulse fc52d9cbb1 WP Filesystem: Correctly parse the permissions field in the directory listings, and actually set it in FTP environments
Props mnelson4 for initial patch.
Fixes #29548


git-svn-id: https://develop.svn.wordpress.org/trunk@32923 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 04:48:18 +00:00
Andrew Ozz 504f154363 Press This: ensure proper tab order in the split button. Tweak padding and border color a bit.
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32921 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 03:22:57 +00:00
Andrew Ozz 9911a1cbe6 Press This: convert the Preview | Save | Publish buttons to a split button.
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32920 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 02:45:38 +00:00
Scott Taylor 7af8195803 In unregister_setting(), search for $option_name in a segment of $new_whitelist_options keyed by $option_group.
Props nofearinc.
Fixes #26479.


git-svn-id: https://develop.svn.wordpress.org/trunk@32905 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 20:50:30 +00:00
Scott Taylor a147a92046 List table views: fix missing current class for "All" when logged in as an author.
Props afercia.
Fixes #32015.


git-svn-id: https://develop.svn.wordpress.org/trunk@32903 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 20:38:32 +00:00
Helen Hou-Sandi 3f4a902051 Add "Scheduled" to post states.
props rclations.
fixes #32131.


git-svn-id: https://develop.svn.wordpress.org/trunk@32902 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 16:06:45 +00:00
Sergey Biryukov ef8ed3e279 Avoid a PHP notice in WP_Press_This::get_suggested_content() after [32828].
props kraftbj.
fixes #32751.

git-svn-id: https://develop.svn.wordpress.org/trunk@32901 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 15:19:53 +00:00
Scott Taylor a968694338 Use valid markup in Walker_Nav_Menu_Edit::start_el() - replace <d(l|t)> with <div> for .menu-item-bar and .menu-item-handle.
Props sagarjadhav.
Fixes #31817.


git-svn-id: https://develop.svn.wordpress.org/trunk@32879 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:22:00 +00:00
Scott Taylor 6ffc540366 Add access modifier to WP_Upgrader::clear_destination()
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32871 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:52:44 +00:00
Scott Taylor c5f72c4ab7 Use <button> instead of <a> for non-link links in Quick Edit.
Props afercia.
Fixes #32213.


git-svn-id: https://develop.svn.wordpress.org/trunk@32869 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:41:07 +00:00
Scott Taylor bb292c74c1 Cleanup (ms-)?admin-filters.php
Props johnjamesjacoby.
Fixes #32529.


git-svn-id: https://develop.svn.wordpress.org/trunk@32865 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:17:20 +00:00
Dion Hulse 9c0750ac52 When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process.
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921


git-svn-id: https://develop.svn.wordpress.org/trunk@32854 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 03:48:55 +00:00
Dion Hulse 4ff7f27c83 Remove a redundant index drop, it'll be dropped and re-created a few lines further down.
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@32852 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 03:17:12 +00:00
Konstantin Obenland 9bf79ed862 Semanticize Help and Screen Options toggle.
Links used as UI controls that are not real links but act as buttons, should be buttons.

Props afercia.
Fixes #32494.



git-svn-id: https://develop.svn.wordpress.org/trunk@32844 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 16:35:12 +00:00
Konstantin Obenland 771509a452 Show the posts meta box by default in Appearance > Menus.
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.

Props bcole808.
Fixes #32440.



git-svn-id: https://develop.svn.wordpress.org/trunk@32842 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 15:03:29 +00:00
Konstantin Obenland 77d2e23a69 Make posts in the 'Most recent' tab of post type meta boxes filterable.
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.

Props jpyper, chriscct7.
Fixes #19365.



git-svn-id: https://develop.svn.wordpress.org/trunk@32833 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 11:34:33 +00:00
Andrew Ozz 80a511015b Press This: Check the embeds list against all of the oembed providers.
Props stephdau. Fixes #32069.

git-svn-id: https://develop.svn.wordpress.org/trunk@32828 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 00:11:30 +00:00
Andrew Ozz 675de40f11 Press This: show error message when the user is attempting to add a category that already exists.
Fixes #32339.

git-svn-id: https://develop.svn.wordpress.org/trunk@32827 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 23:12:08 +00:00
Boone Gorges 322b6cc54f Bail out of 4.3 term splitting routine when no shared terms are found.
Props dd32.
See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@32819 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 11:39:19 +00:00
Boone Gorges f9ae6b826a Split all shared taxonomy terms on upgrade to 4.3.
Dear Shared Terms, Welcome to Splitsville. Population: You.

See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@32814 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 01:52:46 +00:00
Helen Hou-Sandi 0433b87fdf Media list table: Avoid PHP notices by using the proper variables.
Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32805 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 21:32:53 +00:00
Scott Taylor 296c559baf if is a statment, not a function.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32800 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:00:15 +00:00
Helen Hou-Sandi d878ce73f5 Media list table: Restore row actions.
see #29881, #32657.


git-svn-id: https://develop.svn.wordpress.org/trunk@32798 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 19:46:27 +00:00
Dion Hulse 9f2ad2538e Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key.
Props mordauk. Fixes #31784


git-svn-id: https://develop.svn.wordpress.org/trunk@32784 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 06:25:58 +00:00
Dion Hulse 8455dd10da Updats: Add a filter for the options params for the update being performed.
Props nofearinc. Fixes #27754


git-svn-id: https://develop.svn.wordpress.org/trunk@32783 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 05:34:52 +00:00
Dion Hulse 4f8b348c9b Updates: Remove redundant title tags from update outputs.
Props afercia. Fixes #32530


git-svn-id: https://develop.svn.wordpress.org/trunk@32781 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 05:08:48 +00:00
Dion Hulse 5a33c20515 Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message.
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32778 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 03:31:40 +00:00
Andrew Nacin 8b5b201fa1 Tweak the first post/page content to get with the times.
props chriscct7.
fixes #22474.


git-svn-id: https://develop.svn.wordpress.org/trunk@32768 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 18:55:52 +00:00
Scott Taylor 857197f14d In WP_MS_Users_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32757 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 17:10:49 +00:00
Scott Taylor dea07077fa In WP_MS_Themes_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32756 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 16:53:06 +00:00
Scott Taylor ae8bd2bcd3 In WP_MS_Sites_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32755 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 16:23:01 +00:00
Scott Taylor 31d50764c3 In WP_Media_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32754 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 15:56:13 +00:00
Scott Taylor c32f856cf3 In WP_Links_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32753 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 15:32:57 +00:00
Scott Taylor 6c6638c163 In WP_Posts_List_Table, move the <th> markup out of ->column_cb().
See #29881, [32740].


git-svn-id: https://develop.svn.wordpress.org/trunk@32752 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 15:13:47 +00:00
Scott Taylor 0eb50f80b9 In wp_ajax_hidden_columns(), don't explode() on an empty string.
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.

This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.

Props afercia, wonderboymusic.
Fixes #32466.


git-svn-id: https://develop.svn.wordpress.org/trunk@32751 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 14:59:40 +00:00