Recently merged, https://github.com/WordPress/gutenberg/pull/29611, changed the default writing prompt text. WordPress core offers the `write_your_story` filter with a default value using the same text. This change updates the default text to match the recent change in the block editor.
Props Joen, SergeyBiryukov.
Fixes#52948.
git-svn-id: https://develop.svn.wordpress.org/trunk@50647 602fd350-edb4-49c9-b593-d223f7449a82
In [47198], parentheses were removed from `include` and `require` statements, as they are language constructs, not function calls. However, [50161] introduced a new `require_once` instance in `wp-admin/options-privacy.php`. This change removes the unnecessary parentheses.
See #53627.
git-svn-id: https://develop.svn.wordpress.org/trunk@50631 602fd350-edb4-49c9-b593-d223f7449a82
Ensures that `wp-format-library` assets are always loaded for the block editor. Otherwise, they have to be loaded individually for every screen that needs it. It's similar to how `wp-block-directory` assets are handled.
Props ellatrix.
See #52920.
git-svn-id: https://develop.svn.wordpress.org/trunk@50620 602fd350-edb4-49c9-b593-d223f7449a82
This avoids a fatal error on PHP 8 in `wp_privacy_generate_personal_data_export_file()` if the `_export_data_grouped` post meta exists but is not an array.
Additionally, refactor unit tests for the function to:
* Reduce redundant code
* Switch to data provider
* Test on the full HTML output instead of select pieces of the output
* Expand unhappy path coverage
Follow-up to [43012], [44786], [47146], [47278].
Props hellofromTonya, jrf, xknown.
See #51423.
git-svn-id: https://develop.svn.wordpress.org/trunk@50613 602fd350-edb4-49c9-b593-d223f7449a82
This change switches out `sprintf` for `printf` on the "Copy suggested policy text from..." button screen reader text. Also, wrap the actual button text in a `<span aria-hidden="true">` to prevent both the button text and the screen reader text from being spoken.
Props mukesh27, SergeyBiryukov, sabernhardt.
Fixes#52891.
git-svn-id: https://develop.svn.wordpress.org/trunk@50585 602fd350-edb4-49c9-b593-d223f7449a82
In [49178], self-closing `br` tags were switched to non-self-closing `div` elements for "clearing" purposes, but the self-closing "/" remained in place. This fix removes the unnecessary slash.
Props pavelvisualcomposer, audrasjb, sabernhardt, akabarikalpesh, SergeyBiryukov.
Fixes#52878.
git-svn-id: https://develop.svn.wordpress.org/trunk@50582 602fd350-edb4-49c9-b593-d223f7449a82
Replace the float CSS removed in [50569], which is used to align the login & register buttons.
Props mukesh27, audrasjb.
Fixes#52834.
git-svn-id: https://develop.svn.wordpress.org/trunk@50577 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.
Follow-up to [50025], [50525].
Props sabernhardt, ryelle.
Fixes#52760.
git-svn-id: https://develop.svn.wordpress.org/trunk@50571 602fd350-edb4-49c9-b593-d223f7449a82
Prevent misalignment of "generate password" and "save password" buttons on the password reset screen on narrow screens and in languages requiring longer text than English.
Props audrasjb, grapplerulrich, ryelle.
Fixes#52834.
git-svn-id: https://develop.svn.wordpress.org/trunk@50569 602fd350-edb4-49c9-b593-d223f7449a82
On narrow screens allow the text to wrap in the copy buttons on the privacy policy guide screen to avoid horizontal overflow of the parent container.
Props audrasjb, davidbaumwald, jaymanpandya, paaljoachim, palmiak, sabernhardt, SergeyBiryukov, sumitsingh.
Fixes#52751.
git-svn-id: https://develop.svn.wordpress.org/trunk@50568 602fd350-edb4-49c9-b593-d223f7449a82
This fixes erroneous parentheses placement and applies the type cast to the variable it was intended for.
Follow-up to [3864].
Props hellofromTonya, jrf, xknown.
See #51423.
git-svn-id: https://develop.svn.wordpress.org/trunk@50563 602fd350-edb4-49c9-b593-d223f7449a82
While this has no effect on the code, it fixes a minor inconsistency with the rest of core.
Props laxman-prajapati.
Fixes#52870.
git-svn-id: https://develop.svn.wordpress.org/trunk@50556 602fd350-edb4-49c9-b593-d223f7449a82
With changes that were introduced in [49889] the second parameter for getimagesize() function is expecting a a reference.
Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.
This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.
For more see:
* https://github.com/humanmade/S3-Uploads/issues/496
* https://github.com/aws/aws-sdk-php/issues/1923Fixes#52826.
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.
git-svn-id: https://develop.svn.wordpress.org/trunk@50552 602fd350-edb4-49c9-b593-d223f7449a82
When collapsed or on a small screen, these styles would override the color schemes, causing a dark background to appear regardless of the color scheme's settings. This change also uses `focus-within` to show or hide the menu item's arrow, consistent with how the arrow behaves on hover.
Props afercia, Bueltge.
Fixes#32579.
git-svn-id: https://develop.svn.wordpress.org/trunk@50549 602fd350-edb4-49c9-b593-d223f7449a82
If the callback is called before the images are loaded, the comparison doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not guarantee that the images are loaded. This switches to use the `load` event, which waits for all resources to load.
Props vladytimy, joyously, sergeybiryukov.
Fixes#52758.
git-svn-id: https://develop.svn.wordpress.org/trunk@50535 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.
Follow-up to [50025].
Props sabernhardt, Otshelnik-Fm, audrasjb.
Fixes#52760.
git-svn-id: https://develop.svn.wordpress.org/trunk@50525 602fd350-edb4-49c9-b593-d223f7449a82
This ensures the images are loaded correctly from both single site and network About pages.
Props TobiasBg, audrasjb.
Fixes#52743.
git-svn-id: https://develop.svn.wordpress.org/trunk@50523 602fd350-edb4-49c9-b593-d223f7449a82
Removing `display: block` from the element allows the `.hide-if-no-js` class to have the intended effect.
Follow-up to [34275].
Props sabernhardt, mukesh27.
Fixes#52662.
git-svn-id: https://develop.svn.wordpress.org/trunk@50512 602fd350-edb4-49c9-b593-d223f7449a82
Additionally, adjust the "Update to latest nightly" button to include the major version number of the nightly build.
This makes the button labels more accurate and provides more clear understanding of what the update will be.
Follow-up to [49984].
Props afragen, pbiron, SergeyBiryukov.
Fixes#52513.
git-svn-id: https://develop.svn.wordpress.org/trunk@50506 602fd350-edb4-49c9-b593-d223f7449a82
This provides greater discoverability of such hooks in search results on the Code Reference site as well as increased clarity when reading the source.
See #50734, #52628
git-svn-id: https://develop.svn.wordpress.org/trunk@50505 602fd350-edb4-49c9-b593-d223f7449a82
The intro text has been updated for accuracy and to make it easier for translation. The button text has been updated for accuracy.
Props jdy68, audrasjb, marybaum, davidbaumwald.
See #52347.
git-svn-id: https://develop.svn.wordpress.org/trunk@50495 602fd350-edb4-49c9-b593-d223f7449a82
Adds a more obviously interactive comparison for viewing the color scheme differences. Improvements on RTL and IE11. Update strings to be more clear and consistent. Switch to the CDN for loading images.
Props sarahricker, desrosj, melchoyce, SergeyBiryukov, tikifez, clorith, marybaum, audrasjb, francina, hellofromTonya.
Fixes#52693. See #52347.
git-svn-id: https://develop.svn.wordpress.org/trunk@50478 602fd350-edb4-49c9-b593-d223f7449a82
This is the start of the WordPress 5.7 about page.
Props audrasjb, metalandcoffee, melchoyce, hedgefield, francina, webcommsat, lukecarbis, meher, sarahricker, marybaum.
See #52347.
git-svn-id: https://develop.svn.wordpress.org/trunk@50418 602fd350-edb4-49c9-b593-d223f7449a82
Replace loopback health check URL with a `POST` request to `wp-cron.php` in the WordPress install directory. This more closely represents how WordPress uses loopback requests.
A `POST` request is used to cause `wp-cron.php` to exit prior to running any cron jobs. This allows the test to indicate success quicker and accounts for sites that set the `DISABLE_WP_CRON` constant to avoid running cron jobs on loopback requests.
Props clorith, peterwilsoncc, TimothyBlynJacobs.
Fixes#52547.
git-svn-id: https://develop.svn.wordpress.org/trunk@50399 602fd350-edb4-49c9-b593-d223f7449a82
The `addInlineNotice()` function expects a single string as a success or error message, not an array of strings.
Follow-up to [50129].
Props audrasjb.
Fixes#52573.
git-svn-id: https://develop.svn.wordpress.org/trunk@50390 602fd350-edb4-49c9-b593-d223f7449a82
David Baumwald