Commit Graph

53 Commits

Author SHA1 Message Date
Dion Hulse
5b58664439 Expire password reset links after 24 hours (by default). This causes existing password reset links to become invalid.
Props markjaquith, voldemortensen, johnbillion, MikeHansenMe, dd32
See #32429


git-svn-id: https://develop.svn.wordpress.org/trunk@33019 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 06:32:07 +00:00
Scott Taylor
986990163f Add doc blocks to functions that are missing them.
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32672 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 03:17:50 +00:00
Dominik Schilling (ocean90)
b0d6757918 Use HTTPS URLs for codex.wordpress.org.
see #27115.

git-svn-id: https://develop.svn.wordpress.org/trunk@32116 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-12 21:28:58 +00:00
John Blackbourn
d6b90486d1 Implement an aria-describedby attribute for login screen errors, and improve the "Forgot password?" anchor text.
Props aferica, rianrietveld
Fixes #31143


git-svn-id: https://develop.svn.wordpress.org/trunk@31871 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 16:28:56 +00:00
John Blackbourn
66548dcb82 Introduce a logout_redirect filter so the redirect destination can be changed when a user logs out. Parameters:
* string  $redirect_to           The redirect destination URL.
 * string  $requested_redirect_to The requested redirect destination URL passed as a parameter.
 * WP_User $user                  The WP_User object for the user that's logging out. 

Fixes #27617
Props SergeyBiryukov, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@31417 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-11 19:18:19 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Andrew Nacin
0375edc8c6 No need for wp_get_password_hint() to be prefixed as if it is private.
see #21243.


git-svn-id: https://develop.svn.wordpress.org/trunk@30855 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 08:33:48 +00:00
Drew Jaynes (DrewAPicture)
ebdb7cb273 Docs Formatting: Backtick-escape inline code for the login_form_ . $action dynamic hook in wp-login.php.
See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30651 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 11:44:29 +00:00
Drew Jaynes (DrewAPicture)
a22e8b5354 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape code snippets in the description for `get_object_taxonomies()`
* Backtick-escape inline code in a markdown-formatted unordered list in the description for `get_taxonomy_labels()`
* Remove an HTML tag from the summary for the `Walker_Category_Checklist` class
* Remove an HTML tag from the summary for `wp_category_checklist()`, various formatting
* Remove an HTML tag from the summary for `wp_terms_checklist()`
* Backtick-escape an HTML tag in the description for `wp_popular_terms_checklist()`
* Remove HTML tags from the summaries for `page_template_dropdown()`, `parent_dropdown()`, and `wp_dropdown_roles()`
* Backtick-escape HTML tags in a parameter description for `add_settings_error()`
* Various formatting in the description and summary for `settings_errors()`
* Markdown-indent code snippets in the descriptions for `wpdb::prepare()`, `wpdb::insert()`, `wpdb::replace()`, `wpdb::update()`, and `wpdb::delete()`
* Backtick-escape an HTML tag in a parameter description for `login_header()`
* Remove HTML tags from the summaries for the `lostpassword_form` and `signup_header` hooks

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30546 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 06:30:19 +00:00
Andrew Nacin
1023d2bc60 Form validation for password resets.
git-svn-id: https://develop.svn.wordpress.org/trunk@30417 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 12:21:45 +00:00
John Blackbourn
0adcbd0094 Add $user_login and $user_data parameters to the retrieve_password_message filter.
Props ivankristianto, dcavins
Fixes #25853


git-svn-id: https://develop.svn.wordpress.org/trunk@30357 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 07:24:39 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd Correct references of @uses $wpdb in core documentation to use @global.
See #30191, [30105].
Fixes #30217.


git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 17:55:39 +00:00
John Blackbourn
bc1168e953 Rename _wp_password_hint() to _wp_get_password_hint() to bring it inline with core terminology. Fixes #21243.
git-svn-id: https://develop.svn.wordpress.org/trunk@30033 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 23:29:11 +00:00
Sergey Biryukov
5ab446aab7 Move password hint text to a function. Add 'password_hint' filter.
props convissor.
fixes #21243.

git-svn-id: https://develop.svn.wordpress.org/trunk@29962 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 20:20:56 +00:00
Helen Hou-Sandi
179f12066d Refresh the post-update login message.
Just a little older in the soul, like your faithful release lead.

fixes #29388.


git-svn-id: https://develop.svn.wordpress.org/trunk@29644 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-27 05:31:53 +00:00
Andrew Nacin
9c6f4dd67c Password resets: Use network_site_url() for form actions.
props mdawaffe.
fixes #29156.


git-svn-id: https://develop.svn.wordpress.org/trunk@29631 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 20:00:07 +00:00
Sergey Biryukov
31105be6c7 Avoid PHP notices in wp-login.php if password reset cookie is not set.
props mdawaffe.
see #29060.

git-svn-id: https://develop.svn.wordpress.org/trunk@29381 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 02:16:51 +00:00
Andrew Nacin
94c53962b1 Don't pass around the password reset key.
props mdawaffe.
fixes #29060.


git-svn-id: https://develop.svn.wordpress.org/trunk@29327 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 18:18:58 +00:00
Dominik Schilling (ocean90)
ea34a0bdf7 Replace is_https_url() with 'https' === parse_url( $url, PHP_URL_SCHEME ).
see #28427, #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29311 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:45:34 +00:00
Sergey Biryukov
98e7bb798c Don't always focus password field on interim login.
props johnbillion.
fixes #28961.

git-svn-id: https://develop.svn.wordpress.org/trunk@29258 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-21 16:20:05 +00:00
Drew Jaynes (DrewAPicture)
161266c17d Fix syntax for single- and multi-line comments in root-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29205 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:11:46 +00:00
John Blackbourn
0a4e8b2b7e Implement email and url input types where appropriate. Props Kau-Boy. Fixes #22183.
git-svn-id: https://develop.svn.wordpress.org/trunk@29030 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-08 17:51:58 +00:00
Sergey Biryukov
5235448195 Avoid overwriting $error global with an interim variable.
props MikeLittle.
fixes #28691.

git-svn-id: https://develop.svn.wordpress.org/trunk@28925 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 14:38:21 +00:00
Scott Taylor
dcd7ff837d Use the WPINC constant when loading class-phpass.php
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28903 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:11:44 +00:00
John Blackbourn
db4da6e488 Remove the WordPress logo from the focusable elements on the install/update screens. Fixes #28674. Props stompweb
git-svn-id: https://develop.svn.wordpress.org/trunk@28896 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 14:09:39 +00:00
John Blackbourn
15e019d99e Conditionally set the the secure flag on the test cookie, post password cookie, settings cookies, and comment author cookies depending on whether the front end and/or admin area are served over https. Fixes #28427
git-svn-id: https://develop.svn.wordpress.org/trunk@28895 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 13:24:55 +00:00
Scott Taylor
84fb91f383 Don't annotate $wp_error twice in login_header() docs. $wp_error is always expected to be of type WP_Error.
Props SergeyBiryukov.
Fixes #28518.


git-svn-id: https://develop.svn.wordpress.org/trunk@28792 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 19:18:25 +00:00
Andrew Nacin
961459ee31 Forcing SSL logins now forces SSL for the entire admin, with no middle ground.
fixes #10267.


git-svn-id: https://develop.svn.wordpress.org/trunk@28609 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 03:58:41 +00:00
Scott Taylor
451319728b In wp-login.php, break is unreachable after exit
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28340 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:57:17 +00:00
Drew Jaynes (DrewAPicture)
609cf29058 Clean up duplicate hook notations and adjacency for calls to the wp_signup_location filter.
Also adds braces missed in [25535].

See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28215 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 07:11:32 +00:00
Drew Jaynes (DrewAPicture)
9da8915408 Ensure the register filter hook is only documented once.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28208 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 06:23:31 +00:00
Andrew Nacin
985727f256 RTL for login screen.
props yoavf.
fixes #27784.


git-svn-id: https://develop.svn.wordpress.org/trunk@28096 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 16:05:16 +00:00
Drew Jaynes (DrewAPicture)
13d5b7c461 Improve hook docs for the resetpass_form hook added in 3.9.
See #21044, #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28017 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 22:05:51 +00:00
Andrew Nacin
2e5586ee19 Only show test cookie warnings on submit as caching/proxies may intercept the test cookie for GET requests.
Introduce a new string for when headers are sent and link them to http://codex.wordpress.org/Cookies (new page).

props SergeyBiryukov.
fixes #27373.


git-svn-id: https://develop.svn.wordpress.org/trunk@27859 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 00:40:43 +00:00
Andrew Nacin
98ac075d8b Always decode special characters for email subjects.
props tlovett1, jeremyfelt.
fixes #25346.


git-svn-id: https://develop.svn.wordpress.org/trunk@27801 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-28 02:43:04 +00:00
Andrew Nacin
f3a23fb43f Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc.
props Ipstenu, markjaquith.
see #27115.


git-svn-id: https://develop.svn.wordpress.org/trunk@27369 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-03 02:33:24 +00:00
Sergey Biryukov
d885ca8e31 Add Oxford comma to password hint.
props trepmal.
fixes #26457.

git-svn-id: https://develop.svn.wordpress.org/trunk@27246 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-24 23:30:52 +00:00
Helen Hou-Sandi
1c5f1cebff Make login styles standalone. see #12506.
git-svn-id: https://develop.svn.wordpress.org/trunk@27199 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-20 03:23:49 +00:00
Andrew Nacin
509cd20ae4 New resetpass_form hook in wp-login.php.
props romaimperator.
fixes #21044.


git-svn-id: https://develop.svn.wordpress.org/trunk@27068 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 07:51:03 +00:00
Matt Thomas
a8a4ce9f0d Reset the login form inputs to the standard sans-serif font in IE8 to prevent invisible password field inputs when webfonts are used. Fixes #26348, props SergeyBiryukov, iammattthomas.
git-svn-id: https://develop.svn.wordpress.org/trunk@26583 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-03 20:11:22 +00:00
Sergey Biryukov
39d55fddb8 Use get_current_site() instead of the $current_site global when possible.
props jeremyfelt.
fixes #25158.

git-svn-id: https://develop.svn.wordpress.org/trunk@26120 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 03:22:48 +00:00
Sergey Biryukov
bc6c0c9b0f Correct @since values for various hooks. fixes #25766.
git-svn-id: https://develop.svn.wordpress.org/trunk@25991 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 03:19:16 +00:00
Ryan Boren
30f822b8ee Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@25880 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 14:37:54 +00:00
Andrew Nacin
c87ad6023d Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.


git-svn-id: https://develop.svn.wordpress.org/trunk@25868 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 17:21:32 +00:00
Drew Jaynes
b60980d0af Inline documentation for hooks in wp-login.php.
Props ShinichiN, kpdesign.
Fixes #25393.


git-svn-id: https://develop.svn.wordpress.org/trunk@25701 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 16:23:39 +00:00
Andrew Nacin
48f68c8c6b Hash password reset keys in the database.
All existing, unused password reset keys are now considered "expired" and the user will be told they should try again.

Introduces a password_reset_key_expired filter to allow plugins to introduce a grace period.

fixes #24783.


git-svn-id: https://develop.svn.wordpress.org/trunk@25696 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 11:28:42 +00:00
Helen Hou-Sandi
64b021bbce Simplify the login page viewport meta for mobile devices, so it's less restrictive on the user. Allows for developers to override if necessary via the login_head action. props azaozz. fixes #24777.
git-svn-id: https://develop.svn.wordpress.org/trunk@25619 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-25 15:19:11 +00:00
Andrew Nacin
a58d80bbc1 Introduce post_password_expires filter to control the expiration of the post password cookie.
props Viper007Bond for initial patch.
fixes #21466.


git-svn-id: https://develop.svn.wordpress.org/trunk@25450 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-16 17:39:30 +00:00
Sergey Biryukov
67500203f9 Move check_password_reset_key(), reset_password(), and register_new_user() from wp-login.php to wp-includes/user.php, to make them reusable. props beaulebens for initial patch. fixes #20279.
git-svn-id: https://develop.svn.wordpress.org/trunk@25231 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 08:58:41 +00:00
Sergey Biryukov
a276eeb68e Clear 'default_password_nag' flag when resetting a user's password, since the new password is entered manually. props wikicms. fixes #25206.
git-svn-id: https://develop.svn.wordpress.org/trunk@25203 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-02 03:17:34 +00:00