Commit Graph

1936 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
62705eef00 Media: In wp_read_image_metadata() make sure that IPTC keywords are UTF8 encoded.
Prevents missing `_wp_attachment_metadata` when an image contains keywords with latin extended characters.

Fixes #35316.

git-svn-id: https://develop.svn.wordpress.org/trunk@36429 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-01 14:52:15 +00:00
Andrea Fercia
cde933e306 After [36171] remove all the occurrences of the old CSS clearfix.
The old clearfix was applied to very specific items and defined multiple times
across CSS files. Uses the new generic `.wp-clearfix` utility class instead.

See #26396.

git-svn-id: https://develop.svn.wordpress.org/trunk@36422 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-30 13:45:37 +00:00
ericlewis
3fde994152 Networks and sites: Replace "blog" usage with "site" in docs.
Multisite functions use the term "blog" to refer to what we now call a "site," e.g. `get_current_blog_id()`. These functions are here to stay because of our commitment to backwards compatibility. What we can do is set the documentation straight.

See #35417.


git-svn-id: https://develop.svn.wordpress.org/trunk@36416 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-28 03:34:02 +00:00
Eric Andrew Lewis
63afb0dcc8 Plugins: Clarify that mu-plugins can't be "active" in docs.
Plugins installed in the plugins/ folder can be activated by users. This puts the plugin in an "active" state. Plugins in the mu-folder/ are "must-use" plugins that are always loaded. They can't be activated, and thereby can't be "active." Because of this, using the `is_plugin_active()` or `is_plugin_active_for_network()` returns false when checking for these plugins. This clarifies that behavior in the functions' docs.


git-svn-id: https://develop.svn.wordpress.org/trunk@36397 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-26 00:31:08 +00:00
Konstantin Obenland
ddfbfce2e6 Pass data consistently on plugin, network plugin, and network theme screens.
List tables on these three screens look similar but come with unexpected caveats.
The network themes screen in particular has been neglected, using a `.plugin`
class to inherit its sibling's styles and not providing classes and data
attributes that the other two offer. This will provide some more consistency.

Fixes #35335.



git-svn-id: https://develop.svn.wordpress.org/trunk@36394 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-25 22:54:52 +00:00
Boone Gorges
e1b5d2d2bf In comments list table, $post_id should default to false rather than 0.
After [36381], the default value of `0` was causing the list table at
edit-comments.php to be empty. `false` prevents this.

This fix is likely temporary, while more research is done into the backward
compatibility concerns tied to [36381].

See #35090.

git-svn-id: https://develop.svn.wordpress.org/trunk@36387 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-23 22:15:19 +00:00
Ella Iseulde Van Dorpe
b780792d87 TinyMCE: add inline link dialog
First run.
Links the advanced button to the "old" dialog for now.

See #33301.


git-svn-id: https://develop.svn.wordpress.org/trunk@36384 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-23 00:07:29 +00:00
Andrea Fercia
e23986bdb3 Accessibility: Remove title attributes from the Menus screen.
Also, adds missing labels and improves the existing ones. 
Updates the "custom links" labels and inputs in the Customizer too.
Introduces a generic, reusable, `.wp-initial-focus` CSS class to be used for
the sole purpose of setting the initial focus.
"Quick Search": uniform the attached events and avoids new AJAX requests to
be triggered when the pressed key doesn't change the searched term.

Fixes #35374.

git-svn-id: https://develop.svn.wordpress.org/trunk@36379 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-22 14:25:58 +00:00
Sergey Biryukov
ac704e838c Media: In _wp_handle_upload(), move ending brace to a new line.
Props georgestephanis.
Fixes #35565.

git-svn-id: https://develop.svn.wordpress.org/trunk@36373 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-21 20:26:06 +00:00
Dion Hulse
51aee5ab1b Upgrade: Switch the locking mechanism to using static methods so that it can be accessed from other upgrade-classes.
Fixes #34878


git-svn-id: https://develop.svn.wordpress.org/trunk@36370 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-21 01:21:52 +00:00
Dion Hulse
b9e62671f6 Core Upgrader: Add a locking mechanism to avoid two concurrent updates of WordPress occuring.
Fixes #34878


git-svn-id: https://develop.svn.wordpress.org/trunk@36349 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-19 05:06:46 +00:00
Rachel Baker
2da13dda2e List Tables: Use the $GLOBALS array when unsetting the global post and comment in WP_Comments_List_Table::single_row().
In r35674 only the local variables were unset, when using `unset()` with a global variable the `$GLOBALS` array must be used.


Fixes #35506.


git-svn-id: https://develop.svn.wordpress.org/trunk@36339 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-18 02:49:40 +00:00
Andrea Fercia
2e78169eee After [36333] correctly use esc_attr() instead of esc_attr__().
See #35313.

git-svn-id: https://develop.svn.wordpress.org/trunk@36334 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-17 16:02:24 +00:00
Andrea Fercia
838f953d4d Accessibility: Remove title attributes from the Posts list table.
Fixes #35313.

git-svn-id: https://develop.svn.wordpress.org/trunk@36333 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-17 15:46:01 +00:00
Andrea Fercia
f8f12bf78a Accessibility: Remove title attributes from the Media Library list table.
Fixes #35136.

git-svn-id: https://develop.svn.wordpress.org/trunk@36331 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-17 14:45:26 +00:00
Dominik Schilling (ocean90)
54abada4cc Media: Update some attach/detach strings in the columns view.
* Show a "Media attachment reattached."/"Media attachment detached." message when only one attachment was attached/detached. 
* Use the string placeholder as `number_format_i18n()` returns a string.
* Add translator comments.
* Update help text to refer to the new dropdown menus.
* Add a more generic title to the attach modal.

Fixes #33237.

git-svn-id: https://develop.svn.wordpress.org/trunk@36328 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-15 22:28:15 +00:00
Pascal Birchler
cc6fe1179d Allow searching for 0 throughout the admin.
Fixes #31025.

git-svn-id: https://develop.svn.wordpress.org/trunk@36302 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 20:05:06 +00:00
Pascal Birchler
5209de6052 Plugins: Prevent a warning when searching in the plugins list table.
After [36182], plugin data contains compatibility info from the API, which is an array and cannot be searched.

Fixes #35461.

git-svn-id: https://develop.svn.wordpress.org/trunk@36301 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 19:59:06 +00:00
Andrea Fercia
0eed5e07d8 Accessibility: Remove title attributes from the Comments screen.
Fixes #35304.

git-svn-id: https://develop.svn.wordpress.org/trunk@36298 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 16:03:47 +00:00
Pascal Birchler
d2b96ce6b9 Plugins: Make sure the 'Beta testing' tab is first in the plugin installer.
This makes feature plugins more discoverable for people running development builds.

Fixes #29631.

git-svn-id: https://develop.svn.wordpress.org/trunk@36297 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 09:06:12 +00:00
Dominik Schilling (ocean90)
2efcaf2921 Plugins: In _get_plugin_data_markup_translate() remove the fallback to the "default" textdomain for Akismet.
Akismet has its own language files since WordPress 3.9.

Props jrf.
Fixes #35436.

git-svn-id: https://develop.svn.wordpress.org/trunk@36283 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-13 13:55:42 +00:00
Dominik Schilling (ocean90)
c86ffe454a Plugins: In _get_plugin_data_markup_translate() don't reload translations if they're already loaded.
Props jrf.
Fixes #35439.

git-svn-id: https://develop.svn.wordpress.org/trunk@36282 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-13 13:03:21 +00:00
Andrea Fercia
baaa8946a2 Accessibility: Remove title attributes from the Terms list table.
Fixes #35187.

git-svn-id: https://develop.svn.wordpress.org/trunk@36265 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 23:30:00 +00:00
Andrea Fercia
e6297676fb Accessibility: Remove title attributes from the General Settings screen.
Date and time formats are now displayed in plain text and available for all
users. Also, lines up them with the "custom" date and time format fields to
help reinforce what these fields do.

Props afercia, perezlabs.
Fixes #35064.

git-svn-id: https://develop.svn.wordpress.org/trunk@36263 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 22:53:10 +00:00
Pascal Birchler
844e1b6e7e After [36254], commit all the necessary files and not just the unit test.
git-svn-id: https://develop.svn.wordpress.org/trunk@36255 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 19:06:03 +00:00
John Blackbourn
ba5f0fdc7b Docs: Various docblock corrections.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36250 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 01:25:44 +00:00
John Blackbourn
f0a706d1eb Comments: Correct the docblocks for various methods in the comment list table class.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36248 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 00:51:35 +00:00
John Blackbourn
021401424b Docs: @param fixes for a variety of docblocks.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36232 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 01:44:31 +00:00
John Blackbourn
aaa61e80e4 Docs: Correct the parameter docs for various Heartbeat filters and functions.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36231 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 01:36:45 +00:00
Andrea Fercia
05934ebd87 Media: make the Image Editor usable with a keyboard.
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.

Fixes #28864.

git-svn-id: https://develop.svn.wordpress.org/trunk@36223 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 19:12:11 +00:00
Konstantin Obenland
e4b8679d17 Plugins: Use plugin file rather than slug as identifier
The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.

See [36205].
Fixes #35350.



git-svn-id: https://develop.svn.wordpress.org/trunk@36221 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 17:47:18 +00:00
Konstantin Obenland
c67abd1c66 Plugins: Avoid ID attribute collisions in plugins list table.
Removes id attributes with non-unique plugin slug and adds a data attribute
with the unique plugin file.

Props khag7.
Fixes #18974.



git-svn-id: https://develop.svn.wordpress.org/trunk@36205 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 22:39:23 +00:00
Dion Hulse
ce4ef49b10 Background Updates: Remove the 7am/7pm background update check. This check was made redundant by [28129] as background updates are now run after a version check takes place.
See #27772, #35323.


git-svn-id: https://develop.svn.wordpress.org/trunk@36180 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 06:11:46 +00:00
Andrea Fercia
0eba218570 Accessibility: Remove title attributes from the Admin Dashboard.
Uses `aria-label` and `screen-reader-text` where appropriate. Also removes
the default title attribute output by `privacy_on_link_title`, preserving
the ability to use the filter.

Fixes #35049.

git-svn-id: https://develop.svn.wordpress.org/trunk@36172 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 14:18:57 +00:00
Dominik Schilling (ocean90)
d47319710c Docs: Remove indentation from the hidden_columns changelog entry.
Added in [36154].

See #35057.

git-svn-id: https://develop.svn.wordpress.org/trunk@36156 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-02 15:15:53 +00:00
Dion Hulse
84cb626eb6 List Tables: When a user has hidden all columns, do not override that with the default_hidden_columns filter.
Props Compute, jorbin, voldemortensen.
Fixes #35057


git-svn-id: https://develop.svn.wordpress.org/trunk@36154 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-02 04:43:07 +00:00
Andrea Fercia
93e3093a0a Admin: Restore the "Show advanced menu properties" checkboxes IDs.
These checkboxes are used on the Menus screen options and the Customizer Menus options.
Their IDs were removed in [34991] but they're needed to get the checkboxes to be saved
via AJAX. Also, avoids a useless AJAX call.

Fixes #35112 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36137 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 11:51:09 +00:00
Pascal Birchler
4f6d5aa034 Plugins: Add a new pre_uninstall_plugin action that runs right before uninstalling a plugin.
Fixes #34569.

git-svn-id: https://develop.svn.wordpress.org/trunk@36124 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 22:37:49 +00:00
Sergey Biryukov
26d7619306 Import: Add a missing space to post_exists().
The lack of space resulted in SQL error when searching for posts by content.

Props yetAnotherDaniel, johnbillion.
Fixes #35246.

git-svn-id: https://develop.svn.wordpress.org/trunk@36113 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-28 19:06:05 +00:00
Dion Hulse
0df95091ee Nav Menus: Avoid a PHP Notice when a menu contains a now unregistered post type archive.
Props kucrut.
Fixes #34449 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@36095 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 04:04:55 +00:00
Sergey Biryukov
54c918d407 Remove redundant title attribute from wp_star_rating(). Hide the visible number of ratings from assistive technologies.
This data is redundant, as the same information is already conveyed by the text hidden with `.screen-reader-text` class.

Props afercia.
Fixes #35141.

git-svn-id: https://develop.svn.wordpress.org/trunk@36092 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 00:47:35 +00:00
Aaron Jorbin
bc01ead655 Help Tab Order should be based on the Priority Argument
[34370] made the order that tabs are returned respect the order they are added, however it broke the respect of priority. By using a ksort instead of a sort, we can restore that default behavior. This adjusts the unit tests so that both order added and priority are tested.

Props meitar,  swissspidy, jorbin
Fixes #35215. See #33941.


git-svn-id: https://develop.svn.wordpress.org/trunk@36089 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-25 22:43:41 +00:00
SergeyBiryukov
2ce0bfa8f4 Theme Editor: Break $wp_file_descriptions array into sections and reorder for consistency and readability.
Props ramiy.
Fixes #35223.

git-svn-id: https://develop.svn.wordpress.org/trunk@36088 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-25 21:11:02 +00:00
Sergey Biryukov
ffc86bf4e1 Theme Editor: Add taxonomy.php, home.php, front-page.php, date.php, and singular.php to file descriptions.
Props ramiy.
See #35223.

git-svn-id: https://develop.svn.wordpress.org/trunk@36087 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-25 21:04:13 +00:00
Drew Jaynes
857de6f1ba Docs: Properly mark the optional $redirect, $network_wide, and $silent parameters as such in the DocBlock for activate_plugin().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36072 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 06:59:47 +00:00
Drew Jaynes
d4ea8d9f62 Docs: Add missing @since and properly mark the optional $type parameter as such in the DocBlock for the deprecated get_others_unpublished_posts() function.
Introduced in [5707].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36071 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 06:57:12 +00:00
Drew Jaynes
b489587419 Docs: Properly mark the $exclude_zeros parameter in the DocBlock for get_editable_user_ids() as optional.
Also fixes a couple of typos.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36070 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 06:52:15 +00:00
John Blackbourn
a6556195d8 Docs: Miscellaneous docblock corrections.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36069 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 06:30:09 +00:00
Drew Jaynes
688916d200 Docs: Fix a typo in the 4.4.0 changlog entry in the intermediate_image_sizes_advanced hook doc.
Props morganestes.
Fixes #35190.


git-svn-id: https://develop.svn.wordpress.org/trunk@36054 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 22:23:11 +00:00
Andrea Fercia
9c8c6955a9 Accessibility: Remove the revisions limit title attribute from the Publish box.
The revisions limit warning is now always displayed in plain text even when the
limit is not reached yet. Removes the plus "+" from the revisions count number.

Fixes #35029.

git-svn-id: https://develop.svn.wordpress.org/trunk@36053 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 14:38:32 +00:00